)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"acdf34f88c284fb3f3c84094de9b1fb7b7fb509e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch removes the other redundant notification sent in the same"},{"line_number":10,"context_line":"routine to notify whether a security group changed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closed-Bug: 1254924"},{"line_number":13,"context_line":"Partial Blueprint neutron-tempest-parallel"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5bad015decdc197c3fa9b58c680564380d513bc4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BcE8%3D","line":12,"updated":"2013-11-26 02:53:14.000000000","message":"Closes-Bug: #1254924?","commit_id":"de5f148f2cde11a1892954466c69394b70cdd5d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"92b002b2cfdbc50b680a452ef85ee2c2a3b50d07","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch removes the other redundant notification sent in the same"},{"line_number":10,"context_line":"routine to notify whether a security group changed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closed-Bug: #1254924"},{"line_number":13,"context_line":"Partial Blueprint neutron-tempest-parallel"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5bad015decdc197c3fa9b58c680564380d513bc4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2BbT8%3D","line":12,"updated":"2013-11-26 08:27:26.000000000","message":"Closes-Bug: #1254924? I still cannot see the bug link in this commit message.","commit_id":"e424210e730d97c266312660f75ac5a16dc9f833"}],"neutron/db/securitygroups_rpc_base.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"acdf34f88c284fb3f3c84094de9b1fb7b7fb509e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":100,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":101,"context_line":"            self.notify_security_groups_member_updated("},{"line_number":102,"context_line":"                context, updated_port)"},{"line_number":103,"context_line":"            need_notify \u003d True"},{"line_number":104,"context_line":"        return need_notify"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BcD4%3D","side":"PARENT","line":102,"updated":"2013-11-26 02:53:14.000000000","message":"shouldn\u0027t the ovs, linuxbridge be changed accordingly?","commit_id":"15d5f1618c03ed655a441f78e4d903732a95b980"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5ab0c2f060fd34f13c0666df01318671ecb59841","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":100,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":101,"context_line":"            self.notify_security_groups_member_updated("},{"line_number":102,"context_line":"                context, updated_port)"},{"line_number":103,"context_line":"            need_notify \u003d True"},{"line_number":104,"context_line":"        return need_notify"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BbYM%3D","side":"PARENT","line":102,"in_reply_to":"AAAATn%2F%2BcD4%3D","updated":"2013-11-26 08:10:42.000000000","message":"they already send the notification too on port_update, and use this same mixin.\nSee bug report for more details.","commit_id":"15d5f1618c03ed655a441f78e4d903732a95b980"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"92b002b2cfdbc50b680a452ef85ee2c2a3b50d07","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":100,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":101,"context_line":"            self.notify_security_groups_member_updated("},{"line_number":102,"context_line":"                context, updated_port)"},{"line_number":103,"context_line":"            need_notify \u003d True"},{"line_number":104,"context_line":"        return need_notify"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BbUA%3D","side":"PARENT","line":102,"updated":"2013-11-26 08:27:26.000000000","message":"https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L634\nwill send port_update message to agent,\nbut https://github.com/openstack/neutron/blob/master/neutron/db/securitygroups_rpc_base.py#L101\nsends security_groups_member_updated or security_groups_provider_updated.\n\nThese messages are very differently dealt on agent side. are u sure they are redundant?","commit_id":"15d5f1618c03ed655a441f78e4d903732a95b980"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"df9d2d148e45af6972dd7e6c34ef852ca802d4e1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":100,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":101,"context_line":"            self.notify_security_groups_member_updated("},{"line_number":102,"context_line":"                context, updated_port)"},{"line_number":103,"context_line":"            need_notify \u003d True"},{"line_number":104,"context_line":"        return need_notify"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BbEs%3D","side":"PARENT","line":102,"in_reply_to":"AAAATn%2F%2BbUA%3D","updated":"2013-11-26 09:23:25.000000000","message":"the port_update handler on the agent also takes care of refreshing the firewall.\n\nAlternatively I could change the agent for not making that handler refresh the firewall, but sending to notifications to the agent for the same event - a port update, seems wasteful.","commit_id":"15d5f1618c03ed655a441f78e4d903732a95b980"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"a7755836acf8abb787e70d48e5a3d843cdf09a6d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            not utils.compare_elements("},{"line_number":99,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":100,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":101,"context_line":"            self.notify_security_groups_member_updated("},{"line_number":102,"context_line":"                context, updated_port)"},{"line_number":103,"context_line":"            need_notify \u003d True"},{"line_number":104,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Ba2M%3D","side":"PARENT","line":101,"updated":"2013-11-26 10:16:37.000000000","message":"what is the meaning of existence for is_security_group_member_updated function after deleting notify_security_groups_member_updated funtion ?\nstill need to make it as a function to exist independently ?","commit_id":"15d5f1618c03ed655a441f78e4d903732a95b980"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"e8792d80ffcd4e13fcbb2e86d4eaab56999fe0a8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            not utils.compare_elements("},{"line_number":99,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":100,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":101,"context_line":"            self.notify_security_groups_member_updated("},{"line_number":102,"context_line":"                context, updated_port)"},{"line_number":103,"context_line":"            need_notify \u003d True"},{"line_number":104,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BW8k%3D","side":"PARENT","line":101,"in_reply_to":"AAAATn%2F%2BZ%2Bk%3D","updated":"2013-11-26 23:51:27.000000000","message":"Salvatore, thanks for your quickly clarification, I feel it\u0027s ok for me now, thanks.","commit_id":"15d5f1618c03ed655a441f78e4d903732a95b980"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ae00189d8130aae7edfbb7e54de5184a53d28871","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            not utils.compare_elements("},{"line_number":99,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":100,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":101,"context_line":"            self.notify_security_groups_member_updated("},{"line_number":102,"context_line":"                context, updated_port)"},{"line_number":103,"context_line":"            need_notify \u003d True"},{"line_number":104,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BZ%2Bk%3D","side":"PARENT","line":101,"in_reply_to":"AAAATn%2F%2Ba2M%3D","updated":"2013-11-26 13:16:52.000000000","message":"other plugins call it direct from within update_port\n\nI think it\u0027s good to be as conservative as possible.\n\nAlso, notie that this method is called is_security_group_member_updated: I would expect the boolean return value from this method, but not the side effect notification.\n\nFurthermore, note the docstring that also say \"does not perform the notification itself\"\n\nNow, how confusing is that?","commit_id":"15d5f1618c03ed655a441f78e4d903732a95b980"}]}