)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"edc31c3501b42a3831d69ceecf52e10732c0bfad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f7c97a3_b5d02ec8","updated":"2018-07-26 15:49:59.000000000","message":"https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_l3_db.py#L298-L311 can be modified to add mock for _add_router_port and assert it is called if external_gateway_info ?","commit_id":"314a06359e4eaa7a858f2ba88c98b0a849376aba"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"417cf6fb30092fdf709820cda6b1c96838931910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f7c97a3_2e02840d","in_reply_to":"5f7c97a3_2404ea7c","updated":"2018-07-26 22:05:45.000000000","message":"oh yes, you\u0027re right, my bad ! but can a testcase be added for add_router_interface test that asserts the newly added _add_router_ports get called ?","commit_id":"314a06359e4eaa7a858f2ba88c98b0a849376aba"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1a7c54b641160e3d378305570410e12051eb5b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f7c97a3_28583323","in_reply_to":"5f7c97a3_2e02840d","updated":"2018-07-27 06:41:14.000000000","message":"technically it can be added, but I\u0027d consider it\u0027s unrelated as the change itself doesn\u0027t add any new functional, it\u0027s just a small refactoring of one method out of another, so should be covered by existing tests","commit_id":"314a06359e4eaa7a858f2ba88c98b0a849376aba"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5f98fd3f31cd7eb3ff7bba47b81c0c590341b0d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f7c97a3_2404ea7c","in_reply_to":"5f7c97a3_b5d02ec8","updated":"2018-07-26 19:21:18.000000000","message":"but it won\u0027t be called, it\u0027s only for new router interface. Am I missing something?","commit_id":"314a06359e4eaa7a858f2ba88c98b0a849376aba"}]}
