)]}'
{"neutron/db/agents_db.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"140130ebe0318f844d0b9024a470833ac93f1436","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                status \u003d agent_consts.AGENT_NEW"},{"line_number":422,"context_line":"            greenthread.sleep(0)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        registry.notify(resources.AGENT, event_type, self, context\u003dcontext,"},{"line_number":425,"context_line":"                        host\u003dagent_state[\u0027host\u0027], plugin\u003dself,"},{"line_number":426,"context_line":"                        agent\u003dagent_state, status\u003dstatus)"},{"line_number":427,"context_line":"        return status, agent_state"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _get_agents_considered_for_versions(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3fbf00ac","line":426,"range":{"start_line":424,"start_character":8,"end_line":426,"end_character":56},"updated":"2018-09-28 21:03:29.000000000","message":"I don\u0027t see any consumer of this notification being updated to process status passed along ? is that done in separate patch ?","commit_id":"d10137684ac060e689aa825cfcda9cf99f87c211"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ee1756c44f3713859fddab9ba43e607746edc77b","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                status \u003d agent_consts.AGENT_NEW"},{"line_number":422,"context_line":"            greenthread.sleep(0)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        registry.notify(resources.AGENT, event_type, self, context\u003dcontext,"},{"line_number":425,"context_line":"                        host\u003dagent_state[\u0027host\u0027], plugin\u003dself,"},{"line_number":426,"context_line":"                        agent\u003dagent_state, status\u003dstatus)"},{"line_number":427,"context_line":"        return status, agent_state"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _get_agents_considered_for_versions(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f708082f","line":426,"range":{"start_line":424,"start_character":8,"end_line":426,"end_character":56},"in_reply_to":"3f79a3b5_3fbf00ac","updated":"2018-10-09 11:58:44.000000000","message":"It\u0027s here in this change in the next file: neutron/services/segments/db.py.\n\nSubscription is not done by a decorator though, maybe that\u0027s what\u0027s misleading.","commit_id":"d10137684ac060e689aa825cfcda9cf99f87c211"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bb7b1465f498f5369f34462122e7a5c3c03c4115","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                status \u003d agent_consts.AGENT_NEW"},{"line_number":422,"context_line":"            greenthread.sleep(0)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        registry.notify(resources.AGENT, event_type, self, context\u003dcontext,"},{"line_number":425,"context_line":"                        host\u003dagent_state[\u0027host\u0027], plugin\u003dself,"},{"line_number":426,"context_line":"                        agent\u003dagent_state, status\u003dstatus)"},{"line_number":427,"context_line":"        return status, agent_state"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _get_agents_considered_for_versions(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_850fde2d","line":426,"range":{"start_line":424,"start_character":8,"end_line":426,"end_character":56},"in_reply_to":"3f79a3b5_f708082f","updated":"2018-10-11 15:51:34.000000000","message":"ah ok, that\u0027s what I missed too, most of subscriptions are done via decorators which I didn\u0027t see.","commit_id":"d10137684ac060e689aa825cfcda9cf99f87c211"}],"neutron/services/segments/db.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"86775cdd784baa26135b6992423a2dffaca4d556","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"def _update_segment_host_mapping_for_agent(resource, event, trigger,"},{"line_number":254,"context_line":"                                           context, host, plugin, agent,"},{"line_number":255,"context_line":"                                           status):"},{"line_number":256,"context_line":"    check_segment_for_agent \u003d getattr(plugin, \u0027check_segment_for_agent\u0027, None)"},{"line_number":257,"context_line":"    if not check_segment_for_agent:"},{"line_number":258,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_a9165757","line":255,"updated":"2018-10-12 20:18:25.000000000","message":"So \u0027status\u0027 is added here but I don\u0027t see it consumed anywhere in this function.  Am I correct then that this is just stubbing this out for consumption by a later change?","commit_id":"6ee2c244811ac8cb569f8f6280e85ebad8754ae4"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"57031c9bb43c1e1c69cc30e2f4e61eee215aa375","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"def _update_segment_host_mapping_for_agent(resource, event, trigger,"},{"line_number":254,"context_line":"                                           context, host, plugin, agent,"},{"line_number":255,"context_line":"                                           status):"},{"line_number":256,"context_line":"    check_segment_for_agent \u003d getattr(plugin, \u0027check_segment_for_agent\u0027, None)"},{"line_number":257,"context_line":"    if not check_segment_for_agent:"},{"line_number":258,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_303a9fc3","line":255,"in_reply_to":"3f79a3b5_a9165757","updated":"2018-10-13 12:22:16.000000000","message":"Yes, for later use in another notification consumer. Please see here: https://review.openstack.org/#/c/580672/12/neutron/services/placement_report/plugin.py@175","commit_id":"6ee2c244811ac8cb569f8f6280e85ebad8754ae4"}],"releasenotes/notes/agent-notification-signature-status-6a9b9dbce9cb9740.yaml":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"140130ebe0318f844d0b9024a470833ac93f1436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f79a3b5_9fcbb448","updated":"2018-09-28 21:03:29.000000000","message":"IMO, this is not needed, since signature of notify is to pass kwargs, so not really a huge change that is worth of release notes, but if other reviewers are okay with its fine.\n\nIf out of tree consumers are using it from neutron-lib https://github.com/openstack/neutron-lib/blob/master/neutron_lib/callbacks/registry.py#L55 I don\u0027t think there will be any issues.","commit_id":"d10137684ac060e689aa825cfcda9cf99f87c211"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bb7b1465f498f5369f34462122e7a5c3c03c4115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f79a3b5_e51fb257","in_reply_to":"3f79a3b5_6232f8c2","updated":"2018-10-11 15:51:34.000000000","message":"no harm in having this.!","commit_id":"d10137684ac060e689aa825cfcda9cf99f87c211"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ee1756c44f3713859fddab9ba43e607746edc77b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f79a3b5_6232f8c2","in_reply_to":"3f79a3b5_9fcbb448","updated":"2018-10-09 11:58:44.000000000","message":"There was one consumer in neutron that I know I broke by the new kwarg, that\u0027s why I\u0027ve written this. While I did not find another consumer by codesearch.openstack.org there still could be consumers out somewhere, so if you don\u0027t mind I\u0027d leave this here.","commit_id":"d10137684ac060e689aa825cfcda9cf99f87c211"}]}