)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1e391eea741bc3d3dab120431bb462d3241c513e","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            # no csnat ports seen on this subnet - create csnat state"},{"line_number":539,"context_line":"            # for this subnet"},{"line_number":540,"context_line":"            subnet_info \u003d self.plugin_rpc.get_subnet_for_dvr("},{"line_number":541,"context_line":"                self.context, subnet_uuid, fixed_ips\u003dNone)"},{"line_number":542,"context_line":"            if not subnet_info:"},{"line_number":543,"context_line":"                LOG.warning(\"DVR: Unable to retrieve subnet information \""},{"line_number":544,"context_line":"                            \"for subnet_id %s. The subnet or the gateway \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a9136502","line":541,"updated":"2018-08-02 16:06:42.000000000","message":"So this fix looks good.  For context, the issue is on the server-side in get_subnet_for_dvr() it pulls fixed_ips[0][\u0027ip_address\u0027] if fixed_ips is passed, so as was described, if  it\u0027s the wrong port it would break things.  We really only want to pass the subnet uuid.\n\nI also want to look at other callers of this method, since if we only need the subnet uuid here (only fixed_ip[\u0027subnet_id\u0027] seems to be used), we should change the call signature.  I\u0027ll do that in a follow-on.","commit_id":"366736bc12727350bf2394e93208d159e175f837"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"94bee8731f553c69ee98b4f79205b5867f5b1831","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            # no csnat ports seen on this subnet - create csnat state"},{"line_number":539,"context_line":"            # for this subnet"},{"line_number":540,"context_line":"            subnet_info \u003d self.plugin_rpc.get_subnet_for_dvr("},{"line_number":541,"context_line":"                self.context, subnet_uuid, fixed_ips\u003dNone)"},{"line_number":542,"context_line":"            if not subnet_info:"},{"line_number":543,"context_line":"                LOG.warning(\"DVR: Unable to retrieve subnet information \""},{"line_number":544,"context_line":"                            \"for subnet_id %s. The subnet or the gateway \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ac230505","line":541,"in_reply_to":"3f79a3b5_4cc6f14a","updated":"2018-08-09 18:49:14.000000000","message":"Yes, we don\u0027t need to pass in here.\nWe can just pass in the subnet_uuid as you mentioned.\nI will clean it up and push the patch.","commit_id":"366736bc12727350bf2394e93208d159e175f837"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f351112b89c3cfbde3aeaa65f5d45c0f059a3a05","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            # no csnat ports seen on this subnet - create csnat state"},{"line_number":539,"context_line":"            # for this subnet"},{"line_number":540,"context_line":"            subnet_info \u003d self.plugin_rpc.get_subnet_for_dvr("},{"line_number":541,"context_line":"                self.context, subnet_uuid, fixed_ips\u003dNone)"},{"line_number":542,"context_line":"            if not subnet_info:"},{"line_number":543,"context_line":"                LOG.warning(\"DVR: Unable to retrieve subnet information \""},{"line_number":544,"context_line":"                            \"for subnet_id %s. The subnet or the gateway \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4cc6f14a","line":541,"in_reply_to":"3f79a3b5_66e0ac97","updated":"2018-08-09 18:44:18.000000000","message":"Swami - the fixed_ip is still passed in _bind_distributed_router_interface_port() but in this case I don\u0027t think we need it as if we pass a fixed_ip that isn\u0027t the gateway port we\u0027ll get the wrong mac returned.  Not sending it will get the mac of the gateway_ip fixed IP.","commit_id":"366736bc12727350bf2394e93208d159e175f837"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea1b3bcd7604bc1f7fa0d55766ab7fa06e13df31","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            # no csnat ports seen on this subnet - create csnat state"},{"line_number":539,"context_line":"            # for this subnet"},{"line_number":540,"context_line":"            subnet_info \u003d self.plugin_rpc.get_subnet_for_dvr("},{"line_number":541,"context_line":"                self.context, subnet_uuid, fixed_ips\u003dNone)"},{"line_number":542,"context_line":"            if not subnet_info:"},{"line_number":543,"context_line":"                LOG.warning(\"DVR: Unable to retrieve subnet information \""},{"line_number":544,"context_line":"                            \"for subnet_id %s. The subnet or the gateway \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4c77d103","line":541,"in_reply_to":"3f79a3b5_ac230505","updated":"2018-08-09 18:52:24.000000000","message":"Swami - I think this patch is fine as-is, just needs a test.  I created https://review.openstack.org/#/c/588641/ as a follow-on to clean this code up, just want to get this in for Rocky.","commit_id":"366736bc12727350bf2394e93208d159e175f837"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"70bfd2b17ffd0ce589cabc8dae9c535f6f4a3a50","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            # no csnat ports seen on this subnet - create csnat state"},{"line_number":539,"context_line":"            # for this subnet"},{"line_number":540,"context_line":"            subnet_info \u003d self.plugin_rpc.get_subnet_for_dvr("},{"line_number":541,"context_line":"                self.context, subnet_uuid, fixed_ips\u003dNone)"},{"line_number":542,"context_line":"            if not subnet_info:"},{"line_number":543,"context_line":"                LOG.warning(\"DVR: Unable to retrieve subnet information \""},{"line_number":544,"context_line":"                            \"for subnet_id %s. The subnet or the gateway \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_66e0ac97","line":541,"in_reply_to":"5f7c97a3_a9136502","updated":"2018-08-09 17:55:13.000000000","message":"Passing fixed ip to get_subnet_for_dvr was introduced in order to satisfy the condition where a pre-created router port is added in as a gateway port. \nIn that case the gateway IP of the subnet may be different then the port created later with a fixed IP.","commit_id":"366736bc12727350bf2394e93208d159e175f837"}]}
