)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"a9c388467a6c3f8d0f80df85e877a859a205562a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Basically, in case of concurrent requests creating ports"},{"line_number":10,"context_line":"on one network, only one request successes, other requests"},{"line_number":11,"context_line":"mostly getting \u0027standardattribute\u0027 update error as network"},{"line_number":12,"context_line":"revision_number changed about 8 times for all port updates."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch increases network revision_number in database,"},{"line_number":15,"context_line":"only when a port is created in a network, instead of each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_b59a0a0f","line":12,"range":{"start_line":11,"start_character":52,"end_line":12,"end_character":31},"updated":"2018-07-31 22:48:13.000000000","message":"I tried to reproduce this error but I couldn\u0027t. I tried to create/update a port or create a VM but the network\u0027s revision_number is unchanged.\n\nCould you share more details about how to reproduce this error? How you create the VM/port and which neutron plugins/drivers you were using?","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"},{"author":{"_account_id":14581,"name":"ymadhavi@in.ibm.com","email":"ymadhavi@in.ibm.com","username":"ymadhavi"},"change_message_id":"3747f2222049b631c4743f88f0721d69e3dace1f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Basically, in case of concurrent requests creating ports"},{"line_number":10,"context_line":"on one network, only one request successes, other requests"},{"line_number":11,"context_line":"mostly getting \u0027standardattribute\u0027 update error as network"},{"line_number":12,"context_line":"revision_number changed about 8 times for all port updates."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch increases network revision_number in database,"},{"line_number":15,"context_line":"only when a port is created in a network, instead of each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_1c1db2bc","line":12,"range":{"start_line":11,"start_character":52,"end_line":12,"end_character":31},"in_reply_to":"5f7c97a3_b59a0a0f","updated":"2018-08-09 04:47:10.000000000","message":"Please check the stack trace in comment 1, we need to try port creation concurrently with one network, irrespective of any driver this scenario will happen","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bdf705f841d008a0dc68a2e99eb6d18c25c533f1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"mostly getting \u0027standardattribute\u0027 update error as network"},{"line_number":12,"context_line":"revision_number changed about 8 times for all port updates."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch increases network revision_number in database,"},{"line_number":15,"context_line":"only when a port is created in a network, instead of each"},{"line_number":16,"context_line":"update on port."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idffb4edda616677b9b071644d3835c85052091a5"},{"line_number":19,"context_line":"Closes-Bug: #1782421"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_64bda1cf","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":15},"updated":"2018-08-01 01:10:22.000000000","message":"I think this statement needs some testing code.","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"},{"author":{"_account_id":14581,"name":"ymadhavi@in.ibm.com","email":"ymadhavi@in.ibm.com","username":"ymadhavi"},"change_message_id":"3747f2222049b631c4743f88f0721d69e3dace1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"mostly getting \u0027standardattribute\u0027 update error as network"},{"line_number":12,"context_line":"revision_number changed about 8 times for all port updates."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch increases network revision_number in database,"},{"line_number":15,"context_line":"only when a port is created in a network, instead of each"},{"line_number":16,"context_line":"update on port."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idffb4edda616677b9b071644d3835c85052091a5"},{"line_number":19,"context_line":"Closes-Bug: #1782421"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_6088a670","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":15},"in_reply_to":"5f7c97a3_64bda1cf","updated":"2018-08-09 04:47:10.000000000","message":"I added test code to check revision update on ip allocation only but not any other port updates","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9054ff9c34e65cabaacd8d355c9cd212af095591","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2018-07-31 06:16:09 -0400"},{"line_number":4,"context_line":"Commit:     ymadhavi@in.ibm.com \u003cymadhavi@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-09 05:29:22 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Basically, in case of concurrent requests creating ports"},{"line_number":8,"context_line":"on *one* network, only one request successes, other requests"},{"line_number":9,"context_line":"mostly getting \u0027standardattribute\u0027 update error as network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_35665c53","line":6,"updated":"2018-08-09 16:14:37.000000000","message":"You should put the one-line description back, it was something like \"Update network revision only when it needs it\" - or what you feel is a good description.","commit_id":"ebdb6fe0163d1c422734b6268c5e8d3f3f8de36b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8bd02dc38a5aa0bca7c51a4511400ef9910b17df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ymadhavi@in.ibm.com \u003cymadhavi@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-09 16:39:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update network revision only when it needs "},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Basically, in case of concurrent requests creating ports"},{"line_number":10,"context_line":"on *one* network, only one request successes, other requests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_046be684","line":7,"updated":"2018-08-10 02:50:14.000000000","message":"trailing white space","commit_id":"6a7d4eba37f134fd7a974e6a6ecb62337d8597ce"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fc8685282e232830c9e865514efd3186e0b43089","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update network revision only when it needs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Basically, in case of concurrent requests creating ports"},{"line_number":10,"context_line":"on *one* network, only one request successes, other requests"},{"line_number":11,"context_line":"mostly getting \u0027standardattribute\u0027 update error as network"},{"line_number":12,"context_line":"revision_number changed about 8 times for all port updates."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_6e15b79b","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":44},"updated":"2018-08-12 11:21:57.000000000","message":"succeeds","commit_id":"aa9dc0573b9372b7fa298daabaa30233e79d5bb3"}],"neutron/db/models_v2.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bdf705f841d008a0dc68a2e99eb6d18c25c533f1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\","},{"line_number":57,"context_line":"                                                        ondelete\u003d\"CASCADE\"),"},{"line_number":58,"context_line":"                           nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":59,"context_line":"    network_standard_attr \u003d orm.relationship("},{"line_number":60,"context_line":"        \u0027StandardAttribute\u0027, lazy\u003d\u0027subquery\u0027, viewonly\u003dTrue,"},{"line_number":61,"context_line":"        secondary\u003d\u0027networks\u0027, uselist\u003dFalse,"},{"line_number":62,"context_line":"        load_on_pending\u003dTrue)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    revises_on_change \u003d (\u0027port\u0027, \u0027network_standard_attr\u0027,)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_049e2d68","line":62,"range":{"start_line":59,"start_character":0,"end_line":62,"end_character":29},"updated":"2018-08-01 01:10:22.000000000","message":"I don\u0027t see any information about this change in the LP bug, could you please explain?","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"},{"author":{"_account_id":14581,"name":"ymadhavi@in.ibm.com","email":"ymadhavi@in.ibm.com","username":"ymadhavi"},"change_message_id":"3747f2222049b631c4743f88f0721d69e3dace1f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\","},{"line_number":57,"context_line":"                                                        ondelete\u003d\"CASCADE\"),"},{"line_number":58,"context_line":"                           nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":59,"context_line":"    network_standard_attr \u003d orm.relationship("},{"line_number":60,"context_line":"        \u0027StandardAttribute\u0027, lazy\u003d\u0027subquery\u0027, viewonly\u003dTrue,"},{"line_number":61,"context_line":"        secondary\u003d\u0027networks\u0027, uselist\u003dFalse,"},{"line_number":62,"context_line":"        load_on_pending\u003dTrue)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    revises_on_change \u003d (\u0027port\u0027, \u0027network_standard_attr\u0027,)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_20d06e50","line":62,"range":{"start_line":59,"start_character":0,"end_line":62,"end_character":29},"in_reply_to":"5f7c97a3_049e2d68","updated":"2018-08-09 04:47:10.000000000","message":"I mentioned about this in https://bugs.launchpad.net/neutron/+bug/1782421/comments/9\n\nthat only when a IP is allocated then only network revision number will be increased so that there will not be any ip collisions(check comment 4)","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"}],"neutron/services/revisions/revision_plugin.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bdf705f841d008a0dc68a2e99eb6d18c25c533f1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self._enforce_if_match_constraints(session)"},{"line_number":48,"context_line":"        # bump revision number for any updated objects in the session"},{"line_number":49,"context_line":"        for obj in session.dirty:"},{"line_number":50,"context_line":"            if (session.is_modified(obj) and"},{"line_number":51,"context_line":"                    isinstance(obj, standard_attr.HasStandardAttributes)):"},{"line_number":52,"context_line":"                self._bump_obj_revision(session, obj)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a48c1939","line":50,"range":{"start_line":50,"start_character":16,"end_line":50,"end_character":41},"updated":"2018-08-01 01:10:22.000000000","message":"I see, this is the change you mentioned in the LP bug.","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"},{"author":{"_account_id":14581,"name":"ymadhavi@in.ibm.com","email":"ymadhavi@in.ibm.com","username":"ymadhavi"},"change_message_id":"3747f2222049b631c4743f88f0721d69e3dace1f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self._enforce_if_match_constraints(session)"},{"line_number":48,"context_line":"        # bump revision number for any updated objects in the session"},{"line_number":49,"context_line":"        for obj in session.dirty:"},{"line_number":50,"context_line":"            if (session.is_modified(obj) and"},{"line_number":51,"context_line":"                    isinstance(obj, standard_attr.HasStandardAttributes)):"},{"line_number":52,"context_line":"                self._bump_obj_revision(session, obj)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_80c0627d","line":50,"range":{"start_line":50,"start_character":16,"end_line":50,"end_character":41},"in_reply_to":"5f7c97a3_a48c1939","updated":"2018-08-09 04:47:10.000000000","message":"Yes","commit_id":"bc0bb81f1a02f1a7e36b31029a18b9ddfde60b37"}],"neutron/tests/unit/services/revisions/test_revision_plugin.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"eb6b03a002e408097c0f6744e6581394301c9c15","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            rev \u003d port[\u0027port\u0027][\u0027revision_number\u0027]"},{"line_number":89,"context_line":"            network \u003d directory.get_plugin().get_network("},{"line_number":90,"context_line":"                self.ctx, port[\u0027port\u0027][\u0027network_id\u0027])"},{"line_number":91,"context_line":"            net_rev \u003d network[\u0027revision_number\u0027]"},{"line_number":92,"context_line":"            new \u003d {\u0027port\u0027: {\u0027name\u0027: \u0027seaweed\u0027}}"},{"line_number":93,"context_line":"            response \u003d self._update(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027], new)"},{"line_number":94,"context_line":"            new_rev \u003d response[\u0027port\u0027][\u0027revision_number\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d58f9dca","line":91,"updated":"2018-08-13 22:46:54.000000000","message":"I see code identical to lines 89-91 in four other places in this change, perhaps you could DRY it by pulling them into a utility function?","commit_id":"e9a7ed8c63ec5bb0fdca3406c8b21071729dd09d"}]}
