)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"eb03c40d08ea645eee032bef318ab56a6151452e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nguyen Phuong An \u003cAnNP@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-01 15:26:23 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix No SG-log data found."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we couldn\u0027t get ACCEPT packet log because there are some"},{"line_number":10,"context_line":"change related to ovs firewall code since ovs firewall logging is merged."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_e9b422d6","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":25},"updated":"2018-08-01 09:59:35.000000000","message":"no ACCEPT event can get for security group log","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"eb03c40d08ea645eee032bef318ab56a6151452e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix No SG-log data found."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we couldn\u0027t get ACCEPT packet log because there are some"},{"line_number":10,"context_line":"change related to ovs firewall code since ovs firewall logging is merged."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Regards to performance perspective, we only log first accepted packets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_09b87ec4","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":20},"updated":"2018-08-01 09:59:35.000000000","message":"cannot","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"eb03c40d08ea645eee032bef318ab56a6151452e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"log. So we only need to forward first accepted packet of each connection"},{"line_number":14,"context_line":"session to table 91 and table 92."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So this patch tries to fix these issues."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1782576"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_29be9aae","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":26},"updated":"2018-08-01 09:59:35.000000000","message":"fixes","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"eb03c40d08ea645eee032bef318ab56a6151452e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"So this patch tries to fix these issues."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1782576"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib6ced838a7ec6d5c459a8475318556001c31bdf0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_89c32e39","line":19,"updated":"2018-08-01 09:59:35.000000000","message":"Unnecessary blank","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"}],"doc/source/contributor/internals/openvswitch_firewall.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e0cb2da82a780aa9bc6064cfb77601e6cfa5dc5","unresolved":false,"context_lines":[{"line_number":468,"context_line":"Finally, packets sent to ``table 93`` were filtered by the firewall and should"},{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_1d73d2e9","line":471,"range":{"start_line":471,"start_character":0,"end_line":471,"end_character":7},"updated":"2018-08-01 17:01:30.000000000","message":"s/In regard to the","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e0cb2da82a780aa9bc6064cfb77601e6cfa5dc5","unresolved":false,"context_lines":[{"line_number":468,"context_line":"Finally, packets sent to ``table 93`` were filtered by the firewall and should"},{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_1d5c324a","line":471,"range":{"start_line":471,"start_character":58,"end_line":471,"end_character":63},"updated":"2018-08-01 17:01:30.000000000","message":"s/the first","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"336dc1face0dc001a2960020dd09c413a5100ee0","unresolved":false,"context_lines":[{"line_number":468,"context_line":"Finally, packets sent to ``table 93`` were filtered by the firewall and should"},{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_531db25e","line":471,"range":{"start_line":471,"start_character":58,"end_line":471,"end_character":63},"in_reply_to":"5f7c97a3_1d5c324a","updated":"2018-08-02 01:48:23.000000000","message":"Done","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"336dc1face0dc001a2960020dd09c413a5100ee0","unresolved":false,"context_lines":[{"line_number":468,"context_line":"Finally, packets sent to ``table 93`` were filtered by the firewall and should"},{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_f3371ee3","line":471,"range":{"start_line":471,"start_character":0,"end_line":471,"end_character":7},"in_reply_to":"5f7c97a3_1d73d2e9","updated":"2018-08-02 01:48:23.000000000","message":"Done","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e0cb2da82a780aa9bc6064cfb77601e6cfa5dc5","unresolved":false,"context_lines":[{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"},{"line_number":475,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_1dae722e","line":472,"range":{"start_line":472,"start_character":41,"end_line":472,"end_character":42},"updated":"2018-08-01 17:01:30.000000000","message":"nit: space","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e0cb2da82a780aa9bc6064cfb77601e6cfa5dc5","unresolved":false,"context_lines":[{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"},{"line_number":475,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_5db06a8d","line":472,"range":{"start_line":472,"start_character":0,"end_line":472,"end_character":1},"updated":"2018-08-01 17:01:30.000000000","message":"nit: space","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"336dc1face0dc001a2960020dd09c413a5100ee0","unresolved":false,"context_lines":[{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"},{"line_number":475,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_1333baf8","line":472,"range":{"start_line":472,"start_character":41,"end_line":472,"end_character":42},"in_reply_to":"5f7c97a3_1dae722e","updated":"2018-08-02 01:48:23.000000000","message":"Done","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"336dc1face0dc001a2960020dd09c413a5100ee0","unresolved":false,"context_lines":[{"line_number":469,"context_line":"be dropped. Default action is ``drop`` in this table."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"Regards to performance perspective, please note that only first accepted packet"},{"line_number":472,"context_line":" of each connection session will go to `` table 91`` and ``table 92``."},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"Future work"},{"line_number":475,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_b32d2691","line":472,"range":{"start_line":472,"start_character":0,"end_line":472,"end_character":1},"in_reply_to":"5f7c97a3_5db06a8d","updated":"2018-08-02 01:48:23.000000000","message":"Done","commit_id":"6fde1ebd303fffaba7f9c1d70d820ba206017860"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5432ce48f47e7d222e564043497ea2eb181d29cf","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                tp_dst\u003ddst_port,"},{"line_number":994,"context_line":"                actions\u003d\u0027output:{:d},resubmit(,{:d})\u0027.format("},{"line_number":995,"context_line":"                    port.ofport,"},{"line_number":996,"context_line":"                    ovs_consts.ACCEPTED_INGRESS_TRAFFIC_TABLE),"},{"line_number":997,"context_line":"            )"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"        # Track untracked"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ae65d01d","side":"PARENT","line":996,"range":{"start_line":996,"start_character":20,"end_line":996,"end_character":61},"updated":"2018-08-01 09:22:47.000000000","message":"Is logging for DHCP negotiation gonna work if we remove this? I have the same question for the IPv6 NDP above.","commit_id":"7d83f9d2885429538c3ae12106727f17789c3ced"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"38490f03661bd229ddcb531b1113088c5c96e464","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                tp_dst\u003ddst_port,"},{"line_number":994,"context_line":"                actions\u003d\u0027output:{:d},resubmit(,{:d})\u0027.format("},{"line_number":995,"context_line":"                    port.ofport,"},{"line_number":996,"context_line":"                    ovs_consts.ACCEPTED_INGRESS_TRAFFIC_TABLE),"},{"line_number":997,"context_line":"            )"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"        # Track untracked"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_29b1ba45","side":"PARENT","line":996,"range":{"start_line":996,"start_character":20,"end_line":996,"end_character":61},"in_reply_to":"5f7c97a3_ae65d01d","updated":"2018-08-01 09:38:56.000000000","message":"At the moment, it\u0027s just for security group rule.\nSo from my point of view, logging for DHCP and IPv6 NDP can be ignored. If there any usecase for this, we can propose it later something like logging for DHCP or IPv6 NDP. Do you think so?","commit_id":"7d83f9d2885429538c3ae12106727f17789c3ced"}],"neutron/services/logapi/drivers/openvswitch/ovs_firewall_log.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2f8e00c99bbe2e67aace0679234ad3d97e65ac8","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        pkt \u003d packet.Packet(msg.data)"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            cookie_entry \u003d self._get_cookie_by_id(cookie_id)"},{"line_number":170,"context_line":"            LOG.info(\"action\u003d%s project_id\u003d%s log_resource_ids\u003d%s vm_port\u003d%s \""},{"line_number":171,"context_line":"                     \"pkt\u003d%s\", cookie_entry.action, cookie_entry.project,"},{"line_number":172,"context_line":"                     list(cookie_entry.log_object_refs),"},{"line_number":173,"context_line":"                     cookie_entry.port, pkt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ce0fec35","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":20},"updated":"2018-08-01 09:27:47.000000000","message":"do you really want to change the level here?","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"162858be0da4fa43de5c8a6043c59f6bf8053b73","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        pkt \u003d packet.Packet(msg.data)"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            cookie_entry \u003d self._get_cookie_by_id(cookie_id)"},{"line_number":170,"context_line":"            LOG.info(\"action\u003d%s project_id\u003d%s log_resource_ids\u003d%s vm_port\u003d%s \""},{"line_number":171,"context_line":"                     \"pkt\u003d%s\", cookie_entry.action, cookie_entry.project,"},{"line_number":172,"context_line":"                     list(cookie_entry.log_object_refs),"},{"line_number":173,"context_line":"                     cookie_entry.port, pkt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_89c7ae65","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":20},"in_reply_to":"5f7c97a3_a9206a4c","updated":"2018-08-01 09:55:12.000000000","message":"Yes, you\u0027re right. Thanks.","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"87a55c03335250d30881c1d494500691574d7145","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        pkt \u003d packet.Packet(msg.data)"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            cookie_entry \u003d self._get_cookie_by_id(cookie_id)"},{"line_number":170,"context_line":"            LOG.info(\"action\u003d%s project_id\u003d%s log_resource_ids\u003d%s vm_port\u003d%s \""},{"line_number":171,"context_line":"                     \"pkt\u003d%s\", cookie_entry.action, cookie_entry.project,"},{"line_number":172,"context_line":"                     list(cookie_entry.log_object_refs),"},{"line_number":173,"context_line":"                     cookie_entry.port, pkt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a9206a4c","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":20},"in_reply_to":"5f7c97a3_a94f0a67","updated":"2018-08-01 09:47:29.000000000","message":"In prod environment it makes sense to imho to leave this to debug as it seems to only provide information about what rules were generated. This is an internal implementation details, I don\u0027t think it has any value for the operator, it\u0027s rather for troubleshooting.\n\nAlso if you think for any reason it should be changed, it should be done by a different patch. I don\u0027t see how is it related to the problem this patch tries to address.","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"ea7e39748bb92cb22bbb8f6168a67995bfa80ed1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        pkt \u003d packet.Packet(msg.data)"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            cookie_entry \u003d self._get_cookie_by_id(cookie_id)"},{"line_number":170,"context_line":"            LOG.info(\"action\u003d%s project_id\u003d%s log_resource_ids\u003d%s vm_port\u003d%s \""},{"line_number":171,"context_line":"                     \"pkt\u003d%s\", cookie_entry.action, cookie_entry.project,"},{"line_number":172,"context_line":"                     list(cookie_entry.log_object_refs),"},{"line_number":173,"context_line":"                     cookie_entry.port, pkt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a94f0a67","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":20},"in_reply_to":"5f7c97a3_ce0fec35","updated":"2018-08-01 09:32:35.000000000","message":"In production environment, it\u0027s difficult to require Operator to enable debug log level. So I decided to set it as INFO. Does that make sense?","commit_id":"0f33c1676a94c591786dadcb3fc2b2917933d4ee"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"be66be6509fdeeeb9fa6590b3bf6f660a5526b9a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def setup_logging():"},{"line_number":49,"context_line":"    log_file \u003d cfg.CONF.network_log.local_output_log_base"},{"line_number":50,"context_line":"    if log_file:"},{"line_number":51,"context_line":"        import logging"},{"line_number":52,"context_line":"        log_file_handler \u003d logging.handlers.WatchedFileHandler(log_file)"},{"line_number":53,"context_line":"        log_file_handler.setLevel(logging.DEBUG)"},{"line_number":54,"context_line":"        log_file_handler.setFormatter(logging.Formatter("},{"line_number":55,"context_line":"            fmt\u003d\"%(asctime)s %(message)s\", datefmt\u003dcfg.CONF.log_date_format))"},{"line_number":56,"context_line":"        LOG.logger.addHandler(log_file_handler)"},{"line_number":57,"context_line":"    elif cfg.CONF.use_journal:"},{"line_number":58,"context_line":"        journal_handler \u003d handlers.OSJournalHandler()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_14ac16e9","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":77},"updated":"2018-08-01 11:07:42.000000000","message":"just out of curiosity, how is this related to the accepted packets?","commit_id":"0b8ae0b83f1229a0ca4268e633a5b9a4f182a4dd"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"4becf2c1bde07512b33f55ee7d9c0398820aafa9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def setup_logging():"},{"line_number":49,"context_line":"    log_file \u003d cfg.CONF.network_log.local_output_log_base"},{"line_number":50,"context_line":"    if log_file:"},{"line_number":51,"context_line":"        import logging"},{"line_number":52,"context_line":"        log_file_handler \u003d logging.handlers.WatchedFileHandler(log_file)"},{"line_number":53,"context_line":"        log_file_handler.setLevel(logging.DEBUG)"},{"line_number":54,"context_line":"        log_file_handler.setFormatter(logging.Formatter("},{"line_number":55,"context_line":"            fmt\u003d\"%(asctime)s %(message)s\", datefmt\u003dcfg.CONF.log_date_format))"},{"line_number":56,"context_line":"        LOG.logger.addHandler(log_file_handler)"},{"line_number":57,"context_line":"    elif cfg.CONF.use_journal:"},{"line_number":58,"context_line":"        journal_handler \u003d handlers.OSJournalHandler()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_348592ae","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":77},"in_reply_to":"5f7c97a3_14ac16e9","updated":"2018-08-01 11:40:39.000000000","message":"Actually, It\u0027s not related to the accepted packets. It should be move to https://review.openstack.org/#/c/587770/. I\u0027m sorry for making you confused again :)","commit_id":"0b8ae0b83f1229a0ca4268e633a5b9a4f182a4dd"}]}