)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aebb2a0bbdee3df2c0fce40af45eb945ef9dc908","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in _delete_floatingip notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_69130dba","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":26},"updated":"2018-08-04 01:10:31.000000000","message":"Can you elaborate why?\nAre you writing l3 flavor? or just for consistency?\n\nAnyway for consistency, we should check all notification related to l3 flavor to pass context.\nor should we convert them into payload?","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e77b303ce6364417942cd5729879fbdc73c3f44d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in _delete_floatingip notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_8d21b550","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":26},"in_reply_to":"3f79a3b5_296c3507","updated":"2018-08-07 00:38:02.000000000","message":"Okay, you need context.\nCan you please explain why you need context?\nWhat do you want to do with the callback and the context?","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":27602,"name":"Wenran Xiao","email":"wenranxiao@gmail.com","username":"WenranXiao"},"change_message_id":"8650d64ddf9331a344e0e3180ccbe7810b69cdeb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in _delete_floatingip notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_296c3507","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":26},"in_reply_to":"3f79a3b5_69130dba","updated":"2018-08-04 02:29:58.000000000","message":"In fact, I was writing a project as a neutron service plugin, I need to get the notification of floating ip delete, so I found that this function _delete_floatingip has lost context.  should I report a bug? and add release note？\nany suggestions is good.","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"0dec0cd02469239e143e97e42e004bef39f416dc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_fdaa7bd0","line":11,"updated":"2018-08-03 19:51:43.000000000","message":"If this patch is for fixing an issue, it would require a bug report to describe what is the issue that this patch is trying to solve.","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":27602,"name":"Wenran Xiao","email":"wenranxiao@gmail.com","username":"WenranXiao"},"change_message_id":"4573be605a1b2c54a1c6ad712f74e2d8989b7be5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_2c943944","line":11,"in_reply_to":"3f79a3b5_05d035f7","updated":"2018-08-06 03:02:56.000000000","message":"Done :)","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1a42ce0a88a6b37d5bf033bf6bc94ff525d975f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_05d035f7","line":11,"in_reply_to":"3f79a3b5_fdaa7bd0","updated":"2018-08-05 06:57:16.000000000","message":"+1 definitely a bug should be reported and linked.","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":27602,"name":"Wenran Xiao","email":"wenranxiao@gmail.com","username":"WenranXiao"},"change_message_id":"4573be605a1b2c54a1c6ad712f74e2d8989b7be5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_ec9de166","line":11,"in_reply_to":"3f79a3b5_fdaa7bd0","updated":"2018-08-06 03:02:56.000000000","message":"Done :)","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93b120d27807873cb239900acb76a3a43f3cc9da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in _delete_floatingip notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"after_delete needs context information to process"},{"line_number":10,"context_line":"a delete on a floating ip."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"},{"line_number":13,"context_line":"Closes-bug: #1785539"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_6d18d91c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":26},"updated":"2018-08-07 00:38:50.000000000","message":"As I commented on PS1, can you please why it needs context?\nWhat do you want to do with it?","commit_id":"197464784182c9d1fe0093f69fae398e93cf7d1a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"bc6982e69b02168f28ed555dc6aef7e38104f0bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in l3 flavor notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some notifications pass context,"},{"line_number":10,"context_line":"1. FLOATING_IP AFTER_DELETE"},{"line_number":11,"context_line":"2. FLOATING_IP AFTER_DELETE"},{"line_number":12,"context_line":"3. ROUTER_GATEWAY AFTER_CREATE"},{"line_number":13,"context_line":"add context for them."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"},{"line_number":16,"context_line":"Closes-bug: #1785539"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_8350760c","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":21},"updated":"2018-08-08 18:20:36.000000000","message":"Please comment on why? for consistency.\nAs per discussion at bug report, this patch is only for consistency.\n\nalso please add unit tests to check if context is passed.","commit_id":"b56a7667d3e6bb3e938ca1dd7dda10ede18d1d82"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7d1dcfc64a26c484313a61696f1df4a4a5288b1a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in l3 flavor notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some notifications pass context,"},{"line_number":10,"context_line":"1. FLOATING_IP AFTER_DELETE"},{"line_number":11,"context_line":"2. FLOATING_IP AFTER_DELETE"},{"line_number":12,"context_line":"3. ROUTER_GATEWAY AFTER_CREATE"},{"line_number":13,"context_line":"add context for them."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"},{"line_number":16,"context_line":"Closes-bug: #1785539"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_cb3524dc","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":21},"in_reply_to":"3f79a3b5_8350760c","updated":"2018-08-08 20:52:19.000000000","message":"as said earlier, the reasoning is still not clear why this is even needed ? just writing a plugin is not enough, may be adding more details about plugin ? and operation that\u0027s processing context will help.","commit_id":"b56a7667d3e6bb3e938ca1dd7dda10ede18d1d82"},{"author":{"_account_id":27602,"name":"Wenran Xiao","email":"wenranxiao@gmail.com","username":"WenranXiao"},"change_message_id":"6cbac456e8bcb9fb6920f9420b0daea444f2e1c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in l3 flavor notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some notifications pass context,"},{"line_number":10,"context_line":"1. FLOATING_IP AFTER_DELETE"},{"line_number":11,"context_line":"2. FLOATING_IP AFTER_DELETE"},{"line_number":12,"context_line":"3. ROUTER_GATEWAY AFTER_CREATE"},{"line_number":13,"context_line":"add context for them."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"},{"line_number":16,"context_line":"Closes-bug: #1785539"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_eacc8cbd","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":21},"in_reply_to":"3f79a3b5_cb3524dc","updated":"2018-08-09 11:42:53.000000000","message":"When I receive AFTER_DELETE  notification, the floating ip already be deleted,  so I will  delete relation record in my db whether or not this floatingip is associated. Is there any problem with this logic?","commit_id":"b56a7667d3e6bb3e938ca1dd7dda10ede18d1d82"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d09c4f23be5fac05869fdecddf3d4394e33b2431","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass context in l3 flavor notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some notifications pass context,"},{"line_number":10,"context_line":"1. FLOATING_IP AFTER_DELETE"},{"line_number":11,"context_line":"2. FLOATING_IP AFTER_DELETE"},{"line_number":12,"context_line":"3. ROUTER_GATEWAY AFTER_CREATE"},{"line_number":13,"context_line":"add context for them."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I01ced41201b61c624e675375b7bcd9589b2553e0"},{"line_number":16,"context_line":"Closes-bug: #1785539"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_1b7a71f0","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":21},"in_reply_to":"3f79a3b5_eacc8cbd","updated":"2018-08-09 17:16:50.000000000","message":"https://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/l3_db.py#n1475\n\n(FLOATING_IP, PRECOMMIT_DELETE) should be used.","commit_id":"b56a7667d3e6bb3e938ca1dd7dda10ede18d1d82"}],"neutron/db/l3_db.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"0dec0cd02469239e143e97e42e004bef39f416dc","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            self._core_plugin.delete_port("},{"line_number":176,"context_line":"                context, port_id, l3_port_check\u003dFalse)"},{"line_number":177,"context_line":"            registry.notify(resources.FLOATING_IP, events.AFTER_DELETE,"},{"line_number":178,"context_line":"                            self, **fips[0])"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _get_dead_floating_port_candidates(self, context):"},{"line_number":181,"context_line":"        filters \u003d {\u0027device_id\u0027: [\u0027PENDING\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3ad559ba","line":178,"range":{"start_line":178,"start_character":36,"end_line":178,"end_character":40},"updated":"2018-08-03 19:51:43.000000000","message":"This needs the context as well?","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":27602,"name":"Wenran Xiao","email":"wenranxiao@gmail.com","username":"WenranXiao"},"change_message_id":"8650d64ddf9331a344e0e3180ccbe7810b69cdeb","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            self._core_plugin.delete_port("},{"line_number":176,"context_line":"                context, port_id, l3_port_check\u003dFalse)"},{"line_number":177,"context_line":"            registry.notify(resources.FLOATING_IP, events.AFTER_DELETE,"},{"line_number":178,"context_line":"                            self, **fips[0])"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _get_dead_floating_port_candidates(self, context):"},{"line_number":181,"context_line":"        filters \u003d {\u0027device_id\u0027: [\u0027PENDING\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_49d5f1b8","line":178,"range":{"start_line":178,"start_character":36,"end_line":178,"end_character":40},"in_reply_to":"3f79a3b5_3ad559ba","updated":"2018-08-04 02:29:58.000000000","message":"I will test.","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0783e8bc65dc8e43bf798adffd90fbdea8b871e2","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                                               include_gateway\u003dTrue)"},{"line_number":493,"context_line":"            self._create_router_gw_port(context, router,"},{"line_number":494,"context_line":"                                        new_network_id, ext_ips)"},{"line_number":495,"context_line":"            registry.notify(resources.ROUTER_GATEWAY,"},{"line_number":496,"context_line":"                            events.AFTER_CREATE,"},{"line_number":497,"context_line":"                            self._create_gw_port,"},{"line_number":498,"context_line":"                            gw_ips\u003dext_ips,"},{"line_number":499,"context_line":"                            network_id\u003dnew_network_id,"},{"line_number":500,"context_line":"                            router_id\u003drouter_id)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def _update_current_gw_port(self, context, router_id, router, ext_ips):"},{"line_number":503,"context_line":"        self._core_plugin.update_port(context, router.gw_port[\u0027id\u0027], {\u0027port\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_aad6f04e","line":500,"range":{"start_line":495,"start_character":0,"end_line":500,"end_character":48},"updated":"2018-08-04 21:23:40.000000000","message":"Here context is missing.","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0783e8bc65dc8e43bf798adffd90fbdea8b871e2","unresolved":false,"context_lines":[{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"        self._core_plugin.update_port(context.elevated(), external_port[\u0027id\u0027],"},{"line_number":1387,"context_line":"                                      {\u0027port\u0027: {\u0027device_id\u0027: fip_id}})"},{"line_number":1388,"context_line":"        registry.notify(resources.FLOATING_IP,"},{"line_number":1389,"context_line":"                        events.AFTER_UPDATE,"},{"line_number":1390,"context_line":"                        self._update_fip_assoc,"},{"line_number":1391,"context_line":"                        **assoc_result)"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"        if self._is_dns_integration_supported:"},{"line_number":1394,"context_line":"            self._process_dns_floatingip_create_postcommit(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6ad0d851","line":1391,"range":{"start_line":1388,"start_character":0,"end_line":1391,"end_character":39},"updated":"2018-08-04 21:23:40.000000000","message":"this notification also needs modification.","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e36c4b5027916c7796ec56fda1ae86beff10f780","unresolved":false,"context_lines":[{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"        self._core_plugin.update_port(context.elevated(), external_port[\u0027id\u0027],"},{"line_number":1387,"context_line":"                                      {\u0027port\u0027: {\u0027device_id\u0027: fip_id}})"},{"line_number":1388,"context_line":"        registry.notify(resources.FLOATING_IP,"},{"line_number":1389,"context_line":"                        events.AFTER_UPDATE,"},{"line_number":1390,"context_line":"                        self._update_fip_assoc,"},{"line_number":1391,"context_line":"                        **assoc_result)"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"        if self._is_dns_integration_supported:"},{"line_number":1394,"context_line":"            self._process_dns_floatingip_create_postcommit(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d84a117f","line":1391,"range":{"start_line":1388,"start_character":0,"end_line":1391,"end_character":39},"in_reply_to":"3f79a3b5_6ad0d851","updated":"2018-08-06 16:39:16.000000000","message":"not really assoc_result has context, it would break if context is explicitly added to call, for consistency it be done but that may need a refactor of _update_fip_assoc called to prepare assoc_result above","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"0dec0cd02469239e143e97e42e004bef39f416dc","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1429,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"},{"line_number":1430,"context_line":"            registry.notify(resources.FLOATING_IP,"},{"line_number":1431,"context_line":"                            events.PRECOMMIT_UPDATE,"},{"line_number":1432,"context_line":"                            self,"},{"line_number":1433,"context_line":"                            floatingip\u003dfloatingip,"},{"line_number":1434,"context_line":"                            floatingip_db\u003dfloatingip_db,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ba03a90f","line":1431,"range":{"start_line":1431,"start_character":35,"end_line":1431,"end_character":51},"updated":"2018-08-03 19:51:43.000000000","message":"Perhaps, this is out of the scope of this patch but it seems we need to add \u0027context\u0027 in here as well.","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":27602,"name":"Wenran Xiao","email":"wenranxiao@gmail.com","username":"WenranXiao"},"change_message_id":"8650d64ddf9331a344e0e3180ccbe7810b69cdeb","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"                context, id\u003dfloatingip_obj.id)"},{"line_number":1429,"context_line":"            floatingip_db \u003d floatingip_obj.db_obj"},{"line_number":1430,"context_line":"            registry.notify(resources.FLOATING_IP,"},{"line_number":1431,"context_line":"                            events.PRECOMMIT_UPDATE,"},{"line_number":1432,"context_line":"                            self,"},{"line_number":1433,"context_line":"                            floatingip\u003dfloatingip,"},{"line_number":1434,"context_line":"                            floatingip_db\u003dfloatingip_db,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_09c85953","line":1431,"range":{"start_line":1431,"start_character":35,"end_line":1431,"end_character":51},"in_reply_to":"3f79a3b5_ba03a90f","updated":"2018-08-04 02:29:58.000000000","message":"assoc_result has context as well","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0783e8bc65dc8e43bf798adffd90fbdea8b871e2","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"                            old_floatingip\u003dold_floatingip,"},{"line_number":1436,"context_line":"                            **assoc_result)"},{"line_number":1437,"context_line":""},{"line_number":1438,"context_line":"        registry.notify(resources.FLOATING_IP,"},{"line_number":1439,"context_line":"                        events.AFTER_UPDATE,"},{"line_number":1440,"context_line":"                        self._update_fip_assoc,"},{"line_number":1441,"context_line":"                        **assoc_result)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"        if self._is_dns_integration_supported:"},{"line_number":1444,"context_line":"            self._process_dns_floatingip_update_postcommit(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0ac5a48e","line":1441,"range":{"start_line":1438,"start_character":0,"end_line":1441,"end_character":39},"updated":"2018-08-04 21:23:40.000000000","message":"how about here?","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e36c4b5027916c7796ec56fda1ae86beff10f780","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"                            old_floatingip\u003dold_floatingip,"},{"line_number":1436,"context_line":"                            **assoc_result)"},{"line_number":1437,"context_line":""},{"line_number":1438,"context_line":"        registry.notify(resources.FLOATING_IP,"},{"line_number":1439,"context_line":"                        events.AFTER_UPDATE,"},{"line_number":1440,"context_line":"                        self._update_fip_assoc,"},{"line_number":1441,"context_line":"                        **assoc_result)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"        if self._is_dns_integration_supported:"},{"line_number":1444,"context_line":"            self._process_dns_floatingip_update_postcommit(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5b47db4c","line":1441,"range":{"start_line":1438,"start_character":0,"end_line":1441,"end_character":39},"in_reply_to":"3f79a3b5_0ac5a48e","updated":"2018-08-06 16:39:16.000000000","message":"assoc_result has context already","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1a42ce0a88a6b37d5bf033bf6bc94ff525d975f6","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"        self._core_plugin.delete_port(context.elevated(),"},{"line_number":1488,"context_line":"                                      floatingip.floating_port_id,"},{"line_number":1489,"context_line":"                                      l3_port_check\u003dFalse)"},{"line_number":1490,"context_line":"        registry.notify(resources.FLOATING_IP, events.AFTER_DELETE,"},{"line_number":1491,"context_line":"                        self, context\u003dcontext, **floatingip_dict)"},{"line_number":1492,"context_line":"        return floatingip_dict"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_65eb29b0","line":1491,"range":{"start_line":1490,"start_character":7,"end_line":1491,"end_character":65},"updated":"2018-08-05 06:57:16.000000000","message":"The reason why I dropped context in this notification was floatingip_dict had context in it, but with recent code which has changed since, i just tested on a devstack that floatingip_dict no longer has context in it !","commit_id":"7ba99ed246ef8d48071e6f2c7c9ad5845624218d"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"40ea120280fa8a49ca5013200d7c3287f1eaf9b6","unresolved":false,"context_lines":[{"line_number":3728,"context_line":"    def test_floatingip_delete_after_event(self):"},{"line_number":3729,"context_line":"        fake_method \u003d mock.Mock()"},{"line_number":3730,"context_line":"        try:"},{"line_number":3731,"context_line":"            registry.subscribe(fake_method, resources.FLOATING_IP,"},{"line_number":3732,"context_line":"                               events.AFTER_DELETE)"},{"line_number":3733,"context_line":"            with self.subnet(cidr\u003d\u002711.0.0.0/24\u0027) as public_sub:"},{"line_number":3734,"context_line":"                self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":3735,"context_line":"                f \u003d self._make_floatingip(self.fmt,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_bb681d21","line":3732,"range":{"start_line":3731,"start_character":44,"end_line":3732,"end_character":50},"updated":"2018-08-09 17:19:00.000000000","message":"Not only this callback, other callbacks should also be tested.","commit_id":"0593ed6b7b5d419ff180d38c6ca826900fa09623"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3830172cd9acb3c47de5b2a807f690d04deffbc8","unresolved":false,"context_lines":[{"line_number":1926,"context_line":"                                    events.BEFORE_CREATE, mock.ANY,"},{"line_number":1927,"context_line":"                                    context\u003dmock.ANY, network_id\u003dmock.ANY,"},{"line_number":1928,"context_line":"                                    router_id\u003dmock.ANY, subnets\u003dmock.ANY),"},{"line_number":1929,"context_line":"                                mock.call("},{"line_number":1930,"context_line":"                                    resources.ROUTER_GATEWAY,"},{"line_number":1931,"context_line":"                                    events.AFTER_CREATE, mock.ANY,"},{"line_number":1932,"context_line":"                                    context\u003dmock.ANY, gw_ips\u003dmock.ANY,"},{"line_number":1933,"context_line":"                                    network_id\u003dmock.ANY, router_id\u003dmock.ANY),"},{"line_number":1934,"context_line":"                                mock.call("},{"line_number":1935,"context_line":"                                    resources.ROUTER, events.AFTER_UPDATE,"},{"line_number":1936,"context_line":"                                    mock.ANY, context\u003dmock.ANY,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a99c17c0","line":1933,"range":{"start_line":1929,"start_character":32,"end_line":1933,"end_character":76},"updated":"2018-08-13 16:19:35.000000000","message":"only this call need to be asserted as context is added for AFTER_CREATE only !","commit_id":"7965b66b79f91e1b41ce6cb2912bf15a911d34b3"}]}
