)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e8b94608ece384b71d36c4ded5f2c86ce2ee284c","unresolved":false,"context_lines":[{"line_number":600,"context_line":"            # copy values over - except fixed_ips as"},{"line_number":601,"context_line":"            # they\u0027ve already been processed"},{"line_number":602,"context_line":"            port[\u0027port\u0027].pop(\u0027fixed_ips\u0027, None)"},{"line_number":603,"context_line":"            updated_port.update(port[\u0027port\u0027])"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"            if addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027]:"},{"line_number":606,"context_line":"                self._delete_allowed_address_pairs(context, id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BQuc%3D","line":603,"updated":"2013-11-28 08:19:09.000000000","message":"(Same comment as OVS plugin patch)\n\nIMO it is better to copy only allowed_address_pair. All other attributes are added in each method (_process_portbindings_create_and_update, is_security_group_member_updated, ...).","commit_id":"fa5b2573e387306bc536eea86b78a684554435e9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"914a6c4a7329b4250468a00544863b6d7cc7c0fe","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                                                              port)"},{"line_number":591,"context_line":"            if addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027]:"},{"line_number":592,"context_line":"                need_port_update_notify |\u003d ("},{"line_number":593,"context_line":"                    self.update_address_pairs_on_port(context, id, port,"},{"line_number":594,"context_line":"                                                      original_port,"},{"line_number":595,"context_line":"                                                      updated_port))"},{"line_number":596,"context_line":"            elif changed_fixed_ips:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9wcU%3D","line":593,"updated":"2013-12-06 10:39:48.000000000","message":"this is a nice tidy up of the earlier code. So I guess \u0027update_address_pairs_on_port\u0027 is relatively recent addition (confirmed at commit 00814fae ) its hard to search out all the places where this code is being used (i.e., .is_address_pairs_attribute_updated --\u003e _delete_allowed_address_pairs --\u003e _process_create_allowed_address_pairs)","commit_id":"60df1f84133272d956fa16927b24e82b933f9c9d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5aa579a2b782dcd008371890b186b0d0a0a51da1","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                                                              port)"},{"line_number":591,"context_line":"            if addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027]:"},{"line_number":592,"context_line":"                need_port_update_notify |\u003d ("},{"line_number":593,"context_line":"                    self.update_address_pairs_on_port(context, id, port,"},{"line_number":594,"context_line":"                                                      original_port,"},{"line_number":595,"context_line":"                                                      updated_port))"},{"line_number":596,"context_line":"            elif changed_fixed_ips:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9wXY%3D","line":593,"in_reply_to":"AAAATn%2F9wcU%3D","updated":"2013-12-06 10:48:18.000000000","message":"well, eventually followed the links to Ic871fea68fb9fcc862b1fd5ae5fe7aec540e4a30 - they all could have been in a single review, imo","commit_id":"60df1f84133272d956fa16927b24e82b933f9c9d"},{"author":{"_account_id":9073,"name":"Yuanchao Sun","email":"yuanchao.sun@gmail.com","username":"yuanchao"},"change_message_id":"da8c959c6d001f34e86b5214c03823f32eec9001","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            original_port \u003d super(Ml2Plugin, self).get_port(context, id)"},{"line_number":594,"context_line":"            updated_port \u003d super(Ml2Plugin, self).update_port(context, id,"},{"line_number":595,"context_line":"                                                              port)"},{"line_number":596,"context_line":"            if addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027]:"},{"line_number":597,"context_line":"                need_port_update_notify |\u003d ("},{"line_number":598,"context_line":"                    self.update_address_pairs_on_port(context, id, port,"},{"line_number":599,"context_line":"                                                      original_port,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2FbWA%3D","line":596,"updated":"2014-02-13 09:34:04.000000000","message":"In case addr_pair doesn\u0027t change, shouldn\u0027t we continue to check changed_fixed_ips?","commit_id":"9c500992e68fa3b62dd27f7e4f52c9fef2f47fe6"},{"author":{"_account_id":9349,"name":"Jon Grimm","email":"jon.grimm@gmail.com","username":"jgrimm"},"change_message_id":"6dd3d83b64e2298ff4665a47fd47b4a28b8f5a68","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            original_port \u003d super(Ml2Plugin, self).get_port(context, id)"},{"line_number":594,"context_line":"            updated_port \u003d super(Ml2Plugin, self).update_port(context, id,"},{"line_number":595,"context_line":"                                                              port)"},{"line_number":596,"context_line":"            if addr_pair.ADDRESS_PAIRS in port[\u0027port\u0027]:"},{"line_number":597,"context_line":"                need_port_update_notify |\u003d ("},{"line_number":598,"context_line":"                    self.update_address_pairs_on_port(context, id, port,"},{"line_number":599,"context_line":"                                                      original_port,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2BUao%3D","line":596,"in_reply_to":"AAAAUX%2F%2FbWA%3D","updated":"2014-02-21 22:12:51.000000000","message":"I\u0027m sorry I didn\u0027t notice your comment until now.  Let me go look a bit more, I believe the nicira driver was behaving the way I coded it, but that doesn\u0027t mean it was the right thing to do either.  :)  It wouldn\u0027t be difficult to change if so.","commit_id":"9c500992e68fa3b62dd27f7e4f52c9fef2f47fe6"}],"neutron/plugins/nec/nec_plugin.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"914a6c4a7329b4250468a00544863b6d7cc7c0fe","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                need_port_update_notify |\u003d ("},{"line_number":583,"context_line":"                    self.update_address_pairs_on_port(context, id, port,"},{"line_number":584,"context_line":"                                                      old_port,"},{"line_number":585,"context_line":"                                                      new_port))"},{"line_number":586,"context_line":"            elif changed_fixed_ips:"},{"line_number":587,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":588,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9wY4%3D","line":585,"updated":"2013-12-06 10:39:48.000000000","message":"q: in \u0027def update_address_pairs_on_port\u0027 the main difference I can see from what was previously done here is to assign new_pairs to the updated_port address pairs.\n\nIs that the actual fix here, I mean the reason this method was returning existing rather than updated port info?","commit_id":"60df1f84133272d956fa16927b24e82b933f9c9d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d6ac3168f3ab0b73523e37bf6fa245abcda18f75","unresolved":false,"context_lines":[{"line_number":583,"context_line":"                self._process_create_allowed_address_pairs("},{"line_number":584,"context_line":"                    context, new_port,"},{"line_number":585,"context_line":"                    port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS])"},{"line_number":586,"context_line":"                need_port_update_notify \u003d True"},{"line_number":587,"context_line":"            elif changed_fixed_ips:"},{"line_number":588,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":589,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FZSo%3D","side":"PARENT","line":586,"updated":"2014-01-14 08:23:05.000000000","message":"i see same code in ./neutron/plugins/openvswitch/ovs_neutron_plugin.py:597 - does it also need to be changed here?","commit_id":"7fcb64c87b66499f1ebb4419dd4c2644e061bb25"},{"author":{"_account_id":9349,"name":"Jon Grimm","email":"jon.grimm@gmail.com","username":"jgrimm"},"change_message_id":"19a0bdabbc9d80dfb60d490da019c5e56071ac7a","unresolved":false,"context_lines":[{"line_number":583,"context_line":"                self._process_create_allowed_address_pairs("},{"line_number":584,"context_line":"                    context, new_port,"},{"line_number":585,"context_line":"                    port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS])"},{"line_number":586,"context_line":"                need_port_update_notify \u003d True"},{"line_number":587,"context_line":"            elif changed_fixed_ips:"},{"line_number":588,"context_line":"                self._check_fixed_ips_and_address_pairs_no_overlap("},{"line_number":589,"context_line":"                    context, new_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FXQM%3D","side":"PARENT","line":586,"in_reply_to":"AAAAUH%2F%2FZSo%3D","updated":"2014-01-14 16:53:29.000000000","message":"You are correct.  And its already done.. as part of separate patch:\nhttps://review.openstack.org/#/c/58847/","commit_id":"7fcb64c87b66499f1ebb4419dd4c2644e061bb25"}],"neutron/tests/unit/nec/test_nec_plugin.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d6ac3168f3ab0b73523e37bf6fa245abcda18f75","unresolved":false,"context_lines":[{"line_number":848,"context_line":""},{"line_number":849,"context_line":"class TestNecAllowedAddressPairs(NecPluginV2TestCase,"},{"line_number":850,"context_line":"                                 test_pair.TestAllowedAddressPairs):"},{"line_number":851,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FZSI%3D","line":851,"updated":"2014-01-14 08:23:05.000000000","message":"todo?","commit_id":"9c500992e68fa3b62dd27f7e4f52c9fef2f47fe6"},{"author":{"_account_id":9349,"name":"Jon Grimm","email":"jon.grimm@gmail.com","username":"jgrimm"},"change_message_id":"19a0bdabbc9d80dfb60d490da019c5e56071ac7a","unresolved":false,"context_lines":[{"line_number":848,"context_line":""},{"line_number":849,"context_line":"class TestNecAllowedAddressPairs(NecPluginV2TestCase,"},{"line_number":850,"context_line":"                                 test_pair.TestAllowedAddressPairs):"},{"line_number":851,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FXHs%3D","line":851,"in_reply_to":"AAAAUH%2F%2FZSI%3D","updated":"2014-01-14 16:53:29.000000000","message":"Nope. Inheriting from the parent classes is all that was needed. See neutron.tests.unit.test_extension_allowedaddresspairs for the actual tests (if interested). Thanks!","commit_id":"9c500992e68fa3b62dd27f7e4f52c9fef2f47fe6"}]}