)]}'
{"neutron/tests/unit/test_l3_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"063e3a5ba8fbddb15d364a2d0358479a5fa64180","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        router \u003d self._prepare_router_data()"},{"line_number":579,"context_line":"        ri \u003d l3_agent.RouterInfo(router[\u0027id\u0027], self.conf.root_helper,"},{"line_number":580,"context_line":"                                 self.conf.use_namespaces, router\u003drouter)"},{"line_number":581,"context_line":"        called \u003d {\u0027count\u0027: 0}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        def fake_internal_network_added(*args):"},{"line_number":584,"context_line":"            if called[\u0027count\u0027] \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BQjw%3D","line":581,"updated":"2013-11-28 08:54:30.000000000","message":"consider removing #581 - #588, and just do\n  internal_network_added.side_effect \u003d Exception\non #593 and \n  internal_network_added.side_effect \u003d None\nbefore #603","commit_id":"8ba684439fe79fb299c585e01b9659d35d55dae8"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"f2fb280410edc75e116fbee83f31608fca4f0a74","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        router \u003d self._prepare_router_data()"},{"line_number":579,"context_line":"        ri \u003d l3_agent.RouterInfo(router[\u0027id\u0027], self.conf.root_helper,"},{"line_number":580,"context_line":"                                 self.conf.use_namespaces, router\u003drouter)"},{"line_number":581,"context_line":"        called \u003d {\u0027count\u0027: 0}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        def fake_internal_network_added(*args):"},{"line_number":584,"context_line":"            if called[\u0027count\u0027] \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BQic%3D","line":581,"in_reply_to":"AAAATn%2F%2BQjw%3D","updated":"2013-11-28 08:57:05.000000000","message":"Good point. Thanks.","commit_id":"8ba684439fe79fb299c585e01b9659d35d55dae8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"063e3a5ba8fbddb15d364a2d0358479a5fa64180","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                                 self.conf.use_namespaces, router\u003drouter)"},{"line_number":614,"context_line":"        # add an internal port"},{"line_number":615,"context_line":"        agent.process_router(ri)"},{"line_number":616,"context_line":"        called \u003d {\u0027count\u0027: 0}"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        def fake_internal_network_removed(*args):"},{"line_number":619,"context_line":"            if called[\u0027count\u0027] \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BQjk%3D","line":616,"updated":"2013-11-28 08:54:30.000000000","message":"ditto","commit_id":"8ba684439fe79fb299c585e01b9659d35d55dae8"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c454c3092b5779eb5084fff7c7d47afac4a7c22f","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            # raise an exception to simulate that an unexpected exception"},{"line_number":585,"context_line":"            # occurrs"},{"line_number":586,"context_line":"            internal_network_added.side_effect \u003d Exception"},{"line_number":587,"context_line":"            try:"},{"line_number":588,"context_line":"                agent.process_router(ri)"},{"line_number":589,"context_line":"            except Exception:"},{"line_number":590,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BQac%3D","line":587,"updated":"2013-11-28 09:21:19.000000000","message":"please use \n self.assertRaises(Exception, agent.process_router, ri)","commit_id":"815bd524fdeead5d5b326ea243128f4b6c954948"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"4acb4a341401e17074f1d430e39d469fc1850aa3","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            # raise an exception to simulate that an unexpected exception"},{"line_number":585,"context_line":"            # occurrs"},{"line_number":586,"context_line":"            internal_network_added.side_effect \u003d Exception"},{"line_number":587,"context_line":"            try:"},{"line_number":588,"context_line":"                agent.process_router(ri)"},{"line_number":589,"context_line":"            except Exception:"},{"line_number":590,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BNko%3D","line":587,"in_reply_to":"AAAATn%2F%2BPXw%3D","updated":"2013-11-29 03:29:38.000000000","message":"Done","commit_id":"815bd524fdeead5d5b326ea243128f4b6c954948"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"6cd5c29a9f873b784ced0b63b4d1bdcaea0e9a1a","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            # raise an exception to simulate that an unexpected exception"},{"line_number":585,"context_line":"            # occurrs"},{"line_number":586,"context_line":"            internal_network_added.side_effect \u003d Exception"},{"line_number":587,"context_line":"            try:"},{"line_number":588,"context_line":"                agent.process_router(ri)"},{"line_number":589,"context_line":"            except Exception:"},{"line_number":590,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BPXw%3D","line":587,"in_reply_to":"AAAATn%2F%2BQU0%3D","updated":"2013-11-28 12:55:19.000000000","message":"right, but you make it everything you want on line 586","commit_id":"815bd524fdeead5d5b326ea243128f4b6c954948"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"9fb6c4c1a1f94cb924881b502738226d8e5b9871","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            # raise an exception to simulate that an unexpected exception"},{"line_number":585,"context_line":"            # occurrs"},{"line_number":586,"context_line":"            internal_network_added.side_effect \u003d Exception"},{"line_number":587,"context_line":"            try:"},{"line_number":588,"context_line":"                agent.process_router(ri)"},{"line_number":589,"context_line":"            except Exception:"},{"line_number":590,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BQU0%3D","line":587,"in_reply_to":"AAAATn%2F%2BQac%3D","updated":"2013-11-28 09:36:53.000000000","message":"pep8 would complain. \n\nH202  assertRaises Exception too broad","commit_id":"815bd524fdeead5d5b326ea243128f4b6c954948"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c454c3092b5779eb5084fff7c7d47afac4a7c22f","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            internal_net_removed.side_effect \u003d Exception"},{"line_number":618,"context_line":"            ri.internal_ports[0][\u0027admin_state_up\u0027] \u003d False"},{"line_number":619,"context_line":"            # The above port is set to down state, remove it."},{"line_number":620,"context_line":"            try:"},{"line_number":621,"context_line":"                agent.process_router(ri)"},{"line_number":622,"context_line":"            except Exception:"},{"line_number":623,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BQaI%3D","line":620,"updated":"2013-11-28 09:21:19.000000000","message":"same as above","commit_id":"815bd524fdeead5d5b326ea243128f4b6c954948"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"d0adde19b1c57c3d18fc96da55e528c53266581e","unresolved":false,"context_lines":[{"line_number":583,"context_line":"                l3_agent.L3NATAgent,"},{"line_number":584,"context_line":"                \u0027internal_network_added\u0027) as internal_network_added:"},{"line_number":585,"context_line":"            # raise RuntimeError to simulate that an unexpected exception"},{"line_number":586,"context_line":"            # occurrs"},{"line_number":587,"context_line":"            internal_network_added.side_effect \u003d RuntimeError"},{"line_number":588,"context_line":"            self.assertRaises(RuntimeError, agent.process_router, ri)"},{"line_number":589,"context_line":"            self.assertNotIn("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9rg8%3D","line":586,"updated":"2013-12-08 05:44:24.000000000","message":"occurrs -\u003e occurs","commit_id":"dd71021347f782608575d551f2329715c00546ce"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"d0adde19b1c57c3d18fc96da55e528c53266581e","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                l3_agent.L3NATAgent,"},{"line_number":612,"context_line":"                \u0027internal_network_removed\u0027) as internal_net_removed:"},{"line_number":613,"context_line":"            # raise RuntimeError to simulate that an unexpected exception"},{"line_number":614,"context_line":"            # occurrs"},{"line_number":615,"context_line":"            internal_net_removed.side_effect \u003d RuntimeError"},{"line_number":616,"context_line":"            ri.internal_ports[0][\u0027admin_state_up\u0027] \u003d False"},{"line_number":617,"context_line":"            # The above port is set to down state, remove it."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9rg4%3D","line":614,"updated":"2013-12-08 05:44:24.000000000","message":"ditto","commit_id":"dd71021347f782608575d551f2329715c00546ce"}]}
