)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"fc9418ee2ffcbdf78f880374075d3bd2b13521b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the switch to \"CacheBackedPluginApi\" the ovs-agent didn\u0027t try to"},{"line_number":10,"context_line":"rebind ports at startup that were in the \"binding_failed\" state. This is"},{"line_number":11,"context_line":"because the rebinding was triggered as part of the old implementation of"},{"line_number":12,"context_line":"\"get_device_details()\" on the server side."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit changes the \"CacheBackedPluginApi.get_device_details()\" call"},{"line_number":15,"context_line":"to fall back to the older implementation when encountering affected Ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b60c9641","line":12,"range":{"start_line":11,"start_character":51,"end_line":12,"end_character":42},"updated":"2018-08-10 17:07:39.000000000","message":"Why is there a mismatch between old and new implementation. Should we not then provide the right versions for RPC in the agent and server to match so that this does not happen.","commit_id":"a28093e75e248fb36ac69ca08358fd14dfe21ebf"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"5e4513ba6f7e8b0b8ef6180aa246976134ec17d0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the switch to \"CacheBackedPluginApi\" the ovs-agent didn\u0027t try to"},{"line_number":10,"context_line":"rebind ports at startup that were in the \"binding_failed\" state. This is"},{"line_number":11,"context_line":"because the rebinding was triggered as part of the old implementation of"},{"line_number":12,"context_line":"\"get_device_details()\" on the server side."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit changes the \"CacheBackedPluginApi.get_device_details()\" call"},{"line_number":15,"context_line":"to fall back to the older implementation when encountering affected Ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_62849cd3","line":12,"range":{"start_line":11,"start_character":51,"end_line":12,"end_character":42},"in_reply_to":"3f79a3b5_b60c9641","updated":"2018-08-16 01:55:20.000000000","message":"Swami, could you elaborate more on this. What do you mean by mismatch between old and new?","commit_id":"a28093e75e248fb36ac69ca08358fd14dfe21ebf"}],"neutron/agent/rpc.py":[{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"5e4513ba6f7e8b0b8ef6180aa246976134ec17d0","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            LOG.warning(\"Device %s is not bound.\", port_obj)"},{"line_number":284,"context_line":"            return super(CacheBackedPluginApi, self).get_device_details("},{"line_number":285,"context_line":"                context, device, agent_id, host"},{"line_number":286,"context_line":"            )"},{"line_number":287,"context_line":"        segment \u003d port_obj.binding_levels[-1].segment"},{"line_number":288,"context_line":"        if not segment:"},{"line_number":289,"context_line":"            LOG.debug(\"Device %s is not bound to any segment.\", port_obj)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c5c33a37","line":286,"updated":"2018-08-16 01:55:20.000000000","message":"Does the \u0027remote_resouce_cache\u0027 need to be updated at this point? otherwise the call in line 277 will always return\nport_obj.binding_levels \u003d None. Or does some other part of the code do the updating already?\nmaybe using record_resource_update\nfrom neutron\\agent\\resource_cache.py (line 194) ? Not sure that\u0027s the correct method, but it looks like it can be used to update teh remote_resource_cache","commit_id":"a28093e75e248fb36ac69ca08358fd14dfe21ebf"}]}
