)]}'
{"neutron/plugins/nicira/NeutronServicePlugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"93095251c427843ccea091113ffac0b8e52b5eda","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"    def update_vip(self, context, id, vip):"},{"line_number":1202,"context_line":"        edge_id \u003d self._get_edge_id_by_vip_id(context, id)"},{"line_number":1203,"context_line":"        old_vip \u003d self.get_vip(context, id)"},{"line_number":1204,"context_line":"        session_persistence_update \u003d True"},{"line_number":1205,"context_line":"        if vip[\u0027vip\u0027].get(\u0027session_persistence\u0027):"},{"line_number":1206,"context_line":"            session_persistence_update \u003d True"},{"line_number":1207,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BqL8%3D","line":1204,"updated":"2014-02-19 23:26:25.000000000","message":"replace 1204-1208:\n\nsession_persistence_update \u003d bool(vip[\u0027vip\u0027].get(\u0027session_persistence\u0027, True)","commit_id":"56837b707e9ff136fd68e4cfd69c8c9e3b76bb41"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"46b4a7a6d39e0b20fc043a3321e5c9de5c58bf24","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"    def update_vip(self, context, id, vip):"},{"line_number":1202,"context_line":"        edge_id \u003d self._get_edge_id_by_vip_id(context, id)"},{"line_number":1203,"context_line":"        old_vip \u003d self.get_vip(context, id)"},{"line_number":1204,"context_line":"        session_persistence_update \u003d True"},{"line_number":1205,"context_line":"        if vip[\u0027vip\u0027].get(\u0027session_persistence\u0027):"},{"line_number":1206,"context_line":"            session_persistence_update \u003d True"},{"line_number":1207,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BoSk%3D","line":1204,"in_reply_to":"AAAAUX%2F%2BqL8%3D","updated":"2014-02-20 05:01:20.000000000","message":"Done","commit_id":"56837b707e9ff136fd68e4cfd69c8c9e3b76bb41"}],"neutron/plugins/nicira/vshield/edge_loadbalancer_driver.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"8913ddec67d78cb8cc3742f6c82f5e6bf3fb2a9d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027defaultPoolId\u0027: pool_vseid,"},{"line_number":67,"context_line":"            \u0027applicationProfileId\u0027: app_profileid"},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"        if vse_vip[\u0027connectionLimit\u0027] \u003c\u003d 0:"},{"line_number":70,"context_line":"            vse_vip[\u0027connectionLimit\u0027] \u003d 0"},{"line_number":71,"context_line":"        return vse_vip"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F92R8%3D","line":69,"updated":"2013-12-05 09:36:34.000000000","message":"vsi_vip[\u0027connectionLimit\u0027] \u003d max(0, vsi_vip[\u0027connectionLimit\u0027])","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"9d8fbf77aa4a16d183327d0929831c1468106de6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027defaultPoolId\u0027: pool_vseid,"},{"line_number":67,"context_line":"            \u0027applicationProfileId\u0027: app_profileid"},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"        if vse_vip[\u0027connectionLimit\u0027] \u003c\u003d 0:"},{"line_number":70,"context_line":"            vse_vip[\u0027connectionLimit\u0027] \u003d 0"},{"line_number":71,"context_line":"        return vse_vip"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9KaE%3D","line":69,"in_reply_to":"AAAATn%2F92R8%3D","updated":"2013-12-16 05:46:58.000000000","message":"Done","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"change_message_id":"9b0ffc73cc274a97f448ab8fb0c5ff6ce322a946","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def create_vip(self, context, edge_id, vip):"},{"line_number":175,"context_line":"        app_profile \u003d self._convert_app_profile("},{"line_number":176,"context_line":"            vip[\u0027name\u0027], (vip.get(\u0027session_persistence\u0027) or {}),"},{"line_number":177,"context_line":"            vip.get(\u0027protocol\u0027))"},{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            header, response \u003d self.vcns.create_app_profile("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9RhI%3D","line":176,"updated":"2013-12-13 07:48:33.000000000","message":"You can just use vip.get(\u0027session_persistence\u0027, {}) for second argument.","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"9d8fbf77aa4a16d183327d0929831c1468106de6","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def create_vip(self, context, edge_id, vip):"},{"line_number":175,"context_line":"        app_profile \u003d self._convert_app_profile("},{"line_number":176,"context_line":"            vip[\u0027name\u0027], (vip.get(\u0027session_persistence\u0027) or {}),"},{"line_number":177,"context_line":"            vip.get(\u0027protocol\u0027))"},{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            header, response \u003d self.vcns.create_app_profile("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9KZU%3D","line":176,"in_reply_to":"AAAATn%2F9RhI%3D","updated":"2013-12-16 05:46:58.000000000","message":"Actually, vip \u003d {....\n\n\u0027session_persistence\u0027: None} accroding to the new get_vip db func. So if just use vip.get(\u0027session_persistence\u0027, {}), it would just return None.","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"change_message_id":"9b0ffc73cc274a97f448ab8fb0c5ff6ce322a946","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                edge_id, app_profile)"},{"line_number":181,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":182,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":183,"context_line":"                LOG.exception(_(\"Failed to create app profile on edge: %s\") %"},{"line_number":184,"context_line":"                              edge_id)"},{"line_number":185,"context_line":"        objuri \u003d header[\u0027location\u0027]"},{"line_number":186,"context_line":"        app_profileid \u003d objuri[objuri.rfind(\"/\") + 1:]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9RhA%3D","line":183,"updated":"2013-12-13 07:48:33.000000000","message":"It is OK to use the original style (I did get comment about using the original one).","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"9d8fbf77aa4a16d183327d0929831c1468106de6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                edge_id, app_profile)"},{"line_number":181,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":182,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":183,"context_line":"                LOG.exception(_(\"Failed to create app profile on edge: %s\") %"},{"line_number":184,"context_line":"                              edge_id)"},{"line_number":185,"context_line":"        objuri \u003d header[\u0027location\u0027]"},{"line_number":186,"context_line":"        app_profileid \u003d objuri[objuri.rfind(\"/\") + 1:]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9KZ8%3D","line":183,"in_reply_to":"AAAATn%2F9RhA%3D","updated":"2013-12-16 05:46:58.000000000","message":"Done","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"change_message_id":"9b0ffc73cc274a97f448ab8fb0c5ff6ce322a946","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                edge_id, vip_new)"},{"line_number":192,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":193,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":194,"context_line":"                LOG.exception(_(\"Failed to create vip on vshield edge: %s\") %"},{"line_number":195,"context_line":"                              edge_id)"},{"line_number":196,"context_line":"                self.vcns.delete_app_profile(edge_id, app_profileid)"},{"line_number":197,"context_line":"        objuri \u003d header[\u0027location\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Rg8%3D","line":194,"updated":"2013-12-13 07:48:33.000000000","message":"Same, just leave it as it was.","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"9d8fbf77aa4a16d183327d0929831c1468106de6","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                edge_id, vip_new)"},{"line_number":192,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":193,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":194,"context_line":"                LOG.exception(_(\"Failed to create vip on vshield edge: %s\") %"},{"line_number":195,"context_line":"                              edge_id)"},{"line_number":196,"context_line":"                self.vcns.delete_app_profile(edge_id, app_profileid)"},{"line_number":197,"context_line":"        objuri \u003d header[\u0027location\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9KZs%3D","line":194,"in_reply_to":"AAAATn%2F9Rg8%3D","updated":"2013-12-16 05:46:58.000000000","message":"Done","commit_id":"1bfd215a5abf26bb24aa2878ddb350f228863a46"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"change_message_id":"377563b4ff95faa02517c7ca9f25ab691c848bd4","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            vip[\u0027name\u0027], vip.get(\u0027session_persistence\u0027, {}),"},{"line_number":237,"context_line":"            vip.get(\u0027protocol\u0027))"},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            self.vcns.update_app_profile("},{"line_number":240,"context_line":"                edge_id, app_profileid, app_profile)"},{"line_number":241,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":242,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F86uk%3D","line":239,"updated":"2013-12-18 20:14:32.000000000","message":"I suggest to do this only if app_profile is changed because vcns operation is very slow.","commit_id":"20f5e3fe997ea54944da838ce244664c28628013"}]}