)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7618133b63d5c4fc7939ec8f7d4002cb82da9868","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nguyen Phuong An \u003cAnNP@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-15 13:48:47 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix lost connection when create security group log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1787106"},{"line_number":10,"context_line":"Change-Id: I6e95e2e646ec8a5507c7f140ab2c4a56be8404c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_59716a43","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2018-08-15 09:05:16.000000000","message":"In order to provent the code aggression, some tempest verify test case seems needed.","commit_id":"6d1b236a8a68f39bc293f959ed97f048d4c0de7b"}],"neutron/services/logapi/drivers/openvswitch/ovs_firewall_log.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7618133b63d5c4fc7939ec8f7d4002cb82da9868","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        table \u003d flow[\u0027table\u0027] \u003d OVS_FW_TO_LOG_TABLES[flow[\u0027table\u0027]]"},{"line_number":344,"context_line":"        flow[\u0027actions\u0027] \u003d \u0027controller\u0027"},{"line_number":345,"context_line":"        # forward egress accepted packet and log"},{"line_number":346,"context_line":"        if table \u003d\u003d ovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE:"},{"line_number":347,"context_line":"            flow[\u0027actions\u0027] \u003d \u0027normal,controller\u0027"},{"line_number":348,"context_line":"        self._add_flow(**flow)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_39c82e72","line":346,"range":{"start_line":346,"start_character":11,"end_line":346,"end_character":16},"updated":"2018-08-15 09:05:16.000000000","message":"Nit: why not directly use flow[\u0027table\u0027] since that ``table`` variable is not used more than once？","commit_id":"6d1b236a8a68f39bc293f959ed97f048d4c0de7b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"43786713a1ab89fd2d3628a93e3631c7ff876ae4","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        table \u003d flow[\u0027table\u0027] \u003d OVS_FW_TO_LOG_TABLES[flow[\u0027table\u0027]]"},{"line_number":344,"context_line":"        flow[\u0027actions\u0027] \u003d \u0027controller\u0027"},{"line_number":345,"context_line":"        # forward egress accepted packet and log"},{"line_number":346,"context_line":"        if table \u003d\u003d ovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE:"},{"line_number":347,"context_line":"            flow[\u0027actions\u0027] \u003d \u0027normal,controller\u0027"},{"line_number":348,"context_line":"        self._add_flow(**flow)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f9c95625","line":346,"range":{"start_line":346,"start_character":11,"end_line":346,"end_character":16},"in_reply_to":"3f79a3b5_39c82e72","updated":"2018-08-15 09:08:18.000000000","message":"I understand it this is to avoid doing a lookup in flow dictionary. It may be considered a premature optimization though as the lookup is really fast :)","commit_id":"6d1b236a8a68f39bc293f959ed97f048d4c0de7b"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"8f166acf4a6cf44def25ea09c1644d917fc9f94a","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        table \u003d flow[\u0027table\u0027] \u003d OVS_FW_TO_LOG_TABLES[flow[\u0027table\u0027]]"},{"line_number":344,"context_line":"        flow[\u0027actions\u0027] \u003d \u0027controller\u0027"},{"line_number":345,"context_line":"        # forward egress accepted packet and log"},{"line_number":346,"context_line":"        if table \u003d\u003d ovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE:"},{"line_number":347,"context_line":"            flow[\u0027actions\u0027] \u003d \u0027normal,controller\u0027"},{"line_number":348,"context_line":"        self._add_flow(**flow)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ea65efb5","line":346,"range":{"start_line":346,"start_character":11,"end_line":346,"end_character":16},"in_reply_to":"3f79a3b5_f9c95625","updated":"2018-08-15 15:58:48.000000000","message":"Thanks. Done!","commit_id":"6d1b236a8a68f39bc293f959ed97f048d4c0de7b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5f614e1a2c5e72f6e62b7b237c0673188b423449","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        table \u003d flow[\u0027table\u0027] \u003d OVS_FW_TO_LOG_TABLES[flow[\u0027table\u0027]]"},{"line_number":344,"context_line":"        flow[\u0027actions\u0027] \u003d \u0027controller\u0027"},{"line_number":345,"context_line":"        # forward egress accepted packet and log"},{"line_number":346,"context_line":"        if table \u003d\u003d ovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE:"},{"line_number":347,"context_line":"            flow[\u0027actions\u0027] \u003d \u0027normal,controller\u0027"},{"line_number":348,"context_line":"        self._add_flow(**flow)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1fb2eb49","line":346,"range":{"start_line":346,"start_character":8,"end_line":346,"end_character":16},"updated":"2018-08-15 15:24:16.000000000","message":"variable is not used more than once, why not just if flow[\u0027table\u0027] to avoid extra variable.","commit_id":"752445a1edcf1a438078bb2a0f6eae7010424680"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"cc65c890f9a532746f866584a8eab2edfe089de4","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        table \u003d flow[\u0027table\u0027] \u003d OVS_FW_TO_LOG_TABLES[flow[\u0027table\u0027]]"},{"line_number":344,"context_line":"        flow[\u0027actions\u0027] \u003d \u0027controller\u0027"},{"line_number":345,"context_line":"        # forward egress accepted packet and log"},{"line_number":346,"context_line":"        if table \u003d\u003d ovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE:"},{"line_number":347,"context_line":"            flow[\u0027actions\u0027] \u003d \u0027normal,controller\u0027"},{"line_number":348,"context_line":"        self._add_flow(**flow)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2a4e8737","line":346,"range":{"start_line":346,"start_character":8,"end_line":346,"end_character":16},"in_reply_to":"3f79a3b5_1fb2eb49","updated":"2018-08-15 15:58:09.000000000","message":"Cool! Thanks.","commit_id":"752445a1edcf1a438078bb2a0f6eae7010424680"}]}
