)]}'
{"neutron/services/logapi/common/db_api.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee20bcf3808f1ea79457b1d90554e4979f2efc4a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    \"\"\"Return a list of log_resources bound to a security group\"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    project_id \u003d context.tenant_id"},{"line_number":187,"context_line":"    log_objs \u003d \\"},{"line_number":188,"context_line":"        log_object.Log.get_objects(context,"},{"line_number":189,"context_line":"                                   project_id\u003dproject_id,"},{"line_number":190,"context_line":"                                   resource_type\u003dconstants.SECURITY_GROUP,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b443113f","line":187,"range":{"start_line":187,"start_character":15,"end_line":187,"end_character":16},"updated":"2018-08-23 20:45:42.000000000","message":"I\u0027m always a fan of not using backslashes :(","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"c8e2a01e30788153fbaf14a5eca7a608a0e594e0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    \"\"\"Return a list of log_resources bound to a security group\"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    project_id \u003d context.tenant_id"},{"line_number":187,"context_line":"    log_objs \u003d \\"},{"line_number":188,"context_line":"        log_object.Log.get_objects(context,"},{"line_number":189,"context_line":"                                   project_id\u003dproject_id,"},{"line_number":190,"context_line":"                                   resource_type\u003dconstants.SECURITY_GROUP,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ee721512","line":187,"range":{"start_line":187,"start_character":15,"end_line":187,"end_character":16},"in_reply_to":"3f79a3b5_b443113f","updated":"2018-08-24 04:16:38.000000000","message":"Done.\nI have changed variable name to pass pep8 without using backslashes :)","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9e83e62e8fe12857369508e29d8432e98d75984d","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    \"\"\"Return a list of log_resources bound to a security group\"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    project_id \u003d context.tenant_id"},{"line_number":187,"context_line":"    log_objs \u003d \\"},{"line_number":188,"context_line":"        log_object.Log.get_objects(context,"},{"line_number":189,"context_line":"                                   project_id\u003dproject_id,"},{"line_number":190,"context_line":"                                   resource_type\u003dconstants.SECURITY_GROUP,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f5a4194d","line":187,"range":{"start_line":187,"start_character":15,"end_line":187,"end_character":16},"in_reply_to":"3f79a3b5_ee721512","updated":"2018-08-24 11:23:37.000000000","message":"I don\u0027t think changing name of variable is necessary here. It also cause some additional changes below which are in fact not necessary and can make trouble with finding reasons of some changes in git log in the future :)\n\nYou can do it like:\n\n    log_objs \u003d log_object.Log.get_objects(\n        context,\n        project_id\u003dproject_id,\n        resource_type\u003dconstants.SECURITY_GROUP,\n        enabled\u003dTrue)\n\nand should make pep8 and Brian happy :)","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"c1e51a224c443fbbf84e56d60756248a17c345ee","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    \"\"\"Return a list of log_resources bound to a security group\"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    project_id \u003d context.tenant_id"},{"line_number":187,"context_line":"    log_objs \u003d \\"},{"line_number":188,"context_line":"        log_object.Log.get_objects(context,"},{"line_number":189,"context_line":"                                   project_id\u003dproject_id,"},{"line_number":190,"context_line":"                                   resource_type\u003dconstants.SECURITY_GROUP,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_c857eac9","line":187,"range":{"start_line":187,"start_character":15,"end_line":187,"end_character":16},"in_reply_to":"3f79a3b5_f5a4194d","updated":"2018-08-27 01:19:53.000000000","message":"Hi Slawek,\nThank you for the suggestion. I\u0027ve updated it to make pep8 and Brian smile :)","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"}],"releasenotes/notes/fix-co-existence-bug-between-sg-logging-and-fwg-logging-ef16077880d76449.yaml":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"0e781a143a9c92e478812c037f93441b65222581","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":5,"context_line":"    between security group log objects and firewall group log objects."},{"line_number":6,"context_line":"    "},{"line_number":7,"context_line":"    This bug was reported in "},{"line_number":8,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1787119"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_6f446375","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":70},"updated":"2018-08-17 06:10:39.000000000","message":"security group and firewall group log objects.","commit_id":"8d68de450a6fd1c236e194c2e075959e1c4f2912"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"0e781a143a9c92e478812c037f93441b65222581","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":5,"context_line":"    between security group log objects and firewall group log objects."},{"line_number":6,"context_line":"    "},{"line_number":7,"context_line":"    This bug was reported in "},{"line_number":8,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1787119"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_4fade72f","line":6,"range":{"start_line":6,"start_character":1,"end_line":6,"end_character":4},"updated":"2018-08-17 06:10:39.000000000","message":"Unnecessary whitespaces.","commit_id":"8d68de450a6fd1c236e194c2e075959e1c4f2912"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"0e781a143a9c92e478812c037f93441b65222581","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":5,"context_line":"    between security group log objects and firewall group log objects."},{"line_number":6,"context_line":"    "},{"line_number":7,"context_line":"    This bug was reported in "},{"line_number":8,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1787119"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_efa95324","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":29},"updated":"2018-08-17 06:10:39.000000000","message":"ditto","commit_id":"8d68de450a6fd1c236e194c2e075959e1c4f2912"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"0e781a143a9c92e478812c037f93441b65222581","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    between security group log objects and firewall group log objects."},{"line_number":6,"context_line":"    "},{"line_number":7,"context_line":"    This bug was reported in "},{"line_number":8,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1787119"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_0f7ccfb3","line":8,"updated":"2018-08-17 06:10:39.000000000","message":"It\u0027s better to write as follows.  In addition, please write at #4 (beginning of the sentence)\n\n[`bug 1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__]","commit_id":"8d68de450a6fd1c236e194c2e075959e1c4f2912"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee20bcf3808f1ea79457b1d90554e4979f2efc4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__]"},{"line_number":5,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":6,"context_line":"    between security group and firewall group log objects."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_d43b2dce","line":4,"updated":"2018-08-23 20:45:42.000000000","message":"Can you move this to the last line and prepend with text \"For more information see\" so it reads correctly in the release notes?  And I think you can drop the brackets:\n\n\"For more information see bug `1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`_.\n\nhttp://logs.openstack.org/78/591978/6/check/build-openstack-releasenotes/3c7ceff/html/unreleased.html","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"c8e2a01e30788153fbaf14a5eca7a608a0e594e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__]"},{"line_number":5,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":6,"context_line":"    between security group and firewall group log objects."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_0e4991b5","line":4,"in_reply_to":"3f79a3b5_d43b2dce","updated":"2018-08-24 04:16:38.000000000","message":"Done. Thanks for your suggestion :)","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee20bcf3808f1ea79457b1d90554e4979f2efc4a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__]"},{"line_number":5,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":6,"context_line":"    between security group and firewall group log objects."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_74525915","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":26},"updated":"2018-08-23 20:45:42.000000000","message":"s/Add ``resource_type``","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee20bcf3808f1ea79457b1d90554e4979f2efc4a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__]"},{"line_number":5,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":6,"context_line":"    between security group and firewall group log objects."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_1453e517","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":51},"updated":"2018-08-23 20:45:42.000000000","message":"s/query","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"c8e2a01e30788153fbaf14a5eca7a608a0e594e0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__]"},{"line_number":5,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":6,"context_line":"    between security group and firewall group log objects."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_4e53096c","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":51},"in_reply_to":"3f79a3b5_1453e517","updated":"2018-08-24 04:16:38.000000000","message":"Done","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"c8e2a01e30788153fbaf14a5eca7a608a0e594e0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__]"},{"line_number":5,"context_line":"    Adding \u0027resource_type\u0027 into log object querying to distinguish"},{"line_number":6,"context_line":"    between security group and firewall group log objects."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_ee4bf5ad","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":26},"in_reply_to":"3f79a3b5_74525915","updated":"2018-08-24 04:16:38.000000000","message":"Done","commit_id":"ccf6d5f429e81cb52dcbd621621a28ddfcfe48bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f35e8741fafdf5f6c086443c17e56e926b95298f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027resource_type\u0027 into log object query to distinguish between security"},{"line_number":5,"context_line":"    group and firewall group log objects."},{"line_number":6,"context_line":"    For more information see bug `1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_541021a9","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":23},"updated":"2018-08-28 20:49:31.000000000","message":"s/``resource_type``\n\nso it renders correctly in the release note.","commit_id":"d9d04811eb21c3c91b875d7b6fea408948b2956c"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"0ca22dafb2592e05092dff25c150bc1282fba4b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027resource_type\u0027 into log object query to distinguish between security"},{"line_number":5,"context_line":"    group and firewall group log objects."},{"line_number":6,"context_line":"    For more information see bug `1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_e6bc2008","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":23},"in_reply_to":"3f79a3b5_541021a9","updated":"2018-08-29 01:11:09.000000000","message":"Done","commit_id":"d9d04811eb21c3c91b875d7b6fea408948b2956c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f35e8741fafdf5f6c086443c17e56e926b95298f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027resource_type\u0027 into log object query to distinguish between security"},{"line_number":5,"context_line":"    group and firewall group log objects."},{"line_number":6,"context_line":"    For more information see bug `1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_d41bd1c7","line":6,"range":{"start_line":6,"start_character":92,"end_line":6,"end_character":93},"updated":"2018-08-28 20:49:31.000000000","message":"missing a trailing period for the sentence, see http://logs.openstack.org/78/591978/9/check/build-openstack-releasenotes/86bf49c/html/unreleased.html","commit_id":"d9d04811eb21c3c91b875d7b6fea408948b2956c"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"0ca22dafb2592e05092dff25c150bc1282fba4b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027resource_type\u0027 into log object query to distinguish between security"},{"line_number":5,"context_line":"    group and firewall group log objects."},{"line_number":6,"context_line":"    For more information see bug `1787119 \u003chttps://bugs.launchpad.net/neutron/+bug/1787119\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_06ba7c09","line":6,"range":{"start_line":6,"start_character":92,"end_line":6,"end_character":93},"in_reply_to":"3f79a3b5_d41bd1c7","updated":"2018-08-29 01:11:09.000000000","message":"Done","commit_id":"d9d04811eb21c3c91b875d7b6fea408948b2956c"}]}