)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"caf09a087bd067835704b8a7ad200b8c34130f9f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When code needs to load a list of all ports that are not router"},{"line_number":10,"context_line":"interfaces, they tend to fetch the port information into memory and then"},{"line_number":11,"context_line":"iterate over the ports, inspecting each port\u0027s device_owner.  For large"},{"line_number":12,"context_line":"numbers of ports this is presumably inefficient.  This came up in a"},{"line_number":13,"context_line":"discussion of just such a part in the code [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"A more efficient solution is to perform this filtering in SQL.  This"},{"line_number":16,"context_line":"change provides a method in the Port object to do that."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_5e2fc987","line":13,"range":{"start_line":11,"start_character":62,"end_line":13,"end_character":46},"updated":"2018-09-11 16:37:32.000000000","message":"but somehow this soultion is still inspecting port\u0027s device owner after join operation ?","commit_id":"95868a7ad3d8ea2a46134a8b04b0118b971de285"}],"neutron/objects/ports.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7b3bd287d10d00d0fa82d250f416f5ff41e05684","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                            **kwargs)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @classmethod"},{"line_number":412,"context_line":"    def get_object_except_router(cls, context, _pager\u003dNone,"},{"line_number":413,"context_line":"                    validate_filters\u003dTrue, security_group_ids\u003dNone, **kwargs):"},{"line_number":414,"context_line":"        if security_group_ids:"},{"line_number":415,"context_line":"            ports_with_sg \u003d cls.get_ports_ids_by_security_groups_except_router("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_054cdcc5","line":412,"range":{"start_line":412,"start_character":8,"end_line":412,"end_character":32},"updated":"2018-09-07 21:25:52.000000000","message":"Should this be get_objects_except_router.... even better, get_objects_except_router_owned","commit_id":"7a9aadafae65a68352cab017c2218628bd64f516"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7b3bd287d10d00d0fa82d250f416f5ff41e05684","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    @classmethod"},{"line_number":412,"context_line":"    def get_object_except_router(cls, context, _pager\u003dNone,"},{"line_number":413,"context_line":"                    validate_filters\u003dTrue, security_group_ids\u003dNone, **kwargs):"},{"line_number":414,"context_line":"        if security_group_ids:"},{"line_number":415,"context_line":"            ports_with_sg \u003d cls.get_ports_ids_by_security_groups_except_router("},{"line_number":416,"context_line":"                context, security_group_ids)"},{"line_number":417,"context_line":"            port_ids \u003d kwargs.get(\"id\", [])"},{"line_number":418,"context_line":"            if port_ids:"},{"line_number":419,"context_line":"                kwargs[\u0027id\u0027] \u003d list(set(port_ids) \u0026 set(ports_with_sg))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_17e72f14","line":416,"range":{"start_line":414,"start_character":8,"end_line":416,"end_character":44},"updated":"2018-09-07 21:25:52.000000000","message":"Given the way you are calling this method here https://review.openstack.org/#/c/580721/4/neutron/db/ipam_pluggable_backend.py@456, it doesn\u0027t seem you are going to satisfy your original use case https://github.com/openstack/neutron/blob/master/neutron/db/ipam_pluggable_backend.py#L459-L462. Are you implementing this method this way because you have identified already other use cases? If not, I would suggest just adding a method that solves your current use case and let it evolve over time as more use cases are identified","commit_id":"7a9aadafae65a68352cab017c2218628bd64f516"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7b3bd287d10d00d0fa82d250f416f5ff41e05684","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                security_group_ids))"},{"line_number":533,"context_line":"        query \u003d query.filter("},{"line_number":534,"context_line":"            ~models_v2.Port.device_owner.in_("},{"line_number":535,"context_line":"                n_constants.ROUTER_PORT_OWNERS))"},{"line_number":536,"context_line":"        return [port_binding[\u0027port_id\u0027] for port_binding in query.all()]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_37902b4e","line":535,"range":{"start_line":535,"start_character":16,"end_line":535,"end_character":46},"updated":"2018-09-07 21:25:52.000000000","message":"This is not exactly what we have here: https://github.com/openstack/neutron/blob/master/neutron/db/ipam_pluggable_backend.py#L462. Why the change of constant?","commit_id":"7a9aadafae65a68352cab017c2218628bd64f516"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd4c8054f99382775b035aee87e36b99298c1bd8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron_lib import constants"},{"line_number":17,"context_line":"from oslo_utils import versionutils"},{"line_number":18,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":19,"context_line":"from sqlalchemy import and_"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.common import constants as n_constants"},{"line_number":22,"context_line":"from neutron.common import utils"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_fbcfc788","line":19,"updated":"2018-09-11 16:09:00.000000000","message":"Is this used?  Maybe there is some indirect reference?  Gues pep8 will know...","commit_id":"95868a7ad3d8ea2a46134a8b04b0118b971de285"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"0fa2622b11dc208022846fc6eb17a285f88409d0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron_lib import constants"},{"line_number":17,"context_line":"from oslo_utils import versionutils"},{"line_number":18,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":19,"context_line":"from sqlalchemy import and_"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.common import constants as n_constants"},{"line_number":22,"context_line":"from neutron.common import utils"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_6717f1a4","line":19,"in_reply_to":"3f79a3b5_fbcfc788","updated":"2018-09-19 21:05:01.000000000","message":"Nope!  That code got moved out to a different change.  Removed.","commit_id":"95868a7ad3d8ea2a46134a8b04b0118b971de285"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"caf09a087bd067835704b8a7ad200b8c34130f9f","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                security_group_ids))"},{"line_number":520,"context_line":"        query \u003d query.filter("},{"line_number":521,"context_line":"            ~models_v2.Port.device_owner.in_("},{"line_number":522,"context_line":"                constants.ROUTER_INTERFACE_OWNERS_SNAT))"},{"line_number":523,"context_line":"        return [port_binding[\u0027port_id\u0027] for port_binding in query.all()]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_be24dd61","line":522,"range":{"start_line":522,"start_character":16,"end_line":522,"end_character":25},"updated":"2018-09-11 16:37:32.000000000","message":"do you mean the imported alias n_constants ? otherwise I don\u0027t see the use of import at L21","commit_id":"95868a7ad3d8ea2a46134a8b04b0118b971de285"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"0fa2622b11dc208022846fc6eb17a285f88409d0","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                security_group_ids))"},{"line_number":520,"context_line":"        query \u003d query.filter("},{"line_number":521,"context_line":"            ~models_v2.Port.device_owner.in_("},{"line_number":522,"context_line":"                constants.ROUTER_INTERFACE_OWNERS_SNAT))"},{"line_number":523,"context_line":"        return [port_binding[\u0027port_id\u0027] for port_binding in query.all()]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a718a9cc","line":522,"range":{"start_line":522,"start_character":16,"end_line":522,"end_character":25},"in_reply_to":"3f79a3b5_be24dd61","updated":"2018-09-19 21:05:01.000000000","message":"Removed n_constants, that was a part of code that was refactored to a different change.","commit_id":"95868a7ad3d8ea2a46134a8b04b0118b971de285"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"237851248ec9af37d8829279f12bceb9066a793b","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                security_group_ids))"},{"line_number":528,"context_line":"        query \u003d query.filter("},{"line_number":529,"context_line":"            ~models_v2.Port.device_owner.in_("},{"line_number":530,"context_line":"                constants.ROUTER_INTERFACE_OWNERS_SNAT))"},{"line_number":531,"context_line":"        return [port_binding[\u0027port_id\u0027] for port_binding in query.all()]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_f6ee3cb3","line":530,"updated":"2018-09-20 17:05:27.000000000","message":"I think that there are also other device_owners which are router ports","commit_id":"ce706f6f754ea07b5964ff0ca85d0a5893e0541a"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9e188a1a8265b204310f157e1859ad3809f17c2a","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                security_group_ids))"},{"line_number":528,"context_line":"        query \u003d query.filter("},{"line_number":529,"context_line":"            ~models_v2.Port.device_owner.in_("},{"line_number":530,"context_line":"                constants.ROUTER_INTERFACE_OWNERS_SNAT))"},{"line_number":531,"context_line":"        return [port_binding[\u0027port_id\u0027] for port_binding in query.all()]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d964934b","line":530,"in_reply_to":"3f79a3b5_f6ee3cb3","updated":"2018-09-20 18:11:53.000000000","message":"As was pointed out in a previous comment, the code that we are trying to replace with SQL for efficiency was filtering specifically on constants.ROUTER_INTERFACE_OWNERS_SNAT, so whatever method we use should keep that contract.","commit_id":"ce706f6f754ea07b5964ff0ca85d0a5893e0541a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"237851248ec9af37d8829279f12bceb9066a793b","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        query \u003d query.filter("},{"line_number":529,"context_line":"            ~models_v2.Port.device_owner.in_("},{"line_number":530,"context_line":"                constants.ROUTER_INTERFACE_OWNERS_SNAT))"},{"line_number":531,"context_line":"        return [port_binding[\u0027port_id\u0027] for port_binding in query.all()]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_16ead89e","line":531,"updated":"2018-09-20 17:05:27.000000000","message":"maybe You could merge somehow this method with one above? Something like add to method above parameter, like \"excluded_device_owners\" or something similar and then add this join with models_v2.Port and this additional filtering. What You think about that?","commit_id":"ce706f6f754ea07b5964ff0ca85d0a5893e0541a"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9e188a1a8265b204310f157e1859ad3809f17c2a","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        query \u003d query.filter("},{"line_number":529,"context_line":"            ~models_v2.Port.device_owner.in_("},{"line_number":530,"context_line":"                constants.ROUTER_INTERFACE_OWNERS_SNAT))"},{"line_number":531,"context_line":"        return [port_binding[\u0027port_id\u0027] for port_binding in query.all()]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_b961973b","line":531,"in_reply_to":"3f79a3b5_16ead89e","updated":"2018-09-20 18:11:53.000000000","message":"I think that\u0027s a neat idea.  I\u0027ll do that.","commit_id":"ce706f6f754ea07b5964ff0ca85d0a5893e0541a"}],"neutron/tests/unit/objects/test_ports.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"caf09a087bd067835704b8a7ad200b8c34130f9f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        objs[0].security_group_ids \u003d {sg3_id}"},{"line_number":259,"context_line":"        objs[0].update()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        self.assertEqual(1, len("},{"line_number":262,"context_line":"            ports.Port.get_ports_ids_by_security_groups_except_router("},{"line_number":263,"context_line":"            self.context, security_group_ids\u003d(sg3_id, ))))"},{"line_number":264,"context_line":"        objs[0].device_owner \u003d constants.DEVICE_OWNER_ROUTER_SNAT"},{"line_number":265,"context_line":"        objs[0].update()"},{"line_number":266,"context_line":"        self.assertEqual(0, len("},{"line_number":267,"context_line":"            ports.Port.get_ports_ids_by_security_groups_except_router("},{"line_number":268,"context_line":"            self.context, security_group_ids\u003d(sg3_id, ))))"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        objs[0] \u003d ports.Port.get_object(self.context, id\u003dobjs[0].id)"},{"line_number":271,"context_line":"        self.assertEqual({sg3_id}, objs[0].security_group_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_fb5ee777","line":268,"range":{"start_line":261,"start_character":7,"end_line":268,"end_character":58},"updated":"2018-09-11 16:37:32.000000000","message":"I\u0027d suggest to add it as a separate test case, as this test is already so big and says test_security_group_ids, but here port_ids being tested.","commit_id":"95868a7ad3d8ea2a46134a8b04b0118b971de285"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"0fa2622b11dc208022846fc6eb17a285f88409d0","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        objs[0].security_group_ids \u003d {sg3_id}"},{"line_number":259,"context_line":"        objs[0].update()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        self.assertEqual(1, len("},{"line_number":262,"context_line":"            ports.Port.get_ports_ids_by_security_groups_except_router("},{"line_number":263,"context_line":"            self.context, security_group_ids\u003d(sg3_id, ))))"},{"line_number":264,"context_line":"        objs[0].device_owner \u003d constants.DEVICE_OWNER_ROUTER_SNAT"},{"line_number":265,"context_line":"        objs[0].update()"},{"line_number":266,"context_line":"        self.assertEqual(0, len("},{"line_number":267,"context_line":"            ports.Port.get_ports_ids_by_security_groups_except_router("},{"line_number":268,"context_line":"            self.context, security_group_ids\u003d(sg3_id, ))))"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        objs[0] \u003d ports.Port.get_object(self.context, id\u003dobjs[0].id)"},{"line_number":271,"context_line":"        self.assertEqual({sg3_id}, objs[0].security_group_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_2259e7fb","line":268,"range":{"start_line":261,"start_character":7,"end_line":268,"end_character":58},"in_reply_to":"3f79a3b5_fb5ee777","updated":"2018-09-19 21:05:01.000000000","message":"Done","commit_id":"95868a7ad3d8ea2a46134a8b04b0118b971de285"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"560e013bfb303c81b74c802e375a8cc86b87c143","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        self.assertEqual(1, len("},{"line_number":472,"context_line":"            ports.Port.get_ports_ids_by_security_groups("},{"line_number":473,"context_line":"                self.context, security_group_ids\u003d(sg_id, ),"},{"line_number":474,"context_line":"                excluded_device_owners\u003dfilter_owner)))"},{"line_number":475,"context_line":"        obj.device_owner \u003d constants.DEVICE_OWNER_ROUTER_SNAT"},{"line_number":476,"context_line":"        obj.update()"},{"line_number":477,"context_line":"        self.assertEqual(0, len("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_41bc65b4","line":474,"range":{"start_line":474,"start_character":16,"end_line":474,"end_character":51},"updated":"2018-09-28 18:44:51.000000000","message":"this option can be removed, which will test the default argument since there\u0027s just one port and device owner is none of ROUTER_INTERFACE_OWNERS_SNAT so result still be 1.","commit_id":"eaa393ba3b3865adc0cfbc4fdd2e088f2ab705e5"}]}
