)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3760fad06be3f58ce3fcc44055280dcc19a08b15","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With this patch a l3 agent can handle"},{"line_number":10,"context_line":"any networks by setting the neutron"},{"line_number":11,"context_line":"parameter external_network_bridge"},{"line_number":12,"context_line":"and gateway_external_network_id to"},{"line_number":13,"context_line":"as well in the l3_agent.ini."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1234750"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAUH%2F%2FtFM%3D","line":12,"updated":"2014-01-09 12:03:02.000000000","message":"to what?","commit_id":"dacc547595a827cef81d18f4fa070844caf2dab7"}],"etc/l3_agent.ini":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a6e6b67daf5cea72e2c8e1faca8432ff6f3ab54f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# This is done by setting the specific router_id."},{"line_number":28,"context_line":"# router_id \u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Each L3 agent can be associated with at most one external network.  This"},{"line_number":31,"context_line":"# value should be set to the UUID of that external network.  If empty,"},{"line_number":32,"context_line":"# the agent will enforce that only a single external networks exists and"}],"source_content_type":"text/x-properties","patch_set":8,"id":"AAAATn%2F8nao%3D","line":29,"updated":"2013-12-24 10:07:55.000000000","message":"when external_network_bridge is set, each l3 agent can be associated with at most one external network. This value ...\n\nTo allow L3 agent support multiple external networks, set external_network_bridge to nothing and this one also.","commit_id":"fd1dfa5a4be50eb7b435b2c0f343856b46a6c797"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"aadb90a5e820cbf967da229fa10ad87e2be4e171","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# This is done by setting the specific router_id."},{"line_number":28,"context_line":"# router_id \u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Each L3 agent can be associated with at most one external network.  This"},{"line_number":31,"context_line":"# value should be set to the UUID of that external network.  If empty,"},{"line_number":32,"context_line":"# the agent will enforce that only a single external networks exists and"}],"source_content_type":"text/x-properties","patch_set":8,"id":"AAAATn%2F8nPY%3D","line":29,"in_reply_to":"AAAATn%2F8nao%3D","updated":"2013-12-24 10:28:49.000000000","message":"Done, Thanks for the corrections :)","commit_id":"fd1dfa5a4be50eb7b435b2c0f343856b46a6c797"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"a37b5b03a1649ed7487d2c3bc982383b1deef879","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# This is done by setting the specific router_id."},{"line_number":28,"context_line":"# router_id \u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# when external_network_bridge is set, each L3 agent can be associated"},{"line_number":31,"context_line":"# with at most one external network. This value should be set to the UUID"},{"line_number":32,"context_line":"# of that external network. If empty, the agent will enforce that only"},{"line_number":33,"context_line":"# a single external networks exists and use that external network id."}],"source_content_type":"text/x-properties","patch_set":9,"id":"AAAATn%2F8mqw%3D","line":30,"updated":"2013-12-24 13:10:07.000000000","message":"nit: start sentence with capital","commit_id":"f3ae0d93f3805d73c246a18ee227167a69ddb207"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a82240d2c7be606fb372ed11d7cee1b86c39a44e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# router_id \u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# When external_network_bridge is set, each L3 agent can be associated"},{"line_number":31,"context_line":"# with at most one external network. This value should be set to the UUID"},{"line_number":32,"context_line":"# of that external network. If empty, the agent will enforce that only"},{"line_number":33,"context_line":"# a single external networks exists and use that external network id."},{"line_number":34,"context_line":"# To allow L3 agent support multiple external networks, set"}],"source_content_type":"text/x-properties","patch_set":10,"id":"AAAAT3%2F%2FrJA%3D","line":31,"updated":"2014-01-03 17:50:09.000000000","message":"unrelated, pedant: no more than one","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a82240d2c7be606fb372ed11d7cee1b86c39a44e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# of that external network. If empty, the agent will enforce that only"},{"line_number":33,"context_line":"# a single external networks exists and use that external network id."},{"line_number":34,"context_line":"# To allow L3 agent support multiple external networks, set"},{"line_number":35,"context_line":"# external_network_bridge to nothing and this one also."},{"line_number":36,"context_line":"# gateway_external_network_id \u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Indicates that this L3 agent should also handle routers that do not have"}],"source_content_type":"text/x-properties","patch_set":10,"id":"AAAAT3%2F%2FrI0%3D","line":35,"updated":"2014-01-03 17:50:09.000000000","message":"the last sentence seems at odds with the previous one.\nI think the new behaviour will automatically allow the l3 agent to support multiple ext nets if the parameter is empty.\nI don\u0027t think there will be any backward compatibility issue.","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"73ee3901f66719046b03a02448d6cbc95f494b3d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# of that external network. If empty, the agent will enforce that only"},{"line_number":33,"context_line":"# a single external networks exists and use that external network id."},{"line_number":34,"context_line":"# To allow L3 agent support multiple external networks, set"},{"line_number":35,"context_line":"# external_network_bridge to nothing and this one also."},{"line_number":36,"context_line":"# gateway_external_network_id \u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Indicates that this L3 agent should also handle routers that do not have"}],"source_content_type":"text/x-properties","patch_set":10,"id":"AAAAUH%2F%2F88Y%3D","line":35,"in_reply_to":"AAAAT3%2F%2FrI0%3D","updated":"2014-01-06 10:23:12.000000000","message":"You\u0027re right, the last sentence is more or less at odds with the previous one. I\u0027ll rewrite it. To be more precise, if this parameter is not set and the external_network_bridge is set, the agent will ask the plugin to know how many networks exists and raise an exception if there is more than one network. If this parameter is set, the agent will not ask the plugin and will only manage the network specified. If we let the both parameters not set, it means that the agent will not ask the plugin and the agent will handle all networks.","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bc7c313270f25b0439c6b363063077deadacd9c0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# When external_network_bridge is set, each L3 agent can be associated"},{"line_number":31,"context_line":"# with no more than one external network. This value should be set to the UUID"},{"line_number":32,"context_line":"# of that external network. To allow L3 agent support multiple external"},{"line_number":33,"context_line":"# networks, the external_network_bridge paramter have to set to nothing"},{"line_number":34,"context_line":"# and this one also."},{"line_number":35,"context_line":"# gateway_external_network_id \u003d"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-properties","patch_set":11,"id":"AAAAUH%2F%2F4BY%3D","line":33,"updated":"2014-01-07 11:01:49.000000000","message":"parmeter -\u003e parameter\nhave to set -\u003e must be set (or have to be set)\nnothing -\u003e left empty (only advice)\n\nAlso it might be clearer to state\n\"both the external_network_bridge and gateway_external_network_id must be left empty\"","commit_id":"58054a6801071c21221385c3ffd9bc1fd35908e1"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"dfd0b17af50eb6ad12da29a3b6eba431db79356c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# When external_network_bridge is set, each L3 agent can be associated"},{"line_number":31,"context_line":"# with no more than one external network. This value should be set to the UUID"},{"line_number":32,"context_line":"# of that external network. To allow L3 agent support multiple external"},{"line_number":33,"context_line":"# networks, the external_network_bridge paramter have to set to nothing"},{"line_number":34,"context_line":"# and this one also."},{"line_number":35,"context_line":"# gateway_external_network_id \u003d"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-properties","patch_set":11,"id":"AAAAUH%2F%2F1mo%3D","line":33,"in_reply_to":"AAAAUH%2F%2F4BY%3D","updated":"2014-01-07 22:40:48.000000000","message":"Done","commit_id":"58054a6801071c21221385c3ffd9bc1fd35908e1"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a6e6b67daf5cea72e2c8e1faca8432ff6f3ab54f","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # L3 agent doesn\u0027t use external_network_bridge to handle external"},{"line_number":296,"context_line":"        # networks, so bridge_mappings with provider networks will be used"},{"line_number":297,"context_line":"        # and the L3 agent is able to handle any networks."},{"line_number":298,"context_line":"        if not self.conf.external_network_bridge:"},{"line_number":299,"context_line":"            return"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8naM%3D","line":297,"updated":"2013-12-24 10:07:55.000000000","message":"external networks?","commit_id":"fd1dfa5a4be50eb7b435b2c0f343856b46a6c797"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"aadb90a5e820cbf967da229fa10ad87e2be4e171","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # L3 agent doesn\u0027t use external_network_bridge to handle external"},{"line_number":296,"context_line":"        # networks, so bridge_mappings with provider networks will be used"},{"line_number":297,"context_line":"        # and the L3 agent is able to handle any networks."},{"line_number":298,"context_line":"        if not self.conf.external_network_bridge:"},{"line_number":299,"context_line":"            return"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8nMo%3D","line":297,"in_reply_to":"AAAATn%2F8naM%3D","updated":"2013-12-24 10:28:49.000000000","message":"Done","commit_id":"fd1dfa5a4be50eb7b435b2c0f343856b46a6c797"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"2cca0163ffd70ae9b44c668fcd9fd9e4155c67b2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # L3 agent doesn\u0027t use external_network_bridge to handle external"},{"line_number":296,"context_line":"        # networks, so bridge_mappings with provider networks will be used"},{"line_number":297,"context_line":"        # and the L3 agent is able to handle any external networks."},{"line_number":298,"context_line":"        if not self.conf.external_network_bridge:"},{"line_number":299,"context_line":"            return"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2FrLc%3D","line":298,"updated":"2014-01-03 17:27:39.000000000","message":"I\u0027m wondering if we want a more explicit configuration behavior here instead of relying on omission to signal intent.","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"73ee3901f66719046b03a02448d6cbc95f494b3d","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # L3 agent doesn\u0027t use external_network_bridge to handle external"},{"line_number":296,"context_line":"        # networks, so bridge_mappings with provider networks will be used"},{"line_number":297,"context_line":"        # and the L3 agent is able to handle any external networks."},{"line_number":298,"context_line":"        if not self.conf.external_network_bridge:"},{"line_number":299,"context_line":"            return"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2F87Q%3D","line":298,"in_reply_to":"AAAAT3%2F%2FrIU%3D","updated":"2014-01-06 10:23:12.000000000","message":"Yes also agree from the backward compatibility perspective. I also think that the limitation come from the external_network_bridge parameter, since by using the bridge_mappings and the provider networks this limitation doesn\u0027t exist. It means that if we don\u0027t use this parameter there is no more this limitation.","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a82240d2c7be606fb372ed11d7cee1b86c39a44e","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # L3 agent doesn\u0027t use external_network_bridge to handle external"},{"line_number":296,"context_line":"        # networks, so bridge_mappings with provider networks will be used"},{"line_number":297,"context_line":"        # and the L3 agent is able to handle any external networks."},{"line_number":298,"context_line":"        if not self.conf.external_network_bridge:"},{"line_number":299,"context_line":"            return"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2FrIU%3D","line":298,"in_reply_to":"AAAAT3%2F%2FrLc%3D","updated":"2014-01-03 17:50:09.000000000","message":"I think it\u0027s probably ok from a backward compatibility perspective, because if previously the ext net was not specified in the agent this also implicitly implied (sorry for the cacophony) that there was only a single external network in the system imho.","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a82240d2c7be606fb372ed11d7cee1b86c39a44e","unresolved":false,"context_lines":[{"line_number":685,"context_line":"            if not ex_net_id and not self.conf.handle_internal_only_routers:"},{"line_number":686,"context_line":"                continue"},{"line_number":687,"context_line":"            if (target_ex_net_id and ex_net_id and"},{"line_number":688,"context_line":"                    ex_net_id !\u003d target_ex_net_id):"},{"line_number":689,"context_line":"                continue"},{"line_number":690,"context_line":"            cur_router_ids.add(r[\u0027id\u0027])"},{"line_number":691,"context_line":"            if r[\u0027id\u0027] not in self.router_info:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2FrIE%3D","line":688,"updated":"2014-01-03 17:50:09.000000000","message":"unrelated, pedant: I\u0027d rather not indent again on line 688 - pep8 checks on the gate should not complain","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"73ee3901f66719046b03a02448d6cbc95f494b3d","unresolved":false,"context_lines":[{"line_number":685,"context_line":"            if not ex_net_id and not self.conf.handle_internal_only_routers:"},{"line_number":686,"context_line":"                continue"},{"line_number":687,"context_line":"            if (target_ex_net_id and ex_net_id and"},{"line_number":688,"context_line":"                    ex_net_id !\u003d target_ex_net_id):"},{"line_number":689,"context_line":"                continue"},{"line_number":690,"context_line":"            cur_router_ids.add(r[\u0027id\u0027])"},{"line_number":691,"context_line":"            if r[\u0027id\u0027] not in self.router_info:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2F87M%3D","line":688,"in_reply_to":"AAAAT3%2F%2FrIE%3D","updated":"2014-01-06 10:23:12.000000000","message":"Done","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"3cba70d9feeac10cc6d4c3fc96aafe17d7f17905","unresolved":false,"context_lines":[{"line_number":693,"context_line":"            ex_net_id \u003d (r[\u0027external_gateway_info\u0027] or {}).get(\u0027network_id\u0027)"},{"line_number":694,"context_line":"            if not ex_net_id and not self.conf.handle_internal_only_routers:"},{"line_number":695,"context_line":"                continue"},{"line_number":696,"context_line":"            if (target_ex_net_id and ex_net_id and"},{"line_number":697,"context_line":"                ex_net_id !\u003d target_ex_net_id):"},{"line_number":698,"context_line":"                continue"},{"line_number":699,"context_line":"            cur_router_ids.add(r[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2Fpv8%3D","line":696,"updated":"2014-01-10 02:57:16.000000000","message":"If target_ex_net_id is empty, why do we even start the for loop in line 684 since the loop is going to get continued anyway? Maybe move if target_ex_net_id before the for loop?","commit_id":"b5092af696131e611e20f17c6b9aa4f321a854df"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b2f0bcf9f7113cb49295e0069201f5e22c325f58","unresolved":false,"context_lines":[{"line_number":693,"context_line":"            ex_net_id \u003d (r[\u0027external_gateway_info\u0027] or {}).get(\u0027network_id\u0027)"},{"line_number":694,"context_line":"            if not ex_net_id and not self.conf.handle_internal_only_routers:"},{"line_number":695,"context_line":"                continue"},{"line_number":696,"context_line":"            if (target_ex_net_id and ex_net_id and"},{"line_number":697,"context_line":"                ex_net_id !\u003d target_ex_net_id):"},{"line_number":698,"context_line":"                continue"},{"line_number":699,"context_line":"            cur_router_ids.add(r[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2FisU%3D","line":696,"in_reply_to":"AAAAUH%2F%2FoXg%3D","updated":"2014-01-12 02:12:39.000000000","message":"Sorry. My bad to misunderstanding the code. Remove my -1.","commit_id":"b5092af696131e611e20f17c6b9aa4f321a854df"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"84992681ce79b8510fdb413aa92db16b0d13971d","unresolved":false,"context_lines":[{"line_number":693,"context_line":"            ex_net_id \u003d (r[\u0027external_gateway_info\u0027] or {}).get(\u0027network_id\u0027)"},{"line_number":694,"context_line":"            if not ex_net_id and not self.conf.handle_internal_only_routers:"},{"line_number":695,"context_line":"                continue"},{"line_number":696,"context_line":"            if (target_ex_net_id and ex_net_id and"},{"line_number":697,"context_line":"                ex_net_id !\u003d target_ex_net_id):"},{"line_number":698,"context_line":"                continue"},{"line_number":699,"context_line":"            cur_router_ids.add(r[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2FoXg%3D","line":696,"in_reply_to":"AAAAUH%2F%2FpY4%3D","updated":"2014-01-10 09:58:26.000000000","message":"Agree with gongysh, not understand the comment. If target_ex_net_id is empty, this condition not match and the router will be processed between line 699-784.","commit_id":"b5092af696131e611e20f17c6b9aa4f321a854df"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e5130747ca85cf042fa8824c73740f98c32e36fa","unresolved":false,"context_lines":[{"line_number":693,"context_line":"            ex_net_id \u003d (r[\u0027external_gateway_info\u0027] or {}).get(\u0027network_id\u0027)"},{"line_number":694,"context_line":"            if not ex_net_id and not self.conf.handle_internal_only_routers:"},{"line_number":695,"context_line":"                continue"},{"line_number":696,"context_line":"            if (target_ex_net_id and ex_net_id and"},{"line_number":697,"context_line":"                ex_net_id !\u003d target_ex_net_id):"},{"line_number":698,"context_line":"                continue"},{"line_number":699,"context_line":"            cur_router_ids.add(r[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2FpY4%3D","line":696,"in_reply_to":"AAAAUH%2F%2Fpv8%3D","updated":"2014-01-10 05:29:48.000000000","message":"I don\u0027t quite understand the comment. if target_ex_net_id is empty, the router is still ok with this l3 agent.","commit_id":"b5092af696131e611e20f17c6b9aa4f321a854df"}],"neutron/tests/unit/test_l3_agent.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a82240d2c7be606fb372ed11d7cee1b86c39a44e","unresolved":false,"context_lines":[{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        self.conf.set_override(\u0027external_network_bridge\u0027, \u0027br-ex\u0027)"},{"line_number":794,"context_line":"        agent._process_routers(routers)"},{"line_number":795,"context_line":"        self.assertIn(routers[0][\u0027id\u0027], agent.router_info)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        agent.router_info \u003d {}"},{"line_number":798,"context_line":"        self.plugin_api.get_external_network_id.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2FrGc%3D","line":795,"updated":"2014-01-03 17:50:09.000000000","message":"Is it necessary to test as well whether two routers uplinked to different ext nets can be processed on the same agent?","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"73ee3901f66719046b03a02448d6cbc95f494b3d","unresolved":false,"context_lines":[{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        self.conf.set_override(\u0027external_network_bridge\u0027, \u0027br-ex\u0027)"},{"line_number":794,"context_line":"        agent._process_routers(routers)"},{"line_number":795,"context_line":"        self.assertIn(routers[0][\u0027id\u0027], agent.router_info)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        agent.router_info \u003d {}"},{"line_number":798,"context_line":"        self.plugin_api.get_external_network_id.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2F850%3D","line":795,"in_reply_to":"AAAAT3%2F%2FrGc%3D","updated":"2014-01-06 10:23:12.000000000","message":"Ok, i\u0027m going to add this kind of tests","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a82240d2c7be606fb372ed11d7cee1b86c39a44e","unresolved":false,"context_lines":[{"line_number":799,"context_line":"            q_exc.TooManyExternalNetworks())"},{"line_number":800,"context_line":"        self.assertRaises(q_exc.TooManyExternalNetworks,"},{"line_number":801,"context_line":"                          agent._process_routers,"},{"line_number":802,"context_line":"                          routers)"},{"line_number":803,"context_line":"        self.assertNotIn(routers[0][\u0027id\u0027], agent.router_info)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        agent.router_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2FrG4%3D","line":802,"updated":"2014-01-03 17:50:09.000000000","message":"What are we exactly testing here?","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"73ee3901f66719046b03a02448d6cbc95f494b3d","unresolved":false,"context_lines":[{"line_number":799,"context_line":"            q_exc.TooManyExternalNetworks())"},{"line_number":800,"context_line":"        self.assertRaises(q_exc.TooManyExternalNetworks,"},{"line_number":801,"context_line":"                          agent._process_routers,"},{"line_number":802,"context_line":"                          routers)"},{"line_number":803,"context_line":"        self.assertNotIn(routers[0][\u0027id\u0027], agent.router_info)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        agent.router_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2F85M%3D","line":802,"in_reply_to":"AAAAT3%2F%2FrG4%3D","updated":"2014-01-06 10:23:12.000000000","message":"That the previous behavior still happens. I mean that the plugin is still asked when the external_network_bridge is set.","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a82240d2c7be606fb372ed11d7cee1b86c39a44e","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        self.conf.set_override(\u0027external_network_bridge\u0027, \u0027\u0027)"},{"line_number":817,"context_line":"        self.conf.set_override(\u0027gateway_external_network_id\u0027, \u0027\u0027)"},{"line_number":818,"context_line":"        agent._process_routers(routers)"},{"line_number":819,"context_line":"        self.assertIn(routers[0][\u0027id\u0027], agent.router_info)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def test_nonexistent_interface_driver(self):"},{"line_number":822,"context_line":"        self.conf.set_override(\u0027interface_driver\u0027, None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2FrG8%3D","line":819,"updated":"2014-01-03 17:50:09.000000000","message":"I think this should be split in several unit tests, thus making it simpler to debug failures, should they happen\n\n1) test_process_routers_with_no_ext_net_in_conf\n2) test_process_routers_with_right_ext_net_in_conf\n3) test_process_routers_with_other_ext_net_in_conf\n4) test_process_routers_with_no_bridge_no_ext_net_in_conf","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"73ee3901f66719046b03a02448d6cbc95f494b3d","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        self.conf.set_override(\u0027external_network_bridge\u0027, \u0027\u0027)"},{"line_number":817,"context_line":"        self.conf.set_override(\u0027gateway_external_network_id\u0027, \u0027\u0027)"},{"line_number":818,"context_line":"        agent._process_routers(routers)"},{"line_number":819,"context_line":"        self.assertIn(routers[0][\u0027id\u0027], agent.router_info)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def test_nonexistent_interface_driver(self):"},{"line_number":822,"context_line":"        self.conf.set_override(\u0027interface_driver\u0027, None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2F848%3D","line":819,"in_reply_to":"AAAAT3%2F%2FrG8%3D","updated":"2014-01-06 10:23:12.000000000","message":"I\u0027m ok with that, I will split it.","commit_id":"a3f963c28be4d1c0c5fd4d95c6eeb47dcea736b9"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3760fad06be3f58ce3fcc44055280dcc19a08b15","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.agent.linux import interface"},{"line_number":27,"context_line":"from neutron.common import config as base_config"},{"line_number":28,"context_line":"from neutron.common import constants as l3_constants"},{"line_number":29,"context_line":"from neutron.common import exceptions as q_exc"},{"line_number":30,"context_line":"from neutron.openstack.common import uuidutils"},{"line_number":31,"context_line":"from neutron.tests import base"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2FtFA%3D","line":29,"updated":"2014-01-09 12:03:02.000000000","message":"nit: n_exc","commit_id":"dacc547595a827cef81d18f4fa070844caf2dab7"}]}
