)]}'
{"neutron/plugins/nicira/NeutronServicePlugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"        try:"},{"line_number":1109,"context_line":"            self.vcns_driver.delete_vip(context, vip_id)"},{"line_number":1110,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1111,"context_line":"            LOG.warning(_(\"Not found vip %s mapping in VCNS\"), vip_id)"},{"line_number":1112,"context_line":"        except Exception:"},{"line_number":1113,"context_line":"            LOG.exception(_(\"Failed to delete vip: %s on Edge!\") % vip_id)"},{"line_number":1114,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBGc%3D","line":1111,"updated":"2013-12-03 13:07:24.000000000","message":"Nit grammer: \"VIP %s mapping not found in VCNS\"","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"        try:"},{"line_number":1109,"context_line":"            self.vcns_driver.delete_vip(context, vip_id)"},{"line_number":1110,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1111,"context_line":"            LOG.warning(_(\"Not found vip %s mapping in VCNS\"), vip_id)"},{"line_number":1112,"context_line":"        except Exception:"},{"line_number":1113,"context_line":"            LOG.exception(_(\"Failed to delete vip: %s on Edge!\") % vip_id)"},{"line_number":1114,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F99QI%3D","line":1111,"in_reply_to":"AAAATn%2F%2BBGc%3D","updated":"2013-12-05 05:04:35.000000000","message":"Done","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"        try:"},{"line_number":1143,"context_line":"            self.vcns_driver.delete_pool(context, pool_id, edge_id)"},{"line_number":1144,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1145,"context_line":"            LOG.warning(_(\"Not found pool %s mapping in VCNS\") % pool_id)"},{"line_number":1146,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1147,"context_line":"            LOG.exception(_(\"Failed to delete pool: %(pool_id)s \""},{"line_number":1148,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBGU%3D","line":1145,"updated":"2013-12-03 13:07:24.000000000","message":"ditto","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"        try:"},{"line_number":1143,"context_line":"            self.vcns_driver.delete_pool(context, pool_id, edge_id)"},{"line_number":1144,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1145,"context_line":"            LOG.warning(_(\"Not found pool %s mapping in VCNS\") % pool_id)"},{"line_number":1146,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1147,"context_line":"            LOG.exception(_(\"Failed to delete pool: %(pool_id)s \""},{"line_number":1148,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F99QE%3D","line":1145,"in_reply_to":"AAAATn%2F%2BBGU%3D","updated":"2013-12-05 05:04:35.000000000","message":"Done","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1150,"context_line":"            raise"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def _vcns_create_health_monitor(self, context, edge_id, health_monitor):"},{"line_number":1153,"context_line":"        \"\"\"Create HealthMonitor by calling VCNS API."},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        Check whether the monitor has been created on the edge. If not, then"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBC0%3D","line":1152,"updated":"2013-12-03 13:07:24.000000000","message":"Looks like both new functions added and semantics of some of the existing functions changed.  Unit test coverage?","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1150,"context_line":"            raise"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def _vcns_create_health_monitor(self, context, edge_id, health_monitor):"},{"line_number":1153,"context_line":"        \"\"\"Create HealthMonitor by calling VCNS API."},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        Check whether the monitor has been created on the edge. If not, then"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F93OQ%3D","line":1152,"in_reply_to":"AAAATn%2F%2BBC0%3D","updated":"2013-12-05 05:04:35.000000000","message":"Done. Add two_vips_with_same_monitor operation unit test cases","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            self.vcns_driver.delete_health_monitor("},{"line_number":1199,"context_line":"                context, monitor_id, edge_id)"},{"line_number":1200,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1201,"context_line":"            LOG.warning(_(\"Not found monitor %s \""},{"line_number":1202,"context_line":"                          \"mapping in VCNS\") % monitor_id)"},{"line_number":1203,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1204,"context_line":"            LOG.exception(_(\"Failed to delete HealthMonitor: %(monitor_id)s \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBGQ%3D","line":1201,"updated":"2013-12-03 13:07:24.000000000","message":"ditto.","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            self.vcns_driver.delete_health_monitor("},{"line_number":1199,"context_line":"                context, monitor_id, edge_id)"},{"line_number":1200,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1201,"context_line":"            LOG.warning(_(\"Not found monitor %s \""},{"line_number":1202,"context_line":"                          \"mapping in VCNS\") % monitor_id)"},{"line_number":1203,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1204,"context_line":"            LOG.exception(_(\"Failed to delete HealthMonitor: %(monitor_id)s \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F99Pc%3D","line":1201,"in_reply_to":"AAAATn%2F%2BBGQ%3D","updated":"2013-12-05 05:04:35.000000000","message":"Done","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1221,"context_line":"        edge_id \u003d kwargs.get(\u0027edge_id\u0027)"},{"line_number":1222,"context_line":"        if not edge_id:"},{"line_number":1223,"context_line":"            edge_id \u003d self._get_edge_id_by_vip_id(context, pool[\u0027vip_id\u0027])"},{"line_number":1224,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027):"},{"line_number":1225,"context_line":"            hm \u003d self.get_health_monitor(context, monitor_id)"},{"line_number":1226,"context_line":"            try:"},{"line_number":1227,"context_line":"                self._vcns_create_health_monitor(context, edge_id, hm)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxoI%3D","line":1224,"updated":"2014-01-01 19:38:56.000000000","message":"Even if health_monitors should always be defined as a pool attribute and not None,\n\npool.get(\u0027health_monitors\u0027, [])\n\nwill probably be safer anyway","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"            hm \u003d self.get_health_monitor(context, monitor_id)"},{"line_number":1226,"context_line":"            try:"},{"line_number":1227,"context_line":"                self._vcns_create_health_monitor(context, edge_id, hm)"},{"line_number":1228,"context_line":"            except Exception:"},{"line_number":1229,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":1230,"context_line":"                    #Try to do rollback"},{"line_number":1231,"context_line":"                    for monitor_ide in pool.get(\u0027health_monitors\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxZs%3D","line":1228,"updated":"2014-01-01 19:38:56.000000000","message":"Not sure if we should restrict to VcnsApiException.\nWhat\u0027s your opinion?","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1230,"context_line":"                    #Try to do rollback"},{"line_number":1231,"context_line":"                    for monitor_ide in pool.get(\u0027health_monitors\u0027):"},{"line_number":1232,"context_line":"                        if monitor_ide \u003d\u003d monitor_id:"},{"line_number":1233,"context_line":"                            break"},{"line_number":1234,"context_line":"                        self._vcns_delete_health_monitor("},{"line_number":1235,"context_line":"                            context, edge_id, monitor_ide)"},{"line_number":1236,"context_line":"        # Create the pool on the edge"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxoE%3D","line":1233,"updated":"2014-01-01 19:38:56.000000000","message":"I\u0027m not sure I understand correctly the rollback logic, so I\u0027m wondering if the above should be a \u0027break\u0027 or a \u0027continue\u0027","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"        edge_id \u003d kwargs.get(\u0027edge_id\u0027)"},{"line_number":1250,"context_line":"        if not edge_id:"},{"line_number":1251,"context_line":"            if not pool.get(\u0027vip_id\u0027):"},{"line_number":1252,"context_line":"                return"},{"line_number":1253,"context_line":"            edge_id \u003d self._get_edge_id_by_vip_id("},{"line_number":1254,"context_line":"                context, pool[\u0027vip_id\u0027])"},{"line_number":1255,"context_line":"        self._vcns_delete_pool(context, edge_id, pool_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxoA%3D","line":1252,"updated":"2014-01-01 19:38:56.000000000","message":"is it ok to just return here, or should there be some logging or even raising?","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"                context, pool[\u0027vip_id\u0027])"},{"line_number":1255,"context_line":"        self._vcns_delete_pool(context, edge_id, pool_id)"},{"line_number":1256,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027):"},{"line_number":1257,"context_line":"            self._vcns_delete_health_monitor(context, edge_id, monitor_id)"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    def _remove_pool_member(self, pool, member_id):"},{"line_number":1260,"context_line":"        for index in range(len(pool.get(\u0027members\u0027))):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Fxn8%3D","line":1257,"updated":"2014-01-01 19:38:56.000000000","message":"In case of failure during the deletion of a monitor, would it be better to log the failure and try to delete the next monitor anyway?","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"        for index in range(len(pool.get(\u0027members\u0027))):"},{"line_number":1261,"context_line":"            if pool[\u0027members\u0027][index] \u003d\u003d member_id:"},{"line_number":1262,"context_line":"                del pool[\u0027members\u0027][index]"},{"line_number":1263,"context_line":"                return"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"    def _remove_pool_monitor_association(self, pool, monitor_id):"},{"line_number":1266,"context_line":"        for index in range(len(pool.get(\u0027health_monitors\u0027))):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxaE%3D","line":1263,"updated":"2014-01-01 19:38:56.000000000","message":"I am a bit rusty on the data structures used in the advanced plugin. I do not remember if pool[\u0027members\u0027] is a dict or a list. If it is a dict, deletion perhaps might be simpler.","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        for index in range(len(pool.get(\u0027health_monitors\u0027))):"},{"line_number":1267,"context_line":"            if pool[\u0027health_monitors\u0027][index] \u003d\u003d monitor_id:"},{"line_number":1268,"context_line":"                del pool[\u0027health_monitors\u0027][index]"},{"line_number":1269,"context_line":"                return"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"    def create_vip(self, context, vip):"},{"line_number":1272,"context_line":"        LOG.debug(_(\"create_vip() called\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxaA%3D","line":1269,"updated":"2014-01-01 19:38:56.000000000","message":"same comment as above","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        except Exception:"},{"line_number":1311,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1312,"context_line":"                LOG.exception(_(\"Failed to create vip associated \""},{"line_number":1313,"context_line":"                                \"pool and monitors!\"))"},{"line_number":1314,"context_line":"                self._delete_resource_router_id_binding("},{"line_number":1315,"context_line":"                    context, v[\u0027id\u0027], loadbalancer_db.Vip)"},{"line_number":1316,"context_line":"                super(NvpAdvancedPlugin, self).delete_vip(context, v[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxZ4%3D","line":1313,"updated":"2014-01-01 19:38:56.000000000","message":"nit: consider rephrasing to \"failed to create pool and health monitors associated with VIP\"","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":1453,"context_line":"        except Exception:"},{"line_number":1454,"context_line":"            self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1455,"context_line":"                                      id, service_constants.ERROR)"},{"line_number":1456,"context_line":"            raise"},{"line_number":1457,"context_line":"        super(NvpAdvancedPlugin, self).delete_member(context, id)"},{"line_number":1458,"context_line":""},{"line_number":1459,"context_line":"    def update_health_monitor(self, context, id, health_monitor):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxZo%3D","line":1456,"updated":"2014-01-01 19:38:56.000000000","message":"If the error is a VcnsNotFound error, perhaps it is not necessary to raise on a delete.\n\nThis comment might apply to other routines in this module.","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"7dbafe711c8e0730ad6c8a0ed6e116a71aca931c","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1200,"context_line":"                assoc_qry \u003d context.session.query("},{"line_number":1201,"context_line":"                    loadbalancer_db.PoolMonitorAssociation)"},{"line_number":1202,"context_line":"                number +\u003d assoc_qry.filter_by(pool_id\u003dpool_binding.pool_id,"},{"line_number":1203,"context_line":"                                              monitor_id\u003dmonitor_id).count()"},{"line_number":1204,"context_line":"        if number \u003e\u003d 1:"},{"line_number":1205,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BgL4%3D","line":1202,"updated":"2014-02-20 20:30:57.000000000","message":"Why do we need to go through all of the pool_bindings.  Seems that once the count is \u003e0 we should just return.","commit_id":"41bb1ccacde48cfcfc0bf72b4659fa0cb2c15deb"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"e8b05302cc2444a4ca3502ebc59eef728e6c4a59","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1200,"context_line":"                assoc_qry \u003d context.session.query("},{"line_number":1201,"context_line":"                    loadbalancer_db.PoolMonitorAssociation)"},{"line_number":1202,"context_line":"                number +\u003d assoc_qry.filter_by(pool_id\u003dpool_binding.pool_id,"},{"line_number":1203,"context_line":"                                              monitor_id\u003dmonitor_id).count()"},{"line_number":1204,"context_line":"        if number \u003e\u003d 1:"},{"line_number":1205,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BbGI%3D","line":1202,"in_reply_to":"AAAAUX%2F%2BgL4%3D","updated":"2014-02-21 09:08:01.000000000","message":"Yes, you are right. useless to go through all pool_bindings.","commit_id":"41bb1ccacde48cfcfc0bf72b4659fa0cb2c15deb"}],"neutron/plugins/nicira/dbexts/vcns_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def get_vcns_edge_pool_bindings(session, edge_id):"},{"line_number":157,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":158,"context_line":"        return (session.query(vcns_models.VcnsEdgePoolBinding)."},{"line_number":159,"context_line":"                filter_by(edge_id\u003dedge_id).all())"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxZk%3D","line":157,"updated":"2014-01-01 19:38:56.000000000","message":"I am not sure about the need for the nested transaction here, but this is a rather minor point.","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"}],"neutron/plugins/nicira/vshield/common/VcnsApiClient.py":[{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"251b9363b91dcb6625aa5179c87656635d3e1d1b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            if status \u003d\u003d 400:"},{"line_number":87,"context_line":"                error_code \u003d int(jsonutils.loads(response)[\u0027errorCode\u0027])"},{"line_number":88,"context_line":"                if error_code in self.error_codes:"},{"line_number":89,"context_line":"                    cls \u003d self.error_codes[error_code]"},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            cls \u003d exceptions.VcnsApiException"},{"line_number":92,"context_line":"        raise cls(uri\u003duri, status\u003dstatus, header\u003dheader, response\u003dresponse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9KaQ%3D","line":89,"updated":"2013-12-16 05:37:27.000000000","message":"cls \u003d self.error_codes.get(error_code) or cls","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"}],"neutron/plugins/nicira/vshield/edge_firewall_driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                edge_id, vcns_rule_id)[1]"},{"line_number":221,"context_line":"        except vcns_exc.VcnsApiException as e:"},{"line_number":222,"context_line":"            LOG.exception(_(\"Failed to get firewall rule: %(rule_id)s \""},{"line_number":223,"context_line":"                            \"with edge_id: %(edge_id)s\") % {"},{"line_number":224,"context_line":"                                \u0027rule_id\u0027: id,"},{"line_number":225,"context_line":"                                \u0027edge_id\u0027: edge_id})"},{"line_number":226,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBEc%3D","line":223,"updated":"2013-12-03 13:07:24.000000000","message":"Isn\u0027t the recommendation to use the comma, as in original version?","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                edge_id, vcns_rule_id)[1]"},{"line_number":221,"context_line":"        except vcns_exc.VcnsApiException as e:"},{"line_number":222,"context_line":"            LOG.exception(_(\"Failed to get firewall rule: %(rule_id)s \""},{"line_number":223,"context_line":"                            \"with edge_id: %(edge_id)s\") % {"},{"line_number":224,"context_line":"                                \u0027rule_id\u0027: id,"},{"line_number":225,"context_line":"                                \u0027edge_id\u0027: edge_id})"},{"line_number":226,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F99N4%3D","line":223,"in_reply_to":"AAAATn%2F%2BBEc%3D","updated":"2013-12-05 05:04:35.000000000","message":"Verified and found that both percent and comma are okay in LOG.exception.","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fd515e993f22afe523240d764eae7aaeea7ce97a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                if vcns_fw[\u0027firewallRules\u0027][\u0027firewallRules\u0027][i].get("},{"line_number":190,"context_line":"                    \u0027ruleType\u0027) !\u003d \u0027user\u0027:"},{"line_number":191,"context_line":"                    del vcns_fw[\u0027firewallRules\u0027][\u0027firewallRules\u0027][i]"},{"line_number":192,"context_line":"            return vcns_fw"},{"line_number":193,"context_line":"        except vcns_exc.VcnsApiException as e:"},{"line_number":194,"context_line":"            LOG.exception(_(\"Failed to get firewall with edge \""},{"line_number":195,"context_line":"                            \"id: %s\"), edge_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FxXY%3D","line":192,"updated":"2014-01-01 19:38:56.000000000","message":"can you add some comment lines to explain the logic in this method?\nIt seems you want to remove some \u0027non-user\u0027 rules, before returning the firewall object, but I don\u0027t understand why we\u0027re reversing the list.","commit_id":"acdad6f06bd94531a29ffeecb64e14bb6ae80865"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"7dbafe711c8e0730ad6c8a0ed6e116a71aca931c","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        else:"},{"line_number":329,"context_line":"            # append the rule at the bottom"},{"line_number":330,"context_line":"            try:"},{"line_number":331,"context_line":"                fwr_req \u003d {\u0027firewallRules\u0027: [fwr_req]}"},{"line_number":332,"context_line":"                header \u003d self.vcns.add_firewall_rule("},{"line_number":333,"context_line":"                    edge_id, fwr_req)[0]"},{"line_number":334,"context_line":"            except vcns_exc.VcnsApiException:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BgLM%3D","line":331,"updated":"2014-02-20 20:30:57.000000000","message":"Why are we recycling the variable name, but changing the data structure?","commit_id":"41bb1ccacde48cfcfc0bf72b4659fa0cb2c15deb"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"e8b05302cc2444a4ca3502ebc59eef728e6c4a59","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        else:"},{"line_number":329,"context_line":"            # append the rule at the bottom"},{"line_number":330,"context_line":"            try:"},{"line_number":331,"context_line":"                fwr_req \u003d {\u0027firewallRules\u0027: [fwr_req]}"},{"line_number":332,"context_line":"                header \u003d self.vcns.add_firewall_rule("},{"line_number":333,"context_line":"                    edge_id, fwr_req)[0]"},{"line_number":334,"context_line":"            except vcns_exc.VcnsApiException:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2Ba%2BE%3D","line":331,"in_reply_to":"AAAAUX%2F%2BgLM%3D","updated":"2014-02-21 09:08:01.000000000","message":"fwr_req means one firewall rule request to vshield edge. With vShield Edge, you can insert a rule above one rule or append some rules at bottom. Here is a previous minor vcns call error and with appending some rules, it needs to wrap one rule with \u0027firewallRules\u0027 to generate firewallRules list. Maybe fwrs_req is better.","commit_id":"41bb1ccacde48cfcfc0bf72b4659fa0cb2c15deb"}],"neutron/plugins/nicira/vshield/edge_loadbalancer_driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                LOG.exception(_(\"Failed to delete vip on edge: %s\"), edge_id)"},{"line_number":210,"context_line":"        vcns_db.delete_vcns_edge_vip_binding(context.session, id)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _get_pool_binding(self, session, id, edge_id):"},{"line_number":213,"context_line":"        pool_binding \u003d vcns_db.get_vcns_edge_pool_binding("},{"line_number":214,"context_line":"            session, id, edge_id)"},{"line_number":215,"context_line":"        if not pool_binding:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBD0%3D","line":212,"updated":"2013-12-03 13:07:24.000000000","message":"id -\u003e pool_id to avoid built-in function name clash.","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                LOG.exception(_(\"Failed to delete vip on edge: %s\"), edge_id)"},{"line_number":210,"context_line":"        vcns_db.delete_vcns_edge_vip_binding(context.session, id)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _get_pool_binding(self, session, id, edge_id):"},{"line_number":213,"context_line":"        pool_binding \u003d vcns_db.get_vcns_edge_pool_binding("},{"line_number":214,"context_line":"            session, id, edge_id)"},{"line_number":215,"context_line":"        if not pool_binding:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98BU%3D","line":212,"in_reply_to":"AAAATn%2F%2BBD0%3D","updated":"2013-12-05 05:04:35.000000000","message":"Done","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        pool_binding \u003d vcns_db.get_vcns_edge_pool_binding("},{"line_number":214,"context_line":"            session, id, edge_id)"},{"line_number":215,"context_line":"        if not pool_binding:"},{"line_number":216,"context_line":"            msg \u003d (_(\"pool_binding not found with id: %(id)s \""},{"line_number":217,"context_line":"                     \"edge_id: %(edge_id)s\") % {"},{"line_number":218,"context_line":"                   \u0027id\u0027: id,"},{"line_number":219,"context_line":"                   \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBEA%3D","line":216,"updated":"2013-12-03 13:07:24.000000000","message":"Find out whether comma or percent should be used for the parameters. Here and other cases in change set.","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        pool_binding \u003d vcns_db.get_vcns_edge_pool_binding("},{"line_number":214,"context_line":"            session, id, edge_id)"},{"line_number":215,"context_line":"        if not pool_binding:"},{"line_number":216,"context_line":"            msg \u003d (_(\"pool_binding not found with id: %(id)s \""},{"line_number":217,"context_line":"                     \"edge_id: %(edge_id)s\") % {"},{"line_number":218,"context_line":"                   \u0027id\u0027: id,"},{"line_number":219,"context_line":"                   \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98BQ%3D","line":216,"in_reply_to":"AAAATn%2F%2BBEA%3D","updated":"2013-12-05 05:04:35.000000000","message":"Done","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"69c213db1accd9b62b112efaf935316bde422373","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        vcns_db.delete_vcns_edge_pool_binding("},{"line_number":276,"context_line":"            context.session, id, edge_id)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def _get_health_monitor_binding(self, session, id, edge_id):"},{"line_number":279,"context_line":"        monitor_binding \u003d vcns_db.get_vcns_edge_monitor_binding("},{"line_number":280,"context_line":"            session, id, edge_id)"},{"line_number":281,"context_line":"        if not monitor_binding:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BBDo%3D","line":278,"updated":"2013-12-03 13:07:24.000000000","message":"id -\u003e monitor_id?","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"37bc95d617d02959d24d558965d6aca34f4f0abb","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        vcns_db.delete_vcns_edge_pool_binding("},{"line_number":276,"context_line":"            context.session, id, edge_id)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def _get_health_monitor_binding(self, session, id, edge_id):"},{"line_number":279,"context_line":"        monitor_binding \u003d vcns_db.get_vcns_edge_monitor_binding("},{"line_number":280,"context_line":"            session, id, edge_id)"},{"line_number":281,"context_line":"        if not monitor_binding:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F98BM%3D","line":278,"in_reply_to":"AAAATn%2F%2BBDo%3D","updated":"2013-12-05 05:04:35.000000000","message":"Done","commit_id":"659c2e37cfcf7acde68708c875fa8c62b0b71064"}],"neutron/plugins/vmware/dbexts/vcns_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":155,"context_line":"def get_vcns_edge_pool_bindings(session, edge_id):"},{"line_number":156,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":157,"context_line":"        return (session.query(vcns_models.VcnsEdgePoolBinding)."},{"line_number":158,"context_line":"                filter_by(edge_id\u003dedge_id).all())"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_vcns_edge_pool_binding_by_vseid(session, edge_id, pool_vseid):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwV8%3D","line":158,"updated":"2014-04-28 08:28:50.000000000","message":"all() should (and can) generally be avoided, unless callers of this function are going to consume the returned list as a whole.\nIterating over the query object directly will fetch records from the database as requested, which is proven to be more efficient.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":155,"context_line":"def get_vcns_edge_pool_bindings(session, edge_id):"},{"line_number":156,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":157,"context_line":"        return (session.query(vcns_models.VcnsEdgePoolBinding)."},{"line_number":158,"context_line":"                filter_by(edge_id\u003dedge_id).all())"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_vcns_edge_pool_binding_by_vseid(session, edge_id, pool_vseid):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_870d0a41","line":158,"in_reply_to":"AAAAXX%2F%2FwV8%3D","updated":"2014-05-05 03:28:20.000000000","message":"Okay, got it. I would remove the func and use the query object directly in specific place.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"}],"neutron/plugins/vmware/plugins/service.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d5e7c882ec66ab8be5c5eef1c4e65cda60a092e","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"    def _vcns_create_vip(self, context, edge_id, vip):"},{"line_number":1130,"context_line":"        try:"},{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FO1k%3D","line":1132,"updated":"2014-03-19 08:51:30.000000000","message":"please use excutils.save_and_reraise_exception():","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"    def _vcns_create_vip(self, context, edge_id, vip):"},{"line_number":1130,"context_line":"        try:"},{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz8A%3D","line":1132,"in_reply_to":"AAAAWH%2F%2B3Xk%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"    def _vcns_create_vip(self, context, edge_id, vip):"},{"line_number":1130,"context_line":"        try:"},{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Xk%3D","line":1132,"in_reply_to":"AAAAWH%2F%2B4JU%3D","updated":"2014-03-22 13:37:09.000000000","message":"eventlet coroutine switching may occur when there are some IOs and I think this is one of the cases. The reason that I replaced all save_and_reraise in bug 1279813 is because using save_and_reraise is more safe and programmers cannot need to know whether we should use save_and_reraise or not. Honestly speaking I am not totally sure when corner cases described in save_and_reraise docstring happens.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"c503e1f42c4d10fade9223be2d94e078e54ce02a","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"    def _vcns_create_vip(self, context, edge_id, vip):"},{"line_number":1130,"context_line":"        try:"},{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B4JU%3D","line":1132,"in_reply_to":"AAAAWH%2F%2FHhs%3D","updated":"2014-03-22 04:09:16.000000000","message":"Hi gark, I got the reason on https://bugs.launchpad.net/neutron/+bug/1279813. I would fix all these problems.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"12547e8a4cac3bd635e69f85cf12f4c12465b0a4","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"    def _vcns_create_vip(self, context, edge_id, vip):"},{"line_number":1130,"context_line":"        try:"},{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FHhs%3D","line":1132,"in_reply_to":"AAAAWH%2F%2FO1k%3D","updated":"2014-03-20 05:31:24.000000000","message":"I am not sure whether i got the use of save_and_reraise_exception clearly. I think since there is no dangerous code in \"except Exception\", there is no need to use   save_and_ Do I miss something that the save_and_ is necessary.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f94e3789d6aae94f63c52c42c17671e4f445f5b6","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"        try:"},{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1136,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B4FU%3D","line":1133,"updated":"2014-03-22 07:52:26.000000000","message":"nit: use positional args instead of string substitution, here and below","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"        try:"},{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1136,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz78%3D","line":1133,"in_reply_to":"AAAAWH%2F%2B4FU%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1136,"context_line":"            raise"},{"line_number":1137,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Xg%3D","line":1134,"updated":"2014-03-22 13:37:09.000000000","message":"Please use a comma instead of %. It defer string evaluation until the string is used. In this case the log level is \"exception\" and there is no actual difference because exception log must be always evaluated.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"            self.vcns_driver.create_vip(context, edge_id, vip)"},{"line_number":1132,"context_line":"        except Exception:"},{"line_number":1133,"context_line":"            LOG.exception(_(\"Failed to create vip: %(vip_id)s \""},{"line_number":1134,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027vip_id\u0027: vip[\u0027id\u0027],"},{"line_number":1135,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1136,"context_line":"            raise"},{"line_number":1137,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz74%3D","line":1134,"in_reply_to":"AAAAWH%2F%2B3Xg%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d5e7c882ec66ab8be5c5eef1c4e65cda60a092e","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"    def _vcns_update_vip(self, context, vip):"},{"line_number":1139,"context_line":"        try:"},{"line_number":1140,"context_line":"            self.vcns_driver.update_vip(context, vip)"},{"line_number":1141,"context_line":"        except Exception:"},{"line_number":1142,"context_line":"            LOG.exception(_(\"Failed to update vip: %s on Edge!\") % vip[\u0027id\u0027])"},{"line_number":1143,"context_line":"            raise"},{"line_number":1144,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FO1c%3D","line":1141,"updated":"2014-03-19 08:51:30.000000000","message":"ditto","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        try:"},{"line_number":1140,"context_line":"            self.vcns_driver.update_vip(context, vip)"},{"line_number":1141,"context_line":"        except Exception:"},{"line_number":1142,"context_line":"            LOG.exception(_(\"Failed to update vip: %s on Edge!\") % vip[\u0027id\u0027])"},{"line_number":1143,"context_line":"            raise"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    def _vcns_delete_vip(self, context, vip_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Xc%3D","line":1142,"updated":"2014-03-22 13:37:09.000000000","message":"A comma instead of %.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        try:"},{"line_number":1140,"context_line":"            self.vcns_driver.update_vip(context, vip)"},{"line_number":1141,"context_line":"        except Exception:"},{"line_number":1142,"context_line":"            LOG.exception(_(\"Failed to update vip: %s on Edge!\") % vip[\u0027id\u0027])"},{"line_number":1143,"context_line":"            raise"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    def _vcns_delete_vip(self, context, vip_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz7s%3D","line":1142,"in_reply_to":"AAAAWH%2F%2B3Xc%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d5e7c882ec66ab8be5c5eef1c4e65cda60a092e","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"            self.vcns_driver.delete_vip(context, vip_id)"},{"line_number":1148,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1149,"context_line":"            LOG.warning(_(\"Vip %s mapping not found in VCNS\"), vip_id)"},{"line_number":1150,"context_line":"        except Exception:"},{"line_number":1151,"context_line":"            LOG.exception(_(\"Failed to delete vip: %s on Edge!\") % vip_id)"},{"line_number":1152,"context_line":"            raise"},{"line_number":1153,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FO1U%3D","line":1150,"updated":"2014-03-19 08:51:30.000000000","message":"ditto","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"            self.vcns_driver.delete_vip(context, vip_id)"},{"line_number":1148,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1149,"context_line":"            LOG.warning(_(\"Vip %s mapping not found in VCNS\"), vip_id)"},{"line_number":1150,"context_line":"        except Exception:"},{"line_number":1151,"context_line":"            LOG.exception(_(\"Failed to delete vip: %s on Edge!\") % vip_id)"},{"line_number":1152,"context_line":"            raise"},{"line_number":1153,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz7o%3D","line":1150,"in_reply_to":"AAAAWH%2F%2FO1U%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1149,"context_line":"            LOG.warning(_(\"Vip %s mapping not found in VCNS\"), vip_id)"},{"line_number":1150,"context_line":"        except Exception:"},{"line_number":1151,"context_line":"            LOG.exception(_(\"Failed to delete vip: %s on Edge!\") % vip_id)"},{"line_number":1152,"context_line":"            raise"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    def _vcns_create_pool(self, context, edge_id, pool, members):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3XY%3D","line":1151,"updated":"2014-03-22 13:37:09.000000000","message":"A comma instead of %","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1149,"context_line":"            LOG.warning(_(\"Vip %s mapping not found in VCNS\"), vip_id)"},{"line_number":1150,"context_line":"        except Exception:"},{"line_number":1151,"context_line":"            LOG.exception(_(\"Failed to delete vip: %s on Edge!\") % vip_id)"},{"line_number":1152,"context_line":"            raise"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    def _vcns_create_pool(self, context, edge_id, pool, members):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz7k%3D","line":1151,"in_reply_to":"AAAAWH%2F%2B3XY%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d5e7c882ec66ab8be5c5eef1c4e65cda60a092e","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"    def _vcns_create_pool(self, context, edge_id, pool, members):"},{"line_number":1155,"context_line":"        try:"},{"line_number":1156,"context_line":"            self.vcns_driver.create_pool(context, edge_id, pool, members)"},{"line_number":1157,"context_line":"        except Exception:"},{"line_number":1158,"context_line":"            LOG.exception(_(\"Failed to create pool: %(pool_id)s \""},{"line_number":1159,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool[\u0027id\u0027],"},{"line_number":1160,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FO1I%3D","line":1157,"updated":"2014-03-19 08:51:30.000000000","message":"ditto - there are quite a few of these below too","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"    def _vcns_create_pool(self, context, edge_id, pool, members):"},{"line_number":1155,"context_line":"        try:"},{"line_number":1156,"context_line":"            self.vcns_driver.create_pool(context, edge_id, pool, members)"},{"line_number":1157,"context_line":"        except Exception:"},{"line_number":1158,"context_line":"            LOG.exception(_(\"Failed to create pool: %(pool_id)s \""},{"line_number":1159,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool[\u0027id\u0027],"},{"line_number":1160,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz7g%3D","line":1157,"in_reply_to":"AAAAWH%2F%2FO1I%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"            self.vcns_driver.create_pool(context, edge_id, pool, members)"},{"line_number":1157,"context_line":"        except Exception:"},{"line_number":1158,"context_line":"            LOG.exception(_(\"Failed to create pool: %(pool_id)s \""},{"line_number":1159,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool[\u0027id\u0027],"},{"line_number":1160,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1161,"context_line":"            raise"},{"line_number":1162,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3XU%3D","line":1159,"updated":"2014-03-22 13:37:09.000000000","message":"A comma instead of %","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"            self.vcns_driver.create_pool(context, edge_id, pool, members)"},{"line_number":1157,"context_line":"        except Exception:"},{"line_number":1158,"context_line":"            LOG.exception(_(\"Failed to create pool: %(pool_id)s \""},{"line_number":1159,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool[\u0027id\u0027],"},{"line_number":1160,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1161,"context_line":"            raise"},{"line_number":1162,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz7c%3D","line":1159,"in_reply_to":"AAAAWH%2F%2B3XU%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"            self.vcns_driver.update_pool(context, edge_id, pool, members)"},{"line_number":1176,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1177,"context_line":"            LOG.exception(_(\"Failed to update pool: %(pool_id)s \""},{"line_number":1178,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool[\u0027id\u0027],"},{"line_number":1179,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1180,"context_line":"            self._resource_set_status(context, loadbalancer_db.Pool,"},{"line_number":1181,"context_line":"                                      pool_id, service_constants.ERROR)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3XQ%3D","line":1178,"updated":"2014-03-22 13:37:09.000000000","message":"A comma instead of %","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"            self.vcns_driver.update_pool(context, edge_id, pool, members)"},{"line_number":1176,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1177,"context_line":"            LOG.exception(_(\"Failed to update pool: %(pool_id)s \""},{"line_number":1178,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool[\u0027id\u0027],"},{"line_number":1179,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1180,"context_line":"            self._resource_set_status(context, loadbalancer_db.Pool,"},{"line_number":1181,"context_line":"                                      pool_id, service_constants.ERROR)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz7U%3D","line":1178,"in_reply_to":"AAAAWH%2F%2B3XQ%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1187,"context_line":"        try:"},{"line_number":1188,"context_line":"            self.vcns_driver.delete_pool(context, pool_id, edge_id)"},{"line_number":1189,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1190,"context_line":"            LOG.warning(_(\"Pool %s mapping not found in VCNS\") % pool_id)"},{"line_number":1191,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1192,"context_line":"            LOG.exception(_(\"Failed to delete pool: %(pool_id)s \""},{"line_number":1193,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3XM%3D","line":1190,"updated":"2014-03-22 13:37:09.000000000","message":"A comma instead of %","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1187,"context_line":"        try:"},{"line_number":1188,"context_line":"            self.vcns_driver.delete_pool(context, pool_id, edge_id)"},{"line_number":1189,"context_line":"        except exceptions.VcnsNotFound:"},{"line_number":1190,"context_line":"            LOG.warning(_(\"Pool %s mapping not found in VCNS\") % pool_id)"},{"line_number":1191,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1192,"context_line":"            LOG.exception(_(\"Failed to delete pool: %(pool_id)s \""},{"line_number":1193,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz00%3D","line":1190,"in_reply_to":"AAAAWH%2F%2B3XM%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"            LOG.warning(_(\"Pool %s mapping not found in VCNS\") % pool_id)"},{"line_number":1191,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1192,"context_line":"            LOG.exception(_(\"Failed to delete pool: %(pool_id)s \""},{"line_number":1193,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool_id,"},{"line_number":1194,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1195,"context_line":"            raise"},{"line_number":1196,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3XI%3D","line":1193,"updated":"2014-03-22 13:37:09.000000000","message":"A comma instead of %","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"            LOG.warning(_(\"Pool %s mapping not found in VCNS\") % pool_id)"},{"line_number":1191,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1192,"context_line":"            LOG.exception(_(\"Failed to delete pool: %(pool_id)s \""},{"line_number":1193,"context_line":"                            \"on edge: %(edge_id)s!\") % {\u0027pool_id\u0027: pool_id,"},{"line_number":1194,"context_line":"                                                        \u0027edge_id\u0027: edge_id})"},{"line_number":1195,"context_line":"            raise"},{"line_number":1196,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bz60%3D","line":1193,"in_reply_to":"AAAAWH%2F%2B3XI%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f94e3789d6aae94f63c52c42c17671e4f445f5b6","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"        pool_bindings \u003d vcns_db.get_vcns_edge_pool_bindings("},{"line_number":1234,"context_line":"            context.session, edge_id)"},{"line_number":1235,"context_line":"        for pool_binding in pool_bindings:"},{"line_number":1236,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1237,"context_line":"                assoc_qry \u003d context.session.query("},{"line_number":1238,"context_line":"                    loadbalancer_db.PoolMonitorAssociation)"},{"line_number":1239,"context_line":"                if assoc_qry.filter_by(pool_id\u003dpool_binding.pool_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B4FY%3D","line":1236,"updated":"2014-03-22 07:52:26.000000000","message":"why doing transaction for each of pool bindings?\nAlso, i think this can be greatly optimized by collecting pool_ids and then using .in() to issue just 1 sql request instead of many:\n\n assoc_count \u003d context.session.query(\n       loadbalancer_db.PoolMonitorAssociation).\n       filter(loadbalancer_db.PoolMonitorAssociation.pool_id.\n              in(pool_ids).filter(monitor_id\u003dmonitor_id).count()","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"        pool_bindings \u003d vcns_db.get_vcns_edge_pool_bindings("},{"line_number":1234,"context_line":"            context.session, edge_id)"},{"line_number":1235,"context_line":"        for pool_binding in pool_bindings:"},{"line_number":1236,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1237,"context_line":"                assoc_qry \u003d context.session.query("},{"line_number":1238,"context_line":"                    loadbalancer_db.PoolMonitorAssociation)"},{"line_number":1239,"context_line":"                if assoc_qry.filter_by(pool_id\u003dpool_binding.pool_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bzxc%3D","line":1236,"in_reply_to":"AAAAWH%2F%2B4FY%3D","updated":"2014-03-24 15:19:24.000000000","message":"Thanks for your advise and Done.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027):"},{"line_number":1294,"context_line":"            try:"},{"line_number":1295,"context_line":"                self._vcns_delete_health_monitor(context, edge_id, monitor_id)"},{"line_number":1296,"context_line":"            except exceptions.VcnsApiException:"},{"line_number":1297,"context_line":"                pass"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"    def _remove_pool_member(self, pool, member_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3XA%3D","line":1296,"updated":"2014-03-22 13:37:09.000000000","message":"No logging is needed here?","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027):"},{"line_number":1294,"context_line":"            try:"},{"line_number":1295,"context_line":"                self._vcns_delete_health_monitor(context, edge_id, monitor_id)"},{"line_number":1296,"context_line":"            except exceptions.VcnsApiException:"},{"line_number":1297,"context_line":"                pass"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"    def _remove_pool_member(self, pool, member_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BzvE%3D","line":1296,"in_reply_to":"AAAAWH%2F%2B3XA%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"        for index in range(len(pool.get(\u0027members\u0027))):"},{"line_number":1301,"context_line":"            if pool[\u0027members\u0027][index] \u003d\u003d member_id:"},{"line_number":1302,"context_line":"                del pool[\u0027members\u0027][index]"},{"line_number":1303,"context_line":"                return"},{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"    def _remove_pool_monitor_association(self, pool, monitor_id):"},{"line_number":1306,"context_line":"        for index in range(len(pool.get(\u0027health_monitors\u0027))):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3W0%3D","line":1303,"updated":"2014-03-22 13:37:09.000000000","message":"Please consider:\n\n  if member_id in pool.get(\u0027members\u0027, []):\n    pool[\u0027members\u0027].remove(member_id)","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"        for index in range(len(pool.get(\u0027members\u0027))):"},{"line_number":1301,"context_line":"            if pool[\u0027members\u0027][index] \u003d\u003d member_id:"},{"line_number":1302,"context_line":"                del pool[\u0027members\u0027][index]"},{"line_number":1303,"context_line":"                return"},{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"    def _remove_pool_monitor_association(self, pool, monitor_id):"},{"line_number":1306,"context_line":"        for index in range(len(pool.get(\u0027health_monitors\u0027))):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bzug%3D","line":1303,"in_reply_to":"AAAAWH%2F%2B3W0%3D","updated":"2014-03-24 15:19:24.000000000","message":"Thanks for your advise and Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"        for index in range(len(pool.get(\u0027health_monitors\u0027))):"},{"line_number":1307,"context_line":"            if pool[\u0027health_monitors\u0027][index] \u003d\u003d monitor_id:"},{"line_number":1308,"context_line":"                del pool[\u0027health_monitors\u0027][index]"},{"line_number":1309,"context_line":"                return"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"    def create_vip(self, context, vip):"},{"line_number":1312,"context_line":"        LOG.debug(_(\"create_vip() called\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Ww%3D","line":1309,"updated":"2014-03-22 13:37:09.000000000","message":"Same as the above.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"        for index in range(len(pool.get(\u0027health_monitors\u0027))):"},{"line_number":1307,"context_line":"            if pool[\u0027health_monitors\u0027][index] \u003d\u003d monitor_id:"},{"line_number":1308,"context_line":"                del pool[\u0027health_monitors\u0027][index]"},{"line_number":1309,"context_line":"                return"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"    def create_vip(self, context, vip):"},{"line_number":1312,"context_line":"        LOG.debug(_(\"create_vip() called\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BzuU%3D","line":1309,"in_reply_to":"AAAAWH%2F%2B3Ww%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d5e7c882ec66ab8be5c5eef1c4e65cda60a092e","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"            return v"},{"line_number":1392,"context_line":"        try:"},{"line_number":1393,"context_line":"            self._vcns_update_vip(context, v)"},{"line_number":1394,"context_line":"        except Exception:"},{"line_number":1395,"context_line":"            self._resource_set_status(context, loadbalancer_db.Vip,"},{"line_number":1396,"context_line":"                                      id, service_constants.ERROR)"},{"line_number":1397,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FO00%3D","line":1394,"updated":"2014-03-19 08:51:30.000000000","message":"ditto","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"            return v"},{"line_number":1392,"context_line":"        try:"},{"line_number":1393,"context_line":"            self._vcns_update_vip(context, v)"},{"line_number":1394,"context_line":"        except Exception:"},{"line_number":1395,"context_line":"            self._resource_set_status(context, loadbalancer_db.Vip,"},{"line_number":1396,"context_line":"                                      id, service_constants.ERROR)"},{"line_number":1397,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BzuQ%3D","line":1394,"in_reply_to":"AAAAWH%2F%2FO00%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"6178bce16495dd6a6fee6b5b74dcbf11fb6535d4","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"                          \"in VCNS\"), monitor_id)"},{"line_number":1262,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1263,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1264,"context_line":"                LOG.exception(_(\"Failed to update HealthMonitor: \""},{"line_number":1265,"context_line":"                                \"%(monitor_id)s on edge: %(edge_id)s!\"),"},{"line_number":1266,"context_line":"                              {\u0027monitor_id\u0027: monitor_id,"},{"line_number":1267,"context_line":"                               \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXH%2F%2FNY0%3D","line":1264,"updated":"2014-04-23 10:21:24.000000000","message":"update -\u003e delete?","commit_id":"fb90209cacf32b3833236fec7297634678257e5d"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"ced65be20f20729b591b347144a3d0774d6f31c6","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"                          \"in VCNS\"), monitor_id)"},{"line_number":1262,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1263,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1264,"context_line":"                LOG.exception(_(\"Failed to update HealthMonitor: \""},{"line_number":1265,"context_line":"                                \"%(monitor_id)s on edge: %(edge_id)s!\"),"},{"line_number":1266,"context_line":"                              {\u0027monitor_id\u0027: monitor_id,"},{"line_number":1267,"context_line":"                               \u0027edge_id\u0027: edge_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXX%2F%2F99A%3D","line":1264,"in_reply_to":"AAAAXH%2F%2FNY0%3D","updated":"2014-04-25 01:29:42.000000000","message":"yeah,right.","commit_id":"fb90209cacf32b3833236fec7297634678257e5d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"        try:"},{"line_number":1148,"context_line":"            self.vcns_driver.update_vip("},{"line_number":1149,"context_line":"                context, vip, session_persistence_update)"},{"line_number":1150,"context_line":"        except Exception:"},{"line_number":1151,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1152,"context_line":"                LOG.exception(_(\"Failed to update vip: %s on Edge!\"),"},{"line_number":1153,"context_line":"                              vip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwVI%3D","line":1150,"updated":"2014-04-28 08:28:50.000000000","message":"should this method handle VcnsNotFound as well?","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"        try:"},{"line_number":1148,"context_line":"            self.vcns_driver.update_vip("},{"line_number":1149,"context_line":"                context, vip, session_persistence_update)"},{"line_number":1150,"context_line":"        except Exception:"},{"line_number":1151,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1152,"context_line":"                LOG.exception(_(\"Failed to update vip: %s on Edge!\"),"},{"line_number":1153,"context_line":"                              vip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_422210a5","line":1150,"in_reply_to":"AAAAXX%2F%2FwVI%3D","updated":"2014-05-05 03:28:20.000000000","message":"VcnsNotFound specially represents one object binding mapping doesn\u0027t exists. For example,  if I have a pool db object and its uuid, then i would try to find the corresponding pool id in edge through the vcns_edge_pool_binding DB table, if the entry doesn\u0027t found, a VcnsNotFound error would raise. So, for update operation, I would think VcnsNotFound is an exception included in Exception. However, for delete operation, i would just log and ignore it.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"        members \u003d kwargs.get(\u0027members\u0027)"},{"line_number":1178,"context_line":"        if not members:"},{"line_number":1179,"context_line":"            members \u003d ["},{"line_number":1180,"context_line":"                super(NsxAdvancedPlugin, self).get_member(context, member_id)"},{"line_number":1181,"context_line":"                for member_id in pool.get(\u0027members\u0027)"},{"line_number":1182,"context_line":"            ]"},{"line_number":1183,"context_line":"        self._resource_set_status(context, loadbalancer_db.Pool,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwUE%3D","line":1180,"updated":"2014-04-28 08:28:50.000000000","message":"nit... is super really needed or self would be good as well here?","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"        members \u003d kwargs.get(\u0027members\u0027)"},{"line_number":1178,"context_line":"        if not members:"},{"line_number":1179,"context_line":"            members \u003d ["},{"line_number":1180,"context_line":"                super(NsxAdvancedPlugin, self).get_member(context, member_id)"},{"line_number":1181,"context_line":"                for member_id in pool.get(\u0027members\u0027)"},{"line_number":1182,"context_line":"            ]"},{"line_number":1183,"context_line":"        self._resource_set_status(context, loadbalancer_db.Pool,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_ab6d709a","line":1180,"in_reply_to":"AAAAXX%2F%2FwUE%3D","updated":"2014-05-05 03:28:20.000000000","message":"Done.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"                                  pool_id, service_constants.PENDING_UPDATE)"},{"line_number":1185,"context_line":"        try:"},{"line_number":1186,"context_line":"            self.vcns_driver.update_pool(context, edge_id, pool, members)"},{"line_number":1187,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1188,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1189,"context_line":"                LOG.exception(_(\"Failed to update pool: %(pool_id)s \""},{"line_number":1190,"context_line":"                                \"on edge: %(edge_id)s!\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwTg%3D","line":1187,"updated":"2014-04-28 08:28:50.000000000","message":"consider whether VcnsNotFound should be caught as well","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"                                  pool_id, service_constants.PENDING_UPDATE)"},{"line_number":1185,"context_line":"        try:"},{"line_number":1186,"context_line":"            self.vcns_driver.update_pool(context, edge_id, pool, members)"},{"line_number":1187,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1188,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1189,"context_line":"                LOG.exception(_(\"Failed to update pool: %(pool_id)s \""},{"line_number":1190,"context_line":"                                \"on edge: %(edge_id)s!\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_4be22404","line":1187,"in_reply_to":"AAAAXX%2F%2FwTg%3D","updated":"2014-05-05 03:28:20.000000000","message":"ditto for update operation.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"        try:"},{"line_number":1232,"context_line":"            self.vcns_driver.update_health_monitor("},{"line_number":1233,"context_line":"                context, edge_id, old_hm, hm)"},{"line_number":1234,"context_line":"        except Exception:"},{"line_number":1235,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1236,"context_line":"                LOG.exception(_(\"Failed to update HealthMonitor: \""},{"line_number":1237,"context_line":"                                \"%(monitor_id)s on edge: %(edge_id)s!\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwTQ%3D","line":1234,"updated":"2014-04-28 08:28:50.000000000","message":"usual VcnsNotFound comment","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"        try:"},{"line_number":1232,"context_line":"            self.vcns_driver.update_health_monitor("},{"line_number":1233,"context_line":"                context, edge_id, old_hm, hm)"},{"line_number":1234,"context_line":"        except Exception:"},{"line_number":1235,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1236,"context_line":"                LOG.exception(_(\"Failed to update HealthMonitor: \""},{"line_number":1237,"context_line":"                                \"%(monitor_id)s on edge: %(edge_id)s!\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_abf2d0cf","line":1234,"in_reply_to":"AAAAXX%2F%2FwTQ%3D","updated":"2014-05-05 03:28:20.000000000","message":"ditto for update operation.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"        pool_ids \u003d [pool_binding.pool_id for pool_binding in pool_bindings]"},{"line_number":1250,"context_line":"        assoc_count \u003d context.session.query("},{"line_number":1251,"context_line":"            loadbalancer_db.PoolMonitorAssociation).filter("},{"line_number":1252,"context_line":"                loadbalancer_db.PoolMonitorAssociation.pool_id.in_(pool_ids)"},{"line_number":1253,"context_line":"            ).filter_by(monitor_id\u003dmonitor_id).count()"},{"line_number":1254,"context_line":"        if assoc_count \u003e 0:"},{"line_number":1255,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwSc%3D","line":1252,"updated":"2014-04-28 08:28:50.000000000","message":"I find strange that this is not checked already by load balancer\u0027s DB logic?\nDo you think it might be something worth being fixed there?","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"        pool_ids \u003d [pool_binding.pool_id for pool_binding in pool_bindings]"},{"line_number":1250,"context_line":"        assoc_count \u003d context.session.query("},{"line_number":1251,"context_line":"            loadbalancer_db.PoolMonitorAssociation).filter("},{"line_number":1252,"context_line":"                loadbalancer_db.PoolMonitorAssociation.pool_id.in_(pool_ids)"},{"line_number":1253,"context_line":"            ).filter_by(monitor_id\u003dmonitor_id).count()"},{"line_number":1254,"context_line":"        if assoc_count \u003e 0:"},{"line_number":1255,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_2614374d","line":1252,"in_reply_to":"AAAAXX%2F%2FwSc%3D","updated":"2014-05-05 03:28:20.000000000","message":"NO. In community, haproxy is used directly at the backend, and if one healthmonitor is disassociated from a pool, the LB instance\u0027s configuration will be updated. In our VSM, edge is the backend. When one healthmonitor is disassociated from a pool, If the monitor is associated with another pool, I would just update the pool. If not, i also need to delete the monitor object in case of orphan object.  So i think it is only a bug belong to vsm. I would extract these codes into a single patch.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                loadbalancer_db.PoolMonitorAssociation.pool_id.in_(pool_ids)"},{"line_number":1253,"context_line":"            ).filter_by(monitor_id\u003dmonitor_id).count()"},{"line_number":1254,"context_line":"        if assoc_count \u003e 0:"},{"line_number":1255,"context_line":"            return"},{"line_number":1256,"context_line":"        try:"},{"line_number":1257,"context_line":"            self.vcns_driver.delete_health_monitor("},{"line_number":1258,"context_line":"                context, monitor_id, edge_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwSs%3D","line":1255,"updated":"2014-04-28 08:28:50.000000000","message":"could it be the case to log this condition?","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                loadbalancer_db.PoolMonitorAssociation.pool_id.in_(pool_ids)"},{"line_number":1253,"context_line":"            ).filter_by(monitor_id\u003dmonitor_id).count()"},{"line_number":1254,"context_line":"        if assoc_count \u003e 0:"},{"line_number":1255,"context_line":"            return"},{"line_number":1256,"context_line":"        try:"},{"line_number":1257,"context_line":"            self.vcns_driver.delete_health_monitor("},{"line_number":1258,"context_line":"                context, monitor_id, edge_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_2b9b2068","line":1255,"in_reply_to":"AAAAXX%2F%2FwSs%3D","updated":"2014-05-05 03:28:20.000000000","message":"Done.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def _vcns_create_pool_and_monitors(self, context, pool_id, **kwargs):"},{"line_number":1270,"context_line":"        pool \u003d self.get_pool(context, pool_id)"},{"line_number":1271,"context_line":"        edge_id \u003d kwargs.get(\u0027edge_id\u0027)"},{"line_number":1272,"context_line":"        if not edge_id:"},{"line_number":1273,"context_line":"            edge_id \u003d self._get_edge_id_by_vip_id(context, pool[\u0027vip_id\u0027])"},{"line_number":1274,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027, []):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwRg%3D","line":1271,"updated":"2014-04-28 08:28:50.000000000","message":"I see this is happening across the whole module, so perhaps consider fixing it in another patch.\nHowever, kwargs here is really not needed - you could just have a edge_id keyword parameter","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def _vcns_create_pool_and_monitors(self, context, pool_id, **kwargs):"},{"line_number":1270,"context_line":"        pool \u003d self.get_pool(context, pool_id)"},{"line_number":1271,"context_line":"        edge_id \u003d kwargs.get(\u0027edge_id\u0027)"},{"line_number":1272,"context_line":"        if not edge_id:"},{"line_number":1273,"context_line":"            edge_id \u003d self._get_edge_id_by_vip_id(context, pool[\u0027vip_id\u0027])"},{"line_number":1274,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027, []):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_cbee34b4","line":1271,"in_reply_to":"AAAAXX%2F%2FwRg%3D","updated":"2014-05-05 03:28:20.000000000","message":"Got it. I would split the codes into several more topic clear patch. Thanks!","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027, []):"},{"line_number":1275,"context_line":"            hm \u003d self.get_health_monitor(context, monitor_id)"},{"line_number":1276,"context_line":"            try:"},{"line_number":1277,"context_line":"                self._vcns_create_health_monitor(context, edge_id, hm)"},{"line_number":1278,"context_line":"            except exceptions.VcnsApiException:"},{"line_number":1279,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":1280,"context_line":"                    #Try to do rollback"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwRE%3D","line":1277,"updated":"2014-04-28 08:28:50.000000000","message":"If edge_id does not exist in the backend, will we get a VcnsApiException or a VcnsNotFound?","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"        for monitor_id in pool.get(\u0027health_monitors\u0027, []):"},{"line_number":1275,"context_line":"            hm \u003d self.get_health_monitor(context, monitor_id)"},{"line_number":1276,"context_line":"            try:"},{"line_number":1277,"context_line":"                self._vcns_create_health_monitor(context, edge_id, hm)"},{"line_number":1278,"context_line":"            except exceptions.VcnsApiException:"},{"line_number":1279,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":1280,"context_line":"                    #Try to do rollback"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_c602ab0a","line":1277,"in_reply_to":"AAAAXX%2F%2FwRE%3D","updated":"2014-05-05 03:28:20.000000000","message":"If the edge_id unexpectedly disappear in the backend, we will get a VcnsApiException. Also if the edge_id is not found in the router_binding, I think it need to raise a VcnsNotFound error. I would also extract the VcnsNotFound handle codes.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"        except Exception:"},{"line_number":1513,"context_line":"            self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1514,"context_line":"                                      m[\u0027id\u0027], service_constants.ERROR)"},{"line_number":1515,"context_line":"            raise"},{"line_number":1516,"context_line":""},{"line_number":1517,"context_line":"        self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1518,"context_line":"                                  m[\u0027id\u0027], service_constants.ACTIVE, m)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwQM%3D","line":1515,"updated":"2014-04-28 08:28:50.000000000","message":"I\u0027m seeing inconsistent usage patterns when it comes to exception handling. Here you\u0027re removing the save_and_reraise ctx manager (not correctly imho as this exception block execute code which might raise).\nHowever in other instances (see line 1141 for example) you are adding an exception handling block which just logs, and that wrapped within the save_and_reraise ctx manager.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"        except Exception:"},{"line_number":1513,"context_line":"            self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1514,"context_line":"                                      m[\u0027id\u0027], service_constants.ERROR)"},{"line_number":1515,"context_line":"            raise"},{"line_number":1516,"context_line":""},{"line_number":1517,"context_line":"        self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1518,"context_line":"                                  m[\u0027id\u0027], service_constants.ACTIVE, m)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_410e8535","line":1515,"in_reply_to":"AAAAXX%2F%2FwQM%3D","updated":"2014-05-05 03:28:20.000000000","message":"Sorry, it should be save_and_reraise error.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"        try:"},{"line_number":1529,"context_line":"            self._vcns_update_pool(context, pool)"},{"line_number":1530,"context_line":"        except exceptions.NotFound:"},{"line_number":1531,"context_line":"            LOG.warning(_(\"pool: %s not found in VCNS\"), pool_id)"},{"line_number":1532,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1533,"context_line":"            self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1534,"context_line":"                                      id, service_constants.ERROR)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwP4%3D","line":1531,"updated":"2014-04-28 08:28:50.000000000","message":"Ah this might explain my previous comment on VcnsNotFound","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1533,"context_line":"            self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1534,"context_line":"                                      id, service_constants.ERROR)"},{"line_number":1535,"context_line":"            raise"},{"line_number":1536,"context_line":"        super(NsxAdvancedPlugin, self).delete_member(context, id)"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"    def update_health_monitor(self, context, id, health_monitor):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwO4%3D","line":1535,"updated":"2014-04-28 08:28:50.000000000","message":"I don\u0027t understand why the member is set in error state.\nI think it might be possible to use the same member for several pools, is it?","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"        except exceptions.VcnsApiException:"},{"line_number":1533,"context_line":"            self._resource_set_status(context, loadbalancer_db.Member,"},{"line_number":1534,"context_line":"                                      id, service_constants.ERROR)"},{"line_number":1535,"context_line":"            raise"},{"line_number":1536,"context_line":"        super(NsxAdvancedPlugin, self).delete_member(context, id)"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"    def update_health_monitor(self, context, id, health_monitor):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_e1d15958","line":1535,"in_reply_to":"AAAAXX%2F%2FwO4%3D","updated":"2014-05-05 03:28:20.000000000","message":"One member object only belongs to one pool.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"}],"neutron/plugins/vmware/vshield/common/VcnsApiClient.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            cls \u003d self.errors[status]"},{"line_number":82,"context_line":"            if status \u003d\u003d 400:"},{"line_number":83,"context_line":"                error_code \u003d int(jsonutils.loads(response)[\u0027errorCode\u0027])"},{"line_number":84,"context_line":"                cls \u003d self.error_codes.get(error_code) or cls"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            cls \u003d exceptions.VcnsApiException"},{"line_number":87,"context_line":"        raise cls(uri\u003duri, status\u003dstatus, header\u003dheader, response\u003dresponse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Ws%3D","line":84,"updated":"2014-03-22 13:37:09.000000000","message":"self.errors_code.get(error_code, cls)","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            cls \u003d self.errors[status]"},{"line_number":82,"context_line":"            if status \u003d\u003d 400:"},{"line_number":83,"context_line":"                error_code \u003d int(jsonutils.loads(response)[\u0027errorCode\u0027])"},{"line_number":84,"context_line":"                cls \u003d self.error_codes.get(error_code) or cls"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            cls \u003d exceptions.VcnsApiException"},{"line_number":87,"context_line":"        raise cls(uri\u003duri, status\u003dstatus, header\u003dheader, response\u003dresponse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BztQ%3D","line":84,"in_reply_to":"AAAAWH%2F%2B3Ws%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8b493be4934878ceb98f7379e3245db8c394df58","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return header, response"},{"line_number":80,"context_line":"        if status in self.errors:"},{"line_number":81,"context_line":"            cls \u003d self.errors[status]"},{"line_number":82,"context_line":"            if status \u003d\u003d 400:"},{"line_number":83,"context_line":"                error_code \u003d int(jsonutils.loads(response)[\u0027errorCode\u0027])"},{"line_number":84,"context_line":"                cls \u003d self.error_codes.get(error_code, cls)"},{"line_number":85,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2FwOM%3D","line":82,"updated":"2014-04-28 08:28:50.000000000","message":"this is just a curiosity, but why the resource not found errorcode is wrapped within a 400 HTTP status code and not a 404?","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return header, response"},{"line_number":80,"context_line":"        if status in self.errors:"},{"line_number":81,"context_line":"            cls \u003d self.errors[status]"},{"line_number":82,"context_line":"            if status \u003d\u003d 400:"},{"line_number":83,"context_line":"                error_code \u003d int(jsonutils.loads(response)[\u0027errorCode\u0027])"},{"line_number":84,"context_line":"                cls \u003d self.error_codes.get(error_code, cls)"},{"line_number":85,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_01d55d42","line":82,"in_reply_to":"AAAAXX%2F%2FwOM%3D","updated":"2014-05-05 03:28:20.000000000","message":"Well, i also don\u0027t know. It is the current edge\u0027s design.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"}],"neutron/plugins/vmware/vshield/edge_firewall_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                if vcns_fw[\u0027firewallRules\u0027][\u0027firewallRules\u0027][i].get("},{"line_number":191,"context_line":"                    \u0027ruleType\u0027) !\u003d \u0027user\u0027:"},{"line_number":192,"context_line":"                    del vcns_fw[\u0027firewallRules\u0027][\u0027firewallRules\u0027][i]"},{"line_number":193,"context_line":"            return vcns_fw"},{"line_number":194,"context_line":"        except vcns_exc.VcnsApiException as e:"},{"line_number":195,"context_line":"            LOG.exception(_(\"Failed to get firewall with edge \""},{"line_number":196,"context_line":"                            \"id: %s\"), edge_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Wo%3D","line":193,"updated":"2014-03-22 13:37:09.000000000","message":"It is deleting entries whose ruleType is not \u0027user\u0027. i.e., it retrieves entries whose ruleType is \u0027user\u0027:\nHow about the following?\n\n  return [rule for rule in vcns_fw[\u0027firewallRules\u0027][\u0027firewallRules\u0027]\n        if rule.get(\u0027ruleType\u0027) \u003d\u003d \u0027user\u0027]","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                if vcns_fw[\u0027firewallRules\u0027][\u0027firewallRules\u0027][i].get("},{"line_number":191,"context_line":"                    \u0027ruleType\u0027) !\u003d \u0027user\u0027:"},{"line_number":192,"context_line":"                    del vcns_fw[\u0027firewallRules\u0027][\u0027firewallRules\u0027][i]"},{"line_number":193,"context_line":"            return vcns_fw"},{"line_number":194,"context_line":"        except vcns_exc.VcnsApiException as e:"},{"line_number":195,"context_line":"            LOG.exception(_(\"Failed to get firewall with edge \""},{"line_number":196,"context_line":"                            \"id: %s\"), edge_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bzsc%3D","line":193,"in_reply_to":"AAAAWH%2F%2B3Wo%3D","updated":"2014-03-24 15:19:24.000000000","message":"Thanks for your advise and done.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"}],"neutron/plugins/vmware/vshield/edge_loadbalancer_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        try:"},{"line_number":269,"context_line":"            self.vcns.delete_pool(edge_id, pool_vseid)"},{"line_number":270,"context_line":"        except vcns_exc.ResourceNotFound:"},{"line_number":271,"context_line":"            LOG.warning(_(\"pool not found on edge: %s\") % edge_id)"},{"line_number":272,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":273,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":274,"context_line":"                LOG.exception(_(\"Failed to delete pool\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Wk%3D","line":271,"updated":"2014-03-22 13:37:09.000000000","message":"Use a comma instead of %.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        try:"},{"line_number":269,"context_line":"            self.vcns.delete_pool(edge_id, pool_vseid)"},{"line_number":270,"context_line":"        except vcns_exc.ResourceNotFound:"},{"line_number":271,"context_line":"            LOG.warning(_(\"pool not found on edge: %s\") % edge_id)"},{"line_number":272,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":273,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":274,"context_line":"                LOG.exception(_(\"Failed to delete pool\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BzsQ%3D","line":271,"in_reply_to":"AAAAWH%2F%2B3Wk%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            response \u003d self.vcns.get_health_monitor(edge_id, monitor_vseid)[1]"},{"line_number":317,"context_line":"        except vcns_exc.VcnsApiException as e:"},{"line_number":318,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":319,"context_line":"                LOG.exception(_(\"Failed to get monitor on edge: %s\") %"},{"line_number":320,"context_line":"                              e.response)"},{"line_number":321,"context_line":"        return self._restore_lb_monitor(context, edge_id, response)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Wc%3D","line":319,"updated":"2014-03-22 13:37:09.000000000","message":"Use a comma instead of  %.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            response \u003d self.vcns.get_health_monitor(edge_id, monitor_vseid)[1]"},{"line_number":317,"context_line":"        except vcns_exc.VcnsApiException as e:"},{"line_number":318,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":319,"context_line":"                LOG.exception(_(\"Failed to get monitor on edge: %s\") %"},{"line_number":320,"context_line":"                              e.response)"},{"line_number":321,"context_line":"        return self._restore_lb_monitor(context, edge_id, response)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BzsA%3D","line":319,"in_reply_to":"AAAAWH%2F%2B3Wc%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        try:"},{"line_number":343,"context_line":"            self.vcns.delete_health_monitor(edge_id, monitor_vseid)"},{"line_number":344,"context_line":"        except vcns_exc.ResourceNotFound:"},{"line_number":345,"context_line":"            LOG.warning(_(\"pool not found on edge: %s\") % edge_id)"},{"line_number":346,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":347,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":348,"context_line":"                LOG.exception(_(\"Failed to delete monitor\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3Wg%3D","line":345,"updated":"2014-03-22 13:37:09.000000000","message":"Use a comma instead of  %.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        try:"},{"line_number":343,"context_line":"            self.vcns.delete_health_monitor(edge_id, monitor_vseid)"},{"line_number":344,"context_line":"        except vcns_exc.ResourceNotFound:"},{"line_number":345,"context_line":"            LOG.warning(_(\"pool not found on edge: %s\") % edge_id)"},{"line_number":346,"context_line":"        except vcns_exc.VcnsApiException:"},{"line_number":347,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":348,"context_line":"                LOG.exception(_(\"Failed to delete monitor\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bzqk%3D","line":345,"in_reply_to":"AAAAWH%2F%2B3Wg%3D","updated":"2014-03-24 15:19:24.000000000","message":"Done","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"}],"neutron/plugins/vmware/vshield/vcns.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"efd3cf6c37af0e933165270651b72a7f43793eae","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        uri \u003d self._build_uri_path("},{"line_number":158,"context_line":"            edge_id, FIREWALL_SERVICE,"},{"line_number":159,"context_line":"            FIREWALL_RULE_RESOURCE)"},{"line_number":160,"context_line":"        uri +\u003d \"?aboveRuleId\u003d\" + str(ref_vcns_rule_id)"},{"line_number":161,"context_line":"        return self.do_request(HTTP_POST, uri, fwr_req)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def add_firewall_rule(self, edge_id, fwr_req):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FR28%3D","line":160,"updated":"2014-04-22 19:38:27.000000000","message":"uri +\u003d \"?aboveRuleId\u003d%s\" % ref_vcns_rule_id","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"0597c607f5cf25dfe66f54bb3cf672b5f4071563","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        uri \u003d self._build_uri_path("},{"line_number":158,"context_line":"            edge_id, FIREWALL_SERVICE,"},{"line_number":159,"context_line":"            FIREWALL_RULE_RESOURCE)"},{"line_number":160,"context_line":"        uri +\u003d \"?aboveRuleId\u003d\" + str(ref_vcns_rule_id)"},{"line_number":161,"context_line":"        return self.do_request(HTTP_POST, uri, fwr_req)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def add_firewall_rule(self, edge_id, fwr_req):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FQYw%3D","line":160,"in_reply_to":"AAAAXH%2F%2FR28%3D","updated":"2014-04-23 01:13:07.000000000","message":"Done","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"}],"neutron/tests/unit/vmware/vshield/test_fwaas_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"efd3cf6c37af0e933165270651b72a7f43793eae","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                admin_state_up\u003dTrue, description\u003d\u0027fw\u0027),"},{"line_number":241,"context_line":"        ) as (fw1, fw2, fw3):"},{"line_number":242,"context_line":"            sorts \u003d [(\u0027name\u0027, \u0027asc\u0027)]"},{"line_number":243,"context_line":"            query_str \u003d \u0027\u0027"},{"line_number":244,"context_line":"            for key, direction in sorts:"},{"line_number":245,"context_line":"                query_str \u003d query_str + \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % ("},{"line_number":246,"context_line":"                    key, direction)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FR20%3D","line":243,"updated":"2014-04-22 19:38:27.000000000","message":"query_str \u003d []","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"0597c607f5cf25dfe66f54bb3cf672b5f4071563","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                admin_state_up\u003dTrue, description\u003d\u0027fw\u0027),"},{"line_number":241,"context_line":"        ) as (fw1, fw2, fw3):"},{"line_number":242,"context_line":"            sorts \u003d [(\u0027name\u0027, \u0027asc\u0027)]"},{"line_number":243,"context_line":"            query_str \u003d \u0027\u0027"},{"line_number":244,"context_line":"            for key, direction in sorts:"},{"line_number":245,"context_line":"                query_str \u003d query_str + \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % ("},{"line_number":246,"context_line":"                    key, direction)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FQVY%3D","line":243,"in_reply_to":"AAAAXH%2F%2FR20%3D","updated":"2014-04-23 01:13:07.000000000","message":"Done","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"efd3cf6c37af0e933165270651b72a7f43793eae","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            sorts \u003d [(\u0027name\u0027, \u0027asc\u0027)]"},{"line_number":243,"context_line":"            query_str \u003d \u0027\u0027"},{"line_number":244,"context_line":"            for key, direction in sorts:"},{"line_number":245,"context_line":"                query_str \u003d query_str + \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % ("},{"line_number":246,"context_line":"                    key, direction)"},{"line_number":247,"context_line":"            req \u003d self.new_list_request(\u0027firewalls\u0027, params\u003dquery_str)"},{"line_number":248,"context_line":"            res \u003d self.deserialize("}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FR2Q%3D","line":245,"updated":"2014-04-22 19:38:27.000000000","message":"query_str.extend(\n    \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % (key, direction)\n    for key, direction in sorts\n)","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"0597c607f5cf25dfe66f54bb3cf672b5f4071563","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            sorts \u003d [(\u0027name\u0027, \u0027asc\u0027)]"},{"line_number":243,"context_line":"            query_str \u003d \u0027\u0027"},{"line_number":244,"context_line":"            for key, direction in sorts:"},{"line_number":245,"context_line":"                query_str \u003d query_str + \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % ("},{"line_number":246,"context_line":"                    key, direction)"},{"line_number":247,"context_line":"            req \u003d self.new_list_request(\u0027firewalls\u0027, params\u003dquery_str)"},{"line_number":248,"context_line":"            res \u003d self.deserialize("}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FQVc%3D","line":245,"in_reply_to":"AAAAXH%2F%2FR2Q%3D","updated":"2014-04-23 01:13:07.000000000","message":"Done","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"efd3cf6c37af0e933165270651b72a7f43793eae","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            for key, direction in sorts:"},{"line_number":245,"context_line":"                query_str \u003d query_str + \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % ("},{"line_number":246,"context_line":"                    key, direction)"},{"line_number":247,"context_line":"            req \u003d self.new_list_request(\u0027firewalls\u0027, params\u003dquery_str)"},{"line_number":248,"context_line":"            res \u003d self.deserialize("},{"line_number":249,"context_line":"                self.fmt, req.get_response(self.ext_api))"},{"line_number":250,"context_line":"            self.assertEqual(len(res[\u0027firewalls\u0027]), 3)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FR2I%3D","line":247,"updated":"2014-04-22 19:38:27.000000000","message":"req \u003d self.new_list_request(\u0027firewalls\u0027, params\u003d\u0027\u0027.join(query_str))","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"0597c607f5cf25dfe66f54bb3cf672b5f4071563","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            for key, direction in sorts:"},{"line_number":245,"context_line":"                query_str \u003d query_str + \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % ("},{"line_number":246,"context_line":"                    key, direction)"},{"line_number":247,"context_line":"            req \u003d self.new_list_request(\u0027firewalls\u0027, params\u003dquery_str)"},{"line_number":248,"context_line":"            res \u003d self.deserialize("},{"line_number":249,"context_line":"                self.fmt, req.get_response(self.ext_api))"},{"line_number":250,"context_line":"            self.assertEqual(len(res[\u0027firewalls\u0027]), 3)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2FQVg%3D","line":247,"in_reply_to":"AAAAXH%2F%2FR2I%3D","updated":"2014-04-23 01:13:07.000000000","message":"Done","commit_id":"4753607958d28b1c4c683867d3b7c359cc7ea091"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"6178bce16495dd6a6fee6b5b74dcbf11fb6535d4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                admin_state_up\u003dTrue, description\u003d\u0027fw\u0027),"},{"line_number":241,"context_line":"        ) as (fw1, fw2, fw3):"},{"line_number":242,"context_line":"            sorts \u003d [(\u0027name\u0027, \u0027asc\u0027)]"},{"line_number":243,"context_line":"            query_str \u003d []"},{"line_number":244,"context_line":"            query_str.extend("},{"line_number":245,"context_line":"                \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % (key, direction)"},{"line_number":246,"context_line":"                for key, direction in sorts)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXH%2F%2FNaA%3D","line":243,"updated":"2014-04-23 10:21:24.000000000","message":"Couldn\u0027t L243-246 be...\n\nquery_str \u003d [\"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % (key, direction) for key, direction in sorts]","commit_id":"fb90209cacf32b3833236fec7297634678257e5d"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"ced65be20f20729b591b347144a3d0774d6f31c6","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                admin_state_up\u003dTrue, description\u003d\u0027fw\u0027),"},{"line_number":241,"context_line":"        ) as (fw1, fw2, fw3):"},{"line_number":242,"context_line":"            sorts \u003d [(\u0027name\u0027, \u0027asc\u0027)]"},{"line_number":243,"context_line":"            query_str \u003d []"},{"line_number":244,"context_line":"            query_str.extend("},{"line_number":245,"context_line":"                \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % (key, direction)"},{"line_number":246,"context_line":"                for key, direction in sorts)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXX%2F%2F970%3D","line":243,"in_reply_to":"AAAAXH%2F%2FNaA%3D","updated":"2014-04-25 01:29:42.000000000","message":"Done","commit_id":"fb90209cacf32b3833236fec7297634678257e5d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"76dd694c56da4b2fa61eb3eac5e752491c4371a8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                name\u003d\u0027fw2\u0027, router_id\u003dkeys_list[2][\u0027router_id\u0027],"},{"line_number":240,"context_line":"                admin_state_up\u003dTrue, description\u003d\u0027fw\u0027),"},{"line_number":241,"context_line":"        ) as (fw1, fw2, fw3):"},{"line_number":242,"context_line":"            query_str \u003d \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % (\u0027name\u0027, \u0027asc\u0027)"},{"line_number":243,"context_line":"            req \u003d self.new_list_request(\u0027firewalls\u0027, params\u003dquery_str)"},{"line_number":244,"context_line":"            res \u003d self.deserialize("},{"line_number":245,"context_line":"                self.fmt, req.get_response(self.ext_api))"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAXX%2F%2F6bc%3D","line":242,"updated":"2014-04-25 10:52:20.000000000","message":"I din\u0027t notice that it was only one tuple (duh!), so this really could be hard coded:\n\nquery_str \u003d \"\u0026sort_key\u003dname\u0026sort_dir\u003dasc\"\n\nConsider, if you need to push another update.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"f1bed7e451cf8217a716aa688e7633d25f117583","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                name\u003d\u0027fw2\u0027, router_id\u003dkeys_list[2][\u0027router_id\u0027],"},{"line_number":240,"context_line":"                admin_state_up\u003dTrue, description\u003d\u0027fw\u0027),"},{"line_number":241,"context_line":"        ) as (fw1, fw2, fw3):"},{"line_number":242,"context_line":"            query_str \u003d \"\u0026sort_key\u003d%s\u0026sort_dir\u003d%s\" % (\u0027name\u0027, \u0027asc\u0027)"},{"line_number":243,"context_line":"            req \u003d self.new_list_request(\u0027firewalls\u0027, params\u003dquery_str)"},{"line_number":244,"context_line":"            res \u003d self.deserialize("},{"line_number":245,"context_line":"                self.fmt, req.get_response(self.ext_api))"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad9bd40_c1ba9509","line":242,"in_reply_to":"AAAAXX%2F%2F6bc%3D","updated":"2014-05-05 03:28:20.000000000","message":"Thanks!Got it.","commit_id":"f07cedee681c8f76368e08ec6247a7ad85227487"}],"neutron/tests/unit/vmware/vshield/test_lbaas_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"302a230cfcb6794a37290ccb538b10545a86602b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                        yield vip"},{"line_number":191,"context_line":"                    finally:"},{"line_number":192,"context_line":"                        if not no_delete:"},{"line_number":193,"context_line":"                            self._delete(\u0027vips\u0027, vip[\u0027vip\u0027][\u0027id\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_create_vip(self, router_id\u003dNone, **kwargs):"},{"line_number":196,"context_line":"        router_id \u003d self._create_and_get_router()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2B3WU%3D","line":193,"updated":"2014-03-22 13:37:09.000000000","message":"If there is no special reason, please consider not using try-finally. Using try-finally can hide an original exceptions.\nhttps://review.openstack.org/#/c/82259/\n\n  vip \u003d self.deserialize(...)\n  yield vip\n  if not no_delete:\n    self._delete(...)","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"4a8732de3814f885ec9ae00cca6ab2ce161cd261","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                        yield vip"},{"line_number":191,"context_line":"                    finally:"},{"line_number":192,"context_line":"                        if not no_delete:"},{"line_number":193,"context_line":"                            self._delete(\u0027vips\u0027, vip[\u0027vip\u0027][\u0027id\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_create_vip(self, router_id\u003dNone, **kwargs):"},{"line_number":196,"context_line":"        router_id \u003d self._create_and_get_router()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BzmQ%3D","line":193,"in_reply_to":"AAAAWH%2F%2B3WU%3D","updated":"2014-03-24 15:19:24.000000000","message":"thanks for your remind and Done.","commit_id":"8565713a224c3adbe0f5f4a27ea7bb03dec550c0"}]}
