)]}'
{"etc/neutron.conf":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1b48eb678db8cb863e3e29519dcae46f6c89e407","unresolved":false,"context_lines":[{"line_number":240,"context_line":"# Seconds between inspecting LBaaS agents states in order to find down agents"},{"line_number":241,"context_line":"# and reschedule loadbalancer instances to active agents if any."},{"line_number":242,"context_line":"# Zero value means no agent monitoring"},{"line_number":243,"context_line":"# lbaas_agent_monitoring_interval \u003d 10"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  end of items for agent scheduler extension \u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"AAAATn%2F9cZg%3D","line":243,"updated":"2013-12-11 13:43:14.000000000","message":"do we need retries - what if the device is up and unable to respond to this request or the request is lost?","commit_id":"c8d33c82b58f5fbbb3aa637fef911cf4e8bdc598"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"514470b907c477f03a32bfd3aa8fb49ea133aeb8","unresolved":false,"context_lines":[{"line_number":240,"context_line":"# Seconds between inspecting LBaaS agents states in order to find down agents"},{"line_number":241,"context_line":"# and reschedule loadbalancer instances to active agents if any."},{"line_number":242,"context_line":"# Zero value means no agent monitoring"},{"line_number":243,"context_line":"# lbaas_agent_monitoring_interval \u003d 10"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  end of items for agent scheduler extension \u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"AAAATn%2F9Wi8%3D","line":243,"in_reply_to":"AAAATn%2F9cZg%3D","updated":"2013-12-12 11:23:17.000000000","message":"This option does not initiate any requests to an agent. Agent monitorin relies on agent state reporting mechanism. Probably config option \u0027agent_down_time\u0027 on #216 can answer your question?","commit_id":"c8d33c82b58f5fbbb3aa637fef911cf4e8bdc598"},{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"75c9a926172f77a698aba83f02c48fbcd4632659","unresolved":false,"context_lines":[{"line_number":240,"context_line":"# Seconds between inspecting LBaaS agents states in order to find down agents"},{"line_number":241,"context_line":"# and reschedule loadbalancer instances to active agents if any."},{"line_number":242,"context_line":"# Zero value means no agent monitoring"},{"line_number":243,"context_line":"# lbaas_agent_monitoring_interval \u003d 10"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  end of items for agent scheduler extension \u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""}],"source_content_type":"text/plain","patch_set":12,"id":"AAAATn%2F8sTE%3D","line":243,"updated":"2013-12-23 05:55:48.000000000","message":"Whether the parameter should have some relationships with \u0027report_interval\u0027 parameter such as not less than half of report_interval and less than \u0027agent_down_time\u0027 paramether. For example, If report_interval\u003d20,while lbaas_agent_monitoring_interval\u003d2","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4fa5bbb15c8f24e10b7051e457cf4a619047bc25","unresolved":false,"context_lines":[{"line_number":240,"context_line":"# Seconds between inspecting LBaaS agents states in order to find down agents"},{"line_number":241,"context_line":"# and reschedule loadbalancer instances to active agents if any."},{"line_number":242,"context_line":"# Zero value means no agent monitoring"},{"line_number":243,"context_line":"# lbaas_agent_monitoring_interval \u003d 10"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  end of items for agent scheduler extension \u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""}],"source_content_type":"text/plain","patch_set":12,"id":"AAAATn%2F8rsY%3D","line":243,"in_reply_to":"AAAATn%2F8sTE%3D","updated":"2013-12-23 11:45:18.000000000","message":"No, actually it shouldn\u0027t. LBaaS agent monitoring fully relies on agent health mechanism and does not decide itself whether an agent is down or not.","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"}],"neutron/services/loadbalancer/agent_scheduler.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return chosen_agent"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def reschedule(self, plugin, context, pool_id, device_driver):"},{"line_number":124,"context_line":"        \"\"\"If there are eligible loadbalancer agents then unbind the pool from"},{"line_number":125,"context_line":"        the agent currently hosting (for ex. down agent) it and schedule it"},{"line_number":126,"context_line":"        to an active agent"},{"line_number":127,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAdk%3D","line":124,"updated":"2013-12-03 15:41:09.000000000","message":"Multiline doc string, put summary on first line, with period, and then rest of docstring on subsequent lines (separate from summary with blank line).","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return chosen_agent"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def reschedule(self, plugin, context, pool_id, device_driver):"},{"line_number":124,"context_line":"        \"\"\"If there are eligible loadbalancer agents then unbind the pool from"},{"line_number":125,"context_line":"        the agent currently hosting (for ex. down agent) it and schedule it"},{"line_number":126,"context_line":"        to an active agent"},{"line_number":127,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98aE%3D","line":124,"in_reply_to":"AAAATn%2F%2BAdk%3D","updated":"2013-12-04 06:56:52.000000000","message":"Done","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            if binding:"},{"line_number":151,"context_line":"                agent_id \u003d binding.agent_id"},{"line_number":152,"context_line":"                context.session.delete(binding)"},{"line_number":153,"context_line":"                LOG.debug(_(\u0027lbaas agent %(agent_id)s no longer hosts\u0027"},{"line_number":154,"context_line":"                            \u0027pool %(pool_id)s\u0027),"},{"line_number":155,"context_line":"                          {\u0027agent_id\u0027: agent_id, \u0027pool_id\u0027: pool_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAcU%3D","line":153,"updated":"2013-12-03 15:41:09.000000000","message":"and space at end of string.","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            if binding:"},{"line_number":151,"context_line":"                agent_id \u003d binding.agent_id"},{"line_number":152,"context_line":"                context.session.delete(binding)"},{"line_number":153,"context_line":"                LOG.debug(_(\u0027lbaas agent %(agent_id)s no longer hosts\u0027"},{"line_number":154,"context_line":"                            \u0027pool %(pool_id)s\u0027),"},{"line_number":155,"context_line":"                          {\u0027agent_id\u0027: agent_id, \u0027pool_id\u0027: pool_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98aA%3D","line":153,"in_reply_to":"AAAATn%2F%2BAcU%3D","updated":"2013-12-04 06:56:52.000000000","message":"Done","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"64d3513d3b42029b7bd18773af4de6ea45f0b64a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return chosen_agent"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def reschedule(self, plugin, context, pool_id, device_driver):"},{"line_number":124,"context_line":"        \"\"\"Reshedule pool no matter if it\u0027s scheduled already"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        If there are eligible loadbalancer agents then unbind the pool from"},{"line_number":127,"context_line":"        the agent currently hosting (for ex. down agent) it and schedule it"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96z0%3D","line":124,"updated":"2013-12-04 14:02:59.000000000","message":"Reshedule -\u003e reschedule\n\nAdd period to end of line for PEP257","commit_id":"f705c8ec23bbd28df98b2db86df0719a8306e297"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"345c66499dcca22eefa4318c710d0c7074f7bbc7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return chosen_agent"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def reschedule(self, plugin, context, pool_id, device_driver):"},{"line_number":124,"context_line":"        \"\"\"Reshedule pool no matter if it\u0027s scheduled already"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        If there are eligible loadbalancer agents then unbind the pool from"},{"line_number":127,"context_line":"        the agent currently hosting (for ex. down agent) it and schedule it"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F96wk%3D","line":124,"in_reply_to":"AAAATn%2F96z0%3D","updated":"2013-12-05 08:25:09.000000000","message":"Done","commit_id":"f705c8ec23bbd28df98b2db86df0719a8306e297"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1b48eb678db8cb863e3e29519dcae46f6c89e407","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return chosen_agent"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def reschedule(self, plugin, context, pool_id, device_driver):"},{"line_number":124,"context_line":"        \"\"\"Reschedule pool, no matter if it\u0027s scheduled already."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        If there are eligible loadbalancer agents then unbind the pool from"},{"line_number":127,"context_line":"        the agent currently hosting it (for ex. down agent) and schedule it"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9cYY%3D","line":124,"updated":"2013-12-11 13:43:14.000000000","message":"what if there are existing sessions running. will that make a difference?","commit_id":"c8d33c82b58f5fbbb3aa637fef911cf4e8bdc598"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"514470b907c477f03a32bfd3aa8fb49ea133aeb8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return chosen_agent"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def reschedule(self, plugin, context, pool_id, device_driver):"},{"line_number":124,"context_line":"        \"\"\"Reschedule pool, no matter if it\u0027s scheduled already."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        If there are eligible loadbalancer agents then unbind the pool from"},{"line_number":127,"context_line":"        the agent currently hosting it (for ex. down agent) and schedule it"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9WhI%3D","line":124,"in_reply_to":"AAAATn%2F9cYY%3D","updated":"2013-12-12 11:23:17.000000000","message":"No, rescheduling only changes the agent which performs actual loadbalancer managing and doesn\u0027t affect working loadbalancer devices.","commit_id":"c8d33c82b58f5fbbb3aa637fef911cf4e8bdc598"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1281fee311a01fe9185184010e51258e908e13a5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                  {\u0027pool_id\u0027: pool_id, \u0027agent_id\u0027: agent[\u0027id\u0027]})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def unbind_pool(self, context, pool_id):"},{"line_number":149,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":150,"context_line":"            query \u003d context.session.query(PoolLoadbalancerAgentBinding)"},{"line_number":151,"context_line":"            binding \u003d query.get(pool_id)"},{"line_number":152,"context_line":"            if binding:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F82a4%3D","line":149,"updated":"2013-12-19 15:59:02.000000000","message":"bind_pool and unbind_poll should be consistent with with-clause.","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4fa5bbb15c8f24e10b7051e457cf4a619047bc25","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                  {\u0027pool_id\u0027: pool_id, \u0027agent_id\u0027: agent[\u0027id\u0027]})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def unbind_pool(self, context, pool_id):"},{"line_number":149,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":150,"context_line":"            query \u003d context.session.query(PoolLoadbalancerAgentBinding)"},{"line_number":151,"context_line":"            binding \u003d query.get(pool_id)"},{"line_number":152,"context_line":"            if binding:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8zF4%3D","line":149,"in_reply_to":"AAAATn%2F82a4%3D","updated":"2013-12-23 11:45:18.000000000","message":"will update bind_pool()","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"}],"neutron/services/loadbalancer/drivers/haproxy/agent_manager.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            LOG.exception(_(\u0027Unable to deploy instance for pool: %s\u0027), pool_id)"},{"line_number":189,"context_line":"            self.needs_resync \u003d True"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def reload_pool(self, context, pool_id):"},{"line_number":192,"context_line":"        \"\"\"Handle RPC cast from plugin to reload a pool.\"\"\""},{"line_number":193,"context_line":"        self._reload_pool(pool_id)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAbw%3D","line":191,"updated":"2013-12-03 15:41:09.000000000","message":"Cn you elaborate on why a wrapper was added for this function and destroy_pool below?","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            LOG.exception(_(\u0027Unable to deploy instance for pool: %s\u0027), pool_id)"},{"line_number":189,"context_line":"            self.needs_resync \u003d True"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def reload_pool(self, context, pool_id):"},{"line_number":192,"context_line":"        \"\"\"Handle RPC cast from plugin to reload a pool.\"\"\""},{"line_number":193,"context_line":"        self._reload_pool(pool_id)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98Zc%3D","line":191,"in_reply_to":"AAAATn%2F%2BAbw%3D","updated":"2013-12-04 06:56:52.000000000","message":"Sure. Current function is an RPC handler which accepts context parameter along with pool_id; _reload_pool() accepts only pool_id and is used in sync_state() where we have no context. The same for destroy_pool.","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"42ff2b60b182385d84d4c6fa73ba0e9840446c22","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            LOG.exception(_(\u0027Unable to deploy instance for pool: %s\u0027), pool_id)"},{"line_number":189,"context_line":"            self.needs_resync \u003d True"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def reload_pool(self, context, pool_id):"},{"line_number":192,"context_line":"        \"\"\"Handle RPC cast from plugin to reload a pool.\"\"\""},{"line_number":193,"context_line":"        self._reload_pool(pool_id)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F97S4%3D","line":191,"in_reply_to":"AAAATn%2F98Zc%3D","updated":"2013-12-04 11:54:54.000000000","message":"Gotcha. Thanks.","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"}],"neutron/services/loadbalancer/drivers/haproxy/plugin_driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d10,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Seconds between inspecting LBaaS agents states \u0027"},{"line_number":56,"context_line":"                      \u0027in order to find down agents and reschedule \u0027"},{"line_number":57,"context_line":"                      \u0027loadbalancer instances to active agents if any\u0027)),"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"cfg.CONF.register_opts(AGENT_SCHEDULER_OPTS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAX8%3D","line":57,"updated":"2013-12-03 15:41:09.000000000","message":"Add comment \u0027...to active agents, if any\u0027","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d10,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Seconds between inspecting LBaaS agents states \u0027"},{"line_number":56,"context_line":"                      \u0027in order to find down agents and reschedule \u0027"},{"line_number":57,"context_line":"                      \u0027loadbalancer instances to active agents if any\u0027)),"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"cfg.CONF.register_opts(AGENT_SCHEDULER_OPTS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98ZQ%3D","line":57,"in_reply_to":"AAAATn%2F%2BAX8%3D","updated":"2013-12-04 06:56:52.000000000","message":"Done","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self._setup_agent_monitoring_on_plugin()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _setup_agent_monitoring_on_plugin(self):"},{"line_number":365,"context_line":"        # check if agent monitoring was already set by other plugin driver"},{"line_number":366,"context_line":"        if hasattr(self.plugin, \u0027agent_monitoring\u0027):"},{"line_number":367,"context_line":"            return"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAXk%3D","line":365,"updated":"2013-12-03 15:41:09.000000000","message":"May docstring?","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self._setup_agent_monitoring_on_plugin()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _setup_agent_monitoring_on_plugin(self):"},{"line_number":365,"context_line":"        # check if agent monitoring was already set by other plugin driver"},{"line_number":366,"context_line":"        if hasattr(self.plugin, \u0027agent_monitoring\u0027):"},{"line_number":367,"context_line":"            return"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98ZI%3D","line":365,"in_reply_to":"AAAATn%2F%2BAXk%3D","updated":"2013-12-04 06:56:52.000000000","message":"this only describes following two lines so it\u0027s better to be a comment","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self.plugin.agents_states \u003d {}"},{"line_number":370,"context_line":"        interval \u003d cfg.CONF.lbaas_agent_monitoring_interval"},{"line_number":371,"context_line":"        if interval:"},{"line_number":372,"context_line":"            self.plugin.agent_monitoring \u003d ("},{"line_number":373,"context_line":"                loopingcall.FixedIntervalLoopingCall("},{"line_number":374,"context_line":"                    self._check_agents_states)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAXQ%3D","line":371,"updated":"2013-12-03 15:41:09.000000000","message":"Should\u0027t this always have a value?","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self.plugin.agents_states \u003d {}"},{"line_number":370,"context_line":"        interval \u003d cfg.CONF.lbaas_agent_monitoring_interval"},{"line_number":371,"context_line":"        if interval:"},{"line_number":372,"context_line":"            self.plugin.agent_monitoring \u003d ("},{"line_number":373,"context_line":"                loopingcall.FixedIntervalLoopingCall("},{"line_number":374,"context_line":"                    self._check_agents_states)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98Y8%3D","line":371,"in_reply_to":"AAAATn%2F%2BAXQ%3D","updated":"2013-12-04 06:56:52.000000000","message":"it may be zero which means no agent monitoring","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"42617bcbd0fed7ea3882d38b51b5f2139e466910","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self.plugin.agents_states \u003d {}"},{"line_number":370,"context_line":"        interval \u003d cfg.CONF.lbaas_agent_monitoring_interval"},{"line_number":371,"context_line":"        if interval:"},{"line_number":372,"context_line":"            self.plugin.agent_monitoring \u003d ("},{"line_number":373,"context_line":"                loopingcall.FixedIntervalLoopingCall("},{"line_number":374,"context_line":"                    self._check_agents_states)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F97R8%3D","line":371,"in_reply_to":"AAAATn%2F97S8%3D","updated":"2013-12-04 11:57:02.000000000","message":"Done","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"42ff2b60b182385d84d4c6fa73ba0e9840446c22","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self.plugin.agents_states \u003d {}"},{"line_number":370,"context_line":"        interval \u003d cfg.CONF.lbaas_agent_monitoring_interval"},{"line_number":371,"context_line":"        if interval:"},{"line_number":372,"context_line":"            self.plugin.agent_monitoring \u003d ("},{"line_number":373,"context_line":"                loopingcall.FixedIntervalLoopingCall("},{"line_number":374,"context_line":"                    self._check_agents_states)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F97S8%3D","line":371,"in_reply_to":"AAAATn%2F98Y8%3D","updated":"2013-12-04 11:54:54.000000000","message":"Should zero\u003d\u003doff be mentioned in the help string for the config item L53?","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":391,"context_line":"            self.plugin.agents_states[agent[\u0027id\u0027]] \u003d active"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _reschedule_instances(self, context, agent):"},{"line_number":394,"context_line":"        \"\"\"Reschedule all loadbalancer instances currently hosted by agent"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        For each instance if there is other agent able to host it -"},{"line_number":397,"context_line":"        reschedule to that agent"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAWs%3D","line":394,"updated":"2013-12-03 15:41:09.000000000","message":"Nit. PEP257 add period to end of summary line.","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":391,"context_line":"            self.plugin.agents_states[agent[\u0027id\u0027]] \u003d active"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _reschedule_instances(self, context, agent):"},{"line_number":394,"context_line":"        \"\"\"Reschedule all loadbalancer instances currently hosted by agent"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        For each instance if there is other agent able to host it -"},{"line_number":397,"context_line":"        reschedule to that agent"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98Y0%3D","line":394,"in_reply_to":"AAAATn%2F%2BAWs%3D","updated":"2013-12-04 06:56:52.000000000","message":"Done","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    def _reschedule_instances(self, context, agent):"},{"line_number":394,"context_line":"        \"\"\"Reschedule all loadbalancer instances currently hosted by agent"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        For each instance if there is other agent able to host it -"},{"line_number":397,"context_line":"        reschedule to that agent"},{"line_number":398,"context_line":"        \"\"\""},{"line_number":399,"context_line":"        pools \u003d self.plugin.list_pools_on_lbaas_agent(context, agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BAWc%3D","line":396,"updated":"2013-12-03 15:41:09.000000000","message":"For each instance, if there is another...","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    def _reschedule_instances(self, context, agent):"},{"line_number":394,"context_line":"        \"\"\"Reschedule all loadbalancer instances currently hosted by agent"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        For each instance if there is other agent able to host it -"},{"line_number":397,"context_line":"        reschedule to that agent"},{"line_number":398,"context_line":"        \"\"\""},{"line_number":399,"context_line":"        pools \u003d self.plugin.list_pools_on_lbaas_agent(context, agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98Yw%3D","line":396,"in_reply_to":"AAAATn%2F%2BAWc%3D","updated":"2013-12-04 06:56:52.000000000","message":"Done","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"767e017a79cf30f9a6b6165dbd6bd9b221404df4","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            if driver.host_specific:"},{"line_number":403,"context_line":"                LOG.warning(_(\u0027Can\\\u0027t reschedule host specific instance %s\u0027),"},{"line_number":404,"context_line":"                            pool[\u0027id\u0027])"},{"line_number":405,"context_line":"                continue"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"            new_agent \u003d self.pool_scheduler.reschedule("},{"line_number":408,"context_line":"                self.plugin, context, pool[\u0027id\u0027], self.device_driver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BASw%3D","line":405,"updated":"2013-12-03 15:41:09.000000000","message":"Is there a case where driver for one pool is host specific, but others are not?\n\nIs it OK to then reschedule some, but not all (or is it an all or none)? Looks like it is OK.\n\nMay want to mention these points in the docstring.","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f05775bdee0254bed67b9485a055371a0668025b","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            if driver.host_specific:"},{"line_number":403,"context_line":"                LOG.warning(_(\u0027Can\\\u0027t reschedule host specific instance %s\u0027),"},{"line_number":404,"context_line":"                            pool[\u0027id\u0027])"},{"line_number":405,"context_line":"                continue"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"            new_agent \u003d self.pool_scheduler.reschedule("},{"line_number":408,"context_line":"                self.plugin, context, pool[\u0027id\u0027], self.device_driver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F98X0%3D","line":405,"in_reply_to":"AAAATn%2F%2BASw%3D","updated":"2013-12-04 06:56:52.000000000","message":"Yes, only pools from drivers that are not host specific can be rescheduled, will update docstring","commit_id":"b4078b026894208c558cf8c06f6bcebd6eb4d266"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1b48eb678db8cb863e3e29519dcae46f6c89e407","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                self.agent_rpc.instance_removed("},{"line_number":423,"context_line":"                    context, pool[\u0027id\u0027], agent[\u0027host\u0027])"},{"line_number":424,"context_line":"            else:"},{"line_number":425,"context_line":"                LOG.warning(_(\u0027Can\\\u0027t reschedule instance %s: no eligible \u0027"},{"line_number":426,"context_line":"                              \u0027agent found\u0027), pool[\u0027id\u0027])"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def _set_callbacks_on_plugin(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9cXs%3D","line":425,"updated":"2013-12-11 13:43:14.000000000","message":"You can consider \"Can\u0027t ....\"","commit_id":"c8d33c82b58f5fbbb3aa637fef911cf4e8bdc598"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"514470b907c477f03a32bfd3aa8fb49ea133aeb8","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                self.agent_rpc.instance_removed("},{"line_number":423,"context_line":"                    context, pool[\u0027id\u0027], agent[\u0027host\u0027])"},{"line_number":424,"context_line":"            else:"},{"line_number":425,"context_line":"                LOG.warning(_(\u0027Can\\\u0027t reschedule instance %s: no eligible \u0027"},{"line_number":426,"context_line":"                              \u0027agent found\u0027), pool[\u0027id\u0027])"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def _set_callbacks_on_plugin(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9Wgo%3D","line":425,"in_reply_to":"AAAATn%2F9cXs%3D","updated":"2013-12-12 11:23:17.000000000","message":"Yeah, have no preference on this :)","commit_id":"c8d33c82b58f5fbbb3aa637fef911cf4e8bdc598"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ed7240d38ed2ae5ecca134c9fb6b1a107e553320","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d10,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Seconds between inspecting LBaaS agents states \u0027"},{"line_number":56,"context_line":"                      \u0027in order to find down agents and reschedule \u0027"},{"line_number":57,"context_line":"                      \u0027loadbalancer instances to active agents, if any.\u0027"},{"line_number":58,"context_line":"                      \u0027Zero value means no agent monitoring\u0027)),"},{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9Bpw%3D","line":57,"updated":"2013-12-17 15:19:39.000000000","message":"Add space at end of line.","commit_id":"4ac9fd28e6da85d63581e1770ffdd1f9ea62e583"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"739784a6c51f520f821b7842e73eb166ecee5fb7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d10,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Seconds between inspecting LBaaS agents states \u0027"},{"line_number":56,"context_line":"                      \u0027in order to find down agents and reschedule \u0027"},{"line_number":57,"context_line":"                      \u0027loadbalancer instances to active agents, if any.\u0027"},{"line_number":58,"context_line":"                      \u0027Zero value means no agent monitoring\u0027)),"},{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9Bow%3D","line":57,"in_reply_to":"AAAATn%2F9Bpw%3D","updated":"2013-12-17 15:29:08.000000000","message":"Done","commit_id":"4ac9fd28e6da85d63581e1770ffdd1f9ea62e583"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1281fee311a01fe9185184010e51258e908e13a5","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        agents \u003d self.plugin.get_lbaas_agents(ctx)"},{"line_number":390,"context_line":"        for agent in agents:"},{"line_number":391,"context_line":"            active \u003d self.plugin.is_eligible_agent(True, agent)"},{"line_number":392,"context_line":"            if not active and self.plugin.agents_states.get(agent[\u0027id\u0027]):"},{"line_number":393,"context_line":"                # reschedule all instances from that agent to other agents"},{"line_number":394,"context_line":"                LOG.warning(_(\u0027LBaaS agent %(agent_id)s on host %(host)s \u0027"},{"line_number":395,"context_line":"                              \u0027became inactive; going to reschedule instances \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F82Rs%3D","line":392,"updated":"2013-12-19 15:59:02.000000000","message":"This only checks if the agent was active before.\nSo self.agents_states can be something like \nself.previous_active_agent \u003d set(agent[\u0027id\u0027] for agent in agents if agent is active)\nThus we don\u0027t have to track dead agents forever.","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4fa5bbb15c8f24e10b7051e457cf4a619047bc25","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        agents \u003d self.plugin.get_lbaas_agents(ctx)"},{"line_number":390,"context_line":"        for agent in agents:"},{"line_number":391,"context_line":"            active \u003d self.plugin.is_eligible_agent(True, agent)"},{"line_number":392,"context_line":"            if not active and self.plugin.agents_states.get(agent[\u0027id\u0027]):"},{"line_number":393,"context_line":"                # reschedule all instances from that agent to other agents"},{"line_number":394,"context_line":"                LOG.warning(_(\u0027LBaaS agent %(agent_id)s on host %(host)s \u0027"},{"line_number":395,"context_line":"                              \u0027became inactive; going to reschedule instances \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8rP4%3D","line":392,"in_reply_to":"AAAATn%2F82Rs%3D","updated":"2013-12-23 11:45:18.000000000","message":"Done","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1281fee311a01fe9185184010e51258e908e13a5","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                    context, pool[\u0027id\u0027], new_agent[\u0027host\u0027])"},{"line_number":420,"context_line":"                # if agent is back online - it will be notified that no"},{"line_number":421,"context_line":"                # longer handles the instance"},{"line_number":422,"context_line":"                self.agent_rpc.instance_removed("},{"line_number":423,"context_line":"                    context, pool[\u0027id\u0027], agent[\u0027host\u0027])"},{"line_number":424,"context_line":"            else:"},{"line_number":425,"context_line":"                LOG.warning(_(\u0027Can\\\u0027t reschedule instance %s: no eligible \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F82T4%3D","line":422,"updated":"2013-12-19 15:59:02.000000000","message":"Although it is difficult to understand what responsibility of agent without concrete example, doesn\u0027t this cause a sort of split brain?\nSo should this be driver specific?\nsomething like reschedule(remove_agent, new_agent)","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4fa5bbb15c8f24e10b7051e457cf4a619047bc25","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                    context, pool[\u0027id\u0027], new_agent[\u0027host\u0027])"},{"line_number":420,"context_line":"                # if agent is back online - it will be notified that no"},{"line_number":421,"context_line":"                # longer handles the instance"},{"line_number":422,"context_line":"                self.agent_rpc.instance_removed("},{"line_number":423,"context_line":"                    context, pool[\u0027id\u0027], agent[\u0027host\u0027])"},{"line_number":424,"context_line":"            else:"},{"line_number":425,"context_line":"                LOG.warning(_(\u0027Can\\\u0027t reschedule instance %s: no eligible \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8rOw%3D","line":422,"in_reply_to":"AAAATn%2F82T4%3D","updated":"2013-12-23 11:45:18.000000000","message":"Not sure I got your concern here. After rescheduling we need to notify both agents about the change. Agents will update their local cache of known devices and also notify device drivers.","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"}],"neutron/tests/unit/db/loadbalancer/test_db_loadbalancer.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"96e0aa70fa9da0f1a4d4dd2741de8dee9e4d9815","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                              [lbaas_provider],"},{"line_number":331,"context_line":"                              \u0027service_providers\u0027)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        #self.looping_call_p \u003d mock.patch("},{"line_number":334,"context_line":"        #    \u0027neutron.openstack.common.loopingcall.FixedIntervalLoopingCall\u0027)"},{"line_number":335,"context_line":"        #self.looping_call_p.start()"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F89U8%3D","line":333,"updated":"2013-12-18 12:03:29.000000000","message":"Remove commented out code.","commit_id":"5477ef1d0d9e77736909656ca25306419ebca5cb"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"dda6595be59272d7d011f0781edde0173d9cacc1","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.looping_call_p \u003d mock.patch("},{"line_number":334,"context_line":"            \u0027neutron.openstack.common.loopingcall.FixedIntervalLoopingCall\u0027)"},{"line_number":335,"context_line":"        self.looping_call_p.start()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        #force service type manager to reload configuration:"},{"line_number":338,"context_line":"        sdb.ServiceTypeManager._instance \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F88%2BA%3D","line":335,"updated":"2013-12-18 13:04:00.000000000","message":"self.addCleanup() call?","commit_id":"635c6de32d79388d5876aa6b5f049e7df6b0b5b0"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"df845ceaee00efa23076bfb9d670cb11eae6c1fa","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.looping_call_p \u003d mock.patch("},{"line_number":334,"context_line":"            \u0027neutron.openstack.common.loopingcall.FixedIntervalLoopingCall\u0027)"},{"line_number":335,"context_line":"        self.looping_call_p.start()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        #force service type manager to reload configuration:"},{"line_number":338,"context_line":"        sdb.ServiceTypeManager._instance \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8864%3D","line":335,"in_reply_to":"AAAATn%2F88%2BA%3D","updated":"2013-12-18 13:11:12.000000000","message":"please see #360","commit_id":"635c6de32d79388d5876aa6b5f049e7df6b0b5b0"}],"neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_plugin_driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"739784a6c51f520f821b7842e73eb166ecee5fb7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from neutron.tests.unit.db.loadbalancer import test_db_loadbalancer"},{"line_number":38,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestLoadBalancerPluginBase("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9Boc%3D","line":40,"updated":"2013-12-17 15:29:08.000000000","message":"not needed, will be removed","commit_id":"4ac9fd28e6da85d63581e1770ffdd1f9ea62e583"}],"neutron/tests/unit/services/loadbalancer/test_agent_scheduler.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"96e0aa70fa9da0f1a4d4dd2741de8dee9e4d9815","unresolved":false,"context_lines":[{"line_number":79,"context_line":"              \u0027HaproxyOnHostPluginDriver:default\u0027)],"},{"line_number":80,"context_line":"            \u0027service_providers\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        #self.looping_call_p \u003d mock.patch("},{"line_number":83,"context_line":"        #    \u0027neutron.openstack.common.loopingcall.FixedIntervalLoopingCall\u0027)"},{"line_number":84,"context_line":"        #self.looping_call_p.start()"},{"line_number":85,"context_line":"        #self.addCleanup(mock.patch.stopall)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F89Uk%3D","line":82,"updated":"2013-12-18 12:03:29.000000000","message":"remove commented out code.","commit_id":"5477ef1d0d9e77736909656ca25306419ebca5cb"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"dda6595be59272d7d011f0781edde0173d9cacc1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"              \u0027HaproxyOnHostPluginDriver:default\u0027)],"},{"line_number":80,"context_line":"            \u0027service_providers\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        #self.looping_call_p \u003d mock.patch("},{"line_number":83,"context_line":"        #    \u0027neutron.openstack.common.loopingcall.FixedIntervalLoopingCall\u0027)"},{"line_number":84,"context_line":"        #self.looping_call_p.start()"},{"line_number":85,"context_line":"        #self.addCleanup(mock.patch.stopall)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8888%3D","line":82,"updated":"2013-12-18 13:04:00.000000000","message":"Is this needed for the test cases? If not, you can remove.","commit_id":"635c6de32d79388d5876aa6b5f049e7df6b0b5b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1281fee311a01fe9185184010e51258e908e13a5","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            new_agent \u003d self._get_lbaas_agent_hosting_pool("},{"line_number":238,"context_line":"                pool[\u0027pool\u0027][\u0027id\u0027])"},{"line_number":239,"context_line":"            self.assertIsNotNone(new_agent)"},{"line_number":240,"context_line":"            self.assertNotEqual(new_agent[\u0027agent\u0027][\u0027id\u0027], agent[\u0027agent\u0027][\u0027id\u0027])"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class LBaaSAgentSchedulerTestCaseXML(LBaaSAgentSchedulerTestCase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F82Xw%3D","line":240,"updated":"2013-12-19 15:59:02.000000000","message":"Maybe I\u0027m too paranoiac.\nThis assert doesn\u0027t seem always correct. What\u0027s the requirement of reschedule method?\nI think in certain circumstance, reschedule method can return same agent.\nReschedule is called after determining inactive agents. During the window, agent can report and it can be active.","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4fa5bbb15c8f24e10b7051e457cf4a619047bc25","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            new_agent \u003d self._get_lbaas_agent_hosting_pool("},{"line_number":238,"context_line":"                pool[\u0027pool\u0027][\u0027id\u0027])"},{"line_number":239,"context_line":"            self.assertIsNotNone(new_agent)"},{"line_number":240,"context_line":"            self.assertNotEqual(new_agent[\u0027agent\u0027][\u0027id\u0027], agent[\u0027agent\u0027][\u0027id\u0027])"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"class LBaaSAgentSchedulerTestCaseXML(LBaaSAgentSchedulerTestCase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8zEI%3D","line":240,"in_reply_to":"AAAATn%2F82Xw%3D","updated":"2013-12-23 11:45:18.000000000","message":"You are right here about reschedule method. However in this test case agent is put to down state administratively hence won\u0027t become active - so the assertion is always correct here.","commit_id":"677c807b3e149b23e2cefc01f47e96cabbe7c8f8"}]}
