)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e37a853910756250ff87c9f26f22457dcc2e44e3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This option has been moved since Ocata (nova 15.0.0) [1]. Update the"},{"line_number":10,"context_line":"references accordingly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/openstack/nova/commit/4e5ed1c4891"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I45fdc8e40121698bf144d0e0a65537edda2c805d"},{"line_number":15,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d79741eb","line":12,"updated":"2018-08-29 15:05:39.000000000","message":"There are now two reviews for this, the other being https://review.openstack.org/#/c/596454/ - this one seems to have the correct syntax now for the parameter, it\u0027s just missing:\n\nCloses-Bug: #1788900","commit_id":"7377e9618604ef9fd6423361ba8eb3e3075f284c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4672f87e364c60447c8dcdb15c6d526d5655140a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This option has been moved since Ocata (nova 15.0.0) [1]. Update the"},{"line_number":10,"context_line":"references accordingly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/openstack/nova/commit/4e5ed1c4891"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I45fdc8e40121698bf144d0e0a65537edda2c805d"},{"line_number":15,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_473127a2","line":12,"in_reply_to":"3f79a3b5_d79741eb","updated":"2018-08-30 13:17:03.000000000","message":"Ah, I hadn\u0027t seen that. I\u0027ve fixed it here but we can squash this into the other patch if you\u0027d prefer.","commit_id":"7377e9618604ef9fd6423361ba8eb3e3075f284c"}],"doc/source/admin/config-sriov.rst":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"2ac08ef5680bf19c9a97b99ef4940e3fcfa07314","unresolved":false,"context_lines":[{"line_number":140,"context_line":"         iface eth3 inet dhcp"},{"line_number":141,"context_line":"         pre-up echo \u00274\u0027 \u003e /sys/class/net/eth3/device/sriov_numvfs"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On Red Hat, modify the ``/sbin/ifup-local`` file:"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"      .. code-block:: bash"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_b4defcd7","line":143,"updated":"2018-08-31 21:37:04.000000000","message":"Would it be more proper to say \"On RHEL\" or \"On Red Hat Linux\" here?  Comparing it to earlier, Ubuntu is a linux distro and Canonical is a company; RHEL is a linux distribution and Red Hat is a company.","commit_id":"e7c7ae807d013f029df9c19a9faba0283833421e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5ed2eff9f0d2b4843b32a2143332c26150836a29","unresolved":false,"context_lines":[{"line_number":140,"context_line":"         iface eth3 inet dhcp"},{"line_number":141,"context_line":"         pre-up echo \u00274\u0027 \u003e /sys/class/net/eth3/device/sriov_numvfs"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On Red Hat, modify the ``/sbin/ifup-local`` file:"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"      .. code-block:: bash"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_ac6d459a","line":143,"in_reply_to":"3f79a3b5_b4defcd7","updated":"2018-09-03 09:28:31.000000000","message":"Good point. Addressed here https://review.openstack.org/599328","commit_id":"e7c7ae807d013f029df9c19a9faba0283833421e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e7cb8ee6fb24fd16b771e7d08e6687ef229b71e","unresolved":false,"context_lines":[{"line_number":447,"context_line":"   .. code-block:: console"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"      $ openstack port create --network $net_id --vnic-type direct \\"},{"line_number":450,"context_line":"          sriov-port"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"   Alternatively, to request that the SR-IOV port accept trusted capabilities,"},{"line_number":453,"context_line":"   the binding profile should be enhanced with the ``trusted`` tag."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_a0ea3ed5","line":450,"updated":"2018-08-31 18:40:45.000000000","message":"super nit: would fit on previous line","commit_id":"e7c7ae807d013f029df9c19a9faba0283833421e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5ed2eff9f0d2b4843b32a2143332c26150836a29","unresolved":false,"context_lines":[{"line_number":447,"context_line":"   .. code-block:: console"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"      $ openstack port create --network $net_id --vnic-type direct \\"},{"line_number":450,"context_line":"          sriov-port"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"   Alternatively, to request that the SR-IOV port accept trusted capabilities,"},{"line_number":453,"context_line":"   the binding profile should be enhanced with the ``trusted`` tag."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_cc0d21e9","line":450,"in_reply_to":"3f79a3b5_a0ea3ed5","updated":"2018-09-03 09:28:31.000000000","message":"I did this intentionally to allow users to focus on the optional arguments separately from the positional ones. Ditto for the rest of the command examples below","commit_id":"e7c7ae807d013f029df9c19a9faba0283833421e"}]}
