)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b5e4dce0d494677d3513e513c189d225aea04805","unresolved":false,"context_lines":[{"line_number":12,"context_line":"first active ports."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Given that the condition also contains \"or self.agent_restarted(context)\""},{"line_number":15,"context_line":"which makes it True fist 180 sec (by default) after agent restart,"},{"line_number":16,"context_line":"I believe the downside of changing 1 to 2 should be negligible."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Please see bug for more details on the issue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_947bebbc","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":24},"updated":"2018-08-30 13:17:41.000000000","message":"s/first","commit_id":"94fd8f0edf17b5d3804b63e257794fddf360b34e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f8d7137486a39fd5882d300f76888fe04f899753","unresolved":false,"context_lines":[{"line_number":12,"context_line":"first active ports."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Given that the condition also contains \"or self.agent_restarted(context)\""},{"line_number":15,"context_line":"which makes it True fist 180 sec (by default) after agent restart,"},{"line_number":16,"context_line":"I believe the downside of changing 1 to 2 should be negligible."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Please see bug for more details on the issue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_0abb3672","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":24},"in_reply_to":"3f79a3b5_947bebbc","updated":"2018-08-30 14:23:12.000000000","message":"Done","commit_id":"94fd8f0edf17b5d3804b63e257794fddf360b34e"}],"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b5e4dce0d494677d3513e513c189d225aea04805","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"},{"line_number":306,"context_line":"            # we have to provide it with the whole list of fdb entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c76e9795","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":21},"updated":"2018-08-30 13:17:41.000000000","message":"is_first_port is a little misleading as it could be the second.\n\nJust thinking out loud - do we always want to send the fdb entries if this is a router port?  i.e. device_owner in ROUTER_INTERFACE_OWNERS ?  I\u0027m just thinking of the really remote case where there\u0027s an isolated network with two instances already, then the router is added.  Then a \"router or (\u003c 3 and device_owner.startswith(compute))\" check should always catch the first compute as well.","commit_id":"94fd8f0edf17b5d3804b63e257794fddf360b34e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"235037e8a1f816b1771e689105ff955a26e4d00a","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"},{"line_number":306,"context_line":"            # we have to provide it with the whole list of fdb entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a05d8149","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":21},"in_reply_to":"3f79a3b5_85173746","updated":"2018-08-30 15:38:13.000000000","message":"I was just thinking of a way to not always send the entries if 1 or 2 ports, basically:\n\nif the device_owner is a router port, send\nif the device_owner is a compute, and it\u0027s 1st or 2nd, send\n\nInstead of just always sending for first and second, since it seems like we wanted to send for a router port regardless.  Was just looking for your opinion since you\u0027ve seen it and tested this.","commit_id":"94fd8f0edf17b5d3804b63e257794fddf360b34e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"59766ee0279964175364de8ff197593f063db33e","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"},{"line_number":306,"context_line":"            # we have to provide it with the whole list of fdb entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b7d297d0","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":21},"in_reply_to":"3f79a3b5_a05d8149","updated":"2018-08-31 06:59:39.000000000","message":"Ah, thanks for clarification. So what\u0027s the case where we should\u0027n send? \nIn theory it might be 2 ports of any kind activated at the same time in a concurrent scenario, so I\u0027d like to keep it as simple as possible.","commit_id":"94fd8f0edf17b5d3804b63e257794fddf360b34e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f8d7137486a39fd5882d300f76888fe04f899753","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"},{"line_number":306,"context_line":"            # we have to provide it with the whole list of fdb entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_85173746","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":21},"in_reply_to":"3f79a3b5_c76e9795","updated":"2018-08-30 14:23:12.000000000","message":"is_first_port - it\u0027s like we\u0027re treating first 2 ports equally, like the first port, that\u0027s why I created a var and a comment. Failed to come up with a more clear name for the var :) suggestions?\n\nSorry, but the question is not quite clear to me, couldn\u0027t parse \"router or (\u003c 3 and device_owner.startswith(compute))\". Do we have 2 VMs on separate nodes? Is your concern regarding redundant fdb entries update?","commit_id":"94fd8f0edf17b5d3804b63e257794fddf360b34e"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"c40e109867fd9e39a0fd672f684d3d8708f81229","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        other_fdb_ports \u003d other_fdb_entries[network_id][\u0027ports\u0027]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d4b0588e","line":302,"updated":"2018-08-31 21:51:16.000000000","message":"I think it is better to give more details in the comment. For example, how the race was happening? How the end-users call the REST APIs which ends up with a race condition that two ports are active at the same time? Lastly, better to link to the bug report as a reference.","commit_id":"b32db30874a7729c4e9209cfc18e106a7e9fc697"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"22887e5739c7b02495c660438b9b888e3eaa9ec9","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        other_fdb_ports \u003d other_fdb_entries[network_id][\u0027ports\u0027]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_87c39157","line":302,"in_reply_to":"3f79a3b5_d4b0588e","updated":"2018-09-01 05:43:10.000000000","message":"I believe more details is what bug reports are for, not sure we should describe it in code comments, at least I didn\u0027t see such examples. I can add bug id here, but there is \"git blame\" for such things and in some projects you\u0027ll get -1 just for adding bug id in the comment :)","commit_id":"b32db30874a7729c4e9209cfc18e106a7e9fc697"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"c40e109867fd9e39a0fd672f684d3d8708f81229","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"},{"line_number":306,"context_line":"            # we have to provide it with the whole list of fdb entries"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_afb22948","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":21},"updated":"2018-08-31 21:51:16.000000000","message":"Just wondering. If there is more than one active ports, could it only be a VM port + a DVR port. If this is the only case, we could modify \u0027get_agent_network_active_port_count\u0027 to return the number of VM ports and DVR ports so that we can check more precisely that if the number of both VM and DVR port is 1?","commit_id":"b32db30874a7729c4e9209cfc18e106a7e9fc697"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"22887e5739c7b02495c660438b9b888e3eaa9ec9","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # with high concurrency more than 1 port may be activated on an agent"},{"line_number":302,"context_line":"        # at the same time (like VM port + a DVR port) so checking for 1 or 2"},{"line_number":303,"context_line":"        is_first_port \u003d agent_active_ports in (1, 2)"},{"line_number":304,"context_line":"        if is_first_port or self.agent_restarted(context):"},{"line_number":305,"context_line":"            # First port(s) activated on current agent in this network,"},{"line_number":306,"context_line":"            # we have to provide it with the whole list of fdb entries"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_07ad419a","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":21},"in_reply_to":"3f79a3b5_afb22948","updated":"2018-09-01 05:43:10.000000000","message":"\u0027get_agent_network_active_port_count\u0027 already returns both distributed and non-distributed ports count.\nIn this case it were a dvr and a VM port but I can\u0027t guarantee next time it won\u0027t be 2 VM ports. We can add more complexity here, but there should be a good reason for that","commit_id":"b32db30874a7729c4e9209cfc18e106a7e9fc697"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"02973c7bccf5d9991d0c00750c332429bb0da44d","unresolved":false,"context_lines":[{"line_number":802,"context_line":"                                   arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":803,"context_line":"                                   **host_arg) as port3:"},{"line_number":804,"context_line":"                        p1 \u003d port1[\u0027port\u0027]"},{"line_number":805,"context_line":"                        device1 \u003d \u0027tap\u0027 + p1[\u0027id\u0027]"},{"line_number":806,"context_line":"                        p2 \u003d port2[\u0027port\u0027]"},{"line_number":807,"context_line":"                        p3 \u003d port3[\u0027port\u0027]"},{"line_number":808,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9f4bff5d","line":805,"updated":"2018-08-30 17:53:00.000000000","message":"Seen pep8 failures here.\nWhere is this device1 used in the test.","commit_id":"0b4d23de9601a89444e429e5294932a4c2242042"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d4e0c31f8464c76d299a5d5c88460ee25df97d12","unresolved":false,"context_lines":[{"line_number":802,"context_line":"                                   arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":803,"context_line":"                                   **host_arg) as port3:"},{"line_number":804,"context_line":"                        p1 \u003d port1[\u0027port\u0027]"},{"line_number":805,"context_line":"                        device1 \u003d \u0027tap\u0027 + p1[\u0027id\u0027]"},{"line_number":806,"context_line":"                        p2 \u003d port2[\u0027port\u0027]"},{"line_number":807,"context_line":"                        p3 \u003d port3[\u0027port\u0027]"},{"line_number":808,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_77d4ffbb","line":805,"in_reply_to":"3f79a3b5_9f4bff5d","updated":"2018-08-31 07:15:59.000000000","message":"right, forgot to run pep8 check before sending :)","commit_id":"0b4d23de9601a89444e429e5294932a4c2242042"}]}
