)]}'
{"doc/source/contributor/internals/openvswitch_firewall.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b83c84c22ed003ed81b211b933426f16ea4f230a","unresolved":false,"context_lines":[{"line_number":464,"context_line":"are considered accepted by the egress pipeline, and will be processed so that"},{"line_number":465,"context_line":"they are forwarded to their destination by being submitted to a NORMAL action"},{"line_number":466,"context_line":"that results in Ethernet flood/learn processing. Note that ``table 91`` merely"},{"line_number":467,"context_line":"resubmits to ``table 94``that contains the actual NORMAL action; this allows"},{"line_number":468,"context_line":"to have``table 91`` be a single places where the NORMAL action can be overriden"},{"line_number":469,"context_line":"by other components (currently used by ``networking-bagpipe`` driver for"},{"line_number":470,"context_line":"``networking-bgpvpn``)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_3fece0f2","line":467,"range":{"start_line":467,"start_character":25,"end_line":467,"end_character":29},"updated":"2018-09-04 13:52:44.000000000","message":"missing space before","commit_id":"9feb5db61c68c7b95846e80449505f4f1617dd2a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b83c84c22ed003ed81b211b933426f16ea4f230a","unresolved":false,"context_lines":[{"line_number":465,"context_line":"they are forwarded to their destination by being submitted to a NORMAL action"},{"line_number":466,"context_line":"that results in Ethernet flood/learn processing. Note that ``table 91`` merely"},{"line_number":467,"context_line":"resubmits to ``table 94``that contains the actual NORMAL action; this allows"},{"line_number":468,"context_line":"to have``table 91`` be a single places where the NORMAL action can be overriden"},{"line_number":469,"context_line":"by other components (currently used by ``networking-bagpipe`` driver for"},{"line_number":470,"context_line":"``networking-bgpvpn``)."},{"line_number":471,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ffbbc8e1","line":468,"range":{"start_line":468,"start_character":3,"end_line":468,"end_character":7},"updated":"2018-09-04 13:52:44.000000000","message":"missing space after","commit_id":"9feb5db61c68c7b95846e80449505f4f1617dd2a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b83c84c22ed003ed81b211b933426f16ea4f230a","unresolved":false,"context_lines":[{"line_number":465,"context_line":"they are forwarded to their destination by being submitted to a NORMAL action"},{"line_number":466,"context_line":"that results in Ethernet flood/learn processing. Note that ``table 91`` merely"},{"line_number":467,"context_line":"resubmits to ``table 94``that contains the actual NORMAL action; this allows"},{"line_number":468,"context_line":"to have``table 91`` be a single places where the NORMAL action can be overriden"},{"line_number":469,"context_line":"by other components (currently used by ``networking-bagpipe`` driver for"},{"line_number":470,"context_line":"``networking-bgpvpn``)."},{"line_number":471,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_7fdc9873","line":468,"range":{"start_line":468,"start_character":32,"end_line":468,"end_character":38},"updated":"2018-09-04 13:52:44.000000000","message":"super nit: place","commit_id":"9feb5db61c68c7b95846e80449505f4f1617dd2a"}],"neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b83c84c22ed003ed81b211b933426f16ea4f230a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"ACCEPTED_INGRESS_TRAFFIC_TABLE \u003d 92"},{"line_number":77,"context_line":"DROPPED_TRAFFIC_TABLE \u003d 93"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE \u003d 94"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# --- Tunnel bridge (tun_br)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_5fc2fc54","line":79,"updated":"2018-09-04 13:52:44.000000000","message":"Does this need it\u0027s own comment or is it part of the above group?","commit_id":"9feb5db61c68c7b95846e80449505f4f1617dd2a"}],"neutron/tests/functional/services/logapi/test_logging.py":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3da78685a907f8a132dc0015523306e67ac6f1d6","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    ip_cidr \u003d \u0027192.168.0.1/24\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _is_log_flow_set(self, table, egress):"},{"line_number":104,"context_line":"        flows \u003d self.log_driver.int_br.br.dump_flows_for_table(table)"},{"line_number":105,"context_line":"        if egress:"},{"line_number":106,"context_line":"            normal_or_resubmit \u003d \"RESUBMIT(,%d)\" % ("},{"line_number":107,"context_line":"                ovs_consts.ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            normal_or_resubmit \u003d \"NORMAL\""},{"line_number":110,"context_line":"        pattern \u003d re.compile("},{"line_number":111,"context_line":"            r\"^.* table\u003d%s.* \""},{"line_number":112,"context_line":"            r\"actions\u003d(%s,CONTROLLER:65535|CONTROLLER:65535)\" % ("},{"line_number":113,"context_line":"                table,"},{"line_number":114,"context_line":"                normal_or_resubmit)"},{"line_number":115,"context_line":"        )"},{"line_number":116,"context_line":"        for flow in flows.splitlines():"},{"line_number":117,"context_line":"            if pattern.match(flow.strip()):"},{"line_number":118,"context_line":"                return True"},{"line_number":119,"context_line":"        return False"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _assert_logging_flows_set(self):"},{"line_number":122,"context_line":"        self.assertTrue(self._is_log_flow_set("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_187ca5b4","line":119,"range":{"start_line":103,"start_character":4,"end_line":119,"end_character":20},"updated":"2018-09-04 07:53:40.000000000","message":"How about: \ndef _is_log_flow_set(self, table, actions):\n    flows \u003d self.log_driver.int_br.br.dump_flows_for_table(table)\n    pattern \u003d re.compile(\n        r\"^.* table\u003d%s.* actions\u003d%s\" % (table, actions)\n    )\n    for flow in flows.splitlines():\n        if pattern.match(flow.strip()):\n            return True\n    return False\n\n?","commit_id":"c51d460c8abaa9e7b444916ae5d63d0b266997df"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3da78685a907f8a132dc0015523306e67ac6f1d6","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        return False"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _assert_logging_flows_set(self):"},{"line_number":122,"context_line":"        self.assertTrue(self._is_log_flow_set("},{"line_number":123,"context_line":"            table\u003dovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE, egress\u003dTrue))"},{"line_number":124,"context_line":"        self.assertTrue(self._is_log_flow_set("},{"line_number":125,"context_line":"            table\u003dovs_consts.ACCEPTED_INGRESS_TRAFFIC_TABLE, egress\u003dFalse))"},{"line_number":126,"context_line":"        self.assertTrue(self._is_log_flow_set("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_d8306d0a","line":123,"range":{"start_line":122,"start_character":8,"end_line":123,"end_character":73},"updated":"2018-09-04 07:53:40.000000000","message":"then:\nself.assertTrue(self._is_log_flow_set(\n            table\u003dovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE, actions\u003d\"resubmit\\(,94\\),CONTROLLER:65535\"))","commit_id":"c51d460c8abaa9e7b444916ae5d63d0b266997df"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3da78685a907f8a132dc0015523306e67ac6f1d6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def _assert_logging_flows_set(self):"},{"line_number":122,"context_line":"        self.assertTrue(self._is_log_flow_set("},{"line_number":123,"context_line":"            table\u003dovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE, egress\u003dTrue))"},{"line_number":124,"context_line":"        self.assertTrue(self._is_log_flow_set("},{"line_number":125,"context_line":"            table\u003dovs_consts.ACCEPTED_INGRESS_TRAFFIC_TABLE, egress\u003dFalse))"},{"line_number":126,"context_line":"        self.assertTrue(self._is_log_flow_set("},{"line_number":127,"context_line":"            table\u003dovs_consts.DROPPED_TRAFFIC_TABLE))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _assert_logging_flows_not_set(self):"},{"line_number":130,"context_line":"        self.assertFalse(self._is_log_flow_set("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_782119b4","line":127,"range":{"start_line":124,"start_character":8,"end_line":127,"end_character":52},"updated":"2018-09-04 07:53:40.000000000","message":"self.assertTrue(self._is_log_flow_set(\n            table\u003dovs_consts.ACCEPTED_INGRESS_TRAFFIC_TABLE, actions\u003d\"CONTROLLER:65535\"))\nself.assertTrue(self._is_log_flow_set(\n            table\u003dovs_consts.DROPPED_TRAFFIC_TABLE, actions\u003d\"CONTROLLER:65535\"))","commit_id":"c51d460c8abaa9e7b444916ae5d63d0b266997df"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"5a1e77e225ea7152de94a150c05fd1edcae16b2d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def _assert_logging_flows_set(self):"},{"line_number":115,"context_line":"        self.assertTrue(self._is_log_flow_set("},{"line_number":116,"context_line":"            table\u003dovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE,"},{"line_number":117,"context_line":"            actions\u003d\"RESUBMIT\\(,%d\\),CONTROLLER:65535\" % ("},{"line_number":118,"context_line":"                ovs_consts.ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE)))"},{"line_number":119,"context_line":"        self.assertTrue(self._is_log_flow_set("},{"line_number":120,"context_line":"            table\u003dovs_consts.ACCEPTED_INGRESS_TRAFFIC_TABLE,"},{"line_number":121,"context_line":"            actions\u003d\"CONTROLLER:65535\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_398ac363","line":118,"range":{"start_line":117,"start_character":20,"end_line":118,"end_character":66},"updated":"2018-09-04 09:42:06.000000000","message":"It should be: \nr\"resubmit\\(,%d\\),CONTROLLER:65535\" % (\n             ovs_consts.ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE)))","commit_id":"7ffcf6b83cf7c733eebe8f2331ada2698f0b9ba4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"5a1e77e225ea7152de94a150c05fd1edcae16b2d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _assert_logging_flows_not_set(self):"},{"line_number":127,"context_line":"        self.assertFalse(self._is_log_flow_set("},{"line_number":128,"context_line":"            table\u003dovs_consts.ACCEPTED_EGRESS_TRAFFIC_TABLE,"},{"line_number":129,"context_line":"            actions\u003d\"RESUBMIT\\(,%d\\),CONTROLLER:65535\" % ("},{"line_number":130,"context_line":"                ovs_consts.ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE)))"},{"line_number":131,"context_line":"        self.assertFalse(self._is_log_flow_set("},{"line_number":132,"context_line":"            table\u003dovs_consts.ACCEPTED_INGRESS_TRAFFIC_TABLE,"},{"line_number":133,"context_line":"            actions\u003d\"CONTROLLER:65535\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_d9e86f17","line":130,"range":{"start_line":129,"start_character":0,"end_line":130,"end_character":66},"updated":"2018-09-04 09:42:06.000000000","message":"ditto!","commit_id":"7ffcf6b83cf7c733eebe8f2331ada2698f0b9ba4"}]}