)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"579895025380ca541867acad3a805172830218cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mid_one \u003cchenjie.xu@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-06 00:00:32 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Adding a extension registration mechanism so that other subprojects can  extend the information included in a full FDB messages before it is sent to the agent.  At this time it will be used by BGPVPN to add information that was learned from peer BGP routers."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I87450e332c1a6d8bd529eb8082292e73c533676e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_7d318b0a","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":259},"updated":"2018-09-22 01:09:21.000000000","message":"Please follow the doc to rewrite the paragraphs of the commit maessage:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"8ba601b7309812b71692c57845feac71c83688cb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2412f398f4597c75d1959b0ebdbf879786eaec90","unresolved":false,"context_lines":[{"line_number":21,"context_line":"variable l2pop_fdb_extend_funcs will be called to extend the newly"},{"line_number":22,"context_line":"created fdbs."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1793653"},{"line_number":25,"context_line":"Change-Id: I87450e332c1a6d8bd529eb8082292e73c533676e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_253bbc39","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":20},"updated":"2018-09-26 06:51:48.000000000","message":"Accoring to the bug you added here, I wonder if this RFE has a spec or has been approved？","commit_id":"f723f14dbd54c1aa5957250f91f4dceff4ee9bb5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9d25d98660f75d36901a6b120cf832c88c2a8577","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mid_one \u003cchenjie.xu@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-29 20:43:25 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[RFE] Enable other projects to extend l2pop fdb information"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding an extension registration mechanism so that other subprojects"},{"line_number":10,"context_line":"can extend the information included in a full FDB messages before"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_3cd62729","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2018-09-29 05:46:53.000000000","message":"IMO, this more of looks like a refactor since existing design is not being changed.","commit_id":"416531cc9312b411005ac639a52e02d148f521e0"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"50e015c402f118815d0add34beb470d98311ad5c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mid_one \u003cchenjie.xu@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-09 03:01:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[RFE] Enable other projects to extend l2pop fdb information"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding an extension registration mechanism so that other subprojects"},{"line_number":10,"context_line":"can extend the information included in a full FDB messages before"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f79a3b5_2ec9ff22","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":27},"updated":"2018-10-12 05:55:32.000000000","message":"subprojects?","commit_id":"f9705f5bae6422f5009b40b880e45d0cc24c01ab"}],"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"579895025380ca541867acad3a805172830218cc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.plugins.ml2.drivers.l2pop import db as l2pop_db"},{"line_number":29,"context_line":"from neutron.plugins.ml2.drivers.l2pop import rpc as l2pop_rpc"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5d2ccfb1","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":10},"updated":"2018-09-22 01:09:21.000000000","message":"This import should be placed to `third-party` section, aka line 16-23.","commit_id":"8ba601b7309812b71692c57845feac71c83688cb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9d25d98660f75d36901a6b120cf832c88c2a8577","unresolved":false,"context_lines":[{"line_number":36,"context_line":"l2pop_fdb_extend_funcs \u003d {}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def register_fdb_extend_func(name, func):"},{"line_number":40,"context_line":"    l2pop_fdb_extend_funcs[name] \u003d func"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def run_fdb_extend_funcs(context, network_id, fdb_entries, source\u003dNone,"},{"line_number":44,"context_line":"                         exclude_host\u003dNone):"},{"line_number":45,"context_line":"    for name, func in six.iteritems(l2pop_fdb_extend_funcs):"},{"line_number":46,"context_line":"        if source and name \u003d\u003d source:"},{"line_number":47,"context_line":"            # Avoid data loops and do not provide data from a source back to"},{"line_number":48,"context_line":"            # itself when it requests a full data set.  (e.g., the bgpvpn"},{"line_number":49,"context_line":"            # agent should not get its own data when it queries the fdb for"},{"line_number":50,"context_line":"            # a network)."},{"line_number":51,"context_line":"            continue"},{"line_number":52,"context_line":"        fdb_entries \u003d func(context, network_id, fdb_entries,"},{"line_number":53,"context_line":"                           exclude_host\u003dexclude_host)"},{"line_number":54,"context_line":"    return fdb_entries"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class L2populationMechanismDriver(api.MechanismDriver):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1cba4be0","line":54,"range":{"start_line":39,"start_character":0,"end_line":54,"end_character":22},"updated":"2018-09-29 05:46:53.000000000","message":"I think these are candidates for neutron-lib since they\u0027re meant to serve subprojects ? may a note can be left and these can be rehomed later to neutron-lib.","commit_id":"416531cc9312b411005ac639a52e02d148f521e0"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"98b20f0d2e0385d0605888cb56aab73f78fefd8d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"l2pop_fdb_extend_funcs \u003d {}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def register_fdb_extend_func(name, func):"},{"line_number":40,"context_line":"    l2pop_fdb_extend_funcs[name] \u003d func"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_39e1722c","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":28},"updated":"2018-10-23 09:56:09.000000000","message":"No where to call this method, is there a follow up patch using this method?\nNo code found here:\nhttps://github.com/search?q\u003dorg%3Aopenstack+register_fdb_extend_func\u0026type\u003dCode","commit_id":"9828d5d5400dee128976b974f87a4cbf168d3c6e"},{"author":{"_account_id":28961,"name":"ChenjieXu","email":"chenjie.xu@intel.com","username":"mid_one"},"change_message_id":"aadc21a3adcc75fa0de02218de903f71cab0afde","unresolved":false,"context_lines":[{"line_number":36,"context_line":"l2pop_fdb_extend_funcs \u003d {}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def register_fdb_extend_func(name, func):"},{"line_number":40,"context_line":"    l2pop_fdb_extend_funcs[name] \u003d func"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_fafaf60e","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":28},"in_reply_to":"3f79a3b5_39e1722c","updated":"2018-10-24 01:52:23.000000000","message":"This method should be used by other subprojects to register their callback to l2pop. For example, project bgpvpn-networking can import the l2pop_driver by line 1 and define a new function to register its own function bgpvpn_fdb_extend_func to l2pop_driver by line 2 and 3.\n\n1 from neutron.plugins.ml2.drivers.l2pop import mech_driver as l2pop_driver\n2 def register_callbacks(self):\n3 l2pop_driver.register_fdb_extend_func( constants.BGPVPN,                                                      self.bgpvpn_fdb_extend_func)","commit_id":"9828d5d5400dee128976b974f87a4cbf168d3c6e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"98b20f0d2e0385d0605888cb56aab73f78fefd8d","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _create_agent_fdb(self, context, agent, segment, network_id,"},{"line_number":233,"context_line":"                          source\u003dNone):"},{"line_number":234,"context_line":"        exclude_host \u003d agent.host if agent else None"},{"line_number":235,"context_line":"        agent_fdb_entries \u003d {network_id:"},{"line_number":236,"context_line":"                             {\u0027segment_id\u0027: segment[\u0027segmentation_id\u0027],"},{"line_number":237,"context_line":"                              \u0027network_type\u0027: segment[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_b978227e","line":234,"range":{"start_line":234,"start_character":33,"end_line":234,"end_character":42},"updated":"2018-10-23 09:56:09.000000000","message":"Line 310 already check that, right?","commit_id":"9828d5d5400dee128976b974f87a4cbf168d3c6e"},{"author":{"_account_id":28961,"name":"ChenjieXu","email":"chenjie.xu@intel.com","username":"mid_one"},"change_message_id":"aadc21a3adcc75fa0de02218de903f71cab0afde","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _create_agent_fdb(self, context, agent, segment, network_id,"},{"line_number":233,"context_line":"                          source\u003dNone):"},{"line_number":234,"context_line":"        exclude_host \u003d agent.host if agent else None"},{"line_number":235,"context_line":"        agent_fdb_entries \u003d {network_id:"},{"line_number":236,"context_line":"                             {\u0027segment_id\u0027: segment[\u0027segmentation_id\u0027],"},{"line_number":237,"context_line":"                              \u0027network_type\u0027: segment[\u0027network_type\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_5f23dcbb","line":234,"range":{"start_line":234,"start_character":33,"end_line":234,"end_character":42},"in_reply_to":"3f79a3b5_b978227e","updated":"2018-10-24 01:52:23.000000000","message":"Yes, Line 310 already checks that.","commit_id":"9828d5d5400dee128976b974f87a4cbf168d3c6e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"98b20f0d2e0385d0605888cb56aab73f78fefd8d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        agent_host \u003d context.host"},{"line_number":308,"context_line":"        port_context \u003d context._plugin_context"},{"line_number":309,"context_line":"        agent \u003d l2pop_db.get_agent_by_host(port_context, agent_host)"},{"line_number":310,"context_line":"        if not agent:"},{"line_number":311,"context_line":"            LOG.warning(\"Unable to retrieve active L2 agent on host %s\","},{"line_number":312,"context_line":"                        agent_host)"},{"line_number":313,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_f97e9a6b","line":310,"range":{"start_line":310,"start_character":7,"end_line":310,"end_character":21},"updated":"2018-10-23 09:56:09.000000000","message":"here","commit_id":"9828d5d5400dee128976b974f87a4cbf168d3c6e"}]}
