)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"aa7ccaa4edf1c26df7b7e240a8901583ebf601d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lajos Katona \u003clajos.katona@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-11 15:48:54 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"supproted_vnic_type configurable for sriov and ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the machanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_6c98df74","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2018-09-11 20:19:16.000000000","message":"nit: typo","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lajos Katona \u003clajos.katona@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-11 15:48:54 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"supproted_vnic_type configurable for sriov and ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the machanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_911a047a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"3f79a3b5_6c98df74","updated":"2018-09-13 13:56:11.000000000","message":"Done","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bb92556be5a3e010dd307dac28bc65eb16e34e19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"supproted_vnic_type configurable for sriov and ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the machanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"},{"line_number":11,"context_line":"etc."},{"line_number":12,"context_line":"With this patch we give the rigth to the hands of the admin to decide"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_78f65d93","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":54},"updated":"2018-09-11 15:58:59.000000000","message":"\u0027mechanism\u0027","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"supproted_vnic_type configurable for sriov and ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the machanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"},{"line_number":11,"context_line":"etc."},{"line_number":12,"context_line":"With this patch we give the rigth to the hands of the admin to decide"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_3111b05e","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":54},"in_reply_to":"3f79a3b5_78f65d93","updated":"2018-09-13 13:56:11.000000000","message":"Done","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bb92556be5a3e010dd307dac28bc65eb16e34e19","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the machanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"},{"line_number":11,"context_line":"etc."},{"line_number":12,"context_line":"With this patch we give the rigth to the hands of the admin to decide"},{"line_number":13,"context_line":"which vnic types are supported for ovs and sriov agents."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_d88451d6","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":33},"updated":"2018-09-11 15:58:59.000000000","message":"do you mean right ?","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the machanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"},{"line_number":11,"context_line":"etc."},{"line_number":12,"context_line":"With this patch we give the rigth to the hands of the admin to decide"},{"line_number":13,"context_line":"which vnic types are supported for ovs and sriov agents."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_51146c4d","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":33},"in_reply_to":"3f79a3b5_d88451d6","updated":"2018-09-13 13:56:11.000000000","message":"Done","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"e3ee25d5a166c5d231a38d3e304e8a2b4882cdcc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the mechanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"},{"line_number":11,"context_line":"etc."},{"line_number":12,"context_line":"With this patch we give the right to the hands of the admin to decide"},{"line_number":13,"context_line":"which vnic types are supported for ovs and sriov agents."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_42d1fccb","line":12,"updated":"2018-09-13 15:20:43.000000000","message":"nit: The idiom is always \"put X in the hands of Y\" so it would be better to word it as \"we put the right to decide which vnic types are supported for ovs and sriov agents into the hands of the admin\".  \n\nDespite that minor correction, I like how you worded this.","commit_id":"18667ff51511b27f330099b37e2b46b85fedf33a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6a1df018d7431a963bc11831230767d999fe4f6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"},{"line_number":16,"context_line":"* unit tests? Need some more investigation if it is really possible."},{"line_number":17,"context_line":"* admin documentation guide"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I63e562e2eccc5b02c1c767d6a2c28cb803131e99"},{"line_number":20,"context_line":"Partial-Bug: #1578989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_045d4947","line":17,"updated":"2018-09-13 21:47:18.000000000","message":"So should it be consiedered as WIP still?","commit_id":"18667ff51511b27f330099b37e2b46b85fedf33a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8ab58709a2ba6d5065875fb1f1036a3982fa5fda","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"},{"line_number":16,"context_line":"* unit tests? Need some more investigation if it is really possible."},{"line_number":17,"context_line":"* admin documentation guide"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I63e562e2eccc5b02c1c767d6a2c28cb803131e99"},{"line_number":20,"context_line":"Partial-Bug: #1578989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_5ce1a32a","line":17,"in_reply_to":"3f79a3b5_045d4947","updated":"2018-09-17 15:58:05.000000000","message":"I changed it to wip","commit_id":"18667ff51511b27f330099b37e2b46b85fedf33a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"68d7834edcd2aa8b23660c8faec9ae15c3be6bdd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lajos Katona \u003clajos.katona@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-26 15:00:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"supported_vnic_type configurable for sriov and ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the mechanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_3c698e25","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":50},"updated":"2018-09-26 13:18:20.000000000","message":"Why not split to two patch sets, make things simple to review?\nHow about one patch do one thing? Thanks.","commit_id":"1b8a305c5428ef4627d204ba1ce8860db43dd6da"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lajos Katona \u003clajos.katona@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-26 15:00:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"supported_vnic_type configurable for sriov and ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the mechanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_5eabecd5","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":50},"in_reply_to":"3f79a3b5_3c698e25","updated":"2018-09-28 11:06:20.000000000","message":"Thanks Liu, I cut the patch, this","commit_id":"1b8a305c5428ef4627d204ba1ce8860db43dd6da"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lajos Katona \u003clajos.katona@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-26 15:00:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"supported_vnic_type configurable for sriov and ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now supported_vnic_types is hardcoded to the mechanism drivers, but that"},{"line_number":10,"context_line":"can depend on several factors, like type of the NIC, admin decision,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_fe83d853","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":50},"in_reply_to":"3f79a3b5_3c698e25","updated":"2018-09-28 11:06:20.000000000","message":"Thanks Liu, I cut the patch, this one is responsible for ovs, the next (https://review.openstack.org/606034) is for sriov.","commit_id":"1b8a305c5428ef4627d204ba1ce8860db43dd6da"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ef9e7f6d599d061e9365da78b243de9f563e5163","unresolved":false,"context_lines":[{"line_number":11,"context_line":"etc."},{"line_number":12,"context_line":"With this patch we put the right to decide which vnic types are"},{"line_number":13,"context_line":"supported for ovs agent into the admin, by allowing blacklisting items"},{"line_number":14,"context_line":"from the mechanism driver specific list."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I63e562e2eccc5b02c1c767d6a2c28cb803131e99"},{"line_number":17,"context_line":"Partial-Bug: #1578989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f79a3b5_bc59d75b","line":14,"updated":"2018-10-11 15:09:24.000000000","message":"Can you please add this link to the commit message?\n\nhttp://eavesdrop.openstack.org/meetings/neutron_qos/2018/neutron_qos.2018-07-31-15.00.log.html#l-58\n\nI think that meeting log gives a nice background for why we\u0027re doing this.","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":11,"context_line":"etc."},{"line_number":12,"context_line":"With this patch we put the right to decide which vnic types are"},{"line_number":13,"context_line":"supported for ovs agent into the admin, by allowing blacklisting items"},{"line_number":14,"context_line":"from the mechanism driver specific list."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I63e562e2eccc5b02c1c767d6a2c28cb803131e99"},{"line_number":17,"context_line":"Partial-Bug: #1578989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f79a3b5_e8df7435","line":14,"in_reply_to":"3f79a3b5_bc59d75b","updated":"2018-10-12 12:40:37.000000000","message":"Done","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"}],"doc/source/admin/config-ml2.rst":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"VNIC types are used to determine which mechanism driver to use to bind a port."},{"line_number":267,"context_line":"It can be specified via the Neutron API at port create time."},{"line_number":268,"context_line":"The Mechanism drivers keep track of the supported vnic types that are valid for"},{"line_number":269,"context_line":"binding for the given driver. The ``supported_vnic_types`` is a list, and the"},{"line_number":270,"context_line":"default is ``normal``."},{"line_number":271,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_fe6d8e9a","line":268,"range":{"start_line":268,"start_character":50,"end_line":268,"end_character":54},"updated":"2018-10-04 22:02:39.000000000","message":"nit: VNIC","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"VNIC types are used to determine which mechanism driver to use to bind a port."},{"line_number":267,"context_line":"It can be specified via the Neutron API at port create time."},{"line_number":268,"context_line":"The Mechanism drivers keep track of the supported vnic types that are valid for"},{"line_number":269,"context_line":"binding for the given driver. The ``supported_vnic_types`` is a list, and the"},{"line_number":270,"context_line":"default is ``normal``."},{"line_number":271,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_fe56c35e","line":268,"range":{"start_line":268,"start_character":50,"end_line":268,"end_character":54},"in_reply_to":"3f79a3b5_fe6d8e9a","updated":"2018-10-08 07:59:46.000000000","message":"Done","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":275,"context_line":"   * - mech driver / supported_vnic_types"},{"line_number":276,"context_line":"     - supported VNIC types"},{"line_number":277,"context_line":"     - configuration available"},{"line_number":278,"context_line":"   * - LinuxbridgeMechanismDriver"},{"line_number":279,"context_line":"     - normal"},{"line_number":280,"context_line":"     - no"},{"line_number":281,"context_line":"   * - MacvtapMechanismDriver"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_3eb0e6fd","line":278,"range":{"start_line":278,"start_character":7,"end_line":278,"end_character":33},"updated":"2018-10-04 22:02:39.000000000","message":"Suggest to rename this to \u0027Linux bridge\u0027 for consistency with table in line #49","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"   * - mech driver / supported_vnic_types"},{"line_number":276,"context_line":"     - supported VNIC types"},{"line_number":277,"context_line":"     - configuration available"},{"line_number":278,"context_line":"   * - LinuxbridgeMechanismDriver"},{"line_number":279,"context_line":"     - normal"},{"line_number":280,"context_line":"     - no"},{"line_number":281,"context_line":"   * - MacvtapMechanismDriver"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_de4d07c6","line":278,"range":{"start_line":278,"start_character":7,"end_line":278,"end_character":33},"in_reply_to":"3f79a3b5_3eb0e6fd","updated":"2018-10-08 07:59:46.000000000","message":"Thanks for pointing to this","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":278,"context_line":"   * - LinuxbridgeMechanismDriver"},{"line_number":279,"context_line":"     - normal"},{"line_number":280,"context_line":"     - no"},{"line_number":281,"context_line":"   * - MacvtapMechanismDriver"},{"line_number":282,"context_line":"     - macvtap"},{"line_number":283,"context_line":"     - no"},{"line_number":284,"context_line":"   * - OpenvswitchMechanismDriver"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_3ed78625","line":281,"range":{"start_line":281,"start_character":7,"end_line":281,"end_character":29},"updated":"2018-10-04 22:02:39.000000000","message":"Suggest to rename this to \u0027MacVTap\u0027 for consistency with table in line #49","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"   * - LinuxbridgeMechanismDriver"},{"line_number":279,"context_line":"     - normal"},{"line_number":280,"context_line":"     - no"},{"line_number":281,"context_line":"   * - MacvtapMechanismDriver"},{"line_number":282,"context_line":"     - macvtap"},{"line_number":283,"context_line":"     - no"},{"line_number":284,"context_line":"   * - OpenvswitchMechanismDriver"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_9e478fa4","line":281,"range":{"start_line":281,"start_character":7,"end_line":281,"end_character":29},"in_reply_to":"3f79a3b5_3ed78625","updated":"2018-10-08 07:59:46.000000000","message":"Done","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":281,"context_line":"   * - MacvtapMechanismDriver"},{"line_number":282,"context_line":"     - macvtap"},{"line_number":283,"context_line":"     - no"},{"line_number":284,"context_line":"   * - OpenvswitchMechanismDriver"},{"line_number":285,"context_line":"     - normal, direct"},{"line_number":286,"context_line":"     - yes (ovs_driver vnic_type_blacklist, see: `Configuration Reference \u003c../configuration/ml2-conf.html#ovs_driver\u003e`__)"},{"line_number":287,"context_line":"   * - SriovNicSwitchMechanismDriver"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_5e27e264","line":284,"range":{"start_line":284,"start_character":7,"end_line":284,"end_character":33},"updated":"2018-10-04 22:02:39.000000000","message":"Suggest to rename this to \u0027Open vSwitch\u0027 for consistency with table in line #49","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"   * - MacvtapMechanismDriver"},{"line_number":282,"context_line":"     - macvtap"},{"line_number":283,"context_line":"     - no"},{"line_number":284,"context_line":"   * - OpenvswitchMechanismDriver"},{"line_number":285,"context_line":"     - normal, direct"},{"line_number":286,"context_line":"     - yes (ovs_driver vnic_type_blacklist, see: `Configuration Reference \u003c../configuration/ml2-conf.html#ovs_driver\u003e`__)"},{"line_number":287,"context_line":"   * - SriovNicSwitchMechanismDriver"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_3ec2fb03","line":284,"range":{"start_line":284,"start_character":7,"end_line":284,"end_character":33},"in_reply_to":"3f79a3b5_5e27e264","updated":"2018-10-08 07:59:46.000000000","message":"Done","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":284,"context_line":"   * - OpenvswitchMechanismDriver"},{"line_number":285,"context_line":"     - normal, direct"},{"line_number":286,"context_line":"     - yes (ovs_driver vnic_type_blacklist, see: `Configuration Reference \u003c../configuration/ml2-conf.html#ovs_driver\u003e`__)"},{"line_number":287,"context_line":"   * - SriovNicSwitchMechanismDriver"},{"line_number":288,"context_line":"     - direct, macvtap, direct_physical"},{"line_number":289,"context_line":"     - no"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_bec39658","line":287,"range":{"start_line":287,"start_character":7,"end_line":287,"end_character":36},"updated":"2018-10-04 22:02:39.000000000","message":"Suggest to rename this to \u0027SRIOV\u0027 for consistency with table in line #49","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":284,"context_line":"   * - OpenvswitchMechanismDriver"},{"line_number":285,"context_line":"     - normal, direct"},{"line_number":286,"context_line":"     - yes (ovs_driver vnic_type_blacklist, see: `Configuration Reference \u003c../configuration/ml2-conf.html#ovs_driver\u003e`__)"},{"line_number":287,"context_line":"   * - SriovNicSwitchMechanismDriver"},{"line_number":288,"context_line":"     - direct, macvtap, direct_physical"},{"line_number":289,"context_line":"     - no"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_5ec7b712","line":287,"range":{"start_line":287,"start_character":7,"end_line":287,"end_character":36},"in_reply_to":"3f79a3b5_bec39658","updated":"2018-10-08 07:59:46.000000000","message":"Done","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"13a9c83f7dab3546e573b36e2a34fe3c0ae7a84d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"Supported VNIC types"},{"line_number":264,"context_line":"^^^^^^^^^^^^^^^^^^^^"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"VNIC types are used to determine which mechanism driver to use to bind a port."},{"line_number":267,"context_line":"It can be specified via the Neutron API at port create time."},{"line_number":268,"context_line":"The Mechanism drivers keep track of the supported VNIC types that are valid for"},{"line_number":269,"context_line":"binding for the given driver. The ``supported_vnic_types`` is a list, and the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f79a3b5_6223ea59","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":78},"updated":"2018-10-08 18:22:13.000000000","message":"IMO, this is not valid, same vnic can be supported by multiple mechanism drivers, and neutron by default calls all the registered mechanism drivers for l2 operations, one can have multiple mechanism drivers in same deployment that may support same type of vnic, Its upto mechanism driver to register supported types.\n\none can not determine a mechanism driver to use from vnic_types, infact admin registers or enable mechanism driver of choice in conf, it could be driver that support certain vnic types.","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":263,"context_line":"Supported VNIC types"},{"line_number":264,"context_line":"^^^^^^^^^^^^^^^^^^^^"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"VNIC types are used to determine which mechanism driver to use to bind a port."},{"line_number":267,"context_line":"It can be specified via the Neutron API at port create time."},{"line_number":268,"context_line":"The Mechanism drivers keep track of the supported VNIC types that are valid for"},{"line_number":269,"context_line":"binding for the given driver. The ``supported_vnic_types`` is a list, and the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f79a3b5_c8cb9870","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":78},"in_reply_to":"3f79a3b5_6223ea59","updated":"2018-10-12 12:40:37.000000000","message":"Thanks  Manjeet, I removed this section, based on your and Bence\u0027s comments","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ef9e7f6d599d061e9365da78b243de9f563e5163","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"   * - mech driver / supported_vnic_types"},{"line_number":276,"context_line":"     - supported VNIC types"},{"line_number":277,"context_line":"     - configuration available"},{"line_number":278,"context_line":"   * - Linux bridge"},{"line_number":279,"context_line":"     - normal"},{"line_number":280,"context_line":"     - no"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f79a3b5_5cec43bb","line":277,"range":{"start_line":277,"start_character":7,"end_line":277,"end_character":20},"updated":"2018-10-11 15:09:24.000000000","message":"Saying \u0027blacklist available\u0027 would be clearer. Generally this doc seems to be written before the code was changed to provide blacklists. Probably it should be re-phrased to reflect that.","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"   * - mech driver / supported_vnic_types"},{"line_number":276,"context_line":"     - supported VNIC types"},{"line_number":277,"context_line":"     - configuration available"},{"line_number":278,"context_line":"   * - Linux bridge"},{"line_number":279,"context_line":"     - normal"},{"line_number":280,"context_line":"     - no"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f79a3b5_88c12052","line":277,"range":{"start_line":277,"start_character":7,"end_line":277,"end_character":20},"in_reply_to":"3f79a3b5_5cec43bb","updated":"2018-10-12 12:40:37.000000000","message":"Done\nThanks, I really forgot to keep this in sync with the code.","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"}],"neutron/conf/plugins/ml2/drivers/mech_sriov/agent_common.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"aa7ccaa4edf1c26df7b7e240a8901583ebf601d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f79a3b5_e7588832","updated":"2018-09-11 20:19:16.000000000","message":"Why do we have these changes in agent_common.py? The default list of supported vnic types is a property of the mechanism driver, not a property of the agent.","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f79a3b5_54cc5aba","in_reply_to":"3f79a3b5_e7588832","updated":"2018-09-13 13:56:11.000000000","message":"I created mech_driver specific config files for these options.","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"aa7ccaa4edf1c26df7b7e240a8901583ebf601d0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"sriov_driver_opts \u003d ["},{"line_number":54,"context_line":"    cfg.ListOpt(\u0027supported_vnic_types\u0027,"},{"line_number":55,"context_line":"                default\u003dDEFAULT_VNIC_TYPES,"},{"line_number":56,"context_line":"                help\u003d_(\"Comma-separated list of vnic types supported by the \""},{"line_number":57,"context_line":"                       \"mechanism driver. Please note that the supported \""},{"line_number":58,"context_line":"                       \"vnic_types depend on your network interface card, on \""},{"line_number":59,"context_line":"                       \"the kernel version of your operating system, and on \""},{"line_number":60,"context_line":"                       \"other factors, like ovs version.\""},{"line_number":61,"context_line":"                       \"In case of sriov mechanism driver the valid values \""},{"line_number":62,"context_line":"                       \"are direct, macvtap and direct-physical.\")),"},{"line_number":63,"context_line":"]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_67b2384c","line":62,"range":{"start_line":56,"start_character":23,"end_line":62,"end_character":65},"updated":"2018-09-11 20:19:16.000000000","message":"I miss the explanation to why and when would I set this config option. Maybe we could add something like this?\n\n\"By this option you can override the supported vnic types of a mechanism driver. Of course you cannot add support for a new type by just listing it here. But you can disable support for a type by not listing it here. This config option is only relevant when multiple mechanism drivers claim support for the same vnic type (e.g. both openvswitch and sriovnicswitch for direct). Normally you express your preference of which mechanism driver should bind a port of that vnic type by setting the mechanism driver order accordingly. But when Placement drives the binding logic through binding_profile.allocation of a port the order of mechanism drivers no longer matters and you may want to not claim support for the same vnic type by multiple drivers. The order of vnic_types listed here does not matter.\"\n\nNow that I have written the above help text it got me thinking. Would it be simpler for the admin if we introduced a vnic_type_blacklist or disabled_vnic_types instead of supported_vnic_types?","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[{"line_number":53,"context_line":"sriov_driver_opts \u003d ["},{"line_number":54,"context_line":"    cfg.ListOpt(\u0027supported_vnic_types\u0027,"},{"line_number":55,"context_line":"                default\u003dDEFAULT_VNIC_TYPES,"},{"line_number":56,"context_line":"                help\u003d_(\"Comma-separated list of vnic types supported by the \""},{"line_number":57,"context_line":"                       \"mechanism driver. Please note that the supported \""},{"line_number":58,"context_line":"                       \"vnic_types depend on your network interface card, on \""},{"line_number":59,"context_line":"                       \"the kernel version of your operating system, and on \""},{"line_number":60,"context_line":"                       \"other factors, like ovs version.\""},{"line_number":61,"context_line":"                       \"In case of sriov mechanism driver the valid values \""},{"line_number":62,"context_line":"                       \"are direct, macvtap and direct-physical.\")),"},{"line_number":63,"context_line":"]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_94d3d237","line":62,"range":{"start_line":56,"start_character":23,"end_line":62,"end_character":65},"in_reply_to":"3f79a3b5_67b2384c","updated":"2018-09-13 13:56:11.000000000","message":"First for the blacklisting: I am personally not a fan of blacklisting, but here perhaps easier. I think on it and do some coding/testing with it.\n\nWhat about adding this epic to doc/source/admin/config-relevant-whatever.rst, as Manjeet suggested.","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8ab58709a2ba6d5065875fb1f1036a3982fa5fda","unresolved":false,"context_lines":[{"line_number":53,"context_line":"sriov_driver_opts \u003d ["},{"line_number":54,"context_line":"    cfg.ListOpt(\u0027supported_vnic_types\u0027,"},{"line_number":55,"context_line":"                default\u003dDEFAULT_VNIC_TYPES,"},{"line_number":56,"context_line":"                help\u003d_(\"Comma-separated list of vnic types supported by the \""},{"line_number":57,"context_line":"                       \"mechanism driver. Please note that the supported \""},{"line_number":58,"context_line":"                       \"vnic_types depend on your network interface card, on \""},{"line_number":59,"context_line":"                       \"the kernel version of your operating system, and on \""},{"line_number":60,"context_line":"                       \"other factors, like ovs version.\""},{"line_number":61,"context_line":"                       \"In case of sriov mechanism driver the valid values \""},{"line_number":62,"context_line":"                       \"are direct, macvtap and direct-physical.\")),"},{"line_number":63,"context_line":"]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bcc1d782","line":62,"range":{"start_line":56,"start_character":23,"end_line":62,"end_character":65},"in_reply_to":"3f79a3b5_67b2384c","updated":"2018-09-17 15:58:05.000000000","message":"I changed to a blacklist option, please check","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"}],"neutron/conf/plugins/ml2/drivers/mech_sriov/mech_sriov_conf.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ee3621ec694f3d3764d5b2c14052acc3008ff6e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""},{"line_number":28,"context_line":"                       \"version.\""},{"line_number":29,"context_line":"                       \"In case of sriov mechanism driver the supported vnic \""},{"line_number":30,"context_line":"                       \"types are direct, macvtap and direct-physical.\")),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_c616154b","line":29,"updated":"2018-09-19 10:45:47.000000000","message":"maybe \"valid\" would be better word instead of \"supported\" here?","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57c3304d1e88abe2d9c1c4d09f5982b51c3ceb50","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""},{"line_number":28,"context_line":"                       \"version.\""},{"line_number":29,"context_line":"                       \"In case of sriov mechanism driver the supported vnic \""},{"line_number":30,"context_line":"                       \"types are direct, macvtap and direct-physical.\")),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_e563d6a9","line":29,"in_reply_to":"3f79a3b5_c616154b","updated":"2018-09-21 09:55:12.000000000","message":"Done","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"sriov_driver_opts \u003d ["},{"line_number":21,"context_line":"    cfg.ListOpt(\u0027vnic_types_blacklist\u0027,"},{"line_number":22,"context_line":"                default\u003d[],"},{"line_number":23,"context_line":"                help\u003d_(\"Comma-separated list of vnic types that are NOT \""},{"line_number":24,"context_line":"                       \"supported by the mechanism driver. Please note that \""},{"line_number":25,"context_line":"                       \"the supported vnic_types depend on your network \""},{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_71dc6417","line":24,"range":{"start_line":23,"start_character":68,"end_line":24,"end_character":33},"updated":"2018-09-21 13:54:46.000000000","message":"Would it be clearer to say: \u0027for which support is administratively prohibited\u0027?","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"sriov_driver_opts \u003d ["},{"line_number":21,"context_line":"    cfg.ListOpt(\u0027vnic_types_blacklist\u0027,"},{"line_number":22,"context_line":"                default\u003d[],"},{"line_number":23,"context_line":"                help\u003d_(\"Comma-separated list of vnic types that are NOT \""},{"line_number":24,"context_line":"                       \"supported by the mechanism driver. Please note that \""},{"line_number":25,"context_line":"                       \"the supported vnic_types depend on your network \""},{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_728c0d39","line":24,"range":{"start_line":23,"start_character":68,"end_line":24,"end_character":33},"in_reply_to":"3f79a3b5_71dc6417","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                       \"supported by the mechanism driver. Please note that \""},{"line_number":25,"context_line":"                       \"the supported vnic_types depend on your network \""},{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""},{"line_number":28,"context_line":"                       \"version.\""},{"line_number":29,"context_line":"                       \"In case of sriov mechanism driver the valid vnic \""},{"line_number":30,"context_line":"                       \"types are direct, macvtap and direct-physical.\")),"},{"line_number":31,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_91dfc00a","line":28,"range":{"start_line":27,"start_character":64,"end_line":28,"end_character":31},"updated":"2018-09-21 13:54:46.000000000","message":"Do you want to have this in mech_sriov_conf.py?","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                       \"supported by the mechanism driver. Please note that \""},{"line_number":25,"context_line":"                       \"the supported vnic_types depend on your network \""},{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""},{"line_number":28,"context_line":"                       \"version.\""},{"line_number":29,"context_line":"                       \"In case of sriov mechanism driver the valid vnic \""},{"line_number":30,"context_line":"                       \"types are direct, macvtap and direct-physical.\")),"},{"line_number":31,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_129b5973","line":28,"range":{"start_line":27,"start_character":64,"end_line":28,"end_character":31},"in_reply_to":"3f79a3b5_91dfc00a","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"68d7834edcd2aa8b23660c8faec9ae15c3be6bdd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                       \"driver. Please note that the supported vnic_types \""},{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""},{"line_number":27,"context_line":"                       \"version of your operating system, and on other \""},{"line_number":28,"context_line":"                       \"factors.\""},{"line_number":29,"context_line":"                       \"In case of sriov mechanism driver the valid \""},{"line_number":30,"context_line":"                       \"vnic types are direct, macvtap and direct-physical.\")),"},{"line_number":31,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_3cae6e2f","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":32},"updated":"2018-09-26 13:18:20.000000000","message":"nit: here will not be a new paragraph, it will be something like this:\n\"factors.In case of\". Maybe add a space here.","commit_id":"1b8a305c5428ef4627d204ba1ce8860db43dd6da"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                       \"driver. Please note that the supported vnic_types \""},{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""},{"line_number":27,"context_line":"                       \"version of your operating system, and on other \""},{"line_number":28,"context_line":"                       \"factors.\""},{"line_number":29,"context_line":"                       \"In case of sriov mechanism driver the valid \""},{"line_number":30,"context_line":"                       \"vnic types are direct, macvtap and direct-physical.\")),"},{"line_number":31,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_3ede306a","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":32},"in_reply_to":"3f79a3b5_3cae6e2f","updated":"2018-09-28 11:06:20.000000000","message":"Thanks, I removed the break, and now this file is in the next patchset (https://review.openstack.org/606034)","commit_id":"1b8a305c5428ef4627d204ba1ce8860db43dd6da"}],"neutron/conf/plugins/ml2/drivers/openvswitch/mech_ovs_conf.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ee3621ec694f3d3764d5b2c14052acc3008ff6e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""},{"line_number":28,"context_line":"                       \"version.\""},{"line_number":29,"context_line":"                       \"In case of ovs mechanism driver the supported vnic \""},{"line_number":30,"context_line":"                       \"types are normal and direct.\""},{"line_number":31,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":32,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_86fd7d09","line":29,"updated":"2018-09-19 10:45:47.000000000","message":"ditto","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57c3304d1e88abe2d9c1c4d09f5982b51c3ceb50","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                       \"interface card, on the kernel version of your \""},{"line_number":27,"context_line":"                       \"operating system, and on other factors, like ovs \""},{"line_number":28,"context_line":"                       \"version.\""},{"line_number":29,"context_line":"                       \"In case of ovs mechanism driver the supported vnic \""},{"line_number":30,"context_line":"                       \"types are normal and direct.\""},{"line_number":31,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":32,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_850462c7","line":29,"in_reply_to":"3f79a3b5_86fd7d09","updated":"2018-09-21 09:55:12.000000000","message":"Done","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f88c0080c5280c5be9b00e3297794aa44e14995f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"ovs_driver_opts \u003d ["},{"line_number":21,"context_line":"    cfg.ListOpt(\u0027vnic_type_blacklist\u0027,"},{"line_number":22,"context_line":"                default\u003d[],"},{"line_number":23,"context_line":"                help\u003d_(\"Comma-separated list of vnic types for which support \""},{"line_number":24,"context_line":"                       \"is administratively prohibited by the mechanism \""},{"line_number":25,"context_line":"                       \"driver. Please note that the supported vnic_types \""},{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_37d7bc24","line":23,"range":{"start_line":23,"start_character":48,"end_line":23,"end_character":52},"updated":"2018-10-04 09:54:55.000000000","message":"nit: VNIC in upper case","commit_id":"80ed5af80ac140b53fbce152b3ff0ea625df2e60"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":20,"context_line":"ovs_driver_opts \u003d ["},{"line_number":21,"context_line":"    cfg.ListOpt(\u0027vnic_type_blacklist\u0027,"},{"line_number":22,"context_line":"                default\u003d[],"},{"line_number":23,"context_line":"                help\u003d_(\"Comma-separated list of vnic types for which support \""},{"line_number":24,"context_line":"                       \"is administratively prohibited by the mechanism \""},{"line_number":25,"context_line":"                       \"driver. Please note that the supported vnic_types \""},{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_087c3020","line":23,"range":{"start_line":23,"start_character":48,"end_line":23,"end_character":52},"in_reply_to":"3f79a3b5_37d7bc24","updated":"2018-10-12 12:40:37.000000000","message":"Done","commit_id":"80ed5af80ac140b53fbce152b3ff0ea625df2e60"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f88c0080c5280c5be9b00e3297794aa44e14995f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                       \"driver. Please note that the supported vnic_types \""},{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""},{"line_number":27,"context_line":"                       \"version of your operating system, and on other \""},{"line_number":28,"context_line":"                       \"factors, like ovs version. In case of ovs mechanism \""},{"line_number":29,"context_line":"                       \"driver the valid vnic types are normal and direct.\""},{"line_number":30,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":31,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_17e080f7","line":28,"range":{"start_line":28,"start_character":38,"end_line":28,"end_character":41},"updated":"2018-10-04 09:54:55.000000000","message":"ditto: OVS","commit_id":"80ed5af80ac140b53fbce152b3ff0ea625df2e60"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                       \"driver. Please note that the supported vnic_types \""},{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""},{"line_number":27,"context_line":"                       \"version of your operating system, and on other \""},{"line_number":28,"context_line":"                       \"factors, like ovs version. In case of ovs mechanism \""},{"line_number":29,"context_line":"                       \"driver the valid vnic types are normal and direct.\""},{"line_number":30,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":31,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_2881ecfa","line":28,"range":{"start_line":28,"start_character":38,"end_line":28,"end_character":41},"in_reply_to":"3f79a3b5_17e080f7","updated":"2018-10-12 12:40:37.000000000","message":"Done","commit_id":"80ed5af80ac140b53fbce152b3ff0ea625df2e60"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""},{"line_number":27,"context_line":"                       \"version of your operating system, and on other \""},{"line_number":28,"context_line":"                       \"factors, like ovs version. In case of ovs mechanism \""},{"line_number":29,"context_line":"                       \"driver the valid vnic types are normal and direct.\""},{"line_number":30,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":31,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""},{"line_number":32,"context_line":"                       \"to offload the OVS flows using tc to the SR-IOV NIC.\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_9edc9a18","line":29,"range":{"start_line":29,"start_character":73,"end_line":29,"end_character":75},"updated":"2018-10-04 22:02:39.000000000","message":"nit: space in between","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                       \"depend on your network interface card, on the kernel \""},{"line_number":27,"context_line":"                       \"version of your operating system, and on other \""},{"line_number":28,"context_line":"                       \"factors, like ovs version. In case of ovs mechanism \""},{"line_number":29,"context_line":"                       \"driver the valid vnic types are normal and direct.\""},{"line_number":30,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":31,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""},{"line_number":32,"context_line":"                       \"to offload the OVS flows using tc to the SR-IOV NIC.\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_bed5abba","line":29,"range":{"start_line":29,"start_character":73,"end_line":29,"end_character":75},"in_reply_to":"3f79a3b5_9edc9a18","updated":"2018-10-08 07:59:46.000000000","message":"Done","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"driver the valid vnic types are normal and direct.\""},{"line_number":30,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":31,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""},{"line_number":32,"context_line":"                       \"to offload the OVS flows using tc to the SR-IOV NIC.\""},{"line_number":33,"context_line":"                       \"This allows to  support hardware offload via tc and \""},{"line_number":34,"context_line":"                       \"that allows us to manage the VF by OpenFlow control \""},{"line_number":35,"context_line":"                       \"plane using representor net-device.\")),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_7e009e6a","line":32,"range":{"start_line":32,"start_character":75,"end_line":32,"end_character":77},"updated":"2018-10-04 22:02:39.000000000","message":"ditto: space in between","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"driver the valid vnic types are normal and direct.\""},{"line_number":30,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":31,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""},{"line_number":32,"context_line":"                       \"to offload the OVS flows using tc to the SR-IOV NIC.\""},{"line_number":33,"context_line":"                       \"This allows to  support hardware offload via tc and \""},{"line_number":34,"context_line":"                       \"that allows us to manage the VF by OpenFlow control \""},{"line_number":35,"context_line":"                       \"plane using representor net-device.\")),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_ded2e7cf","line":32,"range":{"start_line":32,"start_character":75,"end_line":32,"end_character":77},"in_reply_to":"3f79a3b5_7e009e6a","updated":"2018-10-08 07:59:46.000000000","message":"Done","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"}],"neutron/conf/plugins/ml2/drivers/ovs_conf.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bb92556be5a3e010dd307dac28bc65eb16e34e19","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                       \"other factors, like ovs version.\""},{"line_number":149,"context_line":"                       \"In case of ovs mechanism driver the valid values are \""},{"line_number":150,"context_line":"                       \"normal and direct.\""},{"line_number":151,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":152,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""},{"line_number":153,"context_line":"                       \"to offload the OVS flows using tc to the SR-IOV NIC.\""},{"line_number":154,"context_line":"                       \"This allows to  support hardware offload via tc and \""},{"line_number":155,"context_line":"                       \"that allows us to manage the VF by OpenFlow control \""},{"line_number":156,"context_line":"                       \"plane using representor net-device.\")),"},{"line_number":157,"context_line":"]"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b89b9515","line":156,"range":{"start_line":151,"start_character":24,"end_line":156,"end_character":58},"updated":"2018-09-11 15:58:59.000000000","message":"is this documented somewhere in neutron docs ? if not then I guess it should be added to docs in detail.","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                       \"other factors, like ovs version.\""},{"line_number":149,"context_line":"                       \"In case of ovs mechanism driver the valid values are \""},{"line_number":150,"context_line":"                       \"normal and direct.\""},{"line_number":151,"context_line":"                       \"Note that direct is supported only from kernel 4.8, \""},{"line_number":152,"context_line":"                       \"and from ovs 2.8.0. Bind DIRECT (SR-IOV) port allows \""},{"line_number":153,"context_line":"                       \"to offload the OVS flows using tc to the SR-IOV NIC.\""},{"line_number":154,"context_line":"                       \"This allows to  support hardware offload via tc and \""},{"line_number":155,"context_line":"                       \"that allows us to manage the VF by OpenFlow control \""},{"line_number":156,"context_line":"                       \"plane using representor net-device.\")),"},{"line_number":157,"context_line":"]"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f4d9e683","line":156,"range":{"start_line":151,"start_character":24,"end_line":156,"end_character":58},"in_reply_to":"3f79a3b5_b89b9515","updated":"2018-09-13 13:56:11.000000000","message":"I try to find a good place to document this","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"aa7ccaa4edf1c26df7b7e240a8901583ebf601d0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"def register_ovs_agent_opts(cfg\u003dcfg.CONF):"},{"line_number":161,"context_line":"    cfg.register_opts(ovs_opts, \"OVS\")"},{"line_number":162,"context_line":"    cfg.register_opts(agent_opts, \"AGENT\")"},{"line_number":163,"context_line":"    cfg.register_opts(ovs_driver_opts, \u0027OVS_DRIVER\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b2072c1e","line":163,"range":{"start_line":163,"start_character":39,"end_line":163,"end_character":40},"updated":"2018-09-11 20:19:16.000000000","message":"nit: maybe use \" for consistency","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[{"line_number":160,"context_line":"def register_ovs_agent_opts(cfg\u003dcfg.CONF):"},{"line_number":161,"context_line":"    cfg.register_opts(ovs_opts, \"OVS\")"},{"line_number":162,"context_line":"    cfg.register_opts(agent_opts, \"AGENT\")"},{"line_number":163,"context_line":"    cfg.register_opts(ovs_driver_opts, \u0027OVS_DRIVER\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d4de2a69","line":163,"range":{"start_line":163,"start_character":39,"end_line":163,"end_character":40},"in_reply_to":"3f79a3b5_b2072c1e","updated":"2018-09-13 13:56:11.000000000","message":"I moved the whole stuff to mech driver specific files, but, done (there)","commit_id":"e634ba79512e757b7144d3195a84f8b05ada2361"}],"neutron/opts.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":257,"context_line":"         neutron.conf.agent.securitygroups_rpc.security_group_opts),"},{"line_number":258,"context_line":"        (\u0027l2pop\u0027,"},{"line_number":259,"context_line":"         neutron.conf.plugins.ml2.drivers.l2pop.l2_population_options),"},{"line_number":260,"context_line":"        (\u0027ovs_driver\u0027,"},{"line_number":261,"context_line":"         neutron.conf.plugins.ml2.drivers.openvswitch.mech_ovs_conf."},{"line_number":262,"context_line":"         ovs_driver_opts)"},{"line_number":263,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_5eb122e0","line":260,"range":{"start_line":260,"start_character":10,"end_line":260,"end_character":20},"updated":"2018-10-04 22:02:39.000000000","message":"Instead of creating a new config group, why not simply put this config down \u0027ovs\u0027 at line line #268 ?","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"         neutron.conf.agent.securitygroups_rpc.security_group_opts),"},{"line_number":258,"context_line":"        (\u0027l2pop\u0027,"},{"line_number":259,"context_line":"         neutron.conf.plugins.ml2.drivers.l2pop.l2_population_options),"},{"line_number":260,"context_line":"        (\u0027ovs_driver\u0027,"},{"line_number":261,"context_line":"         neutron.conf.plugins.ml2.drivers.openvswitch.mech_ovs_conf."},{"line_number":262,"context_line":"         ovs_driver_opts)"},{"line_number":263,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_dea98725","line":260,"range":{"start_line":260,"start_character":10,"end_line":260,"end_character":20},"in_reply_to":"3f79a3b5_5eb122e0","updated":"2018-10-08 07:59:46.000000000","message":"The idea is that those are for ovs-agent config mostly, and put the mechanism driver (ovs, sriov) specific vnic types option under a different group.","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"}],"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ee3621ec694f3d3764d5b2c14052acc3008ff6e","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        pass"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @abc.abstractmethod"},{"line_number":202,"context_line":"    def get_supported_vnic_types(self, agent):"},{"line_number":203,"context_line":"        \"\"\"Return the agent\u0027s supported vnic_types.\"\"\""},{"line_number":204,"context_line":"        pass"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4603e50c","line":202,"updated":"2018-09-19 10:45:47.000000000","message":"by adding such abstractmethod we will break all other projects which inherits from SimpleAgentMechanismDriverBase class, and it looks that there is at least couple of them: http://codesearch.openstack.org/?q\u003dSimpleAgentMechanismDriverBase\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57c3304d1e88abe2d9c1c4d09f5982b51c3ceb50","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        pass"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @abc.abstractmethod"},{"line_number":202,"context_line":"    def get_supported_vnic_types(self, agent):"},{"line_number":203,"context_line":"        \"\"\"Return the agent\u0027s supported vnic_types.\"\"\""},{"line_number":204,"context_line":"        pass"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_05f852c1","line":202,"in_reply_to":"3f79a3b5_4603e50c","updated":"2018-09-21 09:55:12.000000000","message":"Thanks, I changed it to normal instance method, do you think that this way it can be kept?","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ee3621ec694f3d3764d5b2c14052acc3008ff6e","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def validate_supported_vnic_types(self, vnic_types, blacklist):"},{"line_number":276,"context_line":"        # Nothing to blacklist:"},{"line_number":277,"context_line":"        if len(blacklist) \u003d\u003d 0:"},{"line_number":278,"context_line":"            return vnic_types"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        # Not valid values in the blacklist:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_66086126","line":277,"updated":"2018-09-19 10:45:47.000000000","message":"wouldn\u0027t be:\n\n    if not blacklist:\n        return vnic_types\n\nenough?","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57c3304d1e88abe2d9c1c4d09f5982b51c3ceb50","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def validate_supported_vnic_types(self, vnic_types, blacklist):"},{"line_number":276,"context_line":"        # Nothing to blacklist:"},{"line_number":277,"context_line":"        if len(blacklist) \u003d\u003d 0:"},{"line_number":278,"context_line":"            return vnic_types"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        # Not valid values in the blacklist:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_25f30ee9","line":277,"in_reply_to":"3f79a3b5_66086126","updated":"2018-09-21 09:55:12.000000000","message":"Done","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ee3621ec694f3d3764d5b2c14052acc3008ff6e","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            LOG.warning(\"It seems that not all of the items from \""},{"line_number":283,"context_line":"                        \"vnic_types_blacklist are valid vnic_types for %s \""},{"line_number":284,"context_line":"                        \"mechanism driver\","},{"line_number":285,"context_line":"                        self.agent_type)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        blacklisted_vnic_types \u003d [vnic_t for vnic_t in vnic_types if"},{"line_number":288,"context_line":"                                  vnic_t not in blacklist]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_06116d53","line":285,"updated":"2018-09-19 10:45:47.000000000","message":"do we really need this warning?\nAnd second question: should\u0027t You return all vnic_types here? Why You still need to check them?","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57c3304d1e88abe2d9c1c4d09f5982b51c3ceb50","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            LOG.warning(\"It seems that not all of the items from \""},{"line_number":283,"context_line":"                        \"vnic_types_blacklist are valid vnic_types for %s \""},{"line_number":284,"context_line":"                        \"mechanism driver\","},{"line_number":285,"context_line":"                        self.agent_type)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        blacklisted_vnic_types \u003d [vnic_t for vnic_t in vnic_types if"},{"line_number":288,"context_line":"                                  vnic_t not in blacklist]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_45a64ac2","line":285,"in_reply_to":"3f79a3b5_06116d53","updated":"2018-09-21 09:55:12.000000000","message":"The idea behind this is to give some warning for the admin that something wrong (actually useless) is in the config.\nFor the 2nd question: My idea is that it\u0027s possible that the blacklist for ovs is something like this: vnic_types_blacklist \u003d direct,direct-macvtap, in that case direct can be blacklisted from ovs\u0027 supported_vnic_types, but direct-macvtap not, so give a warning in log and blacklist what is possible.","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ee3621ec694f3d3764d5b2c14052acc3008ff6e","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                        \"mechanism driver\","},{"line_number":285,"context_line":"                        self.agent_type)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        blacklisted_vnic_types \u003d [vnic_t for vnic_t in vnic_types if"},{"line_number":288,"context_line":"                                  vnic_t not in blacklist]"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        # Nothing left to the supported vnict types list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_260ee931","line":287,"updated":"2018-09-19 10:45:47.000000000","message":"this should be named as \"supported_vnic_types\", no?","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57c3304d1e88abe2d9c1c4d09f5982b51c3ceb50","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                        \"mechanism driver\","},{"line_number":285,"context_line":"                        self.agent_type)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        blacklisted_vnic_types \u003d [vnic_t for vnic_t in vnic_types if"},{"line_number":288,"context_line":"                                  vnic_t not in blacklist]"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        # Nothing left to the supported vnict types list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_c5fd7ab2","line":287,"in_reply_to":"3f79a3b5_260ee931","updated":"2018-09-21 09:55:12.000000000","message":"Done","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        pass"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def get_supported_vnic_types(self, agent):"},{"line_number":202,"context_line":"        \"\"\"Return the agent\u0027s supported vnic_types.\"\"\""},{"line_number":203,"context_line":"        return self.supported_vnic_types"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_9c86f764","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":32},"updated":"2018-09-21 13:54:46.000000000","message":"Shouldn\u0027t we add this method to neutron_lib/plugins/ml2/api.py instead of here?","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3fa3e411171136477123a8ab63bd37514ba2236c","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        pass"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def get_supported_vnic_types(self, agent):"},{"line_number":202,"context_line":"        \"\"\"Return the agent\u0027s supported vnic_types.\"\"\""},{"line_number":203,"context_line":"        return self.supported_vnic_types"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5eded710","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":32},"in_reply_to":"3f79a3b5_9c86f764","updated":"2018-09-25 16:33:27.000000000","message":"I don\u0027t agree with this (and, of course, maybe I\u0027m wrong).\n\n\"api.MechanismDriver\" just the API, so here we should have the method implementation, like we have here.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        return True"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def validate_supported_vnic_types(self, vnic_types, blacklist):"},{"line_number":275,"context_line":"        # Nothing to blacklist:"},{"line_number":276,"context_line":"        if not blacklist:"},{"line_number":277,"context_line":"            return vnic_types"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_bc689387","line":274,"range":{"start_line":274,"start_character":8,"end_line":274,"end_character":37},"updated":"2018-09-21 13:54:46.000000000","message":"This name is misleading. This method does two things: validates the blacklist and subtracts the blacklist from the supported list. None of what the name is telling.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        return True"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def validate_supported_vnic_types(self, vnic_types, blacklist):"},{"line_number":275,"context_line":"        # Nothing to blacklist:"},{"line_number":276,"context_line":"        if not blacklist:"},{"line_number":277,"context_line":"            return vnic_types"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f2057d7a","line":274,"range":{"start_line":274,"start_character":8,"end_line":274,"end_character":37},"in_reply_to":"3f79a3b5_bc689387","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Not valid values in the blacklist:"},{"line_number":280,"context_line":"        if not all(bl in vnic_types for bl in blacklist):"},{"line_number":281,"context_line":"            LOG.warning(\"It seems that not all of the items from \""},{"line_number":282,"context_line":"                        \"vnic_types_blacklist are valid vnic_types for %s \""},{"line_number":283,"context_line":"                        \"mechanism driver\","},{"line_number":284,"context_line":"                        self.agent_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_bce1732d","line":281,"range":{"start_line":281,"start_character":16,"end_line":281,"end_character":23},"updated":"2018-09-21 13:54:46.000000000","message":"Shouldn\u0027t this be an error? This is misconfiguration.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Not valid values in the blacklist:"},{"line_number":280,"context_line":"        if not all(bl in vnic_types for bl in blacklist):"},{"line_number":281,"context_line":"            LOG.warning(\"It seems that not all of the items from \""},{"line_number":282,"context_line":"                        \"vnic_types_blacklist are valid vnic_types for %s \""},{"line_number":283,"context_line":"                        \"mechanism driver\","},{"line_number":284,"context_line":"                        self.agent_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_b2ff0565","line":281,"range":{"start_line":281,"start_character":16,"end_line":281,"end_character":23},"in_reply_to":"3f79a3b5_bce1732d","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        supported_vnic_types \u003d [vnic_t for vnic_t in vnic_types if"},{"line_number":287,"context_line":"                                vnic_t not in blacklist]"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # Nothing left to the supported vnict types list:"},{"line_number":290,"context_line":"        if len(supported_vnic_types) \u003c 1:"},{"line_number":291,"context_line":"            raise ValueError(_(\"All possible vnic_types were blacklisted for \""},{"line_number":292,"context_line":"                               \"%s mechanism driver!\"), self.agent_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_dcb54f1a","line":289,"range":{"start_line":289,"start_character":23,"end_line":289,"end_character":25},"updated":"2018-09-21 13:54:46.000000000","message":"nit: in","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        supported_vnic_types \u003d [vnic_t for vnic_t in vnic_types if"},{"line_number":287,"context_line":"                                vnic_t not in blacklist]"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # Nothing left to the supported vnict types list:"},{"line_number":290,"context_line":"        if len(supported_vnic_types) \u003c 1:"},{"line_number":291,"context_line":"            raise ValueError(_(\"All possible vnic_types were blacklisted for \""},{"line_number":292,"context_line":"                               \"%s mechanism driver!\"), self.agent_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_72f16d96","line":289,"range":{"start_line":289,"start_character":23,"end_line":289,"end_character":25},"in_reply_to":"3f79a3b5_dcb54f1a","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"43a1ebc27042283796ca35e5733bc05455d65252","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :return The blacklisted vnic_types"},{"line_number":276,"context_line":"        \"\"\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        # Nothing to blacklist:"},{"line_number":279,"context_line":"        if not blacklist:"},{"line_number":280,"context_line":"            return vnic_types"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_f9949d38","line":278,"range":{"start_line":278,"start_character":8,"end_line":278,"end_character":31},"updated":"2018-09-25 17:12:15.000000000","message":"small nit: the code is self explanatory","commit_id":"f0d8e1b328f20abf6584cc561be5af2d8d32da48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"43a1ebc27042283796ca35e5733bc05455d65252","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Not valid values in the blacklist:"},{"line_number":283,"context_line":"        if not all(bl in vnic_types for bl in blacklist):"},{"line_number":284,"context_line":"            raise ValueError(_(\"Not all of the items from vnic_type_blacklist \""},{"line_number":285,"context_line":"                               \"are valid vnic_types for %s mechanism \""},{"line_number":286,"context_line":"                               \"driver.\"), self.agent_type)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_598b511d","line":284,"range":{"start_line":284,"start_character":18,"end_line":284,"end_character":28},"updated":"2018-09-25 17:12:15.000000000","message":"Exceptions in Neutron usually are custom made, inheriting from exceptions.NeutronException","commit_id":"f0d8e1b328f20abf6584cc561be5af2d8d32da48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"43a1ebc27042283796ca35e5733bc05455d65252","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Nothing left in the supported vnict types list:"},{"line_number":292,"context_line":"        if len(supported_vnic_types) \u003c 1:"},{"line_number":293,"context_line":"            raise ValueError(_(\"All possible vnic_types were blacklisted for \""},{"line_number":294,"context_line":"                               \"%s mechanism driver!\"), self.agent_type)"},{"line_number":295,"context_line":"        return supported_vnic_types"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d9768140","line":293,"range":{"start_line":293,"start_character":18,"end_line":293,"end_character":28},"updated":"2018-09-25 17:12:15.000000000","message":"ditto","commit_id":"f0d8e1b328f20abf6584cc561be5af2d8d32da48"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b6a677981bbe20528eedda908c2c8e91137edbab","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # Nothing left in the supported vnict types list:"},{"line_number":162,"context_line":"        if len(supported_vnic_types) \u003c 1:"},{"line_number":163,"context_line":"            raise ValueError(_(\"All possible vnic_types were blacklisted for \""},{"line_number":164,"context_line":"                               \"%s mechanism driver!\"), self.agent_type)"},{"line_number":165,"context_line":"        return supported_vnic_types"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_be1b96c9","line":164,"range":{"start_line":164,"start_character":54,"end_line":164,"end_character":55},"updated":"2018-10-04 22:02:39.000000000","message":"use % instead","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0516d26548e9749f3177c65b1c310e4a054c8c1f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # Nothing left in the supported vnict types list:"},{"line_number":162,"context_line":"        if len(supported_vnic_types) \u003c 1:"},{"line_number":163,"context_line":"            raise ValueError(_(\"All possible vnic_types were blacklisted for \""},{"line_number":164,"context_line":"                               \"%s mechanism driver!\"), self.agent_type)"},{"line_number":165,"context_line":"        return supported_vnic_types"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_7edf13d7","line":164,"range":{"start_line":164,"start_character":54,"end_line":164,"end_character":55},"in_reply_to":"3f79a3b5_be1b96c9","updated":"2018-10-08 07:59:46.000000000","message":"Done","commit_id":"8fbbc676a2a2f3a1947702f43e7eed34b774bda5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ef9e7f6d599d061e9365da78b243de9f563e5163","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def initialize(self):"},{"line_number":56,"context_line":"        pass"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_supported_vnic_types(self):"},{"line_number":59,"context_line":"        return self.supported_vnic_types"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def create_port_precommit(self, context):"},{"line_number":62,"context_line":"        self._insert_provisioning_block(context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_7f4a5124","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":40},"updated":"2018-10-11 15:09:24.000000000","message":"This method seems to be used only in unit tests. If that\u0027s true do we need this method at all?","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def initialize(self):"},{"line_number":56,"context_line":"        pass"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_supported_vnic_types(self):"},{"line_number":59,"context_line":"        return self.supported_vnic_types"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def create_port_precommit(self, context):"},{"line_number":62,"context_line":"        self._insert_provisioning_block(context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_28a80c89","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":40},"in_reply_to":"3f79a3b5_7f4a5124","updated":"2018-10-12 12:40:37.000000000","message":"I removed it, as it is really not used.","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"}],"neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6ee3621ec694f3d3764d5b2c14052acc3008ff6e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"cfg.CONF.import_group(\u0027SRIOV_DRIVER\u0027, \u0027neutron.plugins.ml2.drivers.mech_sriov.\u0027"},{"line_number":29,"context_line":"                      \u0027mech_driver.config\u0027)"},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":32,"context_line":"FLAT_VLAN \u003d 0"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a602f907","line":30,"updated":"2018-09-19 10:45:47.000000000","message":"nitty nit: if You will move this line above L28, You will be able to use this shorter variable also there :)","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57c3304d1e88abe2d9c1c4d09f5982b51c3ceb50","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"cfg.CONF.import_group(\u0027SRIOV_DRIVER\u0027, \u0027neutron.plugins.ml2.drivers.mech_sriov.\u0027"},{"line_number":29,"context_line":"                      \u0027mech_driver.config\u0027)"},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":32,"context_line":"FLAT_VLAN \u003d 0"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_65a9068d","line":30,"in_reply_to":"3f79a3b5_a602f907","updated":"2018-09-21 09:55:12.000000000","message":"Done","commit_id":"b584593950f675b77b73b10a342bc049e5dab742"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"43a1ebc27042283796ca35e5733bc05455d65252","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s \""},{"line_number":98,"context_line":"                      \"with switchdev capability\", portbindings.VNIC_DIRECT)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        if vnic_type not in self.supported_vnic_types:"},{"line_number":101,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s\","},{"line_number":102,"context_line":"                      vnic_type)"},{"line_number":103,"context_line":"            return"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_19e879b1","line":102,"range":{"start_line":100,"start_character":0,"end_line":102,"end_character":32},"updated":"2018-09-25 17:12:15.000000000","message":"Now this part should be executed before current L92-99","commit_id":"f0d8e1b328f20abf6584cc561be5af2d8d32da48"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"64c8d66fa77be38f3ba29d6d7f547b919f2cf0bf","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s \""},{"line_number":98,"context_line":"                      \"with switchdev capability\", portbindings.VNIC_DIRECT)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        if vnic_type not in self.supported_vnic_types:"},{"line_number":101,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s\","},{"line_number":102,"context_line":"                      vnic_type)"},{"line_number":103,"context_line":"            return"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_fe2d1845","line":102,"range":{"start_line":100,"start_character":0,"end_line":102,"end_character":32},"in_reply_to":"3f79a3b5_19e879b1","updated":"2018-09-28 11:12:43.000000000","message":"I would do that in a new independent patch.","commit_id":"f0d8e1b328f20abf6584cc561be5af2d8d32da48"}],"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bb92556be5a3e010dd307dac28bc65eb16e34e19","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                IPTABLES_FW_DRIVER_FULL, \u0027iptables_hybrid\u0027)) and sg_enabled"},{"line_number":53,"context_line":"        vif_details \u003d {portbindings.CAP_PORT_FILTER: sg_enabled,"},{"line_number":54,"context_line":"                       portbindings.OVS_HYBRID_PLUG: hybrid_plug_required}"},{"line_number":55,"context_line":"        # NOTE(moshele): Bind DIRECT (SR-IOV) port allows"},{"line_number":56,"context_line":"        # to offload the OVS flows using tc to the SR-IOV NIC."},{"line_number":57,"context_line":"        # We are using OVS mechanism driver because the openvswitch (\u003e\u003d2.8.0)"},{"line_number":58,"context_line":"        # support hardware offload via tc and that allow us to manage the VF by"},{"line_number":59,"context_line":"        # OpenFlow control plane using representor net-device."},{"line_number":60,"context_line":"        super(OpenvswitchMechanismDriver, self).__init__("},{"line_number":61,"context_line":"            constants.AGENT_TYPE_OVS,"},{"line_number":62,"context_line":"            portbindings.VIF_TYPE_OVS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fb5ca7f1","side":"PARENT","line":59,"range":{"start_line":55,"start_character":8,"end_line":59,"end_character":62},"updated":"2018-09-11 15:58:59.000000000","message":"this comment still makes sense, here in code, if VNIC_TYPE is direct, I see a Note added to conf help message, but it can be kept here as well. and right place is to document it somewhere in neutron documents.","commit_id":"eaff4be1c12393545147aa1c18880cf90bd7e8a4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b63e052dca80302d61387630f97606a95684e47","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                IPTABLES_FW_DRIVER_FULL, \u0027iptables_hybrid\u0027)) and sg_enabled"},{"line_number":53,"context_line":"        vif_details \u003d {portbindings.CAP_PORT_FILTER: sg_enabled,"},{"line_number":54,"context_line":"                       portbindings.OVS_HYBRID_PLUG: hybrid_plug_required}"},{"line_number":55,"context_line":"        # NOTE(moshele): Bind DIRECT (SR-IOV) port allows"},{"line_number":56,"context_line":"        # to offload the OVS flows using tc to the SR-IOV NIC."},{"line_number":57,"context_line":"        # We are using OVS mechanism driver because the openvswitch (\u003e\u003d2.8.0)"},{"line_number":58,"context_line":"        # support hardware offload via tc and that allow us to manage the VF by"},{"line_number":59,"context_line":"        # OpenFlow control plane using representor net-device."},{"line_number":60,"context_line":"        super(OpenvswitchMechanismDriver, self).__init__("},{"line_number":61,"context_line":"            constants.AGENT_TYPE_OVS,"},{"line_number":62,"context_line":"            portbindings.VIF_TYPE_OVS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_74e6364d","side":"PARENT","line":59,"range":{"start_line":55,"start_character":8,"end_line":59,"end_character":62},"in_reply_to":"3f79a3b5_fb5ca7f1","updated":"2018-09-13 13:56:11.000000000","message":"I moved back the comment, and try to find a good place to document this.","commit_id":"eaff4be1c12393545147aa1c18880cf90bd7e8a4"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                IPTABLES_FW_DRIVER_FULL, \u0027iptables_hybrid\u0027)) and sg_enabled"},{"line_number":54,"context_line":"        vif_details \u003d {portbindings.CAP_PORT_FILTER: sg_enabled,"},{"line_number":55,"context_line":"                       portbindings.OVS_HYBRID_PLUG: hybrid_plug_required}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # NOTE(moshele): Bind DIRECT (SR-IOV) port allows"},{"line_number":58,"context_line":"        # to offload the OVS flows using tc to the SR-IOV NIC."},{"line_number":59,"context_line":"        # We are using OVS mechanism driver because the openvswitch (\u003e\u003d2.8.0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5cdb7f4c","line":56,"updated":"2018-09-21 13:54:46.000000000","message":"nit: Let\u0027s not add random whitespace.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                IPTABLES_FW_DRIVER_FULL, \u0027iptables_hybrid\u0027)) and sg_enabled"},{"line_number":54,"context_line":"        vif_details \u003d {portbindings.CAP_PORT_FILTER: sg_enabled,"},{"line_number":55,"context_line":"                       portbindings.OVS_HYBRID_PLUG: hybrid_plug_required}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # NOTE(moshele): Bind DIRECT (SR-IOV) port allows"},{"line_number":58,"context_line":"        # to offload the OVS flows using tc to the SR-IOV NIC."},{"line_number":59,"context_line":"        # We are using OVS mechanism driver because the openvswitch (\u003e\u003d2.8.0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_12f03991","line":56,"in_reply_to":"3f79a3b5_5cdb7f4c","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":65,"context_line":"            vif_details)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Note(lajoskatona): blacklisting supported_vnic_types with the"},{"line_number":68,"context_line":"        # vnic_types_blacklist list coming from config"},{"line_number":69,"context_line":"        self.supported_vnic_types \u003d self.validate_supported_vnic_types("},{"line_number":70,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT],"},{"line_number":71,"context_line":"            blacklist\u003dcfg.CONF.OVS_DRIVER.vnic_types_blacklist"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3cb1e301","line":68,"range":{"start_line":67,"start_character":8,"end_line":68,"end_character":54},"updated":"2018-09-21 13:54:46.000000000","message":"If the method below had been named better, this comment would not be needed.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":65,"context_line":"            vif_details)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Note(lajoskatona): blacklisting supported_vnic_types with the"},{"line_number":68,"context_line":"        # vnic_types_blacklist list coming from config"},{"line_number":69,"context_line":"        self.supported_vnic_types \u003d self.validate_supported_vnic_types("},{"line_number":70,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT],"},{"line_number":71,"context_line":"            blacklist\u003dcfg.CONF.OVS_DRIVER.vnic_types_blacklist"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_32ebf5a4","line":68,"range":{"start_line":67,"start_character":8,"end_line":68,"end_character":54},"in_reply_to":"3f79a3b5_3cb1e301","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"43a1ebc27042283796ca35e5733bc05455d65252","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                        portbindings.VNIC_NORMAL)"},{"line_number":91,"context_line":"        profile \u003d context.current.get(portbindings.PROFILE)"},{"line_number":92,"context_line":"        capabilities \u003d []"},{"line_number":93,"context_line":"        if profile:"},{"line_number":94,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":95,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":96,"context_line":"                \u0027switchdev\u0027 not in capabilities):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_592cb100","line":93,"updated":"2018-09-25 17:12:15.000000000","message":"IMO, you should add something like in https://review.openstack.org/#/c/601600/8/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py@100","commit_id":"f0d8e1b328f20abf6584cc561be5af2d8d32da48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f88c0080c5280c5be9b00e3297794aa44e14995f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":65,"context_line":"            vif_details)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.supported_vnic_types \u003d self.blacklist_supported_vnic_types("},{"line_number":68,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT],"},{"line_number":69,"context_line":"            blacklist\u003dcfg.CONF.OVS_DRIVER.vnic_type_blacklist"},{"line_number":70,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_f76aa418","line":67,"updated":"2018-10-04 09:54:55.000000000","message":"Just a comment, maybe a TODO in the code: this can be done generically for all SimpleAgentMechanismDriverBase drivers.\n\nSimpleAgentMechanismDriverBase has \"supported_vnic_types\" as an input parameter. By adding a kwarg \"blacklisted_vnic_types\u003dNone\" in the definition, you can execute \"blacklist_supported_vnic_types()\" for all drivers.\n\n\ndef __init__(self):\n  vnic_types\u003d[portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT]\n  blacklisted_vnic_types\u003dcfg.CONF.OVS_DRIVER.vnic_type_blacklist\n  super(OpenvswitchMechanismDriver, self).__init__(\n            constants.AGENT_TYPE_OVS,\n            portbindings.VIF_TYPE_OVS,\n            vif_details,\n            blacklisted_vnic_types\u003dblacklisted_vnic_types)\n\n\nThis will work with the current code (Linux Bridge or macvtap, for example) and future new implementations with possible blacklisted vnic types (SR-IOV)","commit_id":"80ed5af80ac140b53fbce152b3ff0ea625df2e60"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e547002d8181995d711e15595e19ec261aca52d8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":65,"context_line":"            vif_details)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.supported_vnic_types \u003d self.blacklist_supported_vnic_types("},{"line_number":68,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT],"},{"line_number":69,"context_line":"            blacklist\u003dcfg.CONF.OVS_DRIVER.vnic_type_blacklist"},{"line_number":70,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_4325295a","line":67,"in_reply_to":"3f79a3b5_28afac7c","updated":"2018-10-12 13:21:44.000000000","message":"Another thing for this: as now these 2 patches add the config option vnic_type_blacklist to ovs and sriov mech driver, the same option should be added to linuxbridge... etc drivers as well to make it effective, and useful for the admin.","commit_id":"80ed5af80ac140b53fbce152b3ff0ea625df2e60"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":65,"context_line":"            vif_details)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.supported_vnic_types \u003d self.blacklist_supported_vnic_types("},{"line_number":68,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT],"},{"line_number":69,"context_line":"            blacklist\u003dcfg.CONF.OVS_DRIVER.vnic_type_blacklist"},{"line_number":70,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_28afac7c","line":67,"in_reply_to":"3f79a3b5_f76aa418","updated":"2018-10-12 12:40:37.000000000","message":"I added a TODO. As I see LinuxbridgeMechanismDriver, MacvtapMechanismDriver, SriovNicSwitchMechanismDriver and OpenvswitchMechanismDriver are inheriting from SimpleAgentMechanismDriverBase in neutron tree, as a follow-up patch I will check this possibility, if that is good for you.","commit_id":"80ed5af80ac140b53fbce152b3ff0ea625df2e60"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ef9e7f6d599d061e9365da78b243de9f563e5163","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            blacklist\u003dcfg.CONF.OVS_DRIVER.vnic_type_blacklist"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        LOG.info(\"%s mechanism driver\u0027s supported_vnic_types: %s\","},{"line_number":72,"context_line":"                 self.agent_type, self.supported_vnic_types)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        ovs_qos_driver.register()"},{"line_number":75,"context_line":"        log_driver.register()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_3f1619a9","line":72,"range":{"start_line":72,"start_character":22,"end_line":72,"end_character":32},"updated":"2018-10-11 15:09:24.000000000","message":"The text says mechanism driver, but this is the agent type.","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            blacklist\u003dcfg.CONF.OVS_DRIVER.vnic_type_blacklist"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        LOG.info(\"%s mechanism driver\u0027s supported_vnic_types: %s\","},{"line_number":72,"context_line":"                 self.agent_type, self.supported_vnic_types)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        ovs_qos_driver.register()"},{"line_number":75,"context_line":"        log_driver.register()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_e88d3435","line":72,"range":{"start_line":72,"start_character":22,"end_line":72,"end_character":32},"in_reply_to":"3f79a3b5_3f1619a9","updated":"2018-10-12 12:40:37.000000000","message":"Done","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"0cdf60465e9bb12a3b9f7f22d86a3e3e4f6d6d62","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.services.qos.drivers.openvswitch import driver as ovs_qos_driver"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":"cfg.CONF.import_group(\u0027OVS_DRIVER\u0027, \u0027neutron.plugins.ml2.drivers.openvswitch.\u0027"},{"line_number":34,"context_line":"                      \u0027mech_driver.config\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"IPTABLES_FW_DRIVER_FULL \u003d (\"neutron.agent.linux.iptables_firewall.\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_b42a3175","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":21},"updated":"2018-10-12 15:00:41.000000000","message":"A minor issue.\n\nThis approach is generally used with configuration objects that are shared by multiple modules, but so far this config group is used in this module only. Therefore, we could simplify it a bit by directly registering this config instead:\n\n  mech_ovs_conf.register_ovs_mech_driver_opts()\n\nThen, the file neutron/plugins/ml2/drivers/openvswitch/mech_driver/config.py can be removed.","commit_id":"76f2f88a451f7a40f26019f81b7d0ef90042acd0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d7f4f8c00f200aeea6b9b8895ba3215e1e1c64fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.services.qos.drivers.openvswitch import driver as ovs_qos_driver"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":"cfg.CONF.import_group(\u0027OVS_DRIVER\u0027, \u0027neutron.plugins.ml2.drivers.openvswitch.\u0027"},{"line_number":34,"context_line":"                      \u0027mech_driver.config\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"IPTABLES_FW_DRIVER_FULL \u003d (\"neutron.agent.linux.iptables_firewall.\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_fa5bb31f","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":21},"in_reply_to":"3f79a3b5_b42a3175","updated":"2018-10-12 15:36:10.000000000","message":"+1","commit_id":"76f2f88a451f7a40f26019f81b7d0ef90042acd0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a205f661d3b5806bb2308ada1da061b6bec6cbb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.services.qos.drivers.openvswitch import driver as ovs_qos_driver"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":"cfg.CONF.import_group(\u0027OVS_DRIVER\u0027, \u0027neutron.plugins.ml2.drivers.openvswitch.\u0027"},{"line_number":34,"context_line":"                      \u0027mech_driver.config\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"IPTABLES_FW_DRIVER_FULL \u003d (\"neutron.agent.linux.iptables_firewall.\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_48e0ba27","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":21},"in_reply_to":"3f79a3b5_b42a3175","updated":"2018-10-15 18:38:07.000000000","message":"Thanks, I removed confing.py, and run register_ovs_.... directly.","commit_id":"76f2f88a451f7a40f26019f81b7d0ef90042acd0"}],"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/mech_driver/test_mech_sriov_nic_switch.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"class ConfFixture(config_fixture.Config):"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def __init__(self, conf\u003dcfg.CONF, blacklist\u003dNone):"},{"line_number":206,"context_line":"        super(ConfFixture, self).__init__(conf)"},{"line_number":207,"context_line":"        self.blacklist \u003d blacklist"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_dc4f8f89","line":205,"range":{"start_line":205,"start_character":38,"end_line":205,"end_character":52},"updated":"2018-09-21 13:54:46.000000000","message":"This could be way more generic if it took a config option like this:\n\n {\n   \u0027group1\u0027: {\u0027opt1\u0027: \u0027val1\u0027,\n              \u0027opt2\u0027: ...},\n   \u0027group2\u0027: ...\n }","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"class ConfFixture(config_fixture.Config):"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def __init__(self, conf\u003dcfg.CONF, blacklist\u003dNone):"},{"line_number":206,"context_line":"        super(ConfFixture, self).__init__(conf)"},{"line_number":207,"context_line":"        self.blacklist \u003d blacklist"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f22a5de4","line":205,"range":{"start_line":205,"start_character":38,"end_line":205,"end_character":52},"in_reply_to":"3f79a3b5_dc4f8f89","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                             agent\u003dNone))"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def test_vnic_types_blacklist_valid_item(self):"},{"line_number":237,"context_line":"        black_list \u003d [portbindings.VNIC_MACVTAP]"},{"line_number":238,"context_line":"        fake_conf \u003d cfg.CONF"},{"line_number":239,"context_line":"        fake_conf_fixture \u003d ConfFixture(fake_conf, black_list)"},{"line_number":240,"context_line":"        self.useFixture(fake_conf_fixture)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_7c78bbf6","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":18},"updated":"2018-09-21 13:54:46.000000000","message":"It would be nice to spell blacklist consistently.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                             agent\u003dNone))"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def test_vnic_types_blacklist_valid_item(self):"},{"line_number":237,"context_line":"        black_list \u003d [portbindings.VNIC_MACVTAP]"},{"line_number":238,"context_line":"        fake_conf \u003d cfg.CONF"},{"line_number":239,"context_line":"        fake_conf_fixture \u003d ConfFixture(fake_conf, black_list)"},{"line_number":240,"context_line":"        self.useFixture(fake_conf_fixture)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_b234e54a","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":18},"in_reply_to":"3f79a3b5_7c78bbf6","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        test_driver \u003d mech_driver.SriovNicSwitchMechanismDriver()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        supported_vnic_types \u003d test_driver.get_supported_vnic_types(agent\u003dNone)"},{"line_number":245,"context_line":"        self.assertNotIn(black_list, supported_vnic_types)"},{"line_number":246,"context_line":"        # Note(lajoskatona): assume that SriovNicSwitchMechanismDriver"},{"line_number":247,"context_line":"        # initilaized with the default 3 vnic type."},{"line_number":248,"context_line":"        self.assertEqual(2, len(supported_vnic_types))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_7c2afbe6","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":57},"updated":"2018-09-21 13:54:46.000000000","message":"The \u0027in\u0027 operator tests for list elements, it does not test for sub-lists. I think you wanted something like this:\n\n self.assertNotIn(black_list[0], supported_vnic_types)\n\nOr something like this:\n\n not_wanted \u003d portbindings.VNIC_MACVTAP\n ...\n ... \u003d ConfFixture(fake_conf, [not_wanted])\n ...\n self.assertNotIn(not_wanted, supported_vnic_types)","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        test_driver \u003d mech_driver.SriovNicSwitchMechanismDriver()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        supported_vnic_types \u003d test_driver.get_supported_vnic_types(agent\u003dNone)"},{"line_number":245,"context_line":"        self.assertNotIn(black_list, supported_vnic_types)"},{"line_number":246,"context_line":"        # Note(lajoskatona): assume that SriovNicSwitchMechanismDriver"},{"line_number":247,"context_line":"        # initilaized with the default 3 vnic type."},{"line_number":248,"context_line":"        self.assertEqual(2, len(supported_vnic_types))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3240d5a2","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":57},"in_reply_to":"3f79a3b5_7c2afbe6","updated":"2018-09-28 11:06:20.000000000","message":"Done","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        supported_vnic_types \u003d test_driver.get_supported_vnic_types(agent\u003dNone)"},{"line_number":245,"context_line":"        self.assertNotIn(black_list, supported_vnic_types)"},{"line_number":246,"context_line":"        # Note(lajoskatona): assume that SriovNicSwitchMechanismDriver"},{"line_number":247,"context_line":"        # initilaized with the default 3 vnic type."},{"line_number":248,"context_line":"        self.assertEqual(2, len(supported_vnic_types))"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_vnic_types_blacklist_not_valid_item(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_7cc67b18","line":247,"range":{"start_line":246,"start_character":8,"end_line":247,"end_character":51},"updated":"2018-09-21 13:54:46.000000000","message":"Would it be hard to fake \u0027supported_vnic_types\u0027 too? Then we wouldn\u0027t need this comment and assumption.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        supported_vnic_types \u003d test_driver.get_supported_vnic_types(agent\u003dNone)"},{"line_number":245,"context_line":"        self.assertNotIn(black_list, supported_vnic_types)"},{"line_number":246,"context_line":"        # Note(lajoskatona): assume that SriovNicSwitchMechanismDriver"},{"line_number":247,"context_line":"        # initilaized with the default 3 vnic type."},{"line_number":248,"context_line":"        self.assertEqual(2, len(supported_vnic_types))"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_vnic_types_blacklist_not_valid_item(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_92e689b0","line":247,"range":{"start_line":246,"start_character":8,"end_line":247,"end_character":51},"in_reply_to":"3f79a3b5_7cc67b18","updated":"2018-09-28 11:06:20.000000000","message":"I added instead a class level default_supported_vnics, so no need for faking, or adding comments","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        test_driver \u003d mech_driver.SriovNicSwitchMechanismDriver()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        supported_vnic_types \u003d test_driver.get_supported_vnic_types(agent\u003dNone)"},{"line_number":259,"context_line":"        self.assertNotIn(black_list, supported_vnic_types)"},{"line_number":260,"context_line":"        # Note(lajoskatona): assume that SriovNicSwitchMechanismDriver"},{"line_number":261,"context_line":"        # initilaized with the default 3 vnic type."},{"line_number":262,"context_line":"        self.assertEqual(3, len(supported_vnic_types))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_772774b7","line":259,"range":{"start_line":259,"start_character":22,"end_line":259,"end_character":35},"updated":"2018-09-21 13:54:46.000000000","message":"The same type error as above.\n\nBut also I would expect the blacklisting function to raise() in this case instead of continuing after an error like this.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        test_driver \u003d mech_driver.SriovNicSwitchMechanismDriver()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        supported_vnic_types \u003d test_driver.get_supported_vnic_types(agent\u003dNone)"},{"line_number":259,"context_line":"        self.assertNotIn(black_list, supported_vnic_types)"},{"line_number":260,"context_line":"        # Note(lajoskatona): assume that SriovNicSwitchMechanismDriver"},{"line_number":261,"context_line":"        # initilaized with the default 3 vnic type."},{"line_number":262,"context_line":"        self.assertEqual(3, len(supported_vnic_types))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5200f135","line":259,"range":{"start_line":259,"start_character":22,"end_line":259,"end_character":35},"in_reply_to":"3f79a3b5_772774b7","updated":"2018-09-28 11:06:20.000000000","message":"I changed the validation to raise ValuError, and changed the test accordingly","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"}],"releasenotes/notes/make-supported-vnic-types-configurable-for-ovs-and-sriov-fc73422daffd42b0.yaml":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"339ccd68d051de97b6ce565ac122bcd9b6e91e5a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new configuration group ``ovs_driver`` and ``sriov_driver`` and"},{"line_number":5,"context_line":"    new configuration option under them ``vnic_types_blacklist``, to make the"},{"line_number":6,"context_line":"    previously hardcoded supported_vnic_type parameter of the"},{"line_number":7,"context_line":"    OpenvswitchMechanismDriver and SriovNicSwitchMechanismDriver configurable."},{"line_number":8,"context_line":"    The ``vnic_types`` listed in the blacklist will be removed from the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_d7b5281a","line":5,"range":{"start_line":5,"start_character":51,"end_line":5,"end_character":52},"updated":"2018-09-21 13:54:46.000000000","message":"I\u0027m not a native English speaker, but IMHO in a word like this we usually use the singular form of whatever the list consists of: vnic_type_list.","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a0379cf4ee16789e670c4cb1222ca960ed713e8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new configuration group ``ovs_driver`` and ``sriov_driver`` and"},{"line_number":5,"context_line":"    new configuration option under them ``vnic_types_blacklist``, to make the"},{"line_number":6,"context_line":"    previously hardcoded supported_vnic_type parameter of the"},{"line_number":7,"context_line":"    OpenvswitchMechanismDriver and SriovNicSwitchMechanismDriver configurable."},{"line_number":8,"context_line":"    The ``vnic_types`` listed in the blacklist will be removed from the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_72808d9d","line":5,"range":{"start_line":5,"start_character":51,"end_line":5,"end_character":52},"in_reply_to":"3f79a3b5_d7b5281a","updated":"2018-09-28 11:06:20.000000000","message":"I changed it to vnic_type_blacklist everywhere (I hope at least)","commit_id":"f692883e448974c925821c560563eb2fa6cfeede"}],"releasenotes/notes/make-supported-vnic-types-configurable-for-ovs-fc73422daffd42b0.yaml":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ef9e7f6d599d061e9365da78b243de9f563e5163","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new configuration group ``ovs_driver`` and new configuration option"},{"line_number":5,"context_line":"    under it ``vnic_type_blacklist``, to make the previously hardcoded"},{"line_number":6,"context_line":"    supported_vnic_type parameter of the OpenvswitchMechanismDriver"},{"line_number":7,"context_line":"    configurable."},{"line_number":8,"context_line":"    The ``vnic_types`` listed in the blacklist will be removed from the"},{"line_number":9,"context_line":"    supported_vnic_types list."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_9f7acd22","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":23},"updated":"2018-10-11 15:09:24.000000000","message":"Plural please.","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"beea0bd1e5f720a24f76c9474e223f4252590504","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new configuration group ``ovs_driver`` and new configuration option"},{"line_number":5,"context_line":"    under it ``vnic_type_blacklist``, to make the previously hardcoded"},{"line_number":6,"context_line":"    supported_vnic_type parameter of the OpenvswitchMechanismDriver"},{"line_number":7,"context_line":"    configurable."},{"line_number":8,"context_line":"    The ``vnic_types`` listed in the blacklist will be removed from the"},{"line_number":9,"context_line":"    supported_vnic_types list."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_a893bc58","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":23},"in_reply_to":"3f79a3b5_9f7acd22","updated":"2018-10-12 12:40:37.000000000","message":"Done","commit_id":"7397316d8b9e94be52c976ab982db4b87364fc09"}]}
