)]}'
{"neutron/plugins/plumgrid/drivers/fake_plumlib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b94c56aeb3b83e04e58d11a03ee87f1b56bcbdad","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_network(self, tenant_id, net_db, network):"},{"line_number":42,"context_line":"        pass"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def update_network(self, tenant_id, net_id):"},{"line_number":45,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Fotk%3D","line":42,"updated":"2014-01-10 08:52:51.000000000","message":"IMO fake_plumlib should emulate the behavior of actual plumlib. It seems the actual plumlib fills provider network attribute, so we can emulate the behavior by just filling passed attrs to net_db. Doesn\u0027t it work?\n\n   def create_network(self, tenant_id, net_db, network):\n        for key in (provider.NETWORK_TYPE,\n                    provider.PHYSICAL_NETWORK,\n                    provider.SEGMENTATION_ID):\n            net_db[key] \u003d network[key]\n\n\nI don\u0027t think you need to reuse test_extension_pnet.py (or existing tests for DB based implementation).","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"6623dfe2e2c22f74b30f71fa8deee39bbecd0b53","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_network(self, tenant_id, net_db, network):"},{"line_number":42,"context_line":"        pass"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def update_network(self, tenant_id, net_id):"},{"line_number":45,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FkFc%3D","line":42,"in_reply_to":"AAAAUH%2F%2Bbus%3D","updated":"2014-02-12 10:17:27.000000000","message":"PLUMgrid team is also working on a refactoring of the plugin. Currently, we are having so many race conditions. This proposal will be considered following nicira lead!","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"6623dfe2e2c22f74b30f71fa8deee39bbecd0b53","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_network(self, tenant_id, net_db, network):"},{"line_number":42,"context_line":"        pass"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def update_network(self, tenant_id, net_id):"},{"line_number":45,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FkGI%3D","line":42,"in_reply_to":"AAAAUH%2F%2Fotk%3D","updated":"2014-02-12 10:17:27.000000000","message":"Done","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5f8cd6c42b12946510e496fb9a6856afc37fd0b1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_network(self, tenant_id, net_db, network):"},{"line_number":42,"context_line":"        pass"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def update_network(self, tenant_id, net_id):"},{"line_number":45,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Bbus%3D","line":42,"in_reply_to":"AAAAUH%2F%2Fotk%3D","updated":"2014-01-26 18:35:39.000000000","message":"the fake plumlib looks pretty much a stub at the moment. I think Akihiro is instead suggesting of making it an \u0027emulator\u0027 of the backend API.\n\nThe nicira plugin has something like that, but the nicira is team is starting to move away from it as its mainteinance is costly and it\u0027s a potential source of testing bugs for which there\u0027s no unit testing!\nSo the nicira team is now starting to move towards mocking backend calls but emulating expected return values on a per-call basis. Perhaps this will be more pedantic and boring, but it\u0027s safer and actually makes it easier to ensure the unit test emulates correctly the backend.","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e9db148547d253935101053517439e8770b5dd68","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        for key in (provider.NETWORK_TYPE,"},{"line_number":44,"context_line":"                    provider.PHYSICAL_NETWORK,"},{"line_number":45,"context_line":"                    provider.SEGMENTATION_ID):"},{"line_number":46,"context_line":"            net_db[\"network\"][key] \u003d network[\"network\"][key]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def update_network(self, tenant_id, net_id):"},{"line_number":49,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BxNw%3D","line":46,"updated":"2014-02-19 06:59:38.000000000","message":"nit: it would be better if plumlib didn\u0027t modify the net_db dict passes in and instead just returned an updated network dict.","commit_id":"cda9ab3bf3aebd45ab189807c89b591318196b61"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"1c95a69a79fe3a827d08c9dfe71f858445f69dea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        for key in (provider.NETWORK_TYPE,"},{"line_number":44,"context_line":"                    provider.PHYSICAL_NETWORK,"},{"line_number":45,"context_line":"                    provider.SEGMENTATION_ID):"},{"line_number":46,"context_line":"            net_db[\"network\"][key] \u003d network[\"network\"][key]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def update_network(self, tenant_id, net_id):"},{"line_number":49,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BxMI%3D","line":46,"in_reply_to":"AAAAUX%2F%2BxNw%3D","updated":"2014-02-19 07:00:56.000000000","message":"*passed","commit_id":"cda9ab3bf3aebd45ab189807c89b591318196b61"}],"neutron/plugins/plumgrid/drivers/plumlib.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4e19072da5ae82ec32dbfbe5de7485097557ac68","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def director_conn(self, director_plumgrid, director_port, timeout,"},{"line_number":41,"context_line":"                      director_admin, director_password):"},{"line_number":42,"context_line":"        self.plumlib \u003d plumlib.Plumlib(director_plumgrid,"},{"line_number":43,"context_line":"                                       director_port,"},{"line_number":44,"context_line":"                                       timeout,"},{"line_number":45,"context_line":"                                       director_admin,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F5ak%3D","line":42,"updated":"2014-01-07 03:50:01.000000000","message":"Off topic from patch but In my opinion this is slightly confusing as this class is called Plumlib and this is referencing Plumlib which looks to be something that sits outside of neutron. Is Plumlib opensource out of curiosity?","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"eda09ed027c0dc6bd5c785d4a3ef7ea5764bcce4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def director_conn(self, director_plumgrid, director_port, timeout,"},{"line_number":41,"context_line":"                      director_admin, director_password):"},{"line_number":42,"context_line":"        self.plumlib \u003d plumlib.Plumlib(director_plumgrid,"},{"line_number":43,"context_line":"                                       director_port,"},{"line_number":44,"context_line":"                                       timeout,"},{"line_number":45,"context_line":"                                       director_admin,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F3Mc%3D","line":42,"in_reply_to":"AAAAUH%2F%2F5ak%3D","updated":"2014-01-07 14:59:27.000000000","message":"No yet, Plumlib indeed is an external component that is in process to be opensourced","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"}],"neutron/plugins/plumgrid/plumgrid_plugin/plumgrid_plugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4e19072da5ae82ec32dbfbe5de7485097557ac68","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            try:"},{"line_number":115,"context_line":"                LOG.debug(_(\u0027PLUMgrid Library: create_network() called\u0027))"},{"line_number":116,"context_line":"                self._plumlib.create_network(tenant_id, net_db, network)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                LOG.error(ERR_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F5aU%3D","line":116,"updated":"2014-01-07 03:50:01.000000000","message":"You\u0027re not storing the provider network info in the neutron db here is this intended? \n\nAlso, it would probably be better to pass the provider network attributes to plumlib though the net_db attribute rather than passing in duplicate data through another param.","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"6623dfe2e2c22f74b30f71fa8deee39bbecd0b53","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            try:"},{"line_number":115,"context_line":"                LOG.debug(_(\u0027PLUMgrid Library: create_network() called\u0027))"},{"line_number":116,"context_line":"                self._plumlib.create_network(tenant_id, net_db, network)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                LOG.error(ERR_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FkFE%3D","line":116,"in_reply_to":"AAAAUH%2F%2F2wc%3D","updated":"2014-02-12 10:17:27.000000000","message":"Couldn\u0027t explain it better myself!","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e466003ae2b986c457cead03a38c5fdb6d77014c","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            try:"},{"line_number":115,"context_line":"                LOG.debug(_(\u0027PLUMgrid Library: create_network() called\u0027))"},{"line_number":116,"context_line":"                self._plumlib.create_network(tenant_id, net_db, network)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                LOG.error(ERR_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F2wc%3D","line":116,"in_reply_to":"AAAAUH%2F%2F3Lw%3D","updated":"2014-01-07 16:27:48.000000000","message":"Right now your plugin leverages all of the get_ methods in the db_base class so if someone creates a provider network there is no way to determine the provider network attributes after the fact as you are always returning their values from the db and not saving this there (nor do you  pull these values down from the controller). \n\nYes I understand the data is different in both net_db as create_network(context, network) drops other fields passed in via the api. I\u0027m just saying the interface would be much cleaner if it only passed in network. that said since external plumlib has an interface defined this way this change would probably break backwards compat so nvm.","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"eda09ed027c0dc6bd5c785d4a3ef7ea5764bcce4","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            try:"},{"line_number":115,"context_line":"                LOG.debug(_(\u0027PLUMgrid Library: create_network() called\u0027))"},{"line_number":116,"context_line":"                self._plumlib.create_network(tenant_id, net_db, network)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                LOG.error(ERR_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F3Lw%3D","line":116,"in_reply_to":"AAAAUH%2F%2F5aU%3D","updated":"2014-01-07 14:59:27.000000000","message":"Yes, that is intended. It is easier to controller from the PLUMgrid side. \nThe data is different between net_db and network, this is why we need both.","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e466003ae2b986c457cead03a38c5fdb6d77014c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003dERR_MESSAGE)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # Return created network"},{"line_number":123,"context_line":"        return net_db"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def update_network(self, context, net_id, network):"},{"line_number":126,"context_line":"        \"\"\"Update Neutron network."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F2vw%3D","line":123,"updated":"2014-01-07 16:27:48.000000000","message":"Since you return net_db you don\u0027t return the provider network attributes.","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5f8cd6c42b12946510e496fb9a6856afc37fd0b1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003dERR_MESSAGE)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # Return created network"},{"line_number":123,"context_line":"        return net_db"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def update_network(self, context, net_id, network):"},{"line_number":126,"context_line":"        \"\"\"Update Neutron network."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Bbt8%3D","line":123,"in_reply_to":"AAAAUH%2F%2F2vw%3D","updated":"2014-01-26 18:35:39.000000000","message":"I wonder how this patch passes tempest tests for provider networks, since it\u0027s basically a setting which is directly forwarded to the backend skipping the neutron database.","commit_id":"52c705dbfea899363bcfad3796166c434c4ff598"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e9db148547d253935101053517439e8770b5dd68","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            try:"},{"line_number":114,"context_line":"                LOG.debug(_(\u0027PLUMgrid Library: create_network() called\u0027))"},{"line_number":115,"context_line":"                self._plumlib.create_network(tenant_id, net_db, network)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            except Exception as err_message:"},{"line_number":118,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BxMc%3D","line":115,"updated":"2014-02-19 06:59:38.000000000","message":"nit: it this interface would be better if it didn\u0027t pass in two networks and instead copied over the needed fields to the first one.","commit_id":"cda9ab3bf3aebd45ab189807c89b591318196b61"}]}
