)]}'
{"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5f1cb77a5cd8e579d46b9e7ce200e741b436b788","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    else:"},{"line_number":310,"context_line":"                        devices_down.add(device)"},{"line_number":311,"context_line":"                else:"},{"line_number":312,"context_line":"                    resync \u003d True"},{"line_number":313,"context_line":"                self._update_network_ports(device_details[\u0027network_id\u0027],"},{"line_number":314,"context_line":"                                           port_id,"},{"line_number":315,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6079d080","line":312,"range":{"start_line":312,"start_character":20,"end_line":312,"end_character":33},"updated":"2018-09-24 13:27:35.000000000","message":"I don\u0027t understand why do we need to resync. This device will remain in device_info[\u0027updated\u0027] or device_info[\u0027added\u0027], so in the next agent loop this device will be treated again.\n\nWith the resync flag to True, we are forcing the agent to reset again all VFs, regardless the status of the interface.\n\nIf this is an issue of HW slowness, in the next loop \"self.treat_device\" will try to handle the VF again.","commit_id":"9d0bda554ffda21a55ca0ef0b048c08a71e2cac1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7f907a59134a1aea904696f271748ede69ec1ec0","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    else:"},{"line_number":310,"context_line":"                        devices_down.add(device)"},{"line_number":311,"context_line":"                else:"},{"line_number":312,"context_line":"                    resync \u003d True"},{"line_number":313,"context_line":"                self._update_network_ports(device_details[\u0027network_id\u0027],"},{"line_number":314,"context_line":"                                           port_id,"},{"line_number":315,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_039a636e","line":312,"range":{"start_line":312,"start_character":20,"end_line":312,"end_character":33},"in_reply_to":"3f79a3b5_6079d080","updated":"2018-09-24 15:35:00.000000000","message":"I think this is good here as there is no need to return list of ports which should be resynced in next rpc_loop iteration.","commit_id":"9d0bda554ffda21a55ca0ef0b048c08a71e2cac1"}]}
