)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"09d52572bb8399197f5067525ea05ca39faea08c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config option endpoint_type for designate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Designate client can only use publicURL as default endpoint type when neutron"},{"line_number":10,"context_line":"uses designate as an external dns driver, add this option to use adminURL or"},{"line_number":11,"context_line":"internalURL as the endpoint type. The option endpoint_type can be configured"},{"line_number":12,"context_line":"in neutron.conf as follows."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_c1e53ca6","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":77},"updated":"2018-09-25 00:02:41.000000000","message":"Nit: As you can see by crossing the vertical dotted line, the maximum length of 72 characters in a commit message is being exceeded. Same for L10-11","commit_id":"55b8852fd27109593978d86ecdadbc8cbeef7299"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"09d52572bb8399197f5067525ea05ca39faea08c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Designate client can only use publicURL as default endpoint type when neutron"},{"line_number":10,"context_line":"uses designate as an external dns driver, add this option to use adminURL or"},{"line_number":11,"context_line":"internalURL as the endpoint type. The option endpoint_type can be configured"},{"line_number":12,"context_line":"in neutron.conf as follows."},{"line_number":13,"context_line":"[designate]:"},{"line_number":14,"context_line":"endpoint_type\u003dpublicURL, adminURL or internalURL"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_41f92c4c","line":12,"updated":"2018-09-25 00:02:41.000000000","message":"This is not a bug. This is a RFE as I have indicated in https://bugs.launchpad.net/neutron/+bug/1756291. Let\u0027s debate in the RFE why do we need this?","commit_id":"55b8852fd27109593978d86ecdadbc8cbeef7299"}],"neutron/conf/services/extdns_designate_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d2554165b284e84071ddbe5932ed49f205a9083b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.StrOpt(\u0027admin_auth_url\u0027,"},{"line_number":38,"context_line":"               help\u003d_(\u0027Authorization URL for connecting to designate in admin \u0027"},{"line_number":39,"context_line":"                      \u0027context\u0027)),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027, default\u003d\u0027publicURL\u0027,"},{"line_number":41,"context_line":"               help\u003d_(\u0027Endpoint type for connecting to designate in context\u0027)),"},{"line_number":42,"context_line":"    cfg.BoolOpt(\u0027allow_reverse_dns_lookup\u0027, default\u003dTrue,"},{"line_number":43,"context_line":"                help\u003d_(\u0027Allow the creation of PTR records\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4ed177cc","line":40,"updated":"2018-09-22 14:10:08.000000000","message":"please add a release note for the new variable","commit_id":"92c3c0ff6c44f7a33d09d1a6cb2f1f6bf520714d"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"8ebb8ca008b44cee16ca4a9d568823f3866d242e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.StrOpt(\u0027admin_auth_url\u0027,"},{"line_number":38,"context_line":"               help\u003d_(\u0027Authorization URL for connecting to designate in admin \u0027"},{"line_number":39,"context_line":"                      \u0027context\u0027)),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027, default\u003d\u0027publicURL\u0027,"},{"line_number":41,"context_line":"               help\u003d_(\u0027Endpoint type for connecting to designate in context\u0027)),"},{"line_number":42,"context_line":"    cfg.BoolOpt(\u0027allow_reverse_dns_lookup\u0027, default\u003dTrue,"},{"line_number":43,"context_line":"                help\u003d_(\u0027Allow the creation of PTR records\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_befdd6b3","line":40,"in_reply_to":"3f79a3b5_4ed177cc","updated":"2018-09-24 14:39:27.000000000","message":"Done","commit_id":"92c3c0ff6c44f7a33d09d1a6cb2f1f6bf520714d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"24085e645975bb006ca90b11de379772673eb6f2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.StrOpt(\u0027admin_auth_url\u0027,"},{"line_number":38,"context_line":"               help\u003d_(\u0027Authorization URL for connecting to designate in admin \u0027"},{"line_number":39,"context_line":"                      \u0027context\u0027)),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027, default\u003d\u0027publicURL\u0027,"},{"line_number":41,"context_line":"               help\u003d_(\u0027Endpoint type for connecting to designate in context\u0027)),"},{"line_number":42,"context_line":"    cfg.BoolOpt(\u0027allow_reverse_dns_lookup\u0027, default\u003dTrue,"},{"line_number":43,"context_line":"                help\u003d_(\u0027Allow the creation of PTR records\u0027)),"},{"line_number":44,"context_line":"    cfg.IntOpt(\u0027ipv4_ptr_zone_prefix_size\u0027, default\u003d24,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_7b6d0102","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":79},"updated":"2018-09-24 14:11:57.000000000","message":"Try to add option like this:\nhttps://github.com/openstack/neutron/blob/master/neutron/conf/common.py#L156-L161","commit_id":"2ed4fe8f6c50f624276d2d21e28970d8c25950d9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"09d52572bb8399197f5067525ea05ca39faea08c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":42,"context_line":"               choices\u003d[\u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":43,"context_line":"               help\u003d_(\u0027Endpoint type for connecting to designate in context\u0027)),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027allow_reverse_dns_lookup\u0027, default\u003dTrue,"},{"line_number":45,"context_line":"                help\u003d_(\u0027Allow the creation of PTR records\u0027)),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027ipv4_ptr_zone_prefix_size\u0027, default\u003d24,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_61f6a860","line":43,"range":{"start_line":43,"start_character":65,"end_line":43,"end_character":75},"updated":"2018-09-25 00:02:41.000000000","message":"This is confusing. Please eliminate","commit_id":"55b8852fd27109593978d86ecdadbc8cbeef7299"}],"releasenotes/notes/fix-endpoint-type-configuration-for-designate-9630e42df8a3b9ec.yaml":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"09d52572bb8399197f5067525ea05ca39faea08c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add config option endpoint_type for designate, designate client can use"},{"line_number":5,"context_line":"    publicURL, adminURL or internalURL as the endpoint type, which can be"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_a1aa8017","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2018-09-25 00:02:41.000000000","message":"We are not fixing a bug. If we do this, we will add a feature","commit_id":"55b8852fd27109593978d86ecdadbc8cbeef7299"}]}