)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dff2f903d1a1b91bbba25f0451841ebe8f5044dd","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            return []"},{"line_number":632,"context_line":"        for router in routers:"},{"line_number":633,"context_line":"            gw_port_host \u003d self._get_gateway_port_host("},{"line_number":634,"context_line":"                context, router, gw_ports)"},{"line_number":635,"context_line":"            LOG.info(\"Set router %s gateway port host: %s\","},{"line_number":636,"context_line":"                     router[\u0027id\u0027], gw_port_host)"},{"line_number":637,"context_line":"            router[\u0027gw_port_host\u0027] \u003d gw_port_host"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b32f2bf4","line":634,"updated":"2018-10-07 09:45:24.000000000","message":"if gw_port_host will be None, should You add it to router dict?","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"80f7273af8d5c1b27e3c28536feccee0e5d324a5","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            return []"},{"line_number":632,"context_line":"        for router in routers:"},{"line_number":633,"context_line":"            gw_port_host \u003d self._get_gateway_port_host("},{"line_number":634,"context_line":"                context, router, gw_ports)"},{"line_number":635,"context_line":"            LOG.info(\"Set router %s gateway port host: %s\","},{"line_number":636,"context_line":"                     router[\u0027id\u0027], gw_port_host)"},{"line_number":637,"context_line":"            router[\u0027gw_port_host\u0027] \u003d gw_port_host"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_04c7b713","line":634,"in_reply_to":"3f79a3b5_b32f2bf4","updated":"2018-10-08 01:13:06.000000000","message":"It will, I just keep the original behavior here, see line 629 left section.","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a5ecb9aea924b6160318702438c5ab71a97a9dc0","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        for router in routers:"},{"line_number":633,"context_line":"            gw_port_host \u003d self._get_gateway_port_host("},{"line_number":634,"context_line":"                context, router, gw_ports)"},{"line_number":635,"context_line":"            LOG.info(\"Set router %s gateway port host: %s\","},{"line_number":636,"context_line":"                     router[\u0027id\u0027], gw_port_host)"},{"line_number":637,"context_line":"            router[\u0027gw_port_host\u0027] \u003d gw_port_host"},{"line_number":638,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c0cbba70","line":635,"range":{"start_line":635,"start_character":16,"end_line":635,"end_character":20},"updated":"2018-10-09 20:35:12.000000000","message":"We never logged anything when the gateway port host was valid, only when it was None, so this should be at debug level to match the old behavior.","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"81cd825cfb18b49ff56da0be4b1abdec9c192f1d","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        for router in routers:"},{"line_number":633,"context_line":"            gw_port_host \u003d self._get_gateway_port_host("},{"line_number":634,"context_line":"                context, router, gw_ports)"},{"line_number":635,"context_line":"            LOG.info(\"Set router %s gateway port host: %s\","},{"line_number":636,"context_line":"                     router[\u0027id\u0027], gw_port_host)"},{"line_number":637,"context_line":"            router[\u0027gw_port_host\u0027] \u003d gw_port_host"},{"line_number":638,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6f9ad1c4","line":635,"range":{"start_line":635,"start_character":16,"end_line":635,"end_character":20},"in_reply_to":"3f79a3b5_c0cbba70","updated":"2018-10-10 01:31:01.000000000","message":"Done","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"aee35abfa14327f636df231e63cbe3846d16fb24","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        if not routers:"},{"line_number":630,"context_line":"            return []"},{"line_number":631,"context_line":"        for router in routers:"},{"line_number":632,"context_line":"            gw_port_host \u003d self._get_gateway_port_host("},{"line_number":633,"context_line":"                context, router, gw_ports)"},{"line_number":634,"context_line":"            LOG.debug(\"Set router %s gateway port host: %s\","},{"line_number":635,"context_line":"                      router[\u0027id\u0027], gw_port_host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_73caf347","line":632,"range":{"start_line":632,"start_character":27,"end_line":632,"end_character":55},"updated":"2018-10-18 17:20:07.000000000","message":"Is this refactor a requirement for this bug fix?\nOk I understand it is because you wanted to change its behavior if it is a HA router.","commit_id":"65535f23cb56be1cf93db9933f90e0eda2f1f938"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b0c715684d442b18b277cd845072eee92eb08618","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        if not routers:"},{"line_number":630,"context_line":"            return []"},{"line_number":631,"context_line":"        for router in routers:"},{"line_number":632,"context_line":"            gw_port_host \u003d self._get_gateway_port_host("},{"line_number":633,"context_line":"                context, router, gw_ports)"},{"line_number":634,"context_line":"            LOG.debug(\"Set router %s gateway port host: %s\","},{"line_number":635,"context_line":"                      router[\u0027id\u0027], gw_port_host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a446fca6","line":632,"range":{"start_line":632,"start_character":27,"end_line":632,"end_character":55},"in_reply_to":"3f79a3b5_73caf347","updated":"2018-10-19 04:16:51.000000000","message":"Correct, : )","commit_id":"65535f23cb56be1cf93db9933f90e0eda2f1f938"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd85529b9de523fceef619275cabd1848ab3d273","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":727,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":728,"context_line":"        ha_bindings \u003d self.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":729,"context_line":"            context, router_id)"},{"line_number":730,"context_line":"        device_filter \u003d {\u0027device_id\u0027: [router_id],"},{"line_number":731,"context_line":"                         \u0027device_owner\u0027:"},{"line_number":732,"context_line":"                         [constants.DEVICE_OWNER_ROUTER_GW]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_82ba3b08","line":729,"updated":"2018-10-02 18:40:52.000000000","message":"ha_bindings is possibly not used if we return early on L735, so this call should be right before L744.","commit_id":"00c4695e851a36738ace65789815c20ec8167667"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd85529b9de523fceef619275cabd1848ab3d273","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        device_filter \u003d {\u0027device_id\u0027: [router_id],"},{"line_number":731,"context_line":"                         \u0027device_owner\u0027:"},{"line_number":732,"context_line":"                         [constants.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":733,"context_line":"        ports \u003d self._core_plugin.get_ports(admin_ctx, filters\u003ddevice_filter)"},{"line_number":734,"context_line":"        if not ports:"},{"line_number":735,"context_line":"            return"},{"line_number":736,"context_line":"        gateway_port_status \u003d ports[0][\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_425f43e4","line":733,"updated":"2018-10-02 18:40:52.000000000","message":"Isn\u0027t this going to get the same gateway ports that were passed-in in gw_ports?","commit_id":"00c4695e851a36738ace65789815c20ec8167667"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"9209648e6321288b8afd639a2f0552306053ebd4","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        device_filter \u003d {\u0027device_id\u0027: [router_id],"},{"line_number":731,"context_line":"                         \u0027device_owner\u0027:"},{"line_number":732,"context_line":"                         [constants.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":733,"context_line":"        ports \u003d self._core_plugin.get_ports(admin_ctx, filters\u003ddevice_filter)"},{"line_number":734,"context_line":"        if not ports:"},{"line_number":735,"context_line":"            return"},{"line_number":736,"context_line":"        gateway_port_status \u003d ports[0][\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_18177348","line":733,"in_reply_to":"3f79a3b5_425f43e4","updated":"2018-10-03 02:56:13.000000000","message":"Sounds reasonable, my original thoughs is check the current port status of DB since it will be updated by l2 agent via ml2 plugin.","commit_id":"00c4695e851a36738ace65789815c20ec8167667"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b8e1e2d05da2a58bbb2771925d4a271448a20dbc","unresolved":false,"context_lines":[{"line_number":744,"context_line":"            # For create router gateway, the gateway port may not ACTIVE yet,"},{"line_number":745,"context_line":"            # we return the \u0027master\u0027 host directly."},{"line_number":746,"context_line":"            if (gateway_port_status !\u003d constants.PORT_STATUS_ACTIVE and"},{"line_number":747,"context_line":"                    ha_binding_state \u003d\u003d n_const.HA_ROUTER_STATE_ACTIVE):"},{"line_number":748,"context_line":"                return ha_binding_agent.host"},{"line_number":749,"context_line":"            # Do not let the original \u0027master\u0027 (current is backup) host,"},{"line_number":750,"context_line":"            # override the gateway port binding host."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_34932551","line":747,"range":{"start_line":747,"start_character":20,"end_line":747,"end_character":70},"updated":"2018-10-05 00:14:31.000000000","message":"Since you check this here and L753, it might be better to have it on it\u0027s own above this (check is negative to continue loop):\n\nif ha_binding_state !\u003d n_const.HA_ROUTER_STATE_ACTIVE:\n    continue","commit_id":"a31b3e4bfe9fb9960c995068cc2b052f8f5920d6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dff2f903d1a1b91bbba25f0451841ebe8f5044dd","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":732,"context_line":"        ha_bindings \u003d self.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":733,"context_line":"            admin_ctx, router_id)"},{"line_number":734,"context_line":"        LOG.info(\"Ha router %(router_id)s gateway port %(gw_port_id)s \""},{"line_number":735,"context_line":"                 \"binding host: %(host)s, status: %(status)s\","},{"line_number":736,"context_line":"                 {\"router_id\": router_id,"},{"line_number":737,"context_line":"                  \"gw_port_id\": gateway_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d334274c","line":734,"updated":"2018-10-07 09:45:24.000000000","message":"maybe debug would be better here?","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a5ecb9aea924b6160318702438c5ab71a97a9dc0","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":732,"context_line":"        ha_bindings \u003d self.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":733,"context_line":"            admin_ctx, router_id)"},{"line_number":734,"context_line":"        LOG.info(\"Ha router %(router_id)s gateway port %(gw_port_id)s \""},{"line_number":735,"context_line":"                 \"binding host: %(host)s, status: %(status)s\","},{"line_number":736,"context_line":"                 {\"router_id\": router_id,"},{"line_number":737,"context_line":"                  \"gw_port_id\": gateway_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_809aa26c","line":734,"range":{"start_line":734,"start_character":18,"end_line":734,"end_character":20},"updated":"2018-10-09 20:35:12.000000000","message":"s/HA\n\nI also don\u0027t think this should be \u0027info\u0027 level as the parent class doesn\u0027t log anything at all, and the caller is going to duplicate half of this information - router id and host.","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"81cd825cfb18b49ff56da0be4b1abdec9c192f1d","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":732,"context_line":"        ha_bindings \u003d self.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":733,"context_line":"            admin_ctx, router_id)"},{"line_number":734,"context_line":"        LOG.info(\"Ha router %(router_id)s gateway port %(gw_port_id)s \""},{"line_number":735,"context_line":"                 \"binding host: %(host)s, status: %(status)s\","},{"line_number":736,"context_line":"                 {\"router_id\": router_id,"},{"line_number":737,"context_line":"                  \"gw_port_id\": gateway_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0fa1ddf7","line":734,"range":{"start_line":734,"start_character":18,"end_line":734,"end_character":20},"in_reply_to":"3f79a3b5_809aa26c","updated":"2018-10-10 01:31:01.000000000","message":"Done","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"80f7273af8d5c1b27e3c28536feccee0e5d324a5","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":732,"context_line":"        ha_bindings \u003d self.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":733,"context_line":"            admin_ctx, router_id)"},{"line_number":734,"context_line":"        LOG.info(\"Ha router %(router_id)s gateway port %(gw_port_id)s \""},{"line_number":735,"context_line":"                 \"binding host: %(host)s, status: %(status)s\","},{"line_number":736,"context_line":"                 {\"router_id\": router_id,"},{"line_number":737,"context_line":"                  \"gw_port_id\": gateway_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_44dccfe0","line":734,"in_reply_to":"3f79a3b5_d334274c","updated":"2018-10-08 01:13:06.000000000","message":"IMO, this is an essential information for operator to locate the router gateway, or for developer to trace the code path.","commit_id":"a90a8b74ad453d80a84ff5cf06c9631b6b05d034"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"aee35abfa14327f636df231e63cbe3846d16fb24","unresolved":false,"context_lines":[{"line_number":740,"context_line":"        for ha_binding_agent, ha_binding_state in ha_bindings:"},{"line_number":741,"context_line":"            if ha_binding_state !\u003d n_const.HA_ROUTER_STATE_ACTIVE:"},{"line_number":742,"context_line":"                continue"},{"line_number":743,"context_line":"            # For create router gateway, the gateway port may not ACTIVE yet,"},{"line_number":744,"context_line":"            # we return the \u0027master\u0027 host directly."},{"line_number":745,"context_line":"            if gateway_port_status !\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":746,"context_line":"                return ha_binding_agent.host"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_533fb721","line":743,"range":{"start_line":743,"start_character":58,"end_line":743,"end_character":76},"updated":"2018-10-18 17:20:07.000000000","message":"may not be ACTIVE yet,","commit_id":"65535f23cb56be1cf93db9933f90e0eda2f1f938"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b0c715684d442b18b277cd845072eee92eb08618","unresolved":false,"context_lines":[{"line_number":740,"context_line":"        for ha_binding_agent, ha_binding_state in ha_bindings:"},{"line_number":741,"context_line":"            if ha_binding_state !\u003d n_const.HA_ROUTER_STATE_ACTIVE:"},{"line_number":742,"context_line":"                continue"},{"line_number":743,"context_line":"            # For create router gateway, the gateway port may not ACTIVE yet,"},{"line_number":744,"context_line":"            # we return the \u0027master\u0027 host directly."},{"line_number":745,"context_line":"            if gateway_port_status !\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":746,"context_line":"                return ha_binding_agent.host"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_c4d458bf","line":743,"range":{"start_line":743,"start_character":58,"end_line":743,"end_character":76},"in_reply_to":"3f79a3b5_533fb721","updated":"2018-10-19 04:16:51.000000000","message":"Done","commit_id":"65535f23cb56be1cf93db9933f90e0eda2f1f938"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"aee35abfa14327f636df231e63cbe3846d16fb24","unresolved":false,"context_lines":[{"line_number":741,"context_line":"            if ha_binding_state !\u003d n_const.HA_ROUTER_STATE_ACTIVE:"},{"line_number":742,"context_line":"                continue"},{"line_number":743,"context_line":"            # For create router gateway, the gateway port may not ACTIVE yet,"},{"line_number":744,"context_line":"            # we return the \u0027master\u0027 host directly."},{"line_number":745,"context_line":"            if gateway_port_status !\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":746,"context_line":"                return ha_binding_agent.host"},{"line_number":747,"context_line":"            # Do not let the original \u0027master\u0027 (current is backup) host,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_732193fd","line":744,"range":{"start_line":744,"start_character":14,"end_line":744,"end_character":28},"updated":"2018-10-18 17:20:07.000000000","message":"so we return","commit_id":"65535f23cb56be1cf93db9933f90e0eda2f1f938"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b0c715684d442b18b277cd845072eee92eb08618","unresolved":false,"context_lines":[{"line_number":741,"context_line":"            if ha_binding_state !\u003d n_const.HA_ROUTER_STATE_ACTIVE:"},{"line_number":742,"context_line":"                continue"},{"line_number":743,"context_line":"            # For create router gateway, the gateway port may not ACTIVE yet,"},{"line_number":744,"context_line":"            # we return the \u0027master\u0027 host directly."},{"line_number":745,"context_line":"            if gateway_port_status !\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":746,"context_line":"                return ha_binding_agent.host"},{"line_number":747,"context_line":"            # Do not let the original \u0027master\u0027 (current is backup) host,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e4d154cc","line":744,"range":{"start_line":744,"start_character":14,"end_line":744,"end_character":28},"in_reply_to":"3f79a3b5_732193fd","updated":"2018-10-19 04:16:51.000000000","message":"Done","commit_id":"65535f23cb56be1cf93db9933f90e0eda2f1f938"}]}
