)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f70128d211c5e6810a9e91219714a6623495d094","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yong Sheng Gong \u003cgongysh@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-09 16:48:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"valide if the router has external gateway interface set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the router wants to be work with vpn service, we must"},{"line_number":10,"context_line":"make sure external gateway interface is set."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9pxs%3D","line":7,"updated":"2013-12-09 09:12:56.000000000","message":"nit: Validate","commit_id":"db19964fd8ee1f50216c9631fda85d88bc071186"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dcdc1b252cd283f628f0aaa0119e197fe3693d6e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yong Sheng Gong \u003cgongysh@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-09 16:48:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"valide if the router has external gateway interface set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the router wants to be work with vpn service, we must"},{"line_number":10,"context_line":"make sure external gateway interface is set."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9l8A%3D","line":7,"in_reply_to":"AAAATn%2F9pxs%3D","updated":"2013-12-09 21:24:42.000000000","message":"Done","commit_id":"db19964fd8ee1f50216c9631fda85d88bc071186"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f70128d211c5e6810a9e91219714a6623495d094","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"valide if the router has external gateway interface set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the router wants to be work with vpn service, we must"},{"line_number":10,"context_line":"make sure external gateway interface is set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch cannot prevent user to clear the gateway interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9pxo%3D","line":9,"updated":"2013-12-09 09:12:56.000000000","message":"nit: wants to work","commit_id":"db19964fd8ee1f50216c9631fda85d88bc071186"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dcdc1b252cd283f628f0aaa0119e197fe3693d6e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"valide if the router has external gateway interface set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the router wants to be work with vpn service, we must"},{"line_number":10,"context_line":"make sure external gateway interface is set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch cannot prevent user to clear the gateway interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9l78%3D","line":9,"in_reply_to":"AAAATn%2F9pxo%3D","updated":"2013-12-09 21:24:42.000000000","message":"Done","commit_id":"db19964fd8ee1f50216c9631fda85d88bc071186"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9e11ff64ffaec0d084c4180bb3554b612d4fd34a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the router wants to be work with vpn service, we must"},{"line_number":10,"context_line":"make sure external gateway interface is set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch cannot prevent user to clear the gateway interface"},{"line_number":13,"context_line":"of the router after the vpnservice is created."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If0f00def949b31c1e3da7a2cd055454567201e4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9o%2F8%3D","line":12,"updated":"2013-12-09 12:33:53.000000000","message":"user from clearing","commit_id":"db19964fd8ee1f50216c9631fda85d88bc071186"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dcdc1b252cd283f628f0aaa0119e197fe3693d6e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the router wants to be work with vpn service, we must"},{"line_number":10,"context_line":"make sure external gateway interface is set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch cannot prevent user to clear the gateway interface"},{"line_number":13,"context_line":"of the router after the vpnservice is created."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If0f00def949b31c1e3da7a2cd055454567201e4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9l74%3D","line":12,"in_reply_to":"AAAATn%2F9o%2F8%3D","updated":"2013-12-09 21:24:42.000000000","message":"Done","commit_id":"db19964fd8ee1f50216c9631fda85d88bc071186"}],"neutron/db/vpn/vpn_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1630d1cf8c2255af4a09bbba3e482e44195d9191","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            constants.L3_ROUTER_NAT)"},{"line_number":545,"context_line":"        router \u003d l3_plugin.get_router(context, router_id)"},{"line_number":546,"context_line":"        if not router.get(l3_db.EXTERNAL_GW_INFO):"},{"line_number":547,"context_line":"            raise vpnaas.RouterIsNotExternal(router_id\u003drouter_id)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _check_subnet_id(self, context, router_id, subnet_id):"},{"line_number":550,"context_line":"        core_plugin \u003d manager.NeutronManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FxWo%3D","line":547,"updated":"2014-01-01 19:50:24.000000000","message":"just a question - is it also necessary that snat should be enabled?\nIn that case one should also check whether snat is disabled on the external gateway","commit_id":"3e263ba6c58c43f71c02417f8948300e8cb5c462"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"31733cd9abcbbf08304b296ea36c55a3379c1280","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            constants.L3_ROUTER_NAT)"},{"line_number":545,"context_line":"        router \u003d l3_plugin.get_router(context, router_id)"},{"line_number":546,"context_line":"        if not router.get(l3_db.EXTERNAL_GW_INFO):"},{"line_number":547,"context_line":"            raise vpnaas.RouterIsNotExternal(router_id\u003drouter_id)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _check_subnet_id(self, context, router_id, subnet_id):"},{"line_number":550,"context_line":"        core_plugin \u003d manager.NeutronManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F2Os%3D","line":547,"in_reply_to":"AAAAT3%2F%2FxWo%3D","updated":"2014-01-07 18:29:52.000000000","message":"snat isn\u0027t needed for VPN. VPN handles by their iptables rule","commit_id":"3e263ba6c58c43f71c02417f8948300e8cb5c462"}]}