)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"86ca2e5e804b24f467ec26d7f24aea804c47534b","unresolved":false,"context_lines":[{"line_number":1895,"context_line":"        new_port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":1896,"context_line":"        original_port \u003d kwargs.get(\u0027original_port\u0027)"},{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        is_fixed_ips_changed \u003d utils.port_ip_changed(new_port, original_port)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        if (original_port[\u0027device_owner\u0027] in"},{"line_number":1901,"context_line":"                [constants.DEVICE_OWNER_ROUTER_SNAT,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8a43d1b0","line":1898,"range":{"start_line":1898,"start_character":37,"end_line":1898,"end_character":52},"updated":"2018-10-08 03:16:48.000000000","message":"Is there a \u0027port_ip_changed\u0027 method in that module? How about use like this:\nis_fixed_ips_changed \u003d (\n    \u0027fixed_ips\u0027 in new_port and\n    \u0027fixed_ips\u0027 in original_port and\n    new_port[\u0027fixed_ips\u0027] !\u003d original_port[\u0027fixed_ips\u0027])","commit_id":"0d011fd3cfca662797a338b481bf773fda1f9c8d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"33d4b6913c6a803b88498cad389580a297b026d2","unresolved":false,"context_lines":[{"line_number":1895,"context_line":"        new_port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":1896,"context_line":"        original_port \u003d kwargs.get(\u0027original_port\u0027)"},{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        is_fixed_ips_changed \u003d utils.port_ip_changed(new_port, original_port)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        if (original_port[\u0027device_owner\u0027] in"},{"line_number":1901,"context_line":"                [constants.DEVICE_OWNER_ROUTER_SNAT,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_71c0a12c","line":1898,"range":{"start_line":1898,"start_character":37,"end_line":1898,"end_character":52},"in_reply_to":"3f79a3b5_73050cc1","updated":"2018-10-08 10:45:28.000000000","message":"Got it, thanks.","commit_id":"0d011fd3cfca662797a338b481bf773fda1f9c8d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5f0e6274818f742aa73881d3b113413d456708e9","unresolved":false,"context_lines":[{"line_number":1895,"context_line":"        new_port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":1896,"context_line":"        original_port \u003d kwargs.get(\u0027original_port\u0027)"},{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        is_fixed_ips_changed \u003d utils.port_ip_changed(new_port, original_port)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        if (original_port[\u0027device_owner\u0027] in"},{"line_number":1901,"context_line":"                [constants.DEVICE_OWNER_ROUTER_SNAT,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_73050cc1","line":1898,"range":{"start_line":1898,"start_character":37,"end_line":1898,"end_character":52},"in_reply_to":"3f79a3b5_8a43d1b0","updated":"2018-10-08 06:41:02.000000000","message":"Please see the parent patch:\nhttps://review.openstack.org/#/c/606385/","commit_id":"0d011fd3cfca662797a338b481bf773fda1f9c8d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"2e424d4808c903c68c5732582357cf2cabe1f9e7","unresolved":false,"context_lines":[{"line_number":1898,"context_line":"        is_fixed_ips_changed \u003d utils.port_ip_changed(new_port, original_port)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        if (original_port[\u0027device_owner\u0027] in"},{"line_number":1901,"context_line":"                [constants.DEVICE_OWNER_ROUTER_SNAT,"},{"line_number":1902,"context_line":"                 constants.DEVICE_OWNER_ROUTER_GW] and is_fixed_ips_changed):"},{"line_number":1903,"context_line":"            l3plugin.notify_router_updated(kwargs[\u0027context\u0027],"},{"line_number":1904,"context_line":"                                           new_port[\u0027device_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_52ff9134","line":1901,"range":{"start_line":1901,"start_character":17,"end_line":1901,"end_character":51},"updated":"2018-10-09 06:54:09.000000000","message":"Why here include csnat port?","commit_id":"5899a9dae58f769ec4995168a4e7fdd467b02223"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"79202f070b470489cb9f0d1316b55c89bd54a243","unresolved":false,"context_lines":[{"line_number":1898,"context_line":"        is_fixed_ips_changed \u003d utils.port_ip_changed(new_port, original_port)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        if (original_port[\u0027device_owner\u0027] in"},{"line_number":1901,"context_line":"                [constants.DEVICE_OWNER_ROUTER_SNAT,"},{"line_number":1902,"context_line":"                 constants.DEVICE_OWNER_ROUTER_GW] and is_fixed_ips_changed):"},{"line_number":1903,"context_line":"            l3plugin.notify_router_updated(kwargs[\u0027context\u0027],"},{"line_number":1904,"context_line":"                                           new_port[\u0027device_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_889adc10","line":1901,"range":{"start_line":1901,"start_character":17,"end_line":1901,"end_character":51},"in_reply_to":"3f79a3b5_52ff9134","updated":"2018-10-09 08:49:19.000000000","message":"Good question, I think we just find two problems, one is L3 snat port, and another is L2 port IP update limitation.\n\nFor the l2 port update, I\u0027ve reported a new bug for this:\nhttps://bugs.launchpad.net/neutron/+bug/1796824\n\nFor L3, IMO, it will make the l3 agent side dvr code more complicated, so I will remove this next patch.","commit_id":"5899a9dae58f769ec4995168a4e7fdd467b02223"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f3879a1ba1829bd45dff60f4788515a982a8aad9","unresolved":false,"context_lines":[{"line_number":1898,"context_line":"        is_fixed_ips_changed \u003d utils.port_ip_changed(new_port, original_port)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        gw_device_owner \u003d constants.DEVICE_OWNER_ROUTER_GW"},{"line_number":1901,"context_line":"        if (original_port[\u0027device_owner\u0027] \u003d\u003d gw_device_owner and"},{"line_number":1902,"context_line":"                is_fixed_ips_changed):"},{"line_number":1903,"context_line":"            l3plugin.notify_router_updated(kwargs[\u0027context\u0027],"},{"line_number":1904,"context_line":"                                           new_port[\u0027device_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f3918746","line":1901,"updated":"2018-10-26 08:26:07.000000000","message":"nit: I think that more efficient could be if You first check if port\u0027s device_owner is \"gateway\" and if not, then return. Only if it\u0027s gateway, You should check if ips were changed","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"783d7a7f9cc2cda07229e0f6c0e6addbf518478e","unresolved":false,"context_lines":[{"line_number":1898,"context_line":"        is_fixed_ips_changed \u003d utils.port_ip_changed(new_port, original_port)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        gw_device_owner \u003d constants.DEVICE_OWNER_ROUTER_GW"},{"line_number":1901,"context_line":"        if (original_port[\u0027device_owner\u0027] \u003d\u003d gw_device_owner and"},{"line_number":1902,"context_line":"                is_fixed_ips_changed):"},{"line_number":1903,"context_line":"            l3plugin.notify_router_updated(kwargs[\u0027context\u0027],"},{"line_number":1904,"context_line":"                                           new_port[\u0027device_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_c1c60716","line":1901,"in_reply_to":"3f79a3b5_f3918746","updated":"2018-11-08 02:50:26.000000000","message":"Let\u0027s fix this and get this merged","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"}],"neutron/tests/fullstack/resources/client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c2c3815f9c55db57c37fd897bf0e3fec2a897c94","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def list_ports(self, retrieve_all\u003dTrue, **kwargs):"},{"line_number":66,"context_line":"        resp \u003d self.client.list_ports(retrieve_all\u003dretrieve_all, **kwargs)"},{"line_number":67,"context_line":"        return resp[\u0027ports\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def create_router(self, tenant_id, name\u003dNone, ha\u003dFalse,"},{"line_number":70,"context_line":"                      external_network\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2d777e3d","line":67,"updated":"2018-10-03 19:44:09.000000000","message":"Nit: should be down with the other *port calls, like after L141","commit_id":"326dd19acb89c114326f86028d1bdc5d5c98153f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ac37056c725c0df0b86a4cb561098f47de1317a1","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def list_ports(self, retrieve_all\u003dTrue, **kwargs):"},{"line_number":66,"context_line":"        resp \u003d self.client.list_ports(retrieve_all\u003dretrieve_all, **kwargs)"},{"line_number":67,"context_line":"        return resp[\u0027ports\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def create_router(self, tenant_id, name\u003dNone, ha\u003dFalse,"},{"line_number":70,"context_line":"                      external_network\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_caf309e8","line":67,"in_reply_to":"3f79a3b5_2d777e3d","updated":"2018-10-08 02:25:40.000000000","message":"Done","commit_id":"326dd19acb89c114326f86028d1bdc5d5c98153f"}],"neutron/tests/fullstack/test_l3_agent.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"83f51dc09007c986b8095e7da6ae4f50fc2fb52a","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # ping router gateway new IPs"},{"line_number":123,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":124,"context_line":"        external_vm.block_until_ping(ip_2)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class TestLegacyL3Agent(TestL3Agent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9e56135e","line":124,"updated":"2018-10-02 21:34:31.000000000","message":"Is there a way to enter the router namespace and assert the  device IP address? If this is infeasible, I will remove my -1.","commit_id":"bda4db0f06468f8a9306e9f051ea450021ce0fa2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"daf75d97d178a5acaea2d83b87cdbab5cbfde213","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # ping router gateway new IPs"},{"line_number":123,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":124,"context_line":"        external_vm.block_until_ping(ip_2)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class TestLegacyL3Agent(TestL3Agent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d229daf1","line":124,"in_reply_to":"3f79a3b5_9e56135e","updated":"2018-10-03 00:57:35.000000000","message":"It now can ping, so it is indeed in the namespace. I have tested this locally, without the fix, here will not be pingable.","commit_id":"bda4db0f06468f8a9306e9f051ea450021ce0fa2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4424751f04062f709a7d9722018e717fcc8eb7bd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        gateway_port_id \u003d None"},{"line_number":108,"context_line":"        for port in self.safe_client.list_ports(device_id\u003drouter[\u0027id\u0027]):"},{"line_number":109,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW:"},{"line_number":110,"context_line":"                gateway_port_id \u003d port[\u0027id\u0027]"},{"line_number":111,"context_line":"        self.assertIsNotNone(gateway_port_id)"},{"line_number":112,"context_line":"        ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":113,"context_line":"            ext_sub[\u0027gateway_ip\u0027]).next(100)).split(\u0027/\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6a96c696","line":110,"updated":"2018-10-03 14:13:08.000000000","message":"You can break loop here","commit_id":"326dd19acb89c114326f86028d1bdc5d5c98153f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c2c3815f9c55db57c37fd897bf0e3fec2a897c94","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        gateway_port_id \u003d None"},{"line_number":108,"context_line":"        for port in self.safe_client.list_ports(device_id\u003drouter[\u0027id\u0027]):"},{"line_number":109,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW:"},{"line_number":110,"context_line":"                gateway_port_id \u003d port[\u0027id\u0027]"},{"line_number":111,"context_line":"        self.assertIsNotNone(gateway_port_id)"},{"line_number":112,"context_line":"        ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":113,"context_line":"            ext_sub[\u0027gateway_ip\u0027]).next(100)).split(\u0027/\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6de496df","line":110,"in_reply_to":"3f79a3b5_194f6b8c","updated":"2018-10-03 19:44:09.000000000","message":"You can also specify a device_owner, in which case list_ports should just return one port, then use port[0]","commit_id":"326dd19acb89c114326f86028d1bdc5d5c98153f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"02fd27ff49a33f1c2604a91b6fa732df2cf6af84","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        gateway_port_id \u003d None"},{"line_number":108,"context_line":"        for port in self.safe_client.list_ports(device_id\u003drouter[\u0027id\u0027]):"},{"line_number":109,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW:"},{"line_number":110,"context_line":"                gateway_port_id \u003d port[\u0027id\u0027]"},{"line_number":111,"context_line":"        self.assertIsNotNone(gateway_port_id)"},{"line_number":112,"context_line":"        ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":113,"context_line":"            ext_sub[\u0027gateway_ip\u0027]).next(100)).split(\u0027/\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_194f6b8c","line":110,"in_reply_to":"3f79a3b5_6a96c696","updated":"2018-10-03 15:24:14.000000000","message":"It should be only one port, and it\u0027s just a test case.","commit_id":"326dd19acb89c114326f86028d1bdc5d5c98153f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ac37056c725c0df0b86a4cb561098f47de1317a1","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        gateway_port_id \u003d None"},{"line_number":108,"context_line":"        for port in self.safe_client.list_ports(device_id\u003drouter[\u0027id\u0027]):"},{"line_number":109,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW:"},{"line_number":110,"context_line":"                gateway_port_id \u003d port[\u0027id\u0027]"},{"line_number":111,"context_line":"        self.assertIsNotNone(gateway_port_id)"},{"line_number":112,"context_line":"        ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":113,"context_line":"            ext_sub[\u0027gateway_ip\u0027]).next(100)).split(\u0027/\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_eaf045dd","line":110,"in_reply_to":"3f79a3b5_6de496df","updated":"2018-10-08 02:25:40.000000000","message":"Done","commit_id":"326dd19acb89c114326f86028d1bdc5d5c98153f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f3879a1ba1829bd45dff60f4788515a982a8aad9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            {\u0027ip_address\u0027: ip_2}])"},{"line_number":117,"context_line":"        # ping router gateway new IPs"},{"line_number":118,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":119,"context_line":"        external_vm.block_until_ping(ip_2)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class TestLegacyL3Agent(TestL3Agent):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f3df4708","line":119,"updated":"2018-10-26 08:26:07.000000000","message":"nit: You can also check that old_gw_ip is not pinging anymore","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"783d7a7f9cc2cda07229e0f6c0e6addbf518478e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            {\u0027ip_address\u0027: ip_2}])"},{"line_number":117,"context_line":"        # ping router gateway new IPs"},{"line_number":118,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":119,"context_line":"        external_vm.block_until_ping(ip_2)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class TestLegacyL3Agent(TestL3Agent):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_81cc8f33","line":119,"in_reply_to":"3f79a3b5_f3df4708","updated":"2018-11-08 02:50:26.000000000","message":"This too","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd59dc63558d073a4f069ed2a75ed857c58091b9","unresolved":false,"context_lines":[{"line_number":3438,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_owner\u0027])"},{"line_number":3439,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_id\u0027])"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"    def test__notify_gateway_port_ip_changed(self):"},{"line_number":3442,"context_line":"        \"\"\"Test to make sure notification to routers occurs when the gateway"},{"line_number":3443,"context_line":"            ip address changed."},{"line_number":3444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_cfaa05d2","line":3441,"range":{"start_line":3441,"start_character":3,"end_line":3441,"end_character":50},"updated":"2018-10-10 01:32:40.000000000","message":"may also want to add test case when fixed ip aren\u0027t updated and want to make sure chk_method.callcount is 1 ?","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6c3a0046858aeb269ffae113e6e410ddc8f924a5","unresolved":false,"context_lines":[{"line_number":3438,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_owner\u0027])"},{"line_number":3439,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_id\u0027])"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"    def test__notify_gateway_port_ip_changed(self):"},{"line_number":3442,"context_line":"        \"\"\"Test to make sure notification to routers occurs when the gateway"},{"line_number":3443,"context_line":"            ip address changed."},{"line_number":3444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_c1d118cc","line":3441,"range":{"start_line":3441,"start_character":3,"end_line":3441,"end_character":50},"in_reply_to":"3f79a3b5_a1c18bff","updated":"2018-11-08 15:46:40.000000000","message":"I\u0027ll do it","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f088dd30299295de6856674b7272b06f1f781c83","unresolved":false,"context_lines":[{"line_number":3438,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_owner\u0027])"},{"line_number":3439,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_id\u0027])"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"    def test__notify_gateway_port_ip_changed(self):"},{"line_number":3442,"context_line":"        \"\"\"Test to make sure notification to routers occurs when the gateway"},{"line_number":3443,"context_line":"            ip address changed."},{"line_number":3444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_ed4bdb5a","line":3441,"range":{"start_line":3441,"start_character":3,"end_line":3441,"end_character":50},"in_reply_to":"3f79a3b5_c1d118cc","updated":"2018-11-09 06:14:42.000000000","message":"Done","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"5bc4583a39025f8a1cb9cb8231e07f79bf287814","unresolved":false,"context_lines":[{"line_number":3438,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_owner\u0027])"},{"line_number":3439,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_id\u0027])"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"    def test__notify_gateway_port_ip_changed(self):"},{"line_number":3442,"context_line":"        \"\"\"Test to make sure notification to routers occurs when the gateway"},{"line_number":3443,"context_line":"            ip address changed."},{"line_number":3444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_d0648bb6","line":3441,"range":{"start_line":3441,"start_character":3,"end_line":3441,"end_character":50},"in_reply_to":"3f79a3b5_cfaa05d2","updated":"2018-10-25 19:23:17.000000000","message":"+1","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"783d7a7f9cc2cda07229e0f6c0e6addbf518478e","unresolved":false,"context_lines":[{"line_number":3438,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_owner\u0027])"},{"line_number":3439,"context_line":"                    self.assertEqual(\u0027\u0027, body[\u0027port\u0027][\u0027device_id\u0027])"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"    def test__notify_gateway_port_ip_changed(self):"},{"line_number":3442,"context_line":"        \"\"\"Test to make sure notification to routers occurs when the gateway"},{"line_number":3443,"context_line":"            ip address changed."},{"line_number":3444,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a1c18bff","line":3441,"range":{"start_line":3441,"start_character":3,"end_line":3441,"end_character":50},"in_reply_to":"3f79a3b5_d0648bb6","updated":"2018-11-08 02:50:26.000000000","message":"This still needs to be done.","commit_id":"cef70de20d0537d0a87d1591bc5b1e58739df822"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0ba959ec44efd6cc3cdb3841998af29b02c04199","unresolved":false,"context_lines":[{"line_number":3500,"context_line":"                                                  [router_id], None)"},{"line_number":3501,"context_line":"                    self.assertEqual(2, chk_method.call_count)"},{"line_number":3502,"context_line":""},{"line_number":3503,"context_line":"    def test_no_notify_gateway_port_no_ip_changed(self):"},{"line_number":3504,"context_line":"        plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":3505,"context_line":"        if not hasattr(plugin, \u0027l3_rpc_notifier\u0027):"},{"line_number":3506,"context_line":"            self.skipTest(\"Plugin does not support l3_rpc_notifier\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_f4bff8a9","line":3503,"updated":"2018-11-12 21:18:28.000000000","message":"These two tests are almost identical, I\u0027ll squash them into a helper and add an argument to specify if the gw_ip should be changed.","commit_id":"e8ead2d21d1d321c89300c695d9d4e0df08cb51e"}]}
