)]}'
{"doc/source/cli/neutron-status.rst":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6b80ea18b241d6f00e9d1cb0606e7468e860a24c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"These sections describe the available categories and arguments for"},{"line_number":32,"context_line":":command:`neutron-status`."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Categries and commands"},{"line_number":35,"context_line":"----------------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"``neutron-status upgrade check``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_e49c9f71","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":9},"updated":"2018-10-23 23:59:03.000000000","message":"Categories. In case you push another patch","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"253a22bc43363de186eab9385eca9a7043bdbdc3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"These sections describe the available categories and arguments for"},{"line_number":32,"context_line":":command:`neutron-status`."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Categries and commands"},{"line_number":35,"context_line":"----------------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"``neutron-status upgrade check``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_34fce16f","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":9},"in_reply_to":"3f79a3b5_54ce3d8f","updated":"2018-10-25 10:12:54.000000000","message":"Done","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b2033f8fe4e54ab167532151ef224d479571c24d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"These sections describe the available categories and arguments for"},{"line_number":32,"context_line":":command:`neutron-status`."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Categries and commands"},{"line_number":35,"context_line":"----------------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"``neutron-status upgrade check``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_54ce3d8f","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":9},"in_reply_to":"3f79a3b5_e49c9f71","updated":"2018-10-25 10:03:09.000000000","message":"This section just describes the detail of individual commands.\n\"Command details\" might make more sense.","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3c1a51394682649602320c54db77a4e55999ba7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f79a3b5_68bed6ce","line":62,"updated":"2018-10-15 18:53:38.000000000","message":"I personally like to see the history of checks section in here:\n\nhttps://docs.openstack.org/nova/latest/cli/nova-status.html#upgrade\n\nBut as neutron doesn\u0027t have a real check yet, I guess maybe it\u0027s not worth mentioning the history yet? You could always add it for Stein and say an initial noop placeholder check is added.","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"}],"neutron/cmd/status.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"00355b3579f0ea67ae334a6ae043fe2481cd18dd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    and added to _upgrade_checks tuple."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Check methods here must not rely on the neutron object model since they"},{"line_number":27,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":28,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":29,"context_line":"    schema migrations."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3901073a","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"updated":"2018-10-16 05:34:36.000000000","message":"would be better to explain n in this context ? do you mean any data model ?","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b506e013cf10e5926fba772d3a4d322d87a5bef1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    and added to _upgrade_checks tuple."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Check methods here must not rely on the neutron object model since they"},{"line_number":27,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":28,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":29,"context_line":"    schema migrations."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_26255b0a","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"in_reply_to":"3f79a3b5_0ba14a92","updated":"2018-10-16 13:47:39.000000000","message":"Agree with Slawek. If you\u0027re just asking a question for clarification, then a -1 is kind of inappropriate IMO.\n\nThe \"neutron object model\" refers to versioned objects which wrap DB API access and is versioned per-release, which could potentially not work properly if a check is run against an older database schema, that\u0027s why the actual DB models (sqlalchemy) should be used, like in the database schema migrations, which is pointed out in this comment.","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"24ed46f34f6a2d67df1f005286564f0e7b513f2f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    and added to _upgrade_checks tuple."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Check methods here must not rely on the neutron object model since they"},{"line_number":27,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":28,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":29,"context_line":"    schema migrations."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3c06ca22","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"in_reply_to":"3f79a3b5_26255b0a","updated":"2018-10-16 15:11:36.000000000","message":"I figured that out from release note but n-1 data was bit off for me","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"990e7532d7a05ac7db169758e8cdb0b072a205dc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    and added to _upgrade_checks tuple."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Check methods here must not rely on the neutron object model since they"},{"line_number":27,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":28,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":29,"context_line":"    schema migrations."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0ba14a92","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"in_reply_to":"3f79a3b5_3901073a","updated":"2018-10-16 13:06:43.000000000","message":"It is release of OpenStack and means \"previous\". I think that such term like N and N-1 are quite common in OpenStack\u0027s upgrades area and I\u0027m not sure if there is anything more to explain here","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b2033f8fe4e54ab167532151ef224d479571c24d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    and added to _upgrade_checks tuple."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Check methods here must not rely on the neutron object model since they"},{"line_number":27,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":28,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":29,"context_line":"    schema migrations."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_548abd12","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"in_reply_to":"3f79a3b5_3c06ca22","updated":"2018-10-25 10:03:09.000000000","message":"Following the above convrersation, it looks better to rephrase the sentence. I don\u0027t think \"data\" needs to be used necessarily.\nHow about the following?\n\n  ... since they should be able to run against both N and N-1 releases.\n\n\"releases\" might be replaced with \"data models\".","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"253a22bc43363de186eab9385eca9a7043bdbdc3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    and added to _upgrade_checks tuple."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Check methods here must not rely on the neutron object model since they"},{"line_number":27,"context_line":"    should be able to run on n-1 data. Any queries to the database should be"},{"line_number":28,"context_line":"    done through the sqlalchemy query language directly like the database"},{"line_number":29,"context_line":"    schema migrations."},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b4ceb155","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":32},"in_reply_to":"3f79a3b5_548abd12","updated":"2018-10-25 10:12:54.000000000","message":"Done","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"}],"neutron/tests/unit/cmd/test_status.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6a989b4c9e28887008ad669ba4d20791f54fd5ab","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestUpgradeCheckCmd(base.BaseTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestUpgradeCheckCmd, self).setUp()"},{"line_number":29,"context_line":"        self.output \u003d StringIO()"},{"line_number":30,"context_line":"        self.useFixture(fixtures.MonkeyPatch(\u0027sys.stdout\u0027, self.output))"},{"line_number":31,"context_line":"        self.cmd \u003d status.Checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_check_good(self):"},{"line_number":34,"context_line":"        fake_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":35,"context_line":"        fake_checks \u003d ((\u0027fake\u0027, fake_check_function),)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":38,"context_line":"+-----------------------+"},{"line_number":39,"context_line":"| Upgrade Check Results |"},{"line_number":40,"context_line":"+-----------------------+"},{"line_number":41,"context_line":"| Check: fake           |"},{"line_number":42,"context_line":"| Result: Success       |"},{"line_number":43,"context_line":"| Details: None         |"},{"line_number":44,"context_line":"+-----------------------+"},{"line_number":45,"context_line":"\"\"\""},{"line_number":46,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":47,"context_line":"            self.assertEqual(Code.SUCCESS, self.cmd.check())"},{"line_number":48,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_check_good_and_warning(self):"},{"line_number":51,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":52,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":53,"context_line":"            return_value\u003dResult("},{"line_number":54,"context_line":"                Code.WARNING,"},{"line_number":55,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":56,"context_line":"        fake_checks \u003d ("},{"line_number":57,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":58,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":61,"context_line":"+-----------------------------------------------------+"},{"line_number":62,"context_line":"| Upgrade Check Results                               |"},{"line_number":63,"context_line":"+-----------------------------------------------------+"},{"line_number":64,"context_line":"| Check: fake_good                                    |"},{"line_number":65,"context_line":"| Result: Success                                     |"},{"line_number":66,"context_line":"| Details: None                                       |"},{"line_number":67,"context_line":"+-----------------------------------------------------+"},{"line_number":68,"context_line":"| Check: fake_warning                                 |"},{"line_number":69,"context_line":"| Result: Warning                                     |"},{"line_number":70,"context_line":"| Details: There might be a problem. Please check it. |"},{"line_number":71,"context_line":"+-----------------------------------------------------+"},{"line_number":72,"context_line":"\"\"\""},{"line_number":73,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":74,"context_line":"            self.assertEqual(Code.WARNING, self.cmd.check())"},{"line_number":75,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_check_good_warning_and_failure(self):"},{"line_number":78,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":79,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":80,"context_line":"            return_value\u003dResult("},{"line_number":81,"context_line":"                Code.WARNING,"},{"line_number":82,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":83,"context_line":"        fake_failure_check_function \u003d mock.Mock("},{"line_number":84,"context_line":"            return_value\u003dResult("},{"line_number":85,"context_line":"                Code.FAILURE,"},{"line_number":86,"context_line":"                \"Something really bad happend here. Don\u0027t upgrade until this \""},{"line_number":87,"context_line":"                \"will be fixed :(\"))"},{"line_number":88,"context_line":"        fake_checks \u003d ("},{"line_number":89,"context_line":"            (\u0027fake_failure\u0027, fake_failure_check_function),"},{"line_number":90,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":91,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":94,"context_line":"+----------------------------------------------------------------------+"},{"line_number":95,"context_line":"| Upgrade Check Results                                                |"},{"line_number":96,"context_line":"+----------------------------------------------------------------------+"},{"line_number":97,"context_line":"| Check: fake_failure                                                  |"},{"line_number":98,"context_line":"| Result: Failure                                                      |"},{"line_number":99,"context_line":"| Details: Something really bad happend here. Don\u0027t upgrade until this |"},{"line_number":100,"context_line":"|   will be fixed :(                                                   |"},{"line_number":101,"context_line":"+----------------------------------------------------------------------+"},{"line_number":102,"context_line":"| Check: fake_good                                                     |"},{"line_number":103,"context_line":"| Result: Success                                                      |"},{"line_number":104,"context_line":"| Details: None                                                        |"},{"line_number":105,"context_line":"+----------------------------------------------------------------------+"},{"line_number":106,"context_line":"| Check: fake_warning                                                  |"},{"line_number":107,"context_line":"| Result: Warning                                                      |"},{"line_number":108,"context_line":"| Details: There might be a problem. Please check it.                  |"},{"line_number":109,"context_line":"+----------------------------------------------------------------------+"},{"line_number":110,"context_line":"\"\"\""},{"line_number":111,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":112,"context_line":"            self.assertEqual(Code.FAILURE, self.cmd.check())"},{"line_number":113,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class TestUpgradeChecks(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_dd1a5416","line":113,"range":{"start_line":25,"start_character":0,"end_line":113,"end_character":58},"updated":"2018-10-15 11:10:41.000000000","message":"As I see these tests mostly test oslo_upgradecheck, not the neutron-status command, so I feel these are useless here.","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cc3e86e5d8d11982f6a6ea7c01952eb379601d94","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestUpgradeCheckCmd(base.BaseTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestUpgradeCheckCmd, self).setUp()"},{"line_number":29,"context_line":"        self.output \u003d StringIO()"},{"line_number":30,"context_line":"        self.useFixture(fixtures.MonkeyPatch(\u0027sys.stdout\u0027, self.output))"},{"line_number":31,"context_line":"        self.cmd \u003d status.Checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_check_good(self):"},{"line_number":34,"context_line":"        fake_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":35,"context_line":"        fake_checks \u003d ((\u0027fake\u0027, fake_check_function),)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":38,"context_line":"+-----------------------+"},{"line_number":39,"context_line":"| Upgrade Check Results |"},{"line_number":40,"context_line":"+-----------------------+"},{"line_number":41,"context_line":"| Check: fake           |"},{"line_number":42,"context_line":"| Result: Success       |"},{"line_number":43,"context_line":"| Details: None         |"},{"line_number":44,"context_line":"+-----------------------+"},{"line_number":45,"context_line":"\"\"\""},{"line_number":46,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":47,"context_line":"            self.assertEqual(Code.SUCCESS, self.cmd.check())"},{"line_number":48,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_check_good_and_warning(self):"},{"line_number":51,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":52,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":53,"context_line":"            return_value\u003dResult("},{"line_number":54,"context_line":"                Code.WARNING,"},{"line_number":55,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":56,"context_line":"        fake_checks \u003d ("},{"line_number":57,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":58,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":61,"context_line":"+-----------------------------------------------------+"},{"line_number":62,"context_line":"| Upgrade Check Results                               |"},{"line_number":63,"context_line":"+-----------------------------------------------------+"},{"line_number":64,"context_line":"| Check: fake_good                                    |"},{"line_number":65,"context_line":"| Result: Success                                     |"},{"line_number":66,"context_line":"| Details: None                                       |"},{"line_number":67,"context_line":"+-----------------------------------------------------+"},{"line_number":68,"context_line":"| Check: fake_warning                                 |"},{"line_number":69,"context_line":"| Result: Warning                                     |"},{"line_number":70,"context_line":"| Details: There might be a problem. Please check it. |"},{"line_number":71,"context_line":"+-----------------------------------------------------+"},{"line_number":72,"context_line":"\"\"\""},{"line_number":73,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":74,"context_line":"            self.assertEqual(Code.WARNING, self.cmd.check())"},{"line_number":75,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_check_good_warning_and_failure(self):"},{"line_number":78,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":79,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":80,"context_line":"            return_value\u003dResult("},{"line_number":81,"context_line":"                Code.WARNING,"},{"line_number":82,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":83,"context_line":"        fake_failure_check_function \u003d mock.Mock("},{"line_number":84,"context_line":"            return_value\u003dResult("},{"line_number":85,"context_line":"                Code.FAILURE,"},{"line_number":86,"context_line":"                \"Something really bad happend here. Don\u0027t upgrade until this \""},{"line_number":87,"context_line":"                \"will be fixed :(\"))"},{"line_number":88,"context_line":"        fake_checks \u003d ("},{"line_number":89,"context_line":"            (\u0027fake_failure\u0027, fake_failure_check_function),"},{"line_number":90,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":91,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":94,"context_line":"+----------------------------------------------------------------------+"},{"line_number":95,"context_line":"| Upgrade Check Results                                                |"},{"line_number":96,"context_line":"+----------------------------------------------------------------------+"},{"line_number":97,"context_line":"| Check: fake_failure                                                  |"},{"line_number":98,"context_line":"| Result: Failure                                                      |"},{"line_number":99,"context_line":"| Details: Something really bad happend here. Don\u0027t upgrade until this |"},{"line_number":100,"context_line":"|   will be fixed :(                                                   |"},{"line_number":101,"context_line":"+----------------------------------------------------------------------+"},{"line_number":102,"context_line":"| Check: fake_good                                                     |"},{"line_number":103,"context_line":"| Result: Success                                                      |"},{"line_number":104,"context_line":"| Details: None                                                        |"},{"line_number":105,"context_line":"+----------------------------------------------------------------------+"},{"line_number":106,"context_line":"| Check: fake_warning                                                  |"},{"line_number":107,"context_line":"| Result: Warning                                                      |"},{"line_number":108,"context_line":"| Details: There might be a problem. Please check it.                  |"},{"line_number":109,"context_line":"+----------------------------------------------------------------------+"},{"line_number":110,"context_line":"\"\"\""},{"line_number":111,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":112,"context_line":"            self.assertEqual(Code.FAILURE, self.cmd.check())"},{"line_number":113,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class TestUpgradeChecks(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2dd9d3ef","line":113,"range":{"start_line":25,"start_character":0,"end_line":113,"end_character":58},"in_reply_to":"3f79a3b5_9255a254","updated":"2018-10-15 16:49:05.000000000","message":"Ok, removed.","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c6b0b4f489fdb2b568ff6f22084672964577faff","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestUpgradeCheckCmd(base.BaseTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestUpgradeCheckCmd, self).setUp()"},{"line_number":29,"context_line":"        self.output \u003d StringIO()"},{"line_number":30,"context_line":"        self.useFixture(fixtures.MonkeyPatch(\u0027sys.stdout\u0027, self.output))"},{"line_number":31,"context_line":"        self.cmd \u003d status.Checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_check_good(self):"},{"line_number":34,"context_line":"        fake_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":35,"context_line":"        fake_checks \u003d ((\u0027fake\u0027, fake_check_function),)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":38,"context_line":"+-----------------------+"},{"line_number":39,"context_line":"| Upgrade Check Results |"},{"line_number":40,"context_line":"+-----------------------+"},{"line_number":41,"context_line":"| Check: fake           |"},{"line_number":42,"context_line":"| Result: Success       |"},{"line_number":43,"context_line":"| Details: None         |"},{"line_number":44,"context_line":"+-----------------------+"},{"line_number":45,"context_line":"\"\"\""},{"line_number":46,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":47,"context_line":"            self.assertEqual(Code.SUCCESS, self.cmd.check())"},{"line_number":48,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_check_good_and_warning(self):"},{"line_number":51,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":52,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":53,"context_line":"            return_value\u003dResult("},{"line_number":54,"context_line":"                Code.WARNING,"},{"line_number":55,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":56,"context_line":"        fake_checks \u003d ("},{"line_number":57,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":58,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":61,"context_line":"+-----------------------------------------------------+"},{"line_number":62,"context_line":"| Upgrade Check Results                               |"},{"line_number":63,"context_line":"+-----------------------------------------------------+"},{"line_number":64,"context_line":"| Check: fake_good                                    |"},{"line_number":65,"context_line":"| Result: Success                                     |"},{"line_number":66,"context_line":"| Details: None                                       |"},{"line_number":67,"context_line":"+-----------------------------------------------------+"},{"line_number":68,"context_line":"| Check: fake_warning                                 |"},{"line_number":69,"context_line":"| Result: Warning                                     |"},{"line_number":70,"context_line":"| Details: There might be a problem. Please check it. |"},{"line_number":71,"context_line":"+-----------------------------------------------------+"},{"line_number":72,"context_line":"\"\"\""},{"line_number":73,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":74,"context_line":"            self.assertEqual(Code.WARNING, self.cmd.check())"},{"line_number":75,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_check_good_warning_and_failure(self):"},{"line_number":78,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":79,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":80,"context_line":"            return_value\u003dResult("},{"line_number":81,"context_line":"                Code.WARNING,"},{"line_number":82,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":83,"context_line":"        fake_failure_check_function \u003d mock.Mock("},{"line_number":84,"context_line":"            return_value\u003dResult("},{"line_number":85,"context_line":"                Code.FAILURE,"},{"line_number":86,"context_line":"                \"Something really bad happend here. Don\u0027t upgrade until this \""},{"line_number":87,"context_line":"                \"will be fixed :(\"))"},{"line_number":88,"context_line":"        fake_checks \u003d ("},{"line_number":89,"context_line":"            (\u0027fake_failure\u0027, fake_failure_check_function),"},{"line_number":90,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":91,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":94,"context_line":"+----------------------------------------------------------------------+"},{"line_number":95,"context_line":"| Upgrade Check Results                                                |"},{"line_number":96,"context_line":"+----------------------------------------------------------------------+"},{"line_number":97,"context_line":"| Check: fake_failure                                                  |"},{"line_number":98,"context_line":"| Result: Failure                                                      |"},{"line_number":99,"context_line":"| Details: Something really bad happend here. Don\u0027t upgrade until this |"},{"line_number":100,"context_line":"|   will be fixed :(                                                   |"},{"line_number":101,"context_line":"+----------------------------------------------------------------------+"},{"line_number":102,"context_line":"| Check: fake_good                                                     |"},{"line_number":103,"context_line":"| Result: Success                                                      |"},{"line_number":104,"context_line":"| Details: None                                                        |"},{"line_number":105,"context_line":"+----------------------------------------------------------------------+"},{"line_number":106,"context_line":"| Check: fake_warning                                                  |"},{"line_number":107,"context_line":"| Result: Warning                                                      |"},{"line_number":108,"context_line":"| Details: There might be a problem. Please check it.                  |"},{"line_number":109,"context_line":"+----------------------------------------------------------------------+"},{"line_number":110,"context_line":"\"\"\""},{"line_number":111,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":112,"context_line":"            self.assertEqual(Code.FAILURE, self.cmd.check())"},{"line_number":113,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class TestUpgradeChecks(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9255a254","line":113,"range":{"start_line":25,"start_character":0,"end_line":113,"end_character":58},"in_reply_to":"3f79a3b5_a1c5f291","updated":"2018-10-15 15:20:43.000000000","message":"Lance asked me the same question for keystone and I said I would leave the testing of how the library works to the library, and each project should just test the code it added. So what you have below should be sufficient I think.","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2b14618cf7e4c0ef15d3e6a9dd8375f9ee84bb66","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestUpgradeCheckCmd(base.BaseTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestUpgradeCheckCmd, self).setUp()"},{"line_number":29,"context_line":"        self.output \u003d StringIO()"},{"line_number":30,"context_line":"        self.useFixture(fixtures.MonkeyPatch(\u0027sys.stdout\u0027, self.output))"},{"line_number":31,"context_line":"        self.cmd \u003d status.Checks()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_check_good(self):"},{"line_number":34,"context_line":"        fake_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":35,"context_line":"        fake_checks \u003d ((\u0027fake\u0027, fake_check_function),)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":38,"context_line":"+-----------------------+"},{"line_number":39,"context_line":"| Upgrade Check Results |"},{"line_number":40,"context_line":"+-----------------------+"},{"line_number":41,"context_line":"| Check: fake           |"},{"line_number":42,"context_line":"| Result: Success       |"},{"line_number":43,"context_line":"| Details: None         |"},{"line_number":44,"context_line":"+-----------------------+"},{"line_number":45,"context_line":"\"\"\""},{"line_number":46,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":47,"context_line":"            self.assertEqual(Code.SUCCESS, self.cmd.check())"},{"line_number":48,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_check_good_and_warning(self):"},{"line_number":51,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":52,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":53,"context_line":"            return_value\u003dResult("},{"line_number":54,"context_line":"                Code.WARNING,"},{"line_number":55,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":56,"context_line":"        fake_checks \u003d ("},{"line_number":57,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":58,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":61,"context_line":"+-----------------------------------------------------+"},{"line_number":62,"context_line":"| Upgrade Check Results                               |"},{"line_number":63,"context_line":"+-----------------------------------------------------+"},{"line_number":64,"context_line":"| Check: fake_good                                    |"},{"line_number":65,"context_line":"| Result: Success                                     |"},{"line_number":66,"context_line":"| Details: None                                       |"},{"line_number":67,"context_line":"+-----------------------------------------------------+"},{"line_number":68,"context_line":"| Check: fake_warning                                 |"},{"line_number":69,"context_line":"| Result: Warning                                     |"},{"line_number":70,"context_line":"| Details: There might be a problem. Please check it. |"},{"line_number":71,"context_line":"+-----------------------------------------------------+"},{"line_number":72,"context_line":"\"\"\""},{"line_number":73,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":74,"context_line":"            self.assertEqual(Code.WARNING, self.cmd.check())"},{"line_number":75,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_check_good_warning_and_failure(self):"},{"line_number":78,"context_line":"        fake_good_check_function \u003d mock.Mock(return_value\u003dResult(Code.SUCCESS))"},{"line_number":79,"context_line":"        fake_warning_check_function \u003d mock.Mock("},{"line_number":80,"context_line":"            return_value\u003dResult("},{"line_number":81,"context_line":"                Code.WARNING,"},{"line_number":82,"context_line":"                \"There might be a problem. Please check it.\"))"},{"line_number":83,"context_line":"        fake_failure_check_function \u003d mock.Mock("},{"line_number":84,"context_line":"            return_value\u003dResult("},{"line_number":85,"context_line":"                Code.FAILURE,"},{"line_number":86,"context_line":"                \"Something really bad happend here. Don\u0027t upgrade until this \""},{"line_number":87,"context_line":"                \"will be fixed :(\"))"},{"line_number":88,"context_line":"        fake_checks \u003d ("},{"line_number":89,"context_line":"            (\u0027fake_failure\u0027, fake_failure_check_function),"},{"line_number":90,"context_line":"            (\u0027fake_good\u0027, fake_good_check_function),"},{"line_number":91,"context_line":"            (\u0027fake_warning\u0027, fake_warning_check_function),)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":94,"context_line":"+----------------------------------------------------------------------+"},{"line_number":95,"context_line":"| Upgrade Check Results                                                |"},{"line_number":96,"context_line":"+----------------------------------------------------------------------+"},{"line_number":97,"context_line":"| Check: fake_failure                                                  |"},{"line_number":98,"context_line":"| Result: Failure                                                      |"},{"line_number":99,"context_line":"| Details: Something really bad happend here. Don\u0027t upgrade until this |"},{"line_number":100,"context_line":"|   will be fixed :(                                                   |"},{"line_number":101,"context_line":"+----------------------------------------------------------------------+"},{"line_number":102,"context_line":"| Check: fake_good                                                     |"},{"line_number":103,"context_line":"| Result: Success                                                      |"},{"line_number":104,"context_line":"| Details: None                                                        |"},{"line_number":105,"context_line":"+----------------------------------------------------------------------+"},{"line_number":106,"context_line":"| Check: fake_warning                                                  |"},{"line_number":107,"context_line":"| Result: Warning                                                      |"},{"line_number":108,"context_line":"| Details: There might be a problem. Please check it.                  |"},{"line_number":109,"context_line":"+----------------------------------------------------------------------+"},{"line_number":110,"context_line":"\"\"\""},{"line_number":111,"context_line":"        with mock.patch.object(self.cmd, \u0027_upgrade_checks\u0027, fake_checks):"},{"line_number":112,"context_line":"            self.assertEqual(Code.FAILURE, self.cmd.check())"},{"line_number":113,"context_line":"        self.assertEqual(expected, self.output.getvalue())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class TestUpgradeChecks(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a1c5f291","line":113,"range":{"start_line":25,"start_character":0,"end_line":113,"end_character":58},"in_reply_to":"3f79a3b5_dd1a5416","updated":"2018-10-15 13:40:18.000000000","message":"Yes, those tests are mostly checking oslo lib behavior in fact but I though that maybe it would be good to have such tests here as kind of documentation.\n\nIf others thinks that it should be removed, I can remove that :)","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b2033f8fe4e54ab167532151ef224d479571c24d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test__check_nothing(self):"},{"line_number":28,"context_line":"        check_result \u003d self.cmd._check_nothing()"},{"line_number":29,"context_line":"        self.assertEqual("},{"line_number":30,"context_line":"            Code.SUCCESS, check_result.code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_deacae37","line":30,"range":{"start_line":29,"start_character":8,"end_line":30,"end_character":44},"updated":"2018-10-25 10:03:09.000000000","message":"super minor: I think \n\n  self.assertEqual(Code.SUCCESS,\n                   check_result.code)\n\nis easier to read.\n\nOr it seems to fit to one line.","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"253a22bc43363de186eab9385eca9a7043bdbdc3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test__check_nothing(self):"},{"line_number":28,"context_line":"        check_result \u003d self.cmd._check_nothing()"},{"line_number":29,"context_line":"        self.assertEqual("},{"line_number":30,"context_line":"            Code.SUCCESS, check_result.code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f4f18997","line":30,"range":{"start_line":29,"start_character":8,"end_line":30,"end_character":44},"in_reply_to":"3f79a3b5_deacae37","updated":"2018-10-25 10:12:54.000000000","message":"Yes, it fit in one line now :)","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"}],"releasenotes/notes/Neutron-status-upgrade-check-framework-fc34d03c8829672c.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67301da7c89c2e6fbf9787ce6ec9e90506c29e21","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_55945136","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":32},"updated":"2018-10-09 14:24:38.000000000","message":"s/adding","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67301da7c89c2e6fbf9787ce6ec9e90506c29e21","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_3599956a","line":7,"range":{"start_line":7,"start_character":65,"end_line":7,"end_character":71},"updated":"2018-10-09 14:24:38.000000000","message":"s/before a","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a9747a1c422f340063c3c98fa4573fae999c7752","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_15b66edd","line":7,"range":{"start_line":7,"start_character":65,"end_line":7,"end_character":71},"in_reply_to":"3f79a3b5_3599956a","updated":"2018-10-14 12:45:07.000000000","message":"Done","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a9747a1c422f340063c3c98fa4573fae999c7752","unresolved":false,"context_lines":[{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_35b92aca","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":32},"in_reply_to":"3f79a3b5_55945136","updated":"2018-10-14 12:45:07.000000000","message":"Done","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67301da7c89c2e6fbf9787ce6ec9e90506c29e21","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Operator can now use this new CLI tool to check if Neutron deployment"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_b5b605db","line":8,"range":{"start_line":8,"start_character":48,"end_line":8,"end_character":55},"updated":"2018-10-09 14:24:38.000000000","message":"s/performed","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67301da7c89c2e6fbf9787ce6ec9e90506c29e21","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Operator can now use this new CLI tool to check if Neutron deployment"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_f5a23d97","line":8,"range":{"start_line":8,"start_character":30,"end_line":8,"end_character":32},"updated":"2018-10-09 14:24:38.000000000","message":"s/the","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a9747a1c422f340063c3c98fa4573fae999c7752","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Operator can now use this new CLI tool to check if Neutron deployment"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_f5ae527e","line":8,"range":{"start_line":8,"start_character":48,"end_line":8,"end_character":55},"in_reply_to":"3f79a3b5_b5b605db","updated":"2018-10-14 12:45:07.000000000","message":"Done","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a9747a1c422f340063c3c98fa4573fae999c7752","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows to add various checks which can be run before"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if upgrade can be perform safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Operator can now use this new CLI tool to check if Neutron deployment"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_d5ab166e","line":8,"range":{"start_line":8,"start_character":30,"end_line":8,"end_character":32},"in_reply_to":"3f79a3b5_f5a23d97","updated":"2018-10-14 12:45:07.000000000","message":"Done","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c6b0b4f489fdb2b568ff6f22084672964577faff","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Add new tool ``neutron-status upgrade check``."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows adding various checks which can be run before a"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if the upgrade can be performed safely."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_d2c47a10","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":27},"updated":"2018-10-15 15:20:43.000000000","message":"This won\u0027t make sense when reading release notes as a group - there won\u0027t be context on what \"this\" is.","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cc3e86e5d8d11982f6a6ea7c01952eb379601d94","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Add new tool ``neutron-status upgrade check``."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    This is basic framework for ``neutron-status upgrade check`` command."},{"line_number":7,"context_line":"    This framework allows adding various checks which can be run before a"},{"line_number":8,"context_line":"    Neutron upgrade to ensure if the upgrade can be performed safely."},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_cdbb7f72","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":27},"in_reply_to":"3f79a3b5_d2c47a10","updated":"2018-10-15 16:49:05.000000000","message":"Done","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c6b0b4f489fdb2b568ff6f22084672964577faff","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    Neutron upgrade to ensure if the upgrade can be performed safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Operator can now use this new CLI tool to check if Neutron deployment"},{"line_number":12,"context_line":"    can be safely upgraded from N-1 to N release."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_b2cd3e30","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":34},"updated":"2018-10-15 15:20:43.000000000","message":"again, no context here when reading the release notes in a group","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cc3e86e5d8d11982f6a6ea7c01952eb379601d94","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    Neutron upgrade to ensure if the upgrade can be performed safely."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Operator can now use this new CLI tool to check if Neutron deployment"},{"line_number":12,"context_line":"    can be safely upgraded from N-1 to N release."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_8db10794","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":34},"in_reply_to":"3f79a3b5_b2cd3e30","updated":"2018-10-15 16:49:05.000000000","message":"Done","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"}],"requirements.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e787d2185d1ff752506756fe75dd102b0976d07","unresolved":false,"context_lines":[{"line_number":40,"context_line":"oslo.rootwrap\u003e\u003d5.8.0 # Apache-2.0"},{"line_number":41,"context_line":"oslo.serialization!\u003d2.19.1,\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":42,"context_line":"oslo.service!\u003d1.28.1,\u003e\u003d1.24.0 # Apache-2.0"},{"line_number":43,"context_line":"oslo.upgradecheck\u003e\u003d0.0.1.dev15"},{"line_number":44,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":45,"context_line":"oslo.versionedobjects\u003e\u003d1.31.2 # Apache-2.0"},{"line_number":46,"context_line":"osprofiler\u003e\u003d1.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_ef476fa3","line":43,"updated":"2018-10-12 21:58:43.000000000","message":"Use 0.1.0 and you probably want this in the lower-constraints file too. You\u0027ll need to depend on this:\n\nhttps://review.openstack.org/#/c/610061/","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a9747a1c422f340063c3c98fa4573fae999c7752","unresolved":false,"context_lines":[{"line_number":40,"context_line":"oslo.rootwrap\u003e\u003d5.8.0 # Apache-2.0"},{"line_number":41,"context_line":"oslo.serialization!\u003d2.19.1,\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":42,"context_line":"oslo.service!\u003d1.28.1,\u003e\u003d1.24.0 # Apache-2.0"},{"line_number":43,"context_line":"oslo.upgradecheck\u003e\u003d0.0.1.dev15"},{"line_number":44,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":45,"context_line":"oslo.versionedobjects\u003e\u003d1.31.2 # Apache-2.0"},{"line_number":46,"context_line":"osprofiler\u003e\u003d1.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_95c91e5b","line":43,"in_reply_to":"3f79a3b5_ef476fa3","updated":"2018-10-14 12:45:07.000000000","message":"thx. Changed","commit_id":"5b0bdefaf285059f238a7dcb10f3cc59af770b69"}],"setup.cfg":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c6b0b4f489fdb2b568ff6f22084672964577faff","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":57,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":58,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":59,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":60,"context_line":"neutron.core_plugins \u003d"},{"line_number":61,"context_line":"    ml2 \u003d neutron.plugins.ml2.plugin:Ml2Plugin"},{"line_number":62,"context_line":"neutron.service_plugins \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"3f79a3b5_72d326d4","line":59,"updated":"2018-10-15 15:20:43.000000000","message":"At least add some stub CLI docs:\n\nhttps://docs.openstack.org/neutron/latest/cli/","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cc3e86e5d8d11982f6a6ea7c01952eb379601d94","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":57,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":58,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":59,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":60,"context_line":"neutron.core_plugins \u003d"},{"line_number":61,"context_line":"    ml2 \u003d neutron.plugins.ml2.plugin:Ml2Plugin"},{"line_number":62,"context_line":"neutron.service_plugins \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"3f79a3b5_9898631a","line":59,"in_reply_to":"3f79a3b5_72d326d4","updated":"2018-10-15 16:49:05.000000000","message":"Done","commit_id":"dd1272df52dc4719ecade721ad52a7771bd2d8e1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c115cc92e09254b517d0eaf0246d2f37505c825d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":57,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":58,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":59,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":60,"context_line":"neutron.core_plugins \u003d"},{"line_number":61,"context_line":"    ml2 \u003d neutron.plugins.ml2.plugin:Ml2Plugin"},{"line_number":62,"context_line":"neutron.service_plugins \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3f79a3b5_3cfc8a3d","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":18},"updated":"2018-10-16 15:03:23.000000000","message":"Is everyone using \u0027status\u0027 for these?\n\n\nMy initial impression is that \u0027status\u0027 is a very generic name for this; would something more explicit be better like \"neutron-upgrade-status\u0027?","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"feb9c9c948d2f8eac99d405031f70f4b57b29e7f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":57,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":58,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":59,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":60,"context_line":"neutron.core_plugins \u003d"},{"line_number":61,"context_line":"    ml2 \u003d neutron.plugins.ml2.plugin:Ml2Plugin"},{"line_number":62,"context_line":"neutron.service_plugins \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3f79a3b5_c5c25a54","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":18},"in_reply_to":"3f79a3b5_3cfc8a3d","updated":"2018-10-16 15:56:53.000000000","message":"Yes, it\u0027s like that in community goal","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b2033f8fe4e54ab167532151ef224d479571c24d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":57,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":58,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":59,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":60,"context_line":"neutron.core_plugins \u003d"},{"line_number":61,"context_line":"    ml2 \u003d neutron.plugins.ml2.plugin:Ml2Plugin"},{"line_number":62,"context_line":"neutron.service_plugins \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3f79a3b5_9464d5b5","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":18},"in_reply_to":"3f79a3b5_c5c25a54","updated":"2018-10-25 10:03:09.000000000","message":"FYI: The command name is defined at https://governance.openstack.org/tc/goals/stein/upgrade-checkers.html#completion-criteria","commit_id":"d69761c50b839f527382b19e574e6fd9c3c9cefc"}]}
