)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9082da2161e58e5be5d761046bb5cd6ef29cf1c2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"causing the proxy request to fail with an exception because the url is"},{"line_number":11,"context_line":"not valid."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchs check if the nova_metadata_host is an IPv6 address and"},{"line_number":14,"context_line":"create a valid url enclosing the IPv6 address with brackets"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1796593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_64a3dd00","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":17},"updated":"2018-10-09 17:39:00.000000000","message":"patch checks","commit_id":"eb98340f2b1771ab029f14c2e4907285142fc52c"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"e0e0cb929ac0b2bedf46906424bdd00ca8c126cd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"causing the proxy request to fail with an exception because the url is"},{"line_number":11,"context_line":"not valid."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchs check if the nova_metadata_host is an IPv6 address and"},{"line_number":14,"context_line":"create a valid url enclosing the IPv6 address with brackets"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1796593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_7f2cc6b1","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":17},"in_reply_to":"3f79a3b5_64a3dd00","updated":"2018-10-09 19:19:01.000000000","message":"Done","commit_id":"eb98340f2b1771ab029f14c2e4907285142fc52c"}],"neutron/agent/metadata/agent.py":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"adc5460fe4221191d1b620e3640fe6ccd5cd9a4c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import hashlib"},{"line_number":16,"context_line":"import hmac"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from neutron_lib.agent import topics"},{"line_number":20,"context_line":"from neutron_lib import constants"},{"line_number":21,"context_line":"from neutron_lib import context"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_82bcf46b","line":18,"updated":"2018-10-09 12:33:14.000000000","message":"imho this should be grouped together with either the \"import hmac\" block - netaddr isn\u0027t oslo or openstack specific code","commit_id":"a8f7c5327dc8d5d5a0b919c77f9d00cb9781c0ff"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"e775dc40829ae5540170dddb7bde4708bda17626","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import hashlib"},{"line_number":16,"context_line":"import hmac"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from neutron_lib.agent import topics"},{"line_number":20,"context_line":"from neutron_lib import constants"},{"line_number":21,"context_line":"from neutron_lib import context"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a8df91d5","line":18,"in_reply_to":"3f79a3b5_82bcf46b","updated":"2018-10-09 13:31:57.000000000","message":"ups, didn\u0027t know this conventions sorry","commit_id":"a8f7c5327dc8d5d5a0b919c77f9d00cb9781c0ff"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"ed1c44dcbfe9bf3ff9774430a54f5dbfd128dffe","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            \u0027X-Instance-ID-Signature\u0027: self._sign_instance_id(instance_id)"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        if netaddr.valid_ipv6(self.conf.nova_metadata_host):"},{"line_number":182,"context_line":"            nova_host_port \u003d \u0027[%s]:%s\u0027 % (self.conf.nova_metadata_host,"},{"line_number":183,"context_line":"                                          self.conf.nova_metadata_port)"},{"line_number":184,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6a68aa87","line":181,"updated":"2018-10-08 13:20:30.000000000","message":"Maybe we could break this logic out into its own method? That way this logic could be isolated, making it very simple to write a quick test. As written, testing writing a test for this change seems painful.","commit_id":"a8f7c5327dc8d5d5a0b919c77f9d00cb9781c0ff"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"53da6cca0dc4e67befa273d381bd1276b2418b58","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            \u0027X-Instance-ID-Signature\u0027: self._sign_instance_id(instance_id)"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        if netaddr.valid_ipv6(self.conf.nova_metadata_host):"},{"line_number":182,"context_line":"            nova_host_port \u003d \u0027[%s]:%s\u0027 % (self.conf.nova_metadata_host,"},{"line_number":183,"context_line":"                                          self.conf.nova_metadata_port)"},{"line_number":184,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ca4d3ec6","line":181,"in_reply_to":"3f79a3b5_6a68aa87","updated":"2018-10-08 13:45:46.000000000","message":"I have planned to add a job covering this scenario with tempest, you can see an example here https://bugs.launchpad.net/neutron/+bug/1796593/comments/2\nRegarding using its own method, I think that it\u0027s not worth the effort if we are only going to use this sanity check for urls in this part of the code.","commit_id":"a8f7c5327dc8d5d5a0b919c77f9d00cb9781c0ff"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"e775dc40829ae5540170dddb7bde4708bda17626","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            \u0027X-Instance-ID-Signature\u0027: self._sign_instance_id(instance_id)"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        if netaddr.valid_ipv6(self.conf.nova_metadata_host):"},{"line_number":182,"context_line":"            nova_host_port \u003d \u0027[%s]:%s\u0027 % (self.conf.nova_metadata_host,"},{"line_number":183,"context_line":"                                          self.conf.nova_metadata_port)"},{"line_number":184,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_08fa4543","line":181,"in_reply_to":"3f79a3b5_6a68aa87","updated":"2018-10-09 13:31:57.000000000","message":"test job covering this scenario https://review.openstack.org/#/c/608706/\nIf there is no need in other part of the code to sanitize the url with IPv6, could we move forward and left hsi as low hanging fruit?","commit_id":"a8f7c5327dc8d5d5a0b919c77f9d00cb9781c0ff"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e5fb33a43002dcfaae9cfbdeb4a7febb50865bfd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import hashlib"},{"line_number":16,"context_line":"import hmac"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron_lib.agent import topics"},{"line_number":21,"context_line":"from neutron_lib import constants"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f1eebb1f","line":18,"updated":"2018-10-10 09:13:49.000000000","message":"this should be included in section with other 3rd party libs below. Why You put it here with separate section?","commit_id":"6f51e5ef0085f57564304b6170af9d52b045528c"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"d792029e7fa6022c172be001fe56f9a0a4879b29","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            \u0027X-Instance-ID-Signature\u0027: self._sign_instance_id(instance_id)"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        nova_host_port \u003d ipv6_utils.valid_ipv6_url(self.conf.nova_metadata_host,"},{"line_number":182,"context_line":"                                                   self.conf.nova_metadata_port)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        url \u003d urllib.parse.urlunsplit(("},{"line_number":185,"context_line":"            self.conf.nova_metadata_protocol,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e8480263","line":182,"range":{"start_line":181,"start_character":1,"end_line":182,"end_character":80},"updated":"2018-10-10 19:06:48.000000000","message":"Line length causing pep8 failure","commit_id":"7c17b5e3811b92982a12e29a5bff4b9df9ebb8c0"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"47546f3f86f0c1b7365ac8d991c52b8ab94e6b8d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            \u0027X-Instance-ID-Signature\u0027: self._sign_instance_id(instance_id)"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        nova_host_port \u003d ipv6_utils.valid_ipv6_url(self.conf.nova_metadata_host,"},{"line_number":182,"context_line":"                                                   self.conf.nova_metadata_port)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        url \u003d urllib.parse.urlunsplit(("},{"line_number":185,"context_line":"            self.conf.nova_metadata_protocol,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4466bef0","line":182,"range":{"start_line":181,"start_character":1,"end_line":182,"end_character":80},"in_reply_to":"3f79a3b5_e8480263","updated":"2018-10-10 21:03:44.000000000","message":"Done","commit_id":"7c17b5e3811b92982a12e29a5bff4b9df9ebb8c0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"363c3aa44dc3b6cf85e331a68b23aa3604914738","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import hashlib"},{"line_number":16,"context_line":"import hmac"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.common import ipv6_utils"},{"line_number":19,"context_line":"from neutron_lib.agent import topics"},{"line_number":20,"context_line":"from neutron_lib import constants"},{"line_number":21,"context_line":"from neutron_lib import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_6df39da0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":37},"updated":"2018-10-11 00:57:56.000000000","message":"This is project import. So it should be located in L37.","commit_id":"434c6d224bfcc3f37fe3b9b8247c7589c2c2e217"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9e327ad0dc4b35b7dde074d853972c5b86f72ec1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import hashlib"},{"line_number":16,"context_line":"import hmac"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.common import ipv6_utils"},{"line_number":19,"context_line":"from neutron_lib.agent import topics"},{"line_number":20,"context_line":"from neutron_lib import constants"},{"line_number":21,"context_line":"from neutron_lib import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_58cc5d89","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":37},"in_reply_to":"3f79a3b5_6df39da0","updated":"2018-10-11 02:05:56.000000000","message":"+1 third party imports before project imports","commit_id":"434c6d224bfcc3f37fe3b9b8247c7589c2c2e217"}],"neutron/common/ipv6_utils.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"d792029e7fa6022c172be001fe56f9a0a4879b29","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return subnet.get(\u0027subnetpool_id\u0027) \u003d\u003d const.IPV6_PD_POOL_ID"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def valid_ipv6_url(host, port):"},{"line_number":75,"context_line":"    \"\"\"Given a host and a port returns a valid URL"},{"line_number":76,"context_line":"       RFC2732 https://tools.ietf.org/html/rfc2732"},{"line_number":77,"context_line":"       square brackets always required in ipv6 URI."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4888166a","line":74,"updated":"2018-10-10 19:06:48.000000000","message":"micro-nit: Perhaps ipv6_utils isn\u0027t the appropriate place for this? Maybe move this over to neutron/agent/metadata/agent.py? The method name could be a little more descriptive, perhaps something along the lines of _metadata_url().","commit_id":"7c17b5e3811b92982a12e29a5bff4b9df9ebb8c0"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"47546f3f86f0c1b7365ac8d991c52b8ab94e6b8d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return subnet.get(\u0027subnetpool_id\u0027) \u003d\u003d const.IPV6_PD_POOL_ID"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def valid_ipv6_url(host, port):"},{"line_number":75,"context_line":"    \"\"\"Given a host and a port returns a valid URL"},{"line_number":76,"context_line":"       RFC2732 https://tools.ietf.org/html/rfc2732"},{"line_number":77,"context_line":"       square brackets always required in ipv6 URI."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a46d52cc","line":74,"in_reply_to":"3f79a3b5_4888166a","updated":"2018-10-10 21:03:44.000000000","message":"I thought about that but I chose this one because I\u0027m worried about other corner cases with ipv6 that weren\u0027t tested, so we can reuse the function if needed.\nIn addition, the goal is clearly to create valid ipv6 urls from host fields, that\u0027s why I think that ipv6_utils is the right place.","commit_id":"7c17b5e3811b92982a12e29a5bff4b9df9ebb8c0"}]}
