)]}'
{"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"bea5dd9d6ef4b28c19115a9996f376296087cc16","unresolved":false,"context_lines":[{"line_number":2705,"context_line":"    def test_update_network_set_not_shared_other_tenant_access_via_rbac(self):"},{"line_number":2706,"context_line":"        with self.network(shared\u003dTrue) as network:"},{"line_number":2707,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":2708,"context_line":"            with db_api.context_manager.writer.using(ctx):"},{"line_number":2709,"context_line":"                ctx.session.add("},{"line_number":2710,"context_line":"                    rbac_db_models.NetworkRBAC("},{"line_number":2711,"context_line":"                        object_id\u003dnetwork[\u0027network\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_bedb204c","side":"PARENT","line":2708,"range":{"start_line":2708,"start_character":47,"end_line":2708,"end_character":52},"updated":"2018-10-10 20:39:28.000000000","message":"Just want to point out that the removal of writer session looks more than OVO conversion. However, I guess it doesn\u0027t matter in tests.","commit_id":"81083f1b89a822120752851a79523f6be35ef93b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"315f0819a8cb8b4ed86fc97bf507fa26eebe1ae8","unresolved":false,"context_lines":[{"line_number":2705,"context_line":"    def test_update_network_set_not_shared_other_tenant_access_via_rbac(self):"},{"line_number":2706,"context_line":"        with self.network(shared\u003dTrue) as network:"},{"line_number":2707,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":2708,"context_line":"            with db_api.context_manager.writer.using(ctx):"},{"line_number":2709,"context_line":"                ctx.session.add("},{"line_number":2710,"context_line":"                    rbac_db_models.NetworkRBAC("},{"line_number":2711,"context_line":"                        object_id\u003dnetwork[\u0027network\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_3665e61d","side":"PARENT","line":2708,"range":{"start_line":2708,"start_character":47,"end_line":2708,"end_character":52},"in_reply_to":"3f79a3b5_bedb204c","updated":"2018-10-11 14:04:02.000000000","message":"It \"is\" more than OVO conversion! I\u0027ll take this back. Thanks!","commit_id":"81083f1b89a822120752851a79523f6be35ef93b"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"bea5dd9d6ef4b28c19115a9996f376296087cc16","unresolved":false,"context_lines":[{"line_number":6312,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":6313,"context_line":"            network \u003d models_v2.Network("},{"line_number":6314,"context_line":"                name\u003d\u0027net_net\u0027, status\u003d\u0027OK\u0027, admin_state_up\u003dTrue,"},{"line_number":6315,"context_line":"                project_id\u003d\u0027project_id\u0027)"},{"line_number":6316,"context_line":"            ctx.session.add(network)"},{"line_number":6317,"context_line":"            with lib_db_api.autonested_transaction(ctx.session):"},{"line_number":6318,"context_line":"                sg \u003d sg_models.SecurityGroup(name\u003d\u0027sg\u0027, description\u003d\u0027sg\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_be332061","line":6315,"range":{"start_line":6315,"start_character":16,"end_line":6315,"end_character":39},"updated":"2018-10-10 20:39:28.000000000","message":"This change looks unrelated.","commit_id":"5ba05db861afef78582ecf5240c163fc56035ae3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1ac15dd9f9d268ef8af3f91a809a93ef87a1f68a","unresolved":false,"context_lines":[{"line_number":6312,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":6313,"context_line":"            network \u003d models_v2.Network("},{"line_number":6314,"context_line":"                name\u003d\u0027net_net\u0027, status\u003d\u0027OK\u0027, admin_state_up\u003dTrue,"},{"line_number":6315,"context_line":"                project_id\u003d\u0027project_id\u0027)"},{"line_number":6316,"context_line":"            ctx.session.add(network)"},{"line_number":6317,"context_line":"            with lib_db_api.autonested_transaction(ctx.session):"},{"line_number":6318,"context_line":"                sg \u003d sg_models.SecurityGroup(name\u003d\u0027sg\u0027, description\u003d\u0027sg\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_8007b0c8","line":6315,"range":{"start_line":6315,"start_character":16,"end_line":6315,"end_character":39},"in_reply_to":"3f79a3b5_369726ee","updated":"2018-10-12 17:20:43.000000000","message":"Actually we need this to build the NetworkRBAC object","commit_id":"5ba05db861afef78582ecf5240c163fc56035ae3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"315f0819a8cb8b4ed86fc97bf507fa26eebe1ae8","unresolved":false,"context_lines":[{"line_number":6312,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":6313,"context_line":"            network \u003d models_v2.Network("},{"line_number":6314,"context_line":"                name\u003d\u0027net_net\u0027, status\u003d\u0027OK\u0027, admin_state_up\u003dTrue,"},{"line_number":6315,"context_line":"                project_id\u003d\u0027project_id\u0027)"},{"line_number":6316,"context_line":"            ctx.session.add(network)"},{"line_number":6317,"context_line":"            with lib_db_api.autonested_transaction(ctx.session):"},{"line_number":6318,"context_line":"                sg \u003d sg_models.SecurityGroup(name\u003d\u0027sg\u0027, description\u003d\u0027sg\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_369726ee","line":6315,"range":{"start_line":6315,"start_character":16,"end_line":6315,"end_character":39},"in_reply_to":"3f79a3b5_be332061","updated":"2018-10-11 14:04:02.000000000","message":"Done","commit_id":"5ba05db861afef78582ecf5240c163fc56035ae3"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"bea5dd9d6ef4b28c19115a9996f376296087cc16","unresolved":false,"context_lines":[{"line_number":6322,"context_line":"            network_obj.NetworkRBAC("},{"line_number":6323,"context_line":"                ctx, object_id\u003dnetwork.id,"},{"line_number":6324,"context_line":"                action\u003d\u0027access_as_shared\u0027,"},{"line_number":6325,"context_line":"                project_id\u003dnetwork.project_id,"},{"line_number":6326,"context_line":"                target_tenant\u003d\u0027*\u0027).create()"},{"line_number":6327,"context_line":"            net2 \u003d models_v2.Network(name\u003d\"net_net2\", status\u003d\"OK\","},{"line_number":6328,"context_line":"                                     admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5e3a0c35","line":6325,"range":{"start_line":6325,"start_character":35,"end_line":6325,"end_character":45},"updated":"2018-10-10 20:39:28.000000000","message":"tenant_id","commit_id":"5ba05db861afef78582ecf5240c163fc56035ae3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"315f0819a8cb8b4ed86fc97bf507fa26eebe1ae8","unresolved":false,"context_lines":[{"line_number":6322,"context_line":"            network_obj.NetworkRBAC("},{"line_number":6323,"context_line":"                ctx, object_id\u003dnetwork.id,"},{"line_number":6324,"context_line":"                action\u003d\u0027access_as_shared\u0027,"},{"line_number":6325,"context_line":"                project_id\u003dnetwork.project_id,"},{"line_number":6326,"context_line":"                target_tenant\u003d\u0027*\u0027).create()"},{"line_number":6327,"context_line":"            net2 \u003d models_v2.Network(name\u003d\"net_net2\", status\u003d\"OK\","},{"line_number":6328,"context_line":"                                     admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d697d2e9","line":6325,"range":{"start_line":6325,"start_character":35,"end_line":6325,"end_character":45},"in_reply_to":"3f79a3b5_5e3a0c35","updated":"2018-10-11 14:04:02.000000000","message":"Done","commit_id":"5ba05db861afef78582ecf5240c163fc56035ae3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1ac15dd9f9d268ef8af3f91a809a93ef87a1f68a","unresolved":false,"context_lines":[{"line_number":6322,"context_line":"            network_obj.NetworkRBAC("},{"line_number":6323,"context_line":"                ctx, object_id\u003dnetwork.id,"},{"line_number":6324,"context_line":"                action\u003d\u0027access_as_shared\u0027,"},{"line_number":6325,"context_line":"                project_id\u003dnetwork.project_id,"},{"line_number":6326,"context_line":"                target_tenant\u003d\u0027*\u0027).create()"},{"line_number":6327,"context_line":"            net2 \u003d models_v2.Network(name\u003d\"net_net2\", status\u003d\"OK\","},{"line_number":6328,"context_line":"                                     admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_c00128b7","line":6325,"range":{"start_line":6325,"start_character":35,"end_line":6325,"end_character":45},"in_reply_to":"3f79a3b5_d697d2e9","updated":"2018-10-12 17:20:43.000000000","message":"tenant_id is deprecated. Every DB object with project ID, project_id \u003d\u003d tenant_id","commit_id":"5ba05db861afef78582ecf5240c163fc56035ae3"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3d516dd2449d40f8ee00420d346d426199d3169c","unresolved":false,"context_lines":[{"line_number":2703,"context_line":"    def test_update_network_set_not_shared_other_tenant_access_via_rbac(self):"},{"line_number":2704,"context_line":"        with self.network(shared\u003dTrue) as network:"},{"line_number":2705,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":2706,"context_line":"            with db_api.context_manager.writer.using(ctx):"},{"line_number":2707,"context_line":"                network_obj.NetworkRBAC("},{"line_number":2708,"context_line":"                    ctx, object_id\u003dnetwork[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2709,"context_line":"                    action\u003d\u0027access_as_shared\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b066d654","line":2706,"range":{"start_line":2706,"start_character":11,"end_line":2706,"end_character":58},"updated":"2018-10-11 16:55:54.000000000","message":"is this needed ?","commit_id":"e26fcc88d0bc6cdc75ff13f3408ce25cf4032e4a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e259aaf002e7ebdcdda50e89d8d8d4221a7fa39f","unresolved":false,"context_lines":[{"line_number":2703,"context_line":"    def test_update_network_set_not_shared_other_tenant_access_via_rbac(self):"},{"line_number":2704,"context_line":"        with self.network(shared\u003dTrue) as network:"},{"line_number":2705,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":2706,"context_line":"            with db_api.context_manager.writer.using(ctx):"},{"line_number":2707,"context_line":"                network_obj.NetworkRBAC("},{"line_number":2708,"context_line":"                    ctx, object_id\u003dnetwork[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2709,"context_line":"                    action\u003d\u0027access_as_shared\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b9f78cd1","line":2706,"range":{"start_line":2706,"start_character":11,"end_line":2706,"end_character":58},"in_reply_to":"3f79a3b5_b066d654","updated":"2018-10-12 14:34:37.000000000","message":"Not in UT","commit_id":"e26fcc88d0bc6cdc75ff13f3408ce25cf4032e4a"}]}