)]}'
{"neutron/agent/l3/dvr_edge_ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"70d3566729ad713b57527e299dacda41052dbdc8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        return self.agent_conf.agent_mode \u003d\u003d constants.L3_AGENT_MODE_DVR_SNAT"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def update_routing_table(self, operation, route):"},{"line_number":124,"context_line":"        super(DvrEdgeHaRouter, self).update_routing_table(operation, route)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _dvr_internal_network_removed(self, port):"},{"line_number":127,"context_line":"        super(DvrEdgeHaRouter, self)._dvr_internal_network_removed(port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_59d1cef7","line":124,"updated":"2018-10-10 15:48:50.000000000","message":"Why didn\u0027t this just happen automatically with class inheritance?  Is it because the multiple classes?","commit_id":"d1f45ce2126f422014f7a2ccbf7b7d6de174d28f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"2337a7f71ca3cd3a4c2d965861ec80e955da0b7b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        return self.agent_conf.agent_mode \u003d\u003d constants.L3_AGENT_MODE_DVR_SNAT"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def update_routing_table(self, operation, route):"},{"line_number":124,"context_line":"        super(DvrEdgeHaRouter, self).update_routing_table(operation, route)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _dvr_internal_network_removed(self, port):"},{"line_number":127,"context_line":"        super(DvrEdgeHaRouter, self)._dvr_internal_network_removed(port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4f1260ff","line":124,"in_reply_to":"3f79a3b5_59d1cef7","updated":"2018-10-10 17:00:19.000000000","message":"That\u0027s what I think?","commit_id":"d1f45ce2126f422014f7a2ccbf7b7d6de174d28f"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"70d3566729ad713b57527e299dacda41052dbdc8","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"        self._setup_dvr_router_static_routes()"},{"line_number":1575,"context_line":""},{"line_number":1576,"context_line":"    def test_dvr_ha_rtr_static_routes_in_rtr_namespace("},{"line_number":1577,"context_line":"        self):"},{"line_number":1578,"context_line":"        self._setup_dvr_router_static_routes(enable_ha\u003dTrue)"},{"line_number":1579,"context_line":""},{"line_number":1580,"context_line":"    def test_dvr_router_rule_and_route_table_cleared_when_fip_removed("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_596eae64","line":1577,"updated":"2018-10-10 15:48:50.000000000","message":"nit: this could be on previous line","commit_id":"d1f45ce2126f422014f7a2ccbf7b7d6de174d28f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"2337a7f71ca3cd3a4c2d965861ec80e955da0b7b","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"        self._setup_dvr_router_static_routes()"},{"line_number":1575,"context_line":""},{"line_number":1576,"context_line":"    def test_dvr_ha_rtr_static_routes_in_rtr_namespace("},{"line_number":1577,"context_line":"        self):"},{"line_number":1578,"context_line":"        self._setup_dvr_router_static_routes(enable_ha\u003dTrue)"},{"line_number":1579,"context_line":""},{"line_number":1580,"context_line":"    def test_dvr_router_rule_and_route_table_cleared_when_fip_removed("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cfdbd04b","line":1577,"in_reply_to":"3f79a3b5_596eae64","updated":"2018-10-10 17:00:19.000000000","message":"Sure if I rebase it I will fix it.","commit_id":"d1f45ce2126f422014f7a2ccbf7b7d6de174d28f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c3f5e5dd350114db15f142a467f65dab894506b2","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"            self._assert_extra_routes(router_updated)"},{"line_number":1484,"context_line":"        elif router_namespace and not enable_ha:"},{"line_number":1485,"context_line":"            self._assert_extra_routes(router_updated)"},{"line_number":1486,"context_line":"            self._assert_extra_routes(router_updated, namespace\u003dsnat_ns_name)"},{"line_number":1487,"context_line":"        elif not router_namespace:"},{"line_number":1488,"context_line":"            rtr_2_fip, fip_2_rtr \u003d router_updated.rtr_fip_subnet.get_pair()"},{"line_number":1489,"context_line":"            # Now get the table index based on the fpr-interface ip."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5916785a","line":1486,"updated":"2018-10-12 15:00:53.000000000","message":"nit: we\u0027re duplicating lines here, this could be:\n\nif router_namespace:\n    self._assert_extra_routes(router_updated)                           \n    if not enable_ha:                                                   \n        self._assert_extra_routes(router_updated,                       \n                                  namespace\u003dsnat_ns_name)\nelse:\n    ...\n\nI\u0027ll send a quick update.","commit_id":"ae52b618c0c08fb399a801157540ca1afaab2c38"}]}
