)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa21eb8b3e4f62f397ff73d0afa0afd35776646","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"filter \"updated_at\" and \"revision_number\" in _gateway_ports_equal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the router ha changed, the code determines whether"},{"line_number":10,"context_line":"the gateway in memory is consistent with the gateway"},{"line_number":11,"context_line":"in the database to decide whether it needs to be reconfigured."},{"line_number":12,"context_line":"But there are problems with the judging conditions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_3e754687","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":18},"updated":"2018-11-13 12:03:47.000000000","message":"You are referring to the same concept, \"HA router\", with three different terms: \"router ha\", \"router HA\" (L14) and \"router_ha\" (L17). Please, be consistent.","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c29fe194fc4d4ed7963ac05c6fcbc1e49598f2df","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        callback(self.router_id, state)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    @staticmethod"},{"line_number":406,"context_line":"    def _gateway_ports_equal(port1, port2):"},{"line_number":407,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":408,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5900df35","line":406,"range":{"start_line":406,"start_character":36,"end_line":406,"end_character":41},"updated":"2018-10-11 06:42:54.000000000","message":"Does this port include the attribute \u0027revision_number\u0027, if this is increased with nothing else. IMO, the following check can also be not equal.","commit_id":"adb70a2b98a835ed7b63a4ed71b68c460d20498d"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"7cce12384f03460f66f0ca9908b057652e3d5d1f","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        callback(self.router_id, state)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    @staticmethod"},{"line_number":406,"context_line":"    def _gateway_ports_equal(port1, port2):"},{"line_number":407,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":408,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4b6d6665","line":406,"range":{"start_line":406,"start_character":36,"end_line":406,"end_character":41},"in_reply_to":"3f79a3b5_5900df35","updated":"2018-10-11 07:36:55.000000000","message":"Yes, \"revision_number\" is included, and increased with nothing else.\nso can we filter it same as \"updated_at\"?","commit_id":"adb70a2b98a835ed7b63a4ed71b68c460d20498d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c29fe194fc4d4ed7963ac05c6fcbc1e49598f2df","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":408,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, \u0027updated_at\u0027])"},{"line_number":411,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":412,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":413,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_79827ba7","line":410,"range":{"start_line":410,"start_character":53,"end_line":410,"end_character":63},"updated":"2018-10-11 06:42:54.000000000","message":"What about import this from neutron.extensions.timestamp and use that UPDATED instead?","commit_id":"adb70a2b98a835ed7b63a4ed71b68c460d20498d"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"7cce12384f03460f66f0ca9908b057652e3d5d1f","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":408,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, \u0027updated_at\u0027])"},{"line_number":411,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":412,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":413,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_eb27921d","line":410,"range":{"start_line":410,"start_character":53,"end_line":410,"end_character":63},"in_reply_to":"3f79a3b5_79827ba7","updated":"2018-10-11 07:36:55.000000000","message":"Done","commit_id":"adb70a2b98a835ed7b63a4ed71b68c460d20498d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c053fb5cee43e459409e03ee48d1cddfc980313a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":29,"context_line":"from neutron.agent.linux import keepalived"},{"line_number":30,"context_line":"from neutron.common import utils as common_utils"},{"line_number":31,"context_line":"from neutron.extensions.revisions import REVISION"},{"line_number":32,"context_line":"from neutron.extensions.timestamp import UPDATED"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_aec44895","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":33},"updated":"2018-10-11 08:09:57.000000000","message":"We only import things in the package level, aka you should do it like this:\n\"from neutron.extensions import revisions as ext_revisions\"\nand then use the \"ext_revisions.REVISION\" in the following code.","commit_id":"28bfc3094cb66e7d8e46469ee15877075812928a"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"60282d5ee68eb16f9f559b7b5da64db7d23b98bf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":29,"context_line":"from neutron.agent.linux import keepalived"},{"line_number":30,"context_line":"from neutron.common import utils as common_utils"},{"line_number":31,"context_line":"from neutron.extensions.revisions import REVISION"},{"line_number":32,"context_line":"from neutron.extensions.timestamp import UPDATED"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c16dd5cb","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":33},"in_reply_to":"3f79a3b5_aec44895","updated":"2018-10-11 08:46:34.000000000","message":"Done","commit_id":"28bfc3094cb66e7d8e46469ee15877075812928a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c053fb5cee43e459409e03ee48d1cddfc980313a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.agent.linux import keepalived"},{"line_number":30,"context_line":"from neutron.common import utils as common_utils"},{"line_number":31,"context_line":"from neutron.extensions.revisions import REVISION"},{"line_number":32,"context_line":"from neutron.extensions.timestamp import UPDATED"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"HA_DEV_PREFIX \u003d \u0027ha-\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8ebf0cfb","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":48},"updated":"2018-10-11 08:09:57.000000000","message":"ditto","commit_id":"28bfc3094cb66e7d8e46469ee15877075812928a"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"60282d5ee68eb16f9f559b7b5da64db7d23b98bf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.agent.linux import keepalived"},{"line_number":30,"context_line":"from neutron.common import utils as common_utils"},{"line_number":31,"context_line":"from neutron.extensions.revisions import REVISION"},{"line_number":32,"context_line":"from neutron.extensions.timestamp import UPDATED"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"HA_DEV_PREFIX \u003d \u0027ha-\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a168d9bb","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"3f79a3b5_8ebf0cfb","updated":"2018-10-11 08:46:34.000000000","message":"Done","commit_id":"28bfc3094cb66e7d8e46469ee15877075812928a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c053fb5cee43e459409e03ee48d1cddfc980313a","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":410,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, UPDATED, REVISION])"},{"line_number":413,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":414,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":415,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_aeebe80e","line":412,"range":{"start_line":412,"start_character":52,"end_line":412,"end_character":69},"updated":"2018-10-11 08:09:57.000000000","message":"Please add some test case to see if there are any other attribute can influence the check blow.","commit_id":"28bfc3094cb66e7d8e46469ee15877075812928a"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"37b46550b32557f572b5a5d7c10af34bc8a7046f","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":410,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, UPDATED, REVISION])"},{"line_number":413,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":414,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":415,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0bff0335","line":412,"range":{"start_line":412,"start_character":52,"end_line":412,"end_character":69},"in_reply_to":"3f79a3b5_aeebe80e","updated":"2018-11-12 06:44:45.000000000","message":"Done","commit_id":"28bfc3094cb66e7d8e46469ee15877075812928a"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"60282d5ee68eb16f9f559b7b5da64db7d23b98bf","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":410,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, UPDATED, REVISION])"},{"line_number":413,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":414,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":415,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_41aea5e4","line":412,"range":{"start_line":412,"start_character":52,"end_line":412,"end_character":69},"in_reply_to":"3f79a3b5_aeebe80e","updated":"2018-10-11 08:46:34.000000000","message":"Router gateway data is obtained from database, and UT is not easy to simulate.","commit_id":"28bfc3094cb66e7d8e46469ee15877075812928a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa21eb8b3e4f62f397ff73d0afa0afd35776646","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, timestamp.UPDATED,"},{"line_number":414,"context_line":"                              revisions.REVISION])"},{"line_number":415,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":416,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":417,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5ea122f6","line":414,"updated":"2018-11-13 12:03:47.000000000","message":"If those ports are in two different hosts, all standard attributes (version, created_at, updated_at, description) can be different too.","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"040fb95ef66f811141e9e7fb379cf05a7b3973b0","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, timestamp.UPDATED,"},{"line_number":414,"context_line":"                              revisions.REVISION])"},{"line_number":415,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":416,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":417,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_d0b3cf0b","line":414,"in_reply_to":"3f79a3b5_204d18c6","updated":"2018-11-14 09:09:10.000000000","message":"Are port1 and port2 the same port but updated or are different ports?","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"9c9d93467c15efff84fe6c03f10e4206c4af370f","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, timestamp.UPDATED,"},{"line_number":414,"context_line":"                              revisions.REVISION])"},{"line_number":415,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":416,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":417,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_204d18c6","line":414,"in_reply_to":"3f79a3b5_5ea122f6","updated":"2018-11-14 02:17:22.000000000","message":"Can you explain why create_at and description change when port host changes?","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"d32d81a27d5a5e9c64d0b2e1fc86af87a771787f","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, timestamp.UPDATED,"},{"line_number":414,"context_line":"                              revisions.REVISION])"},{"line_number":415,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":416,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":417,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_e32ac72c","line":414,"in_reply_to":"3f79a3b5_d0b3cf0b","updated":"2018-11-14 09:22:55.000000000","message":"They are same ports but updated.","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b53220a2f27d3d0a649ef94f6570080440777d3c","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":411,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, timestamp.UPDATED,"},{"line_number":414,"context_line":"                              revisions.REVISION])"},{"line_number":415,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":416,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":417,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_98a9ee79","line":414,"range":{"start_line":413,"start_character":52,"end_line":414,"end_character":48},"updated":"2018-11-15 05:03:25.000000000","message":"Yes, I think Rodolfo\u0027s comments give me a reminder for this. Port can have a variety of extensions, such as QoS. So if port change the qos_policy_id, IPs (for L3 view) do not change, here will also consider it is not equal. That port qos policy is not ralated to L3,  right? This can be more generic.","commit_id":"4a4d7ce5ec16442395ba86baba5a81407d0926ed"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"f357e554767ebe02421566df907036a385e26d25","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        def _get_filtered_dict(d, ignore):"},{"line_number":411,"context_line":"            return {k: v for k, v in d.items() if k not in ignore}"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        keys_to_ignore \u003d set([portbindings.HOST_ID, timestamp.UPDATED,"},{"line_number":414,"context_line":"                              revisions.REVISION])"},{"line_number":415,"context_line":"        port1_filtered \u003d _get_filtered_dict(port1, keys_to_ignore)"},{"line_number":416,"context_line":"        port2_filtered \u003d _get_filtered_dict(port2, keys_to_ignore)"},{"line_number":417,"context_line":"        return port1_filtered \u003d\u003d port2_filtered"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_efb90117","line":414,"range":{"start_line":413,"start_character":52,"end_line":414,"end_character":48},"in_reply_to":"3f79a3b5_98a9ee79","updated":"2018-11-20 02:33:42.000000000","message":"By consulting the code, I found that all port (except floating IP) set QoS to be processed on ml2-agent. The qos_policy_id field of port can bind the QoS policy, but if the policy rule changes, it is really impossible to find it through the _gateway_ports_equal method here, but it should not be judged here.","commit_id":"4a4d7ce5ec16442395ba86baba5a81407d0926ed"}],"neutron/tests/unit/agent/l3/test_ha_router.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7d5e79f2a90ffb94b99d25deb006c5b1877284e8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_82352da9","line":164,"updated":"2018-11-12 13:58:03.000000000","message":"PEP8 check failed here:\n\"\"\"\n \"./neutron/tests/unit/agent/l3/test_ha_router.py:164:1: W391 blank line at end of file\",\n                                    \"\",\n                                    \"^\",\n\"\"\"","commit_id":"e1a20fa4b5f5788b2f5f9c0d57fa0593b4c3c116"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"1287de513476e78c1784e36df07722da4444cd60","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_daf0e596","line":164,"in_reply_to":"3f79a3b5_82352da9","updated":"2018-11-13 01:29:17.000000000","message":"Done","commit_id":"e1a20fa4b5f5788b2f5f9c0d57fa0593b4c3c116"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c302d1b48854389214aae6e6e22296dbca3ccf7c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                       \u0027binding:host_id\u0027: \u0027node02\u0027,"},{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_c3fb2014","line":163,"updated":"2018-11-13 08:28:02.000000000","message":"ok, but maybe You can also add test case where two ports will be different and You will also assert that?","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"040fb95ef66f811141e9e7fb379cf05a7b3973b0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                       \u0027binding:host_id\u0027: \u0027node02\u0027,"},{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a31e0f5c","line":163,"in_reply_to":"3f79a3b5_607a30f0","updated":"2018-11-14 09:09:10.000000000","message":"For sure, you retrieve this information in the agent through the RPC calls. What is the information you receive? You receive this information form \"L3_NAT_dbonly_mixim._get_sync_routers\". There \"_make_router_dict_with_gw_port\" is called. In this function, router[\u0027gw_port\u0027] is populated reading the port object and calling \"core_plugin._make_port_dict\". There you have how a port dict is created. This is the information contained (including extensions extra parameters).","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"9c9d93467c15efff84fe6c03f10e4206c4af370f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                       \u0027binding:host_id\u0027: \u0027node02\u0027,"},{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_607a30f0","line":163,"in_reply_to":"3f79a3b5_9e97ba9c","updated":"2018-11-14 02:17:22.000000000","message":"Thank you for your review.\nAgent is only used to receive RPC requests sent from server. The format is all dictionary type.\nI have seen other UT, and the gateway objects are also simulated by dictionary.\n\nAnd this UT is only used to confirm whether the \"revision_number\", \"update_at\" and \"binding: host_id\" objects can be filtered properly. I think it can achieve the goal.","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":22016,"name":"hujin","email":"guokehujin@163.com","username":"hujin"},"change_message_id":"f357e554767ebe02421566df907036a385e26d25","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                       \u0027binding:host_id\u0027: \u0027node02\u0027,"},{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_6fe5f13c","line":163,"in_reply_to":"3f79a3b5_a31e0f5c","updated":"2018-11-20 02:33:42.000000000","message":"This process is correct, I also understand, but L3 agent obtains gateway information by acquiring router list information at regular intervals, it is impossible to obtain gateway information alone. By printing gateway port information, I found that only this three fields were allowed to be updated and were not perceived by the user.","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa21eb8b3e4f62f397ff73d0afa0afd35776646","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                       \u0027binding:host_id\u0027: \u0027node02\u0027,"},{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_9e97ba9c","line":163,"in_reply_to":"3f79a3b5_c3fb2014","updated":"2018-11-13 12:03:47.000000000","message":"Actually, IMO, two port objects should be created (not only a dict) and then converted to dict using \"to_dict\" method.","commit_id":"3287434084e904ab5671bcf9c1974006897b2c7f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d222732659d4c9c403c3e4be7077704bb3ba2fc2","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                       \u0027binding:host_id\u0027: \u0027node02\u0027,"},{"line_number":161,"context_line":"                       \u0027updated_at\u0027: \u00272018-11-02T14:07:00\u0027,"},{"line_number":162,"context_line":"                       \u0027revision_number\u0027: 101}"},{"line_number":163,"context_line":"        self.assertNotEqual(old_gw_port, new_gw_port)"},{"line_number":164,"context_line":"        self.assertTrue(ri._gateway_ports_equal(old_gw_port, new_gw_port))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_30cfa355","line":163,"updated":"2018-11-14 08:44:37.000000000","message":"I was thinking about something else, like additional test case where old_gw_port and new_gw_port would have some field (like e.g. fixed_ips) different and You will check that ri._gateway_ports_equal() will return false for them. Just to ensure that it\u0027s not returning True all the time :)","commit_id":"741f7b95295c96981b383a9112b2373d57798881"}]}
