)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"98154f2c834131ddc4cdc76d26737ae4abc262fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-10 15:54:48 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable to set dhcp port attributes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9kCA%3D","line":7,"updated":"2013-12-10 08:00:00.000000000","message":"pls fix the pep8 error for the commit info\n\n$ ./run_tests.sh -N -p\nRunning flake8 ...\n./setup.py:1:1: H803  git commit title (\u0027Enable to set dhcp port attributes.\u0027) should not end with period\n#!/usr/bin/env python\n^","commit_id":"469b080ab0bfc774e998d534190bb8f5772cab58"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d8f3a9b93391ca859166219ff8551dd8205c327f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-10 17:40:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable to set dhcp port attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9HTU%3D","line":7,"updated":"2013-12-16 17:19:34.000000000","message":"I am not 100% sure why a tenant would ever want to specify the IP/MAC for the dhcp port, as this is fully managed by the infrastructure. Could you elaborate? Without a proper justification I find hard to consider this as a sensible addition to the dhcp functionality that Neutron already provides.","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8c6bc97d897937e891a1805bcf3e6fc45bd614af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-10 17:40:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable to set dhcp port attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9FVY%3D","line":7,"in_reply_to":"AAAATn%2F9HTU%3D","updated":"2013-12-16 23:21:24.000000000","message":"Ports other than dhcp ports (VM ports, router interfaces, vips etc) can be specified ip/mac by a user. Why only dhcp ports can not be specified ?\n\nThere is a customer who does not want to assign ip address of a dhcp port by system.","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d8f3a9b93391ca859166219ff8551dd8205c327f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable to set dhcp port attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add dhcp port attributes parameter to \"add network to dhcp agent\" API."},{"line_number":12,"context_line":"If the parameter is specifyed a dhcp port will be created with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9HUE%3D","line":9,"updated":"2013-12-16 17:19:34.000000000","message":"Do we need a client-side patch to introduce a way to augment the operation?","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8c6bc97d897937e891a1805bcf3e6fc45bd614af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable to set dhcp port attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add dhcp port attributes parameter to \"add network to dhcp agent\" API."},{"line_number":12,"context_line":"If the parameter is specifyed a dhcp port will be created with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9FVU%3D","line":9,"in_reply_to":"AAAATn%2F9HUE%3D","updated":"2013-12-16 23:21:24.000000000","message":"Yes. I don\u0027t think an explicit option is not necessary but supporting \u0027value_specs\u0027 is enough.","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d8f3a9b93391ca859166219ff8551dd8205c327f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add dhcp port attributes parameter to \"add network to dhcp agent\" API."},{"line_number":12,"context_line":"If the parameter is specifyed a dhcp port will be created with the"},{"line_number":13,"context_line":"specified attributes when the network is attached to the dhcp agent."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8071dd43a4371338523a0a9028045e6d054e75b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9HUg%3D","line":12,"updated":"2013-12-16 17:19:34.000000000","message":"if I understand correctly, this blueprint extends the current API, but I couldn\u0027t see changes made to the agent extension. Is this patch meant to be a standalone patch?","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fda56a97c104a029dc4314f29259778fdbd23484","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add dhcp port attributes parameter to \"add network to dhcp agent\" API."},{"line_number":12,"context_line":"If the parameter is specifyed a dhcp port will be created with the"},{"line_number":13,"context_line":"specified attributes when the network is attached to the dhcp agent."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8071dd43a4371338523a0a9028045e6d054e75b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F86Is%3D","line":12,"in_reply_to":"AAAATn%2F9FVQ%3D","updated":"2013-12-30 22:51:51.000000000","message":"I meant the API agent schema","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8c6bc97d897937e891a1805bcf3e6fc45bd614af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements blueprint enable-to-set-dhcp-port-attributes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add dhcp port attributes parameter to \"add network to dhcp agent\" API."},{"line_number":12,"context_line":"If the parameter is specifyed a dhcp port will be created with the"},{"line_number":13,"context_line":"specified attributes when the network is attached to the dhcp agent."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8071dd43a4371338523a0a9028045e6d054e75b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9FVQ%3D","line":12,"in_reply_to":"AAAATn%2F9HUg%3D","updated":"2013-12-16 23:21:24.000000000","message":"dhcpagentscheduler.py is modified.","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"8e2ae6d1e3b03cc2e2b1d5bf00f11620adc389ef","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.agent.linux import utils"},{"line_number":32,"context_line":"from neutron.common import constants"},{"line_number":33,"context_line":"from neutron.common import exceptions"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.openstack.common import importutils"},{"line_number":36,"context_line":"from neutron.openstack.common import jsonutils"},{"line_number":37,"context_line":"from neutron.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B0c0%3D","line":34,"updated":"2014-01-21 19:16:59.000000000","message":"We should try to avoid making this module dependent on anything the db submodule.","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"17fa6c72ee81f6bead03960ffbf68a68e0a9e5ea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.agent.linux import utils"},{"line_number":32,"context_line":"from neutron.common import constants"},{"line_number":33,"context_line":"from neutron.common import exceptions"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.openstack.common import importutils"},{"line_number":36,"context_line":"from neutron.openstack.common import jsonutils"},{"line_number":37,"context_line":"from neutron.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BzRI%3D","line":34,"in_reply_to":"AAAAUH%2F%2B0c0%3D","updated":"2014-01-22 00:27:46.000000000","message":"move get_dhcp_agent_device_id() to here from agentschedulers_db and agentschedulers_db.py refers neutron.agent.linux.dhcp.\nIs it OK?","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"}],"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"98154f2c834131ddc4cdc76d26737ae4abc262fc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from sqlalchemy import orm"},{"line_number":21,"context_line":"from sqlalchemy.orm import exc"},{"line_number":22,"context_line":"from sqlalchemy.orm import joinedload"},{"line_number":23,"context_line":"import uuid"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron.api.v2 import attributes"},{"line_number":26,"context_line":"from neutron.common import constants"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9kBQ%3D","line":23,"updated":"2013-12-10 08:00:00.000000000","message":"pls move the system module \"uuid\" before the third modules accroding to the code specification.","commit_id":"469b080ab0bfc774e998d534190bb8f5772cab58"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d8f3a9b93391ca859166219ff8551dd8205c327f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                #       since create_port may take a long time."},{"line_number":173,"context_line":"                self.create_dhcp_port(context, network_id, agent_db[\u0027host\u0027],"},{"line_number":174,"context_line":"                                      dhcp_port)"},{"line_number":175,"context_line":"            except Exception:"},{"line_number":176,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":177,"context_line":"                    context.session.begin()"},{"line_number":178,"context_line":"                    context.session.delete(binding)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9HYs%3D","line":175,"updated":"2013-12-16 17:19:34.000000000","message":"please refrain from catching all exceptions, it\u0027s best to catch the ones you care about and are not introduced by programming errors, bad inputs etc.","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8c6bc97d897937e891a1805bcf3e6fc45bd614af","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                #       since create_port may take a long time."},{"line_number":173,"context_line":"                self.create_dhcp_port(context, network_id, agent_db[\u0027host\u0027],"},{"line_number":174,"context_line":"                                      dhcp_port)"},{"line_number":175,"context_line":"            except Exception:"},{"line_number":176,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":177,"context_line":"                    context.session.begin()"},{"line_number":178,"context_line":"                    context.session.delete(binding)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9FUQ%3D","line":175,"in_reply_to":"AAAATn%2F9HYs%3D","updated":"2013-12-16 23:21:24.000000000","message":"exception reraises. I think deleting a record is necessary for any error.","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"d655998fbed92c401896d4783201baa7f01538a6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        dhcp_notifier \u003d self.agent_notifiers.get(constants.AGENT_TYPE_DHCP)"},{"line_number":182,"context_line":"        if dhcp_notifier:"},{"line_number":183,"context_line":"            dhcp_notifier.network_added_to_agent("},{"line_number":184,"context_line":"                context, network_id, agent_db.host)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def remove_network_from_dhcp_agent(self, context, id, network_id):"},{"line_number":187,"context_line":"        agent \u003d self._get_agent(context, id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9js4%3D","line":184,"updated":"2013-12-10 09:18:43.000000000","message":"should line 706 in the file $neutron/agent/linux/dhcp.py (dhcp_port \u003d self.plugin.create_dhcp_port({\u0027port\u0027: port_dict})) also use dhcp_port parameter ?","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f523669b645c28f162862b71b970569746911894","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        dhcp_notifier \u003d self.agent_notifiers.get(constants.AGENT_TYPE_DHCP)"},{"line_number":182,"context_line":"        if dhcp_notifier:"},{"line_number":183,"context_line":"            dhcp_notifier.network_added_to_agent("},{"line_number":184,"context_line":"                context, network_id, agent_db.host)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def remove_network_from_dhcp_agent(self, context, id, network_id):"},{"line_number":187,"context_line":"        agent \u003d self._get_agent(context, id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9jlw%3D","line":184,"in_reply_to":"AAAATn%2F9js4%3D","updated":"2013-12-10 09:41:45.000000000","message":"I think  whether \u0027pass the parameter to dhcp_agent\u0027 or \u0027create the port before notifying to dhcp_agent\u0027 is implementation decision.\n\nIt is hard to bring up dhcp_port parameter to setup_dhcp_port() (which you mentioned) under current dhcp_agent implementation.\nIt is easy to create dhcp port before notifying to dhcp_agent. \n\nIs this an answer for your question ?","commit_id":"aa64021a1a60d311041648fdfa8f87ec587117b5"}]}
