)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a36f5281d149298d730724448028c62f1af27732","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        subnet."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        # Grab all allocation pools for the subnet"},{"line_number":328,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":329,"context_line":"            models_v2.IPAllocationPool).with_lockmode(\u0027update\u0027)"},{"line_number":330,"context_line":"        allocation_pools \u003d pool_qry.filter_by(subnet_id\u003dsubnet_id)"},{"line_number":331,"context_line":"        # If there are no available ranges the previous query will return no"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9js8%3D","line":328,"updated":"2013-12-10 09:19:18.000000000","message":"nitpicking:\n\n  Why not using fullnames \"query\" vs \"qry\" , it will save 1-2 seconds when reading the code, and adds clarity.","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"37ff01afb2fb91f11054e39414652486daaa7dc9","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        subnet."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        # Grab all allocation pools for the subnet"},{"line_number":328,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":329,"context_line":"            models_v2.IPAllocationPool).with_lockmode(\u0027update\u0027)"},{"line_number":330,"context_line":"        allocation_pools \u003d pool_qry.filter_by(subnet_id\u003dsubnet_id)"},{"line_number":331,"context_line":"        # If there are no available ranges the previous query will return no"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F84Zs%3D","line":328,"in_reply_to":"AAAATn%2F8%2FGI%3D","updated":"2013-12-19 08:18:36.000000000","message":"Yes, I understand your point.\n\nBut that others didn\u0027t do it as good as they could (_qry is obscure) , doesn\u0027t mean that you can.\n\nI think _query describes exactly the contents, while _qry is open for guessing...","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"0575ae6b8bedef8a366be799e2cc482e04b0f243","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        subnet."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        # Grab all allocation pools for the subnet"},{"line_number":328,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":329,"context_line":"            models_v2.IPAllocationPool).with_lockmode(\u0027update\u0027)"},{"line_number":330,"context_line":"        allocation_pools \u003d pool_qry.filter_by(subnet_id\u003dsubnet_id)"},{"line_number":331,"context_line":"        # If there are no available ranges the previous query will return no"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F84WY%3D","line":328,"in_reply_to":"AAAATn%2F84Zs%3D","updated":"2013-12-19 08:30:23.000000000","message":"sure.many thanks,Miguel","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"9d10ab42f247fac96c7375bda8ea5870c46535ce","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        subnet."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        # Grab all allocation pools for the subnet"},{"line_number":328,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":329,"context_line":"            models_v2.IPAllocationPool).with_lockmode(\u0027update\u0027)"},{"line_number":330,"context_line":"        allocation_pools \u003d pool_qry.filter_by(subnet_id\u003dsubnet_id)"},{"line_number":331,"context_line":"        # If there are no available ranges the previous query will return no"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8%2FGI%3D","line":328,"in_reply_to":"AAAATn%2F9SrY%3D","updated":"2013-12-18 02:32:23.000000000","message":"hi,Miguel and dekehn ,thanks for the comments,actually this was the original code here, u can find it here https://review.openstack.org/#/c/35671/8/neutron/db/db_base_plugin_v2.py, later this part of code was modified in https://review.openstack.org/#/c/43305/3/neutron/db/db_base_plugin_v2.py. This change basically reverts this part of code + also modifies the lazy/eager load. So that is why I am not using the name pool_query. Thanks","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"35dca84924b186f2cf37471899db878f152fdb3d","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        subnet."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        # Grab all allocation pools for the subnet"},{"line_number":328,"context_line":"        pool_qry \u003d context.session.query("},{"line_number":329,"context_line":"            models_v2.IPAllocationPool).with_lockmode(\u0027update\u0027)"},{"line_number":330,"context_line":"        allocation_pools \u003d pool_qry.filter_by(subnet_id\u003dsubnet_id)"},{"line_number":331,"context_line":"        # If there are no available ranges the previous query will return no"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SrY%3D","line":328,"in_reply_to":"AAAATn%2F9js8%3D","updated":"2013-12-12 23:38:51.000000000","message":"given the international involvement I would prefer query, it leaves nothing to be guessed.","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"}],"neutron/db/models_v2.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"35dca84924b186f2cf37471899db878f152fdb3d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    last_ip \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":79,"context_line":"    available_ranges \u003d orm.relationship(IPAvailabilityRange,"},{"line_number":80,"context_line":"                                        backref\u003d\u0027ipallocationpool\u0027,"},{"line_number":81,"context_line":"                                        lazy\u003d\"select\","},{"line_number":82,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Sr0%3D","line":81,"updated":"2013-12-12 23:38:51.000000000","message":"nit: Is this necessary given that lazy\u003d\u0027select\u0027 is the default?","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"dc65e284eebe56daab48dacb49799b1ebdee2f33","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    last_ip \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":79,"context_line":"    available_ranges \u003d orm.relationship(IPAvailabilityRange,"},{"line_number":80,"context_line":"                                        backref\u003d\u0027ipallocationpool\u0027,"},{"line_number":81,"context_line":"                                        lazy\u003d\"select\","},{"line_number":82,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8sBg%3D","line":81,"in_reply_to":"AAAATn%2F84aM%3D","updated":"2013-12-23 07:33:27.000000000","message":"maybe we can use \"enable_eagerloads(False)\" to avoid to give that lazy\u003d\u0027select\u0027 as the default, after all there are lot of codes using lazy\u003d\"joined\"","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"37ff01afb2fb91f11054e39414652486daaa7dc9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    last_ip \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":79,"context_line":"    available_ranges \u003d orm.relationship(IPAvailabilityRange,"},{"line_number":80,"context_line":"                                        backref\u003d\u0027ipallocationpool\u0027,"},{"line_number":81,"context_line":"                                        lazy\u003d\"select\","},{"line_number":82,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F84aM%3D","line":81,"in_reply_to":"AAAATn%2F9PhE%3D","updated":"2013-12-19 08:18:36.000000000","message":"Understood :)","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"4d56af539638a5ea42b61eb75cb632b92608a266","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    last_ip \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":79,"context_line":"    available_ranges \u003d orm.relationship(IPAvailabilityRange,"},{"line_number":80,"context_line":"                                        backref\u003d\u0027ipallocationpool\u0027,"},{"line_number":81,"context_line":"                                        lazy\u003d\"select\","},{"line_number":82,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9PhE%3D","line":81,"in_reply_to":"AAAATn%2F9RYo%3D","updated":"2013-12-13 15:58:56.000000000","message":"yes, u r right. having it here makes people think it\u0027s not the default mode,but without it, people might not be aware of the mode here.Anyway, this is no big deal. thanks much","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1e3e830c3ceb66314a87d9d3f57a90f4db346ad6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    last_ip \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":79,"context_line":"    available_ranges \u003d orm.relationship(IPAvailabilityRange,"},{"line_number":80,"context_line":"                                        backref\u003d\u0027ipallocationpool\u0027,"},{"line_number":81,"context_line":"                                        lazy\u003d\"select\","},{"line_number":82,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9RYo%3D","line":81,"in_reply_to":"AAAATn%2F9SLc%3D","updated":"2013-12-13 08:42:50.000000000","message":"May be if it\u0027s the default we must favor compact/concise code. But I understand your point Jun.\n\nAlso having the lazy\u003d\"select\" here could make anyone think that it\u0027s not the default mode, and expect different things otherwise.\n\nCheers,","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"b1342499326d100969e95a1dd54ca8fe8fa8c6be","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    last_ip \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":79,"context_line":"    available_ranges \u003d orm.relationship(IPAvailabilityRange,"},{"line_number":80,"context_line":"                                        backref\u003d\u0027ipallocationpool\u0027,"},{"line_number":81,"context_line":"                                        lazy\u003d\"select\","},{"line_number":82,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SLc%3D","line":81,"in_reply_to":"AAAATn%2F9Sr0%3D","updated":"2013-12-13 02:24:01.000000000","message":"dekenhn, thanks for the comment. yes,u r right, that one is the default. I am leaving the line here so that reviewers know that it is turning to the default mode,which is \u0027select\u0027. Otherwise, they only see I have deleted one line, without knowing so clearly that the default \u0027select\u0027 mode is used here. so that is the reason I decided to keep it.","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"35dca84924b186f2cf37471899db878f152fdb3d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":123,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":124,"context_line":"                           nullable\u003dFalse)"},{"line_number":125,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027ports\u0027, lazy\u003d\u0027select\u0027)"},{"line_number":126,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"},{"line_number":127,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":128,"context_line":"    status \u003d sa.Column(sa.String(16), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Srk%3D","line":125,"updated":"2013-12-12 23:38:51.000000000","message":"nit: Is this necessary given that lazy\u003d\u0027select\u0027 is the default?","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"b1342499326d100969e95a1dd54ca8fe8fa8c6be","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":123,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":124,"context_line":"                           nullable\u003dFalse)"},{"line_number":125,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027ports\u0027, lazy\u003d\u0027select\u0027)"},{"line_number":126,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"},{"line_number":127,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":128,"context_line":"    status \u003d sa.Column(sa.String(16), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SLY%3D","line":125,"in_reply_to":"AAAATn%2F9Srk%3D","updated":"2013-12-13 02:24:01.000000000","message":"same","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"35dca84924b186f2cf37471899db878f152fdb3d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    gateway_ip \u003d sa.Column(sa.String(64))"},{"line_number":155,"context_line":"    allocation_pools \u003d orm.relationship(IPAllocationPool,"},{"line_number":156,"context_line":"                                        backref\u003d\u0027subnet\u0027,"},{"line_number":157,"context_line":"                                        lazy\u003d\"select\","},{"line_number":158,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":159,"context_line":"    enable_dhcp \u003d sa.Column(sa.Boolean())"},{"line_number":160,"context_line":"    dns_nameservers \u003d orm.relationship(DNSNameServer,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Srg%3D","line":157,"updated":"2013-12-12 23:38:51.000000000","message":"nit: Is this necessary given that lazy\u003d\u0027select\u0027 is the default?","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"b1342499326d100969e95a1dd54ca8fe8fa8c6be","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    gateway_ip \u003d sa.Column(sa.String(64))"},{"line_number":155,"context_line":"    allocation_pools \u003d orm.relationship(IPAllocationPool,"},{"line_number":156,"context_line":"                                        backref\u003d\u0027subnet\u0027,"},{"line_number":157,"context_line":"                                        lazy\u003d\"select\","},{"line_number":158,"context_line":"                                        cascade\u003d\u0027delete\u0027)"},{"line_number":159,"context_line":"    enable_dhcp \u003d sa.Column(sa.Boolean())"},{"line_number":160,"context_line":"    dns_nameservers \u003d orm.relationship(DNSNameServer,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SLU%3D","line":157,"in_reply_to":"AAAATn%2F9Srg%3D","updated":"2013-12-13 02:24:01.000000000","message":"same","commit_id":"693b2ea33bc07e059e508607ae23f2668843f833"}]}
