)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"796b12740ee09d72081e9b25d841242c3bc56a94","unresolved":false,"context_lines":[{"line_number":10,"context_line":"event with floating ip status should be sent out"},{"line_number":11,"context_line":"after updating floating ip."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add function _notify_fip_status to send event after"},{"line_number":14,"context_line":"updating floating ip."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Modify function _delete_floatingip to use _notify_fip_status"},{"line_number":17,"context_line":"to notify the floating ip status."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Modify function _update_fip_assoc which is used by function"},{"line_number":20,"context_line":"_create_floatingip and update_floatingip. Insert floating"},{"line_number":21,"context_line":"ip status into the result of _update_fip_assoc. The two"},{"line_number":22,"context_line":"functions will send the event with the result of"},{"line_number":23,"context_line":"_update_fip_assoc after updating floating ip."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Modify function disassociate_floatingips to insert floating ip"},{"line_number":26,"context_line":"status, last_known_router_id and last_fixed_port_id into"},{"line_number":27,"context_line":"the event after updating floating ip."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: Ifced3d2945b3afd5d62b470f65f2534f609115fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_0559e7fb","line":27,"range":{"start_line":13,"start_character":0,"end_line":27,"end_character":37},"updated":"2018-10-19 09:45:05.000000000","message":"You really do not need to say all the work you added to the code, just say something effectively summarized.","commit_id":"1ddd03c89383f06722e80178378ac1e28941a00d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"796b12740ee09d72081e9b25d841242c3bc56a94","unresolved":false,"context_lines":[{"line_number":26,"context_line":"status, last_known_router_id and last_fixed_port_id into"},{"line_number":27,"context_line":"the event after updating floating ip."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: Ifced3d2945b3afd5d62b470f65f2534f609115fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_c56a0f81","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":6},"updated":"2018-10-19 09:45:05.000000000","message":"This RFE change is approved or not? Add (create one) the LP bug here to trace it.","commit_id":"1ddd03c89383f06722e80178378ac1e28941a00d"}],"neutron/db/l3_db.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"796b12740ee09d72081e9b25d841242c3bc56a94","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"                \u0027floating_ip_id\u0027: floatingip_db.id,"},{"line_number":1477,"context_line":"                \u0027status\u0027: status,"},{"line_number":1478,"context_line":"                \u0027context\u0027: context}"},{"line_number":1479,"context_line":"        registry.notify(resources.FLOATING_IP,"},{"line_number":1480,"context_line":"                        events.AFTER_UPDATE,"},{"line_number":1481,"context_line":"                        self.update_floatingip_status,"},{"line_number":1482,"context_line":"                        **args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4536ffb5","line":1479,"range":{"start_line":1479,"start_character":8,"end_line":1479,"end_character":23},"updated":"2018-10-19 09:45:05.000000000","message":"\u0027notify\u0027 is deprecated, please try to use \u0027publish\u0027 instead.","commit_id":"1ddd03c89383f06722e80178378ac1e28941a00d"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"125a9d88245484229fcbdbb29c168c782c9898c1","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"        self._core_plugin.delete_port(context.elevated(),"},{"line_number":1509,"context_line":"                                      floatingip.floating_port_id,"},{"line_number":1510,"context_line":"                                      l3_port_check\u003dFalse)"},{"line_number":1511,"context_line":"        self._notify_fip_status(context, floatingip,"},{"line_number":1512,"context_line":"                                constants.FLOATINGIP_STATUS_DOWN)"},{"line_number":1513,"context_line":"        registry.notify(resources.FLOATING_IP, events.AFTER_DELETE,"},{"line_number":1514,"context_line":"                        self, context\u003dcontext, **floatingip_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_dc8db328","line":1511,"updated":"2018-12-05 23:28:22.000000000","message":"Is there a way we can use the AFTER_DELETE notification to initiate the action we want to take? It seems like we\u0027re unnecessarily breaking this up into 2 notifications. It seems to me that l2pop could take action on the AFTER_DELETE.","commit_id":"b4aa5f31050f630019c08ac321e065179fd504f9"}]}