)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"7527c47f4114424473896abf87eb791a906bc0e8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-10-18 09:50:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_9932345d","line":8,"updated":"2018-10-19 22:10:36.000000000","message":"Is there any BP this patch implements? or any bug this patch is fixing?","commit_id":"07f707c572532ea0b033b50c391746fc3e9607a0"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"9d4f263415780901edc7027fc6e3da8fe25f77b9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"},{"line_number":10,"context_line":"Implements: blueprint qos-direct-ports"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_abd93628","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":38},"updated":"2018-10-29 13:34:14.000000000","message":"Wait for the bp get approved...","commit_id":"30bab4e5f398589085b7f863ed6eddf28698d5a8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c1f691d9c4e4ec4c45590cb50267005eda4bfa66","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."},{"line_number":13,"context_line":"We just want to add Direct port to ovs Qos driver as done here [4]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":16,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_62531d18","line":13,"range":{"start_line":13,"start_character":62,"end_line":13,"end_character":66},"updated":"2019-11-07 14:29:48.000000000","message":"This is not neede, the patch is just pointing to itself.","commit_id":"17c56842fc03bcada8d57ce4d18eee6f7bfee40c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"84c3153f98a49755f7d8aed584a00f4caf319cd9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."},{"line_number":13,"context_line":"We just want to add Direct port to ovs Qos driver as done here [4]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":16,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_62c8fda7","line":13,"range":{"start_line":13,"start_character":62,"end_line":13,"end_character":66},"in_reply_to":"3fa7e38b_62531d18","updated":"2019-11-07 14:41:53.000000000","message":"Done","commit_id":"17c56842fc03bcada8d57ce4d18eee6f7bfee40c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c1f691d9c4e4ec4c45590cb50267005eda4bfa66","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":16,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"},{"line_number":17,"context_line":"[3] - https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/openvswitch/driver.py#L56"},{"line_number":18,"context_line":"[4] - https://review.opendev.org/#/c/611605/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"},{"line_number":21,"context_line":"Closes-Bug: #1843165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_82589931","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":44},"updated":"2019-11-07 14:29:48.000000000","message":"ditto","commit_id":"17c56842fc03bcada8d57ce4d18eee6f7bfee40c"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"84c3153f98a49755f7d8aed584a00f4caf319cd9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":16,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"},{"line_number":17,"context_line":"[3] - https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/openvswitch/driver.py#L56"},{"line_number":18,"context_line":"[4] - https://review.opendev.org/#/c/611605/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"},{"line_number":21,"context_line":"Closes-Bug: #1843165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_82cdf9b8","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":44},"in_reply_to":"3fa7e38b_82589931","updated":"2019-11-07 14:41:53.000000000","message":"Done","commit_id":"17c56842fc03bcada8d57ce4d18eee6f7bfee40c"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     waleed mousa \u003cwaleedm@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-07 14:38:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_141eb96f","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":47},"updated":"2019-11-17 12:32:43.000000000","message":"nit: OVS  (across the commit message)","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     waleed mousa \u003cwaleedm@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-07 14:38:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_942069b2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2019-11-17 12:32:43.000000000","message":"nit:Add","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     waleed mousa \u003cwaleedm@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-07 14:38:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_f418bd84","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":40},"updated":"2019-11-17 12:32:43.000000000","message":"nit:QoS (across the commit message)","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_d4134164","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":58},"updated":"2019-11-17 12:32:43.000000000","message":"did you mean [2] ?  [1] links to OVS commit for adding ingress rate limit.","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_3429759b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"updated":"2019-11-17 12:32:43.000000000","message":"nit: this can be simply: \"Today\"","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support for direct ports with qos in ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_b40ec53a","line":9,"range":{"start_line":9,"start_character":63,"end_line":9,"end_character":74},"updated":"2019-11-17 12:32:43.000000000","message":"ovs hardware offloads","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."},{"line_number":13,"context_line":"We just want to add Direct port to ovs Qos driver"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_542671cd","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":17},"updated":"2019-11-17 12:32:43.000000000","message":"driver ?","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"So today ovs mechanism driver can bind Direct port see [1] for ovs offload."},{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."},{"line_number":13,"context_line":"We just want to add Direct port to ovs Qos driver"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_740ccd41","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":24},"updated":"2019-11-17 12:32:43.000000000","message":"is ?","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"104eb8b60c8e67501ca7460f2691dc1f85520616","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ovs was extended with tc-offload to support rate limit see [1]."},{"line_number":11,"context_line":"The ovs qos drive [2] it limited to work only with Normal Ports, so we"},{"line_number":12,"context_line":"can\u0027t put QOS rules on direct port."},{"line_number":13,"context_line":"We just want to add Direct port to ovs Qos driver"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":16,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_3402d50d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":49},"updated":"2019-11-17 12:32:43.000000000","message":"I would replace this with:\n\n\"This patch proposes to add support in OVS QoS driver for direct ports. The mechanism to enforce such policies is the same with normal and hardware offloaded direct ports.\"","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3893716d153697b68503c85d1dc450befebac86e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[3] - https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/openvswitch/driver.py#L56"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"},{"line_number":20,"context_line":"Closes-Bug: #1843165"},{"line_number":21,"context_line":"Implements: blueprint qos-direct-ports"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_22e3e508","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":20},"updated":"2019-11-07 14:49:56.000000000","message":"Yes, IMO, this should be enough to track all details we needed, the discussion is there.","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"26b302b6a87848501b5301c1783bcf1324519787","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Today OVS mechanism driver can bind Direct port see [1] for OVS hardware"},{"line_number":10,"context_line":"offloads."},{"line_number":11,"context_line":"OVS was extended with tc-offload to support rate limit see [1]."},{"line_number":12,"context_line":"The OVS QoS driver [2] is limited to work only with Normal Ports, so we"},{"line_number":13,"context_line":"can\u0027t put QoS rules on direct port."},{"line_number":14,"context_line":"This patch proposes to add support in OVS QoS driver for direct ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa7e38b_d7726eb0","line":11,"range":{"start_line":11,"start_character":60,"end_line":11,"end_character":61},"updated":"2019-12-26 09:10:58.000000000","message":"nit: 2","commit_id":"dcec0683dceab0216e96322f6840a81141f65385"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"26b302b6a87848501b5301c1783bcf1324519787","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Today OVS mechanism driver can bind Direct port see [1] for OVS hardware"},{"line_number":10,"context_line":"offloads."},{"line_number":11,"context_line":"OVS was extended with tc-offload to support rate limit see [1]."},{"line_number":12,"context_line":"The OVS QoS driver [2] is limited to work only with Normal Ports, so we"},{"line_number":13,"context_line":"can\u0027t put QoS rules on direct port."},{"line_number":14,"context_line":"This patch proposes to add support in OVS QoS driver for direct ports."},{"line_number":15,"context_line":"The mechanism to enforce such policies is the same with normal and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa7e38b_f7776a9e","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":21},"updated":"2019-12-26 09:10:58.000000000","message":"nit: 3","commit_id":"dcec0683dceab0216e96322f6840a81141f65385"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"26b302b6a87848501b5301c1783bcf1324519787","unresolved":false,"context_lines":[{"line_number":16,"context_line":"hardware offloaded direct ports."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":19,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"},{"line_number":20,"context_line":"[3] - https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/openvswitch/driver.py#L56"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa7e38b_175c8618","line":19,"range":{"start_line":19,"start_character":127,"end_line":19,"end_character":130},"updated":"2019-12-26 09:10:58.000000000","message":"should be:\nhttps://github.com/openstack/neutron/blob/3b074128ca91ba335bd8ef9db8dfe00fda51a63d/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83","commit_id":"dcec0683dceab0216e96322f6840a81141f65385"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"90cf7cb46d184ccadf4b7f5d6557358cfe281c0a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"hardware offloaded direct ports."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":19,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"},{"line_number":20,"context_line":"[3] - https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/openvswitch/driver.py#L56"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"},{"line_number":23,"context_line":"Closes-Bug: #1843165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa7e38b_f318e183","line":20,"range":{"start_line":19,"start_character":6,"end_line":20,"end_character":109},"updated":"2019-12-25 14:58:21.000000000","message":"nit: it would be nice if you use a specific commit hash rather than \"master\" as the link (with the master) will point wrong lines after some commits have been merged.","commit_id":"dcec0683dceab0216e96322f6840a81141f65385"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"26b302b6a87848501b5301c1783bcf1324519787","unresolved":false,"context_lines":[{"line_number":16,"context_line":"hardware offloaded direct ports."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] - https://github.com/openvswitch/ovs/commit/e7f6ba220e10c0b560da097185514b6e33e2dc71"},{"line_number":19,"context_line":"[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L83"},{"line_number":20,"context_line":"[3] - https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/openvswitch/driver.py#L56"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I24b5cd6c022e479080fc84e4c445c9cddfc88e38"},{"line_number":23,"context_line":"Closes-Bug: #1843165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa7e38b_b76d72cc","line":20,"range":{"start_line":19,"start_character":6,"end_line":20,"end_character":109},"in_reply_to":"3fa7e38b_f318e183","updated":"2019-12-26 09:10:58.000000000","message":"should be:\nhttps://github.com/openstack/neutron/blob/3b074128ca91ba335bd8ef9db8dfe00fda51a63d/neutron/services/qos/drivers/openvswitch/driver.py#L56","commit_id":"dcec0683dceab0216e96322f6840a81141f65385"}],"doc/source/contributor/internals/quality_of_service.rst":[{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":".. note::"},{"line_number":367,"context_line":" As of Ussuri release, the QoS rules can be applied both for normal ports as"},{"line_number":368,"context_line":" well as direct ports."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"SR-IOV"},{"line_number":371,"context_line":"++++++"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3fa7e38b_befdc90a","line":368,"range":{"start_line":368,"start_character":9,"end_line":368,"end_character":21},"updated":"2020-01-13 08:39:49.000000000","message":"nit: maybe we can be more specific here, something like:\n\ndirect ports with hardware offload capability (switchdev).","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0ba50d0ca3b9ce8fa69914f85d1b35de49312a13","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":".. note::"},{"line_number":367,"context_line":" As of Ussuri release, the QoS rules can be applied both for normal ports as"},{"line_number":368,"context_line":" well as direct ports with hardware offload capability (switchdev)."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"SR-IOV"},{"line_number":371,"context_line":"++++++"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3fa7e38b_d3bae9de","line":368,"updated":"2020-01-14 10:28:10.000000000","message":"You should IMO mention here what OVS and what kernel is needed for that. It\u0027s great place to document it IMO","commit_id":"b99eca4d3a823bb210c73e9a4a4dd7887b618dac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"c3c3043d020f707e72eb40670c7dbc0b65ad777f","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":".. note::"},{"line_number":367,"context_line":" As of Ussuri release, the QoS rules can be applied for direct ports with hardware"},{"line_number":368,"context_line":" offload capability (switchdev), this requires the Open vSwitch to be version 2.11.0"},{"line_number":369,"context_line":" or newer and the Linux kernel needs to be based on kernel 5.4.0 or newer."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"SR-IOV"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3fa7e38b_bce375a0","line":368,"range":{"start_line":368,"start_character":47,"end_line":368,"end_character":69},"updated":"2020-01-14 17:35:43.000000000","message":"nit: \"Open vSwitch\" is enough here","commit_id":"5ed852a8a16ac9e16d0a211cbfb615645b514a30"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"c3c3043d020f707e72eb40670c7dbc0b65ad777f","unresolved":false,"context_lines":[{"line_number":366,"context_line":".. note::"},{"line_number":367,"context_line":" As of Ussuri release, the QoS rules can be applied for direct ports with hardware"},{"line_number":368,"context_line":" offload capability (switchdev), this requires the Open vSwitch to be version 2.11.0"},{"line_number":369,"context_line":" or newer and the Linux kernel needs to be based on kernel 5.4.0 or newer."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"SR-IOV"},{"line_number":372,"context_line":"++++++"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3fa7e38b_3cf7855d","line":369,"range":{"start_line":369,"start_character":14,"end_line":369,"end_character":17},"updated":"2020-01-14 17:35:43.000000000","message":"nit: can be dropped","commit_id":"5ed852a8a16ac9e16d0a211cbfb615645b514a30"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"c3c3043d020f707e72eb40670c7dbc0b65ad777f","unresolved":false,"context_lines":[{"line_number":366,"context_line":".. note::"},{"line_number":367,"context_line":" As of Ussuri release, the QoS rules can be applied for direct ports with hardware"},{"line_number":368,"context_line":" offload capability (switchdev), this requires the Open vSwitch to be version 2.11.0"},{"line_number":369,"context_line":" or newer and the Linux kernel needs to be based on kernel 5.4.0 or newer."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"SR-IOV"},{"line_number":372,"context_line":"++++++"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3fa7e38b_7cfdfd3a","line":369,"range":{"start_line":369,"start_character":31,"end_line":369,"end_character":42},"updated":"2020-01-14 17:35:43.000000000","message":"nit: can be dropped","commit_id":"5ed852a8a16ac9e16d0a211cbfb615645b514a30"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    return DNSMASQ_VERSION_DHCP_RELEASE6"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def get_ovs_version_for_qos_support():"},{"line_number":204,"context_line":"    return MINIMUM_OVS_VERSION"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_99b10749","line":203,"range":{"start_line":203,"start_character":28,"end_line":203,"end_character":35},"updated":"2020-01-13 08:39:49.000000000","message":"nit: direct_port_support","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    return True"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"def ovs_version_check():"},{"line_number":239,"context_line":"    try:"},{"line_number":240,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027-V\u0027]"},{"line_number":241,"context_line":"        out \u003d agent_utils.execute(cmd)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_d9621fdb","line":238,"range":{"start_line":238,"start_character":4,"end_line":238,"end_character":22},"updated":"2020-01-13 08:39:49.000000000","message":"nit: ovs_qos_direct_port_supported()","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0ba50d0ca3b9ce8fa69914f85d1b35de49312a13","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"MINIMUM_DNSMASQ_VERSION \u003d 2.67"},{"line_number":44,"context_line":"DNSMASQ_VERSION_DHCP_RELEASE6 \u003d 2.76"},{"line_number":45,"context_line":"MINIMUM_OVS_VERSION \u003d 2.11"},{"line_number":46,"context_line":"MINIMUM_DIBBLER_VERSION \u003d \u00271.0.1\u0027"},{"line_number":47,"context_line":"CONNTRACK_GRE_MODULE \u003d \u0027nf_conntrack_proto_gre\u0027"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3fa7e38b_b383ad06","line":45,"updated":"2020-01-14 10:28:10.000000000","message":"I would name it DIRECT_PORT_QOS_MIN_OVS_VERSION or something similar, as it\u0027s not minimal version required in general by Neutron but minimal version for this specific feature","commit_id":"b99eca4d3a823bb210c73e9a4a4dd7887b618dac"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"403bd06b13ad366079492ad28ac4304207191e31","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def get_ovs_version_for_qos_direct_port_support():"},{"line_number":204,"context_line":"    return MINIMUM_OVS_VERSION"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def dnsmasq_local_service_supported():"}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa7e38b_bcb13594","line":204,"range":{"start_line":204,"start_character":11,"end_line":204,"end_character":30},"updated":"2020-01-14 17:36:59.000000000","message":"DIRECT_PORT_QOS_MIN_OVS_VERSION ?","commit_id":"5ed852a8a16ac9e16d0a211cbfb615645b514a30"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"de35382fcafe45452960325c9e14601e442c8355","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    try:"},{"line_number":240,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027-V\u0027]"},{"line_number":241,"context_line":"        out \u003d agent_utils.execute(cmd)"},{"line_number":242,"context_line":"        m \u003d re.search(r\"(\\d+\\.\\d+)\", out)"},{"line_number":243,"context_line":"        ver \u003d float(m.group(0)) if m else 0"},{"line_number":244,"context_line":"        if ver \u003c DIRECT_PORT_QOS_MIN_OVS_VERSION:"},{"line_number":245,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_da773c8e","line":242,"updated":"2020-01-15 17:02:33.000000000","message":"nit: This regex is not very robust. \"ovs-vsctl -V\" returns several lines (the order of those lines is not guaranteed). You should grep by:\n  r\"ovs-vsctl.*(\\d+\\.\\d+).*\"\n\nThen:\n  ver \u003d float(m.group(1)) if m else 0","commit_id":"91600370f974d3dc46a21a3e2f702c01c0455fc0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"de35382fcafe45452960325c9e14601e442c8355","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        ver \u003d float(m.group(0)) if m else 0"},{"line_number":244,"context_line":"        if ver \u003c DIRECT_PORT_QOS_MIN_OVS_VERSION:"},{"line_number":245,"context_line":"            return False"},{"line_number":246,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":247,"context_line":"        LOG.debug(\"Exception while checking minimal ovs version \""},{"line_number":248,"context_line":"                  \"required for supporting direct ports QoS rules. \""},{"line_number":249,"context_line":"                  \"Exception: %s\", e)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_5a158ce5","line":246,"range":{"start_line":246,"start_character":35,"end_line":246,"end_character":45},"updated":"2020-01-15 17:02:33.000000000","message":"Instead of controlling the code by exceptions, you can check \nif the regex returns something:\n  m \u003d re.search()\n  if m:\n     \u003ccode\u003e","commit_id":"91600370f974d3dc46a21a3e2f702c01c0455fc0"},{"author":{"_account_id":30921,"name":"Abdallah Yasin","email":"abdallahyas@mellanox.com","username":"abdallahyas"},"change_message_id":"a5a6afaa8f5f25535c965412b6cba3f4e79bee98","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        ver \u003d float(m.group(0)) if m else 0"},{"line_number":244,"context_line":"        if ver \u003c DIRECT_PORT_QOS_MIN_OVS_VERSION:"},{"line_number":245,"context_line":"            return False"},{"line_number":246,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":247,"context_line":"        LOG.debug(\"Exception while checking minimal ovs version \""},{"line_number":248,"context_line":"                  \"required for supporting direct ports QoS rules. \""},{"line_number":249,"context_line":"                  \"Exception: %s\", e)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_bb8cbb2d","line":246,"range":{"start_line":246,"start_character":35,"end_line":246,"end_character":45},"in_reply_to":"3fa7e38b_5a158ce5","updated":"2020-01-20 07:21:28.000000000","message":"Removing \"IndexError\" \u003e\u003e Done","commit_id":"91600370f974d3dc46a21a3e2f702c01c0455fc0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3242375e179e073b576c803a8ac234ba72f1d339","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    try:"},{"line_number":240,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027-V\u0027]"},{"line_number":241,"context_line":"        out \u003d agent_utils.execute(cmd)"},{"line_number":242,"context_line":"        matched_line \u003d re.search(r\"ovs-vsctl.*\", out)"},{"line_number":243,"context_line":"        matched_version \u003d re.search(r\"(\\d+\\.\\d+)\", matched_line.group(0))"},{"line_number":244,"context_line":"        ver \u003d float(matched_version.group(1)) if matched_version else 0"},{"line_number":245,"context_line":"        if ver \u003c DIRECT_PORT_QOS_MIN_OVS_VERSION:"},{"line_number":246,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_41d27861","line":243,"range":{"start_line":242,"start_character":8,"end_line":243,"end_character":73},"updated":"2020-01-16 10:04:09.000000000","message":"Sorry, this is not what I commented in PS20. Why do you need two regex? Why don\u0027t you read the whole output?\n\nThis is what I proposed:\n\nm \u003d re.search(r\"ovs-vsctl.*(\\d+\\.\\d+)\", out, re.M)\nver \u003d float(m.group(1)) if m else 0\nif ver \u003c DIRECT_PORT_QOS_MIN_OVS_VERSION:\n  return False\n\nAnyway, I don\u0027t want to nit-picking this patch.","commit_id":"9164edfb12668a7e629ef1ff80e642245b658dd1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a51653458fa8b57e5edc62f35b18a7feea036fe1","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        matched_line \u003d re.search(r\"ovs-vsctl.*\", out)"},{"line_number":243,"context_line":"        matched_version \u003d re.search(r\"(\\d+\\.\\d+)\", matched_line.group(0))"},{"line_number":244,"context_line":"        ver \u003d float(matched_version.group(1)) if matched_version else 0"},{"line_number":245,"context_line":"        if ver \u003c DIRECT_PORT_QOS_MIN_OVS_VERSION:"},{"line_number":246,"context_line":"            return False"},{"line_number":247,"context_line":"    except (OSError, RuntimeError, ValueError) as e:"},{"line_number":248,"context_line":"        LOG.debug(\"Exception while checking minimal ovs version \""}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_21d5fcb8","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":49},"updated":"2020-01-16 11:01:49.000000000","message":"As commented via IRC, this is going to fail when, for example, ver\u003d2.9 and DIRECT_PORT_QOS_MIN_OVS_VERSION\u003d2.11\n\nWe need to use something like this:\n_target_version \u003d versionutils.convert_version_to_tuple(target_version)\nif _target_version \u003c (2, 11):\n  ...","commit_id":"9164edfb12668a7e629ef1ff80e642245b658dd1"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if not result:"},{"line_number":124,"context_line":"        LOG.error(\u0027The installed version of OVS does not support \u0027"},{"line_number":125,"context_line":"                  \u0027QoS rules for direct ports. \u0027"},{"line_number":126,"context_line":"                  \u0027Please update to at least version %s.\u0027,"},{"line_number":127,"context_line":"                  checks.get_ovs_version_for_qos_support())"},{"line_number":128,"context_line":"    return result"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_395573fa","line":126,"range":{"start_line":126,"start_character":36,"end_line":126,"end_character":56},"updated":"2020-01-13 08:39:49.000000000","message":"nit: version %s or newer","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    BoolOptCallback(\u0027dnsmasq_local_service_supported\u0027,"},{"line_number":335,"context_line":"                    check_dnsmasq_local_service_supported,"},{"line_number":336,"context_line":"                    help\u003d_(\u0027Check for local-service support in dnsmasq\u0027)),"},{"line_number":337,"context_line":"    BoolOptCallback(\u0027ovs_qos_supported\u0027,"},{"line_number":338,"context_line":"                    check_qos_ovs_version,"},{"line_number":339,"context_line":"                    help\u003d_(\u0027Check if the ovs supports QoS for direct ports \u0027"},{"line_number":340,"context_line":"                     \u0027or not\u0027)),"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_d90bff20","line":337,"range":{"start_line":337,"start_character":21,"end_line":337,"end_character":38},"updated":"2020-01-13 08:39:49.000000000","message":"nit: ovs_qos_direct_port_supported","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                    check_dnsmasq_local_service_supported,"},{"line_number":336,"context_line":"                    help\u003d_(\u0027Check for local-service support in dnsmasq\u0027)),"},{"line_number":337,"context_line":"    BoolOptCallback(\u0027ovs_qos_supported\u0027,"},{"line_number":338,"context_line":"                    check_qos_ovs_version,"},{"line_number":339,"context_line":"                    help\u003d_(\u0027Check if the ovs supports QoS for direct ports \u0027"},{"line_number":340,"context_line":"                     \u0027or not\u0027)),"},{"line_number":341,"context_line":"    BoolOptCallback(\u0027dnsmasq_version\u0027, check_dnsmasq_version,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_79268bbc","line":338,"range":{"start_line":338,"start_character":20,"end_line":338,"end_character":41},"updated":"2020-01-13 08:39:49.000000000","message":"nit: check_ovs_qos_direct_port_supported","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    BoolOptCallback(\u0027ovs_qos_supported\u0027,"},{"line_number":338,"context_line":"                    check_qos_ovs_version,"},{"line_number":339,"context_line":"                    help\u003d_(\u0027Check if the ovs supports QoS for direct ports \u0027"},{"line_number":340,"context_line":"                     \u0027or not\u0027)),"},{"line_number":341,"context_line":"    BoolOptCallback(\u0027dnsmasq_version\u0027, check_dnsmasq_version,"},{"line_number":342,"context_line":"                    help\u003d_(\u0027Check minimal dnsmasq version\u0027),"},{"line_number":343,"context_line":"                    deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_d9345fe3","line":340,"range":{"start_line":340,"start_character":22,"end_line":340,"end_character":28},"updated":"2020-01-13 08:39:49.000000000","message":"no need for the \u0027or not\u0027","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"}],"neutron/services/qos/drivers/openvswitch/driver.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"52d2f0993d49cb3c303fda11bffc04d16dd43045","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            name\u003d\u0027openvswitch\u0027,"},{"line_number":54,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_OVS,"},{"line_number":55,"context_line":"                       portbindings.VIF_TYPE_VHOST_USER],"},{"line_number":56,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL, portbindings.VNIC_DIRECT],"},{"line_number":57,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":58,"context_line":"            requires_rpc_notifications\u003dTrue)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_a47349e8","line":56,"range":{"start_line":56,"start_character":48,"end_line":56,"end_character":74},"updated":"2019-11-11 10:01:47.000000000","message":"Please note that minimum bandwidth feature due to placement modelling issues has some limitations for case when both agent supports Direct for example (see: https://docs.openstack.org/neutron/latest/admin/config-qos-min-bw.html#neutron-server-config)","commit_id":"11bdfc47a4bf82064f57c1cc246c901e2295fdac"}],"releasenotes/notes/Add-support-for-direct-ports-with-QoS-in-OVS-48c78c156606e724.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"90cf7cb46d184ccadf4b7f5d6557358cfe281c0a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for bandwidth limit QoS rule for direct ports in neutron,"},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 and kernel 5.4.0 and above."},{"line_number":6,"context_line":"    [`1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_731b9183","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":13},"updated":"2019-12-25 14:58:21.000000000","message":"nit: we usually use \"bug NNNNN\" for such case.","commit_id":"dcec0683dceab0216e96322f6840a81141f65385"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"86423216b4ce38fd1a2887a744b710080a1d1e6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for bandwidth limit QoS rule for direct ports in neutron,"},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 and kernel 5.4.0 and above."},{"line_number":6,"context_line":"    [`bug 1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_ec740dcf","line":4,"range":{"start_line":4,"start_character":74,"end_line":4,"end_character":75},"updated":"2020-01-10 14:10:25.000000000","message":"comma should be a period","commit_id":"190e55a99ecf81b8173988089d05bcda6a9a3fc4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"86423216b4ce38fd1a2887a744b710080a1d1e6a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for bandwidth limit QoS rule for direct ports in neutron,"},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 and kernel 5.4.0 and above."},{"line_number":6,"context_line":"    [`bug 1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_ac4cd59c","line":6,"updated":"2020-01-10 14:10:25.000000000","message":"missing trailing period","commit_id":"190e55a99ecf81b8173988089d05bcda6a9a3fc4"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for bandwidth limit QoS rule for direct ports in neutron."},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 and kernel 5.4.0 and above."},{"line_number":6,"context_line":"    [`bug 1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_596f0fc7","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":46},"updated":"2020-01-13 08:39:49.000000000","message":"nit: rules ?","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"38f63c9a525dbadf508b75bf0b39de94cc8135ab","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for bandwidth limit QoS rule for direct ports in neutron."},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 and kernel 5.4.0 and above."},{"line_number":6,"context_line":"    [`bug 1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_7e4bd15d","line":5,"range":{"start_line":5,"start_character":40,"end_line":5,"end_character":52},"updated":"2020-01-13 06:25:34.000000000","message":"kernel based on 5.4.0","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"79d3760b3af80223cc8a6b8651f5e80ad4745305","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for bandwidth limit QoS rule for direct ports in neutron."},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 and kernel 5.4.0 and above."},{"line_number":6,"context_line":"    [`bug 1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_79744b9c","line":5,"range":{"start_line":5,"start_character":53,"end_line":5,"end_character":62},"updated":"2020-01-13 08:39:49.000000000","message":"nit: or newer.","commit_id":"2b7e63d4ccb37d51f56173f6aae6f9aae28cc054"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0ba50d0ca3b9ce8fa69914f85d1b35de49312a13","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added QoS support for direct ports in neutron."},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 or newer and is based on kernel 5.4.0 or newer."},{"line_number":6,"context_line":"    [`bug 1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fa7e38b_7392154d","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":28},"updated":"2020-01-14 10:28:10.000000000","message":"IMO \"Open vSwitch\" would be better here","commit_id":"b99eca4d3a823bb210c73e9a4a4dd7887b618dac"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0ba50d0ca3b9ce8fa69914f85d1b35de49312a13","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added QoS support for direct ports in neutron."},{"line_number":5,"context_line":"    The support requires ovs 2.11.0 or newer and is based on kernel 5.4.0 or newer."},{"line_number":6,"context_line":"    [`bug 1843165 \u003chttps://bugs.launchpad.net/neutron/+bug/1843165\u003e`_]."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fa7e38b_9397913a","line":5,"range":{"start_line":5,"start_character":61,"end_line":5,"end_character":67},"updated":"2020-01-14 10:28:10.000000000","message":"IMO should be \"Linux kernel\"","commit_id":"b99eca4d3a823bb210c73e9a4a4dd7887b618dac"}]}