)]}'
{"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a25dabe2a5fd57e67e2d11653f8c35e188d4693d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            context, [network_id], active\u003dTrue)"},{"line_number":55,"context_line":"        if not agents:"},{"line_number":56,"context_line":"            agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":57,"context_line":"                context, [network_id], active\u003dNone)"},{"line_number":58,"context_line":"            if agents:"},{"line_number":59,"context_line":"                # Make an attempt to filter for active agents in case"},{"line_number":60,"context_line":"                # the db has changed since the first query."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9eIA%3D","line":57,"updated":"2013-12-11 06:27:25.000000000","message":"I think we can just remove 53-54","commit_id":"b81dc07f58b76d10a7df445622564f87b824247d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"ab87b4037be40cbd57e72be21956f621259506b5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            context, [network_id], active\u003dTrue)"},{"line_number":55,"context_line":"        if not agents:"},{"line_number":56,"context_line":"            agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":57,"context_line":"                context, [network_id], active\u003dNone)"},{"line_number":58,"context_line":"            if agents:"},{"line_number":59,"context_line":"                # Make an attempt to filter for active agents in case"},{"line_number":60,"context_line":"                # the db has changed since the first query."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9eGA%3D","line":57,"in_reply_to":"AAAATn%2F9eIA%3D","updated":"2013-12-11 06:47:18.000000000","message":"Done","commit_id":"b81dc07f58b76d10a7df445622564f87b824247d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4da9bb7a80940c1cfb178d30b9a6ae0def5927de","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_scheduled_agents(self, context, network_id):"},{"line_number":47,"context_line":"        \"\"\"Return dhcp agents scheduled for the indicated network."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        Attempt to retrieve scheduled agents that are considered"},{"line_number":50,"context_line":"        active, but failing that, try to return inactive agents."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9dw0%3D","line":47,"updated":"2013-12-11 08:55:11.000000000","message":"method name and docstring are a bit misleading for me as I think it\u0027s networks who are scheduled to agents and not vise versa. Can you use \u0027hosting_agents\u0027 unless I\u0027m missing smth?","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"911b183d3fc165e177918934be4a7453a4050084","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_scheduled_agents(self, context, network_id):"},{"line_number":47,"context_line":"        \"\"\"Return dhcp agents scheduled for the indicated network."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        Attempt to retrieve scheduled agents that are considered"},{"line_number":50,"context_line":"        active, but failing that, try to return inactive agents."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9cHg%3D","line":47,"in_reply_to":"AAAATn%2F9dw0%3D","updated":"2013-12-11 14:38:19.000000000","message":"Done","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"38799716d89fe400fac3060855f6c9c071f24505","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            active_agents \u003d [x for x in agents if x.admin_state_up]"},{"line_number":56,"context_line":"            if active_agents:"},{"line_number":57,"context_line":"                agents \u003d active_agents"},{"line_number":58,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9d%2Fo%3D","line":55,"updated":"2013-12-11 07:17:43.000000000","message":"line 53: active parameter of get_dhcp_agents_hosting_networks should be split into two: admin_up and active\n\nthe activeness of agent should depend on state report from agents.\nhttps://github.com/openstack/neutron/blob/master/neutron/db/agentschedulers_db.py#L107\nhttps://github.com/openstack/neutron/blob/master/neutron/db/agentschedulers_db.py#L72","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4da9bb7a80940c1cfb178d30b9a6ae0def5927de","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            active_agents \u003d [x for x in agents if x.admin_state_up]"},{"line_number":56,"context_line":"            if active_agents:"},{"line_number":57,"context_line":"                agents \u003d active_agents"},{"line_number":58,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9dso%3D","line":55,"in_reply_to":"AAAATn%2F9d%2Fo%3D","updated":"2013-12-11 08:55:11.000000000","message":"Isn\u0027t it the intention of the patch - to send notifications regardless of agent activeness?","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"911b183d3fc165e177918934be4a7453a4050084","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            active_agents \u003d [x for x in agents if x.admin_state_up]"},{"line_number":56,"context_line":"            if active_agents:"},{"line_number":57,"context_line":"                agents \u003d active_agents"},{"line_number":58,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9cGg%3D","line":55,"in_reply_to":"AAAATn%2F9dcc%3D","updated":"2013-12-11 14:38:19.000000000","message":"Done","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"01681a2eddcfedfc71ee532f3bc78f5bc3ec4c43","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            active_agents \u003d [x for x in agents if x.admin_state_up]"},{"line_number":56,"context_line":"            if active_agents:"},{"line_number":57,"context_line":"                agents \u003d active_agents"},{"line_number":58,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9dcc%3D","line":55,"in_reply_to":"AAAATn%2F9dso%3D","updated":"2013-12-11 09:44:56.000000000","message":"my fault, but active_agents can be named as admin_state_up_agents or other name.","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"ce3d2033c18402d3d66860ca37df718ff2161d1f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(DhcpAgentNotifyAPI, self).__init__("},{"line_number":44,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_dhcp_agents(self, context, network_id):"},{"line_number":47,"context_line":"        \"\"\"Return dhcp agents associated with the given network."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        Attempt to retrieve agents that are considered active, but"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9Yjs%3D","line":46,"updated":"2013-12-12 02:12:31.000000000","message":"according to your git commit msg, this function should return dhcp agents which hosts the network:\n1. no matter if they are down in the term of down time.\n2. with admin_stauts up.","commit_id":"0681a29d126f5720737e5d3365d760703297a616"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4ab5e928437163e68c27a925b12b0c8b0829c5f4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(DhcpAgentNotifyAPI, self).__init__("},{"line_number":44,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_dhcp_agents(self, context, network_id):"},{"line_number":47,"context_line":"        \"\"\"Return dhcp agents associated with the given network."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        Attempt to retrieve agents that are considered active, but"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9XQ4%3D","line":46,"in_reply_to":"AAAATn%2F9XWA%3D","updated":"2013-12-12 08:28:41.000000000","message":"Well, but according to the function behaviour, it could return the either the enabled agents, all of them (if none active).\n\nI spent a few minutes thinking about this and using _get_enabled_dhcp_agents, could be misleading when all are down?","commit_id":"0681a29d126f5720737e5d3365d760703297a616"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"d18c99ca952f4b612dec7cc9768e28ef195198d9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(DhcpAgentNotifyAPI, self).__init__("},{"line_number":44,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_dhcp_agents(self, context, network_id):"},{"line_number":47,"context_line":"        \"\"\"Return dhcp agents associated with the given network."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        Attempt to retrieve agents that are considered active, but"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9XWA%3D","line":46,"in_reply_to":"AAAATn%2F9Yjs%3D","updated":"2013-12-12 08:09:05.000000000","message":"Done","commit_id":"0681a29d126f5720737e5d3365d760703297a616"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"ce3d2033c18402d3d66860ca37df718ff2161d1f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            active_agents \u003d [x for x in agents if x.is_active]"},{"line_number":56,"context_line":"            if active_agents:"},{"line_number":57,"context_line":"                agents \u003d active_agents"},{"line_number":58,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9Yik%3D","line":55,"updated":"2013-12-12 02:12:31.000000000","message":"admin_up_agents \u003d [x for x in agents if x.admin_state_up],\nor add a new function parameter to get_dhcp_agents_hosting_networks, such as admin_up so that this function can return admin_up agents regardless of the downtime.","commit_id":"0681a29d126f5720737e5d3365d760703297a616"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"d18c99ca952f4b612dec7cc9768e28ef195198d9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            active_agents \u003d [x for x in agents if x.is_active]"},{"line_number":56,"context_line":"            if active_agents:"},{"line_number":57,"context_line":"                agents \u003d active_agents"},{"line_number":58,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9XWE%3D","line":55,"in_reply_to":"AAAATn%2F9Yik%3D","updated":"2013-12-12 08:09:05.000000000","message":"Done","commit_id":"0681a29d126f5720737e5d3365d760703297a616"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"dc2eeba3f2f79c8d6867fddb652ea642edcb519f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(DhcpAgentNotifyAPI, self).__init__("},{"line_number":44,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_enabled_dhcp_agents(self, context, network_id):"},{"line_number":47,"context_line":"        \"\"\"Return enabled dhcp agents associated with the given network."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        Attempt to retrieve agents that are considered active, but"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9XPk%3D","line":46,"updated":"2013-12-12 08:39:28.000000000","message":"Check a comment I added on the previous changeset thread.\n\nNow the name would be misleading in some cases, but I couldn\u0027t find a reasonable name either....\n\n_get_enabled_dhcp_agents_or_all_dhcp_agents_if_none_active..... nonsense \u0027\u0027:?","commit_id":"85cc5c3ba3dcefe06da28a8afc4f53fe00eeea2d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"ba72e62cc24d4880df886908ef6b266ed0edb82b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(DhcpAgentNotifyAPI, self).__init__("},{"line_number":44,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_enabled_dhcp_agents(self, context, network_id):"},{"line_number":47,"context_line":"        \"\"\"Return enabled dhcp agents associated with the given network."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        Attempt to retrieve agents that are considered active, but"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9XHk%3D","line":46,"in_reply_to":"AAAATn%2F9XPk%3D","updated":"2013-12-12 08:57:48.000000000","message":"I think the name is accurate.  Only enabled (admin_state_up\u003dTrue) dhcp agents will be returned.  As per the docstring, inactive, enabled agents will be returned only if there are no active, enabled agents.","commit_id":"85cc5c3ba3dcefe06da28a8afc4f53fe00eeea2d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d815fba77507ec1cdd646bfde21b5b9c3bb0ec38","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            # Exclude agents that have been explicitly disabled"},{"line_number":56,"context_line":"            agents \u003d [x for x in agents if x.admin_state_up]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            active_agents \u003d [x for x in agents if x.is_active]"},{"line_number":59,"context_line":"            if active_agents:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9GTU%3D","line":56,"updated":"2013-12-16 20:07:36.000000000","message":"We should produce a generator here:\n\nagents \u003d (x for x in agents if x.admin_state_up)","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"eaa86a2ddd1e551264a614ea1f5cfc57e3260423","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            # Exclude agents that have been explicitly disabled"},{"line_number":56,"context_line":"            agents \u003d [x for x in agents if x.admin_state_up]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            active_agents \u003d [x for x in agents if x.is_active]"},{"line_number":59,"context_line":"            if active_agents:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9ELw%3D","line":56,"in_reply_to":"AAAATn%2F9GTU%3D","updated":"2013-12-17 06:07:41.000000000","message":"I\u0027m not sure I understand why this should be the case.   A generator is consumable only once and the list created here is used in more than one place (line 58, 61, and returned if there are no active agents).  \n\nIf the goal is to ensure scalability to large numbers of dhcp agents per network (ala nova multihost), won\u0027t it be necessary to use generators from the db on up?  And wouldn\u0027t such an effort be better implemented in a dedicated patch?","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"a18281014dcd9a1ceeaa34ee51266ce6fd2951f6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            elif agents:"},{"line_number":62,"context_line":"                # Return potentially inactive agents"},{"line_number":63,"context_line":"                LOG.warning(_(\u0027No active DHCP agent(s) found for \u0027"},{"line_number":64,"context_line":"                              \u0027network: %s\u0027), network_id)"},{"line_number":65,"context_line":"        return agents"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _notification_host(self, context, method, payload, host):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9PBc%3D","line":64,"updated":"2013-12-13 17:48:53.000000000","message":"nit: Why to not say that there is no active DHCP agent, but the message will be sent anyway ?","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"eaa86a2ddd1e551264a614ea1f5cfc57e3260423","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            elif agents:"},{"line_number":62,"context_line":"                # Return potentially inactive agents"},{"line_number":63,"context_line":"                LOG.warning(_(\u0027No active DHCP agent(s) found for \u0027"},{"line_number":64,"context_line":"                              \u0027network: %s\u0027), network_id)"},{"line_number":65,"context_line":"        return agents"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _notification_host(self, context, method, payload, host):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9EEs%3D","line":64,"in_reply_to":"AAAATn%2F9PBc%3D","updated":"2013-12-17 06:07:41.000000000","message":"Done","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1e8ade16887dd29e05817f79b97fb9a931d9eba3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            agents \u003d self._get_enabled_dhcp_agents(context, network_id)"},{"line_number":94,"context_line":"            if not agents:"},{"line_number":95,"context_line":"                LOG.error(_(\"No DHCP agents are scheduled for network \""},{"line_number":96,"context_line":"                            \"\u0027%(net_id)s\u0027.  Unable to send notification \""},{"line_number":97,"context_line":"                            \" for \u0027%(method)s\u0027 with payload: %(payload)s\"),"},{"line_number":98,"context_line":"                          {"},{"line_number":99,"context_line":"                              \u0027net_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9KKo%3D","line":96,"updated":"2013-12-16 07:06:03.000000000","message":"nit: \u0027.  Unable\u0027 - two spaces","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"eaa86a2ddd1e551264a614ea1f5cfc57e3260423","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            agents \u003d self._get_enabled_dhcp_agents(context, network_id)"},{"line_number":94,"context_line":"            if not agents:"},{"line_number":95,"context_line":"                LOG.error(_(\"No DHCP agents are scheduled for network \""},{"line_number":96,"context_line":"                            \"\u0027%(net_id)s\u0027.  Unable to send notification \""},{"line_number":97,"context_line":"                            \" for \u0027%(method)s\u0027 with payload: %(payload)s\"),"},{"line_number":98,"context_line":"                          {"},{"line_number":99,"context_line":"                              \u0027net_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9EEo%3D","line":96,"in_reply_to":"AAAATn%2F9KKo%3D","updated":"2013-12-17 06:07:41.000000000","message":"Done","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1e8ade16887dd29e05817f79b97fb9a931d9eba3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not agents:"},{"line_number":95,"context_line":"                LOG.error(_(\"No DHCP agents are scheduled for network \""},{"line_number":96,"context_line":"                            \"\u0027%(net_id)s\u0027.  Unable to send notification \""},{"line_number":97,"context_line":"                            \" for \u0027%(method)s\u0027 with payload: %(payload)s\"),"},{"line_number":98,"context_line":"                          {"},{"line_number":99,"context_line":"                              \u0027net_id\u0027: network_id,"},{"line_number":100,"context_line":"                              \u0027method\u0027: method,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9KKA%3D","line":97,"updated":"2013-12-16 07:06:03.000000000","message":"nit: space before \u0027for\u0027 is redundant","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"eaa86a2ddd1e551264a614ea1f5cfc57e3260423","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if not agents:"},{"line_number":95,"context_line":"                LOG.error(_(\"No DHCP agents are scheduled for network \""},{"line_number":96,"context_line":"                            \"\u0027%(net_id)s\u0027.  Unable to send notification \""},{"line_number":97,"context_line":"                            \" for \u0027%(method)s\u0027 with payload: %(payload)s\"),"},{"line_number":98,"context_line":"                          {"},{"line_number":99,"context_line":"                              \u0027net_id\u0027: network_id,"},{"line_number":100,"context_line":"                              \u0027method\u0027: method,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9EEg%3D","line":97,"in_reply_to":"AAAATn%2F9KKA%3D","updated":"2013-12-17 06:07:41.000000000","message":"Done","commit_id":"2d1b19ed873a115a0cb14a2d5afb7ea0d1dd95cf"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6808b08b75e62933e19c71d9b0b3559543c2a4ff","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        agents \u003d plugin.get_dhcp_agents_hosting_networks(context, [network_id])"},{"line_number":54,"context_line":"        if agents:"},{"line_number":55,"context_line":"            # Exclude agents that have been explicitly disabled"},{"line_number":56,"context_line":"            agents \u003d [x for x in agents if x.admin_state_up]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"            active_agents \u003d [x for x in agents if x.is_active]"},{"line_number":59,"context_line":"            if active_agents:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F89Sw%3D","line":56,"updated":"2013-12-18 12:10:44.000000000","message":"I wonder if admin_state_up can be passed as a database filter, unless it might be deemed ok to collect agent which are active but administratively down (whatever that means)","commit_id":"862fc29ffd39e1d8b560a2d963154b2f11f1f630"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6808b08b75e62933e19c71d9b0b3559543c2a4ff","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                # Return potentially inactive agents"},{"line_number":63,"context_line":"                LOG.warning(_(\"No active DHCP agent(s) found for \""},{"line_number":64,"context_line":"                              \"network \u0027%s\u0027, but notifications will \""},{"line_number":65,"context_line":"                              \"be sent anyway.\"), network_id)"},{"line_number":66,"context_line":"        return agents"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _notification_host(self, context, method, payload, host):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F89Tc%3D","line":65,"updated":"2013-12-18 12:10:44.000000000","message":"what about the case in which some agents are active and some not?\nIt appears the current patch adopts the following approach: if an agent is active, use it for notification; otherwise retrieve all agent.","commit_id":"862fc29ffd39e1d8b560a2d963154b2f11f1f630"}],"neutron/tests/unit/api/rpc/agentnotifiers/test_dhcp_rpc_agent_api.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a25dabe2a5fd57e67e2d11653f8c35e188d4693d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9eHo%3D","line":1,"updated":"2013-12-11 06:27:25.000000000","message":"neutron/tests/unit/openvswitch/test_agent_scheduler.py","commit_id":"b81dc07f58b76d10a7df445622564f87b824247d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"ab87b4037be40cbd57e72be21956f621259506b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9eGI%3D","line":1,"in_reply_to":"AAAATn%2F9eHo%3D","updated":"2013-12-11 06:47:18.000000000","message":"There are no direct tests for dhcp_rpc_agent_api.py in that module, so I think it makes sense to add a new module whose path makes it clear what it is targeting.","commit_id":"b81dc07f58b76d10a7df445622564f87b824247d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4da9bb7a80940c1cfb178d30b9a6ae0def5927de","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.notify \u003d dhcp_rpc_agent_api.DhcpAgentNotifyAPI()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_get_scheduled_agents(self, agents):"},{"line_number":33,"context_line":"        with mock.patch.object(manager.NeutronManager, \u0027get_plugin\u0027) \\"},{"line_number":34,"context_line":"                as mock_get_plugin:"},{"line_number":35,"context_line":"            mock_get_plugin.return_value \u003d mock_plugin \u003d mock.Mock()"},{"line_number":36,"context_line":"            with mock.patch.object(mock_plugin,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9drg%3D","line":33,"updated":"2013-12-11 08:55:11.000000000","message":"\\ are not welcome AFAIK","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"911b183d3fc165e177918934be4a7453a4050084","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.notify \u003d dhcp_rpc_agent_api.DhcpAgentNotifyAPI()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_get_scheduled_agents(self, agents):"},{"line_number":33,"context_line":"        with mock.patch.object(manager.NeutronManager, \u0027get_plugin\u0027) \\"},{"line_number":34,"context_line":"                as mock_get_plugin:"},{"line_number":35,"context_line":"            mock_get_plugin.return_value \u003d mock_plugin \u003d mock.Mock()"},{"line_number":36,"context_line":"            with mock.patch.object(mock_plugin,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9cEc%3D","line":33,"in_reply_to":"AAAATn%2F9drg%3D","updated":"2013-12-11 14:38:19.000000000","message":"Done","commit_id":"0e012fb6b50e8f6b8d98930ff870fbc76be62b1c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9f30303592ae84add3c47afc923f4e9ffec258cd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(TestDhcpAgentNotifyAPI, self).setUp()"},{"line_number":30,"context_line":"        self.notify \u003d dhcp_rpc_agent_api.DhcpAgentNotifyAPI()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_get_enabled_dhcp_agents_filters_disabled_agents(self, agents):"},{"line_number":33,"context_line":"        disabled_agent \u003d mock.Mock()"},{"line_number":34,"context_line":"        disabled_agent.admin_state_up \u003d False"},{"line_number":35,"context_line":"        enabled_agent \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F85eE%3D","line":32,"updated":"2013-12-19 01:58:15.000000000","message":"This test won\u0027t get run. Remove the leading underscore and the unused \u0027agents\u0027 argument.","commit_id":"ed87c91a6f161dbb69021f84453984ef8187ff9f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"ae049cb7a3d242d4d3849f85da5f0fcc8ce24946","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(TestDhcpAgentNotifyAPI, self).setUp()"},{"line_number":30,"context_line":"        self.notify \u003d dhcp_rpc_agent_api.DhcpAgentNotifyAPI()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_get_enabled_dhcp_agents_filters_disabled_agents(self, agents):"},{"line_number":33,"context_line":"        disabled_agent \u003d mock.Mock()"},{"line_number":34,"context_line":"        disabled_agent.admin_state_up \u003d False"},{"line_number":35,"context_line":"        enabled_agent \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F84o0%3D","line":32,"in_reply_to":"AAAATn%2F85eE%3D","updated":"2013-12-19 07:09:00.000000000","message":"Done","commit_id":"ed87c91a6f161dbb69021f84453984ef8187ff9f"}]}
