)]}'
{"neutron/tests/unit/services/metering/drivers/test_iptables_driver.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"093f5f74fd286d36319c874c965ad99d06f3c036","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                               \u0027\u0027,"},{"line_number":143,"context_line":"                               wrap\u003dFalse),"},{"line_number":144,"context_line":"                 call.add_rule(\u0027neutron-meter-r-eeef45da-c60\u0027,"},{"line_number":145,"context_line":"                               \u0027-i qg-7d411f48-ec -d 20.0.0.0/24 -j RETURN\u0027,"},{"line_number":146,"context_line":"                               wrap\u003dFalse, top\u003dTrue)]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.v4filter_inst.assert_has_calls(calls)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9HD0%3D","line":145,"updated":"2013-12-16 17:54:23.000000000","message":"it looks like now we\u0027re only testing one side of the if branch, what about the other? If we had coverage for both cases (True and False for rule[\u0027excluded\u0027]) this bug fix would\u0027ve not existed.","commit_id":"504f496d6b4fd6234c3e65ba636ee12b004fae1f"},{"author":{"_account_id":9283,"name":"Siming Yin","email":"saelvyn@gmail.com","username":"saelvyn"},"change_message_id":"00f2e6781ed47e73e7ca918f1f739f1b6c82f420","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                               \u0027\u0027,"},{"line_number":143,"context_line":"                               wrap\u003dFalse),"},{"line_number":144,"context_line":"                 call.add_rule(\u0027neutron-meter-r-eeef45da-c60\u0027,"},{"line_number":145,"context_line":"                               \u0027-i qg-7d411f48-ec -d 20.0.0.0/24 -j RETURN\u0027,"},{"line_number":146,"context_line":"                               wrap\u003dFalse, top\u003dTrue)]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.v4filter_inst.assert_has_calls(calls)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9B74%3D","line":145,"in_reply_to":"AAAATn%2F9HD0%3D","updated":"2013-12-17 14:25:39.000000000","message":"Hi Armando, thanks for reviewing.  This case has covered both branches(look at #100 and #114), but unfortunately, the expect result of excluded\u003dTrue was wrong.","commit_id":"504f496d6b4fd6234c3e65ba636ee12b004fae1f"}]}