)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c2afa667a726371e4b22b76acd4d42595194e5f7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forbidden create port forwarding to port which has binding fip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For dvr scenario, if port has a binding floating, and then create"},{"line_number":10,"context_line":"port forwarding to it. This port forwarding will not work, due to"},{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_4b79b0f7","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":48},"updated":"2018-11-08 09:35:32.000000000","message":"IMO should be \"has bound floating IP\"","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0f34b4bc7e0eb7df4f6aa57fa48ca5c7f7dd112f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forbidden create port forwarding to port which has binding fip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For dvr scenario, if port has a binding floating, and then create"},{"line_number":10,"context_line":"port forwarding to it. This port forwarding will not work, due to"},{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_930e13d6","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":48},"in_reply_to":"3f79a3b5_4b79b0f7","updated":"2018-11-08 16:05:59.000000000","message":"Done","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c2afa667a726371e4b22b76acd4d42595194e5f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Forbidden create port forwarding to port which has binding fip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For dvr scenario, if port has a binding floating, and then create"},{"line_number":10,"context_line":"port forwarding to it. This port forwarding will not work, due to"},{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch restricted the request from the API, if user try to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_0b673854","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":24},"updated":"2018-11-08 09:35:32.000000000","message":"nit: IMO should be \", this port\"","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0f34b4bc7e0eb7df4f6aa57fa48ca5c7f7dd112f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Forbidden create port forwarding to port which has binding fip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For dvr scenario, if port has a binding floating, and then create"},{"line_number":10,"context_line":"port forwarding to it. This port forwarding will not work, due to"},{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch restricted the request from the API, if user try to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_33cfff8b","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":24},"in_reply_to":"3f79a3b5_0b673854","updated":"2018-11-08 16:05:59.000000000","message":"Done","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c2afa667a726371e4b22b76acd4d42595194e5f7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"port forwarding to it. This port forwarding will not work, due to"},{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch restricted the request from the API, if user try to"},{"line_number":14,"context_line":"create port forwarding to a port, check if it has binding floating"},{"line_number":15,"context_line":"IP first. This will be run for all type of routers, since neutron"},{"line_number":16,"context_line":"should not let user to waste public IP address on a port which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_cb45c09d","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":46},"updated":"2018-11-08 09:35:32.000000000","message":"IMO better would be something like \"restricts such API request, \"","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0f34b4bc7e0eb7df4f6aa57fa48ca5c7f7dd112f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"port forwarding to it. This port forwarding will not work, due to"},{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch restricted the request from the API, if user try to"},{"line_number":14,"context_line":"create port forwarding to a port, check if it has binding floating"},{"line_number":15,"context_line":"IP first. This will be run for all type of routers, since neutron"},{"line_number":16,"context_line":"should not let user to waste public IP address on a port which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_13d8c34e","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":46},"in_reply_to":"3f79a3b5_cb45c09d","updated":"2018-11-08 16:05:59.000000000","message":"Done","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c2afa667a726371e4b22b76acd4d42595194e5f7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch restricted the request from the API, if user try to"},{"line_number":14,"context_line":"create port forwarding to a port, check if it has binding floating"},{"line_number":15,"context_line":"IP first. This will be run for all type of routers, since neutron"},{"line_number":16,"context_line":"should not let user to waste public IP address on a port which"},{"line_number":17,"context_line":"already has a floating IP, it can take care all the procotol port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_8bc10800","line":14,"range":{"start_line":14,"start_character":50,"end_line":14,"end_character":66},"updated":"2018-11-08 09:35:32.000000000","message":"bound floating IP","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0f34b4bc7e0eb7df4f6aa57fa48ca5c7f7dd112f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the traffic is redirected to dvr rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch restricted the request from the API, if user try to"},{"line_number":14,"context_line":"create port forwarding to a port, check if it has binding floating"},{"line_number":15,"context_line":"IP first. This will be run for all type of routers, since neutron"},{"line_number":16,"context_line":"should not let user to waste public IP address on a port which"},{"line_number":17,"context_line":"already has a floating IP, it can take care all the procotol port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_d3dd6b3f","line":14,"range":{"start_line":14,"start_character":50,"end_line":14,"end_character":66},"in_reply_to":"3f79a3b5_8bc10800","updated":"2018-11-08 16:05:59.000000000","message":"Done","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"}],"neutron/services/portforwarding/common/exceptions.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c2afa667a726371e4b22b76acd4d42595194e5f7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    message \u003d _(\"Floating IP %(id)s in use by Port Forwarding resources.\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class PortHasBindingFloatingIP(n_exc.InUse):"},{"line_number":33,"context_line":"    message \u003d _(\"Cannot create port forwarding to floating IP \""},{"line_number":34,"context_line":"                \"%(floating_ip_address)s (%(fip_id)s) with port %(port_id)s \""},{"line_number":35,"context_line":"                \"using fixed IP %(fixed_ip)s, as that port already \""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0bd5f8b7","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":20},"updated":"2018-11-08 09:35:32.000000000","message":"Bound","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d3bee9ee872e0ddf14cd804547566b46a3dd7337","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    message \u003d _(\"Cannot create port forwarding to floating IP \""},{"line_number":34,"context_line":"                \"%(floating_ip_address)s (%(fip_id)s) with port %(port_id)s \""},{"line_number":35,"context_line":"                \"using fixed IP %(fixed_ip)s, as that port already \""},{"line_number":36,"context_line":"                \"has a binding floating IP.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f57d4ec3","line":36,"updated":"2018-11-04 17:59:13.000000000","message":"has bound floating IP","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"}],"neutron/services/portforwarding/pf_plugin.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c2afa667a726371e4b22b76acd4d42595194e5f7","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            raise lib_exc.BadRequest(resource\u003dapidef.RESOURCE_NAME,"},{"line_number":278,"context_line":"                                     msg\u003dmessage)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2bfb1448","line":280,"range":{"start_line":280,"start_character":24,"end_line":280,"end_character":31},"updated":"2018-11-08 09:35:32.000000000","message":"\"bound\" would be better IMHO","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d3bee9ee872e0ddf14cd804547566b46a3dd7337","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"},{"line_number":286,"context_line":"            floating_ip_address \u003d floatingip_obj[0].floating_ip_address"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_958c1ad9","line":283,"updated":"2018-11-04 17:59:13.000000000","message":"why You need elevated context here?","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c2afa667a726371e4b22b76acd4d42595194e5f7","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"},{"line_number":286,"context_line":"            floating_ip_address \u003d floatingip_obj[0].floating_ip_address"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_6b9a6c12","line":283,"in_reply_to":"3f79a3b5_1d14b04f","updated":"2018-11-08 09:35:32.000000000","message":"ok","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"33886c5e3f060508bf5fbe15078b4b92108eed33","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"},{"line_number":286,"context_line":"            floating_ip_address \u003d floatingip_obj[0].floating_ip_address"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_1d14b04f","line":283,"in_reply_to":"3f79a3b5_958c1ad9","updated":"2018-11-05 05:56:39.000000000","message":"Admin can manipulate all resource, aka admin user can create a floating IP binding to one tenant port, this is invisible to a normal user.","commit_id":"57cdce799dde638d71836f218ba6af4798cec3f5"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"32fbf5d84c14f5e72aaeb2bd1f7da16596c1be6c","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9d605ca0","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":54},"updated":"2018-11-08 20:36:16.000000000","message":"It seems we can use get_object (instead of get_objects) since we care the first object only.\n\nHowever, if we choose to use get_objects, the variable should be renamed to floatingip_objs (add \u0027s\u0027) to avoid confusion.","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"889f1ea9a33a2161336081bc96a37798bc11e66b","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6f9ed855","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":54},"in_reply_to":"3f79a3b5_0fd16456","updated":"2018-11-09 15:34:27.000000000","message":"Ignore the upper comment, I mixed it with another patch....","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fb697a986ae1c1e736003169e25ee241860bdd00","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f0e7240f","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":54},"in_reply_to":"3f79a3b5_9d605ca0","updated":"2018-11-09 17:02:26.000000000","message":"Done","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"81bb3f9c2ecff2348c7eb9a0ab858004918cdc0d","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6d6a56b4","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":54},"in_reply_to":"3f79a3b5_9d605ca0","updated":"2018-11-10 11:03:51.000000000","message":"FYI: get_object does not work. Revert to get_objects.","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f3e3b441e0c0dfb47dad1883b9892a677ee77e4b","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _check_port_has_binding_floating_ip(self, context, port_forwarding):"},{"line_number":281,"context_line":"        port_id \u003d port_forwarding[\u0027internal_port_id\u0027]"},{"line_number":282,"context_line":"        floatingip_obj \u003d l3_obj.FloatingIP.get_objects("},{"line_number":283,"context_line":"            context.elevated(),"},{"line_number":284,"context_line":"            fixed_port_id\u003dport_id)"},{"line_number":285,"context_line":"        if floatingip_obj:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0fd16456","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":54},"in_reply_to":"3f79a3b5_9d605ca0","updated":"2018-11-09 15:31:27.000000000","message":"One port can have multiple port forwarding floating IP, so get_objects looks more reasonable, I will add a test for this.","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"32fbf5d84c14f5e72aaeb2bd1f7da16596c1be6c","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        port_forwarding \u003d port_forwarding.get(apidef.RESOURCE_NAME)"},{"line_number":297,"context_line":"        port_forwarding[\u0027floatingip_id\u0027] \u003d floatingip_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        self._check_port_has_binding_floating_ip(context, port_forwarding)"},{"line_number":300,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":301,"context_line":"            fip_obj \u003d self._get_fip_obj(context, floatingip_id)"},{"line_number":302,"context_line":"            if fip_obj.fixed_port_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_7ddea06b","line":299,"range":{"start_line":299,"start_character":13,"end_line":299,"end_character":48},"updated":"2018-11-08 20:36:16.000000000","message":"Two questions:\n\n* Should we move this inside the context_writer below so that we can avoid opening another DB connection for this check.\n* Does update_floatingip_port_forwarding needs this check as well? It looks internal_port_id is allowed to be updated so if users update the portforwarding\u0027s internal_port_id to a bound port, the same problem will occur?","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"eab512a392d7ef3fc93bbf8c3b0ad435e9db198a","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        port_forwarding \u003d port_forwarding.get(apidef.RESOURCE_NAME)"},{"line_number":297,"context_line":"        port_forwarding[\u0027floatingip_id\u0027] \u003d floatingip_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        self._check_port_has_binding_floating_ip(context, port_forwarding)"},{"line_number":300,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":301,"context_line":"            fip_obj \u003d self._get_fip_obj(context, floatingip_id)"},{"line_number":302,"context_line":"            if fip_obj.fixed_port_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_8a8ec277","line":299,"range":{"start_line":299,"start_character":13,"end_line":299,"end_character":48},"in_reply_to":"3f79a3b5_6f46d824","updated":"2018-11-09 16:02:29.000000000","message":"ACK","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f3e3b441e0c0dfb47dad1883b9892a677ee77e4b","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        port_forwarding \u003d port_forwarding.get(apidef.RESOURCE_NAME)"},{"line_number":297,"context_line":"        port_forwarding[\u0027floatingip_id\u0027] \u003d floatingip_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        self._check_port_has_binding_floating_ip(context, port_forwarding)"},{"line_number":300,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":301,"context_line":"            fip_obj \u003d self._get_fip_obj(context, floatingip_id)"},{"line_number":302,"context_line":"            if fip_obj.fixed_port_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6f46d824","line":299,"range":{"start_line":299,"start_character":13,"end_line":299,"end_character":48},"in_reply_to":"3f79a3b5_7ddea06b","updated":"2018-11-09 15:31:27.000000000","message":"1. There too many logical code under the following transaction, and there are some code were written in such style, so IMO, it is OK.\n\n2. I will test such scenario.","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fb697a986ae1c1e736003169e25ee241860bdd00","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        port_forwarding \u003d port_forwarding.get(apidef.RESOURCE_NAME)"},{"line_number":297,"context_line":"        port_forwarding[\u0027floatingip_id\u0027] \u003d floatingip_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        self._check_port_has_binding_floating_ip(context, port_forwarding)"},{"line_number":300,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":301,"context_line":"            fip_obj \u003d self._get_fip_obj(context, floatingip_id)"},{"line_number":302,"context_line":"            if fip_obj.fixed_port_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d0ba28de","line":299,"range":{"start_line":299,"start_character":13,"end_line":299,"end_character":48},"in_reply_to":"3f79a3b5_7ddea06b","updated":"2018-11-09 17:02:26.000000000","message":"Done","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"}],"neutron/tests/functional/services/portforwarding/test_port_forwarding.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f5268383d67b89d4ba0ca85dba7703283d54b477","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                          self.context, self.fip[\u0027id\u0027], self.port_forwarding)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_create_floatingip_port_forwarding_port_in_use(self):"},{"line_number":129,"context_line":"        fip_2 \u003d self._create_floatingip(self.ext_net[\u0027id\u0027])"},{"line_number":130,"context_line":"        self._update_floatingip(fip_2[\u0027id\u0027], {\u0027port_id\u0027: self.port[\u0027id\u0027]})"},{"line_number":131,"context_line":"        self.assertRaises("},{"line_number":132,"context_line":"            pf_exc.PortHasBindingFloatingIP,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_3dc34808","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":13},"updated":"2018-11-08 21:06:33.000000000","message":"nit: if there is no fip_1, the name fip_2 would look a bit odd.","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fb697a986ae1c1e736003169e25ee241860bdd00","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                          self.context, self.fip[\u0027id\u0027], self.port_forwarding)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_create_floatingip_port_forwarding_port_in_use(self):"},{"line_number":129,"context_line":"        fip_2 \u003d self._create_floatingip(self.ext_net[\u0027id\u0027])"},{"line_number":130,"context_line":"        self._update_floatingip(fip_2[\u0027id\u0027], {\u0027port_id\u0027: self.port[\u0027id\u0027]})"},{"line_number":131,"context_line":"        self.assertRaises("},{"line_number":132,"context_line":"            pf_exc.PortHasBindingFloatingIP,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_90d7d021","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":13},"in_reply_to":"3f79a3b5_0f2de443","updated":"2018-11-09 17:02:26.000000000","message":"Done","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f3e3b441e0c0dfb47dad1883b9892a677ee77e4b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                          self.context, self.fip[\u0027id\u0027], self.port_forwarding)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_create_floatingip_port_forwarding_port_in_use(self):"},{"line_number":129,"context_line":"        fip_2 \u003d self._create_floatingip(self.ext_net[\u0027id\u0027])"},{"line_number":130,"context_line":"        self._update_floatingip(fip_2[\u0027id\u0027], {\u0027port_id\u0027: self.port[\u0027id\u0027]})"},{"line_number":131,"context_line":"        self.assertRaises("},{"line_number":132,"context_line":"            pf_exc.PortHasBindingFloatingIP,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0f2de443","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":13},"in_reply_to":"3f79a3b5_3dc34808","updated":"2018-11-09 15:31:27.000000000","message":"Self.fip is considered as fip_1, see line 134, adds a new floating IP for the test. I will change the name to ``normal_fip``.","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"}],"neutron/tests/unit/services/portforwarding/test_pf_plugin.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f5268383d67b89d4ba0ca85dba7703283d54b477","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                    \u0027internal_port_id\u0027: \u0027internal_neutron_port\u0027,"},{"line_number":348,"context_line":"                    \u0027floatingip_id\u0027: \u0027fip_id\u0027}},"},{"line_number":349,"context_line":"            \u0027floatingip_id\u0027: \u0027fip_id\u0027}"},{"line_number":350,"context_line":"        fip_obj \u003d mock.Mock()"},{"line_number":351,"context_line":"        fip_obj.floating_ip_address \u003d \"10.10.10.10\""},{"line_number":352,"context_line":"        mock_fip_get_objects.return_value \u003d [fip_obj]"},{"line_number":353,"context_line":"        self.assertRaises(pf_exc.PortHasBindingFloatingIP,"},{"line_number":354,"context_line":"                          self.pf_plugin.create_floatingip_port_forwarding,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1d9a0c11","line":351,"range":{"start_line":350,"start_character":0,"end_line":351,"end_character":51},"updated":"2018-11-08 21:06:33.000000000","message":"nit: i guess it can be combined into one line.\n\n  fip_obj \u003d mock.Mock(floating_ip_address \u003d \"10.10.10.10\")","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fb697a986ae1c1e736003169e25ee241860bdd00","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                    \u0027internal_port_id\u0027: \u0027internal_neutron_port\u0027,"},{"line_number":348,"context_line":"                    \u0027floatingip_id\u0027: \u0027fip_id\u0027}},"},{"line_number":349,"context_line":"            \u0027floatingip_id\u0027: \u0027fip_id\u0027}"},{"line_number":350,"context_line":"        fip_obj \u003d mock.Mock()"},{"line_number":351,"context_line":"        fip_obj.floating_ip_address \u003d \"10.10.10.10\""},{"line_number":352,"context_line":"        mock_fip_get_objects.return_value \u003d [fip_obj]"},{"line_number":353,"context_line":"        self.assertRaises(pf_exc.PortHasBindingFloatingIP,"},{"line_number":354,"context_line":"                          self.pf_plugin.create_floatingip_port_forwarding,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_50ddb83c","line":351,"range":{"start_line":350,"start_character":0,"end_line":351,"end_character":51},"in_reply_to":"3f79a3b5_1d9a0c11","updated":"2018-11-09 17:02:26.000000000","message":"Done","commit_id":"eca0a1326744b0177c1d3fd7614006ee38206543"}]}
