)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0c5f7802be4c0f338e962fe9214d229916143462","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If one port has port forwarding and the port is under"},{"line_number":10,"context_line":"a dvr router, then binding floating IP to this port"},{"line_number":11,"context_line":"will not be allowed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia014e18264b43cf751a5bc0e82bc55d106582620"},{"line_number":14,"context_line":"Closes-Bug: #1799138"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1f769fc5_9a69ed26","line":11,"updated":"2018-12-27 09:31:33.000000000","message":"So IIUC this means that in case of DVR You can only configure one TCP/UDP port to be forwarding per Floating IP, right?\nIf yes, does it makes sense to use port forwarding in such case?\nAnd second question, shouldn\u0027t You update maybe some docs to mention such limitation?","commit_id":"1c1ae1f5f20df9fb464bceb272299827842eefb2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"59188bc05d4bebd2390eb3c897d498a684a47ba7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If one port has port forwarding and the port is under"},{"line_number":10,"context_line":"a dvr router, then binding floating IP to this port"},{"line_number":11,"context_line":"will not be allowed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia014e18264b43cf751a5bc0e82bc55d106582620"},{"line_number":14,"context_line":"Closes-Bug: #1799138"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1f769fc5_cb08f929","line":11,"in_reply_to":"1f769fc5_20674c50","updated":"2018-12-27 14:30:33.000000000","message":"release note added.","commit_id":"1c1ae1f5f20df9fb464bceb272299827842eefb2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5fd9b98eddf1935d003c933a43c9d5ee4e4ddb6f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If one port has port forwarding and the port is under"},{"line_number":10,"context_line":"a dvr router, then binding floating IP to this port"},{"line_number":11,"context_line":"will not be allowed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia014e18264b43cf751a5bc0e82bc55d106582620"},{"line_number":14,"context_line":"Closes-Bug: #1799138"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1f769fc5_20674c50","line":11,"in_reply_to":"1f769fc5_9a69ed26","updated":"2018-12-27 14:02:11.000000000","message":"No, user can create multiple port forwardings to one neutron_port, but the internal port number should be different if the protocol is same.\nWith different protocols, the port forwardings to one neutron_port can have same internal port number.\n\nI\u0027ll add a release note or update current user doc.","commit_id":"1c1ae1f5f20df9fb464bceb272299827842eefb2"}],"neutron/services/portforwarding/common/exceptions.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5cf8dabd59f5fe4b49b5f4f14c69fc5d7cbc9aee","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class PortHasPortForwarding(n_exc.BadRequest):"},{"line_number":29,"context_line":"    message \u003d _(\"Cannot associate floating IP %(fip_id)s to port \""},{"line_number":30,"context_line":"                \"%(port_id)s because it has binding port \""},{"line_number":31,"context_line":"                \"forwarding\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class FipInUseByPortForwarding(n_exc.InUse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7f7da66e","line":31,"range":{"start_line":30,"start_character":40,"end_line":31,"end_character":27},"updated":"2018-11-02 21:50:47.000000000","message":"s/already has a Port Forwarding binding. (was missing trailing period as well)\n\nDoes that wording sound Ok?","commit_id":"481036b08199bd2215bf080d2b5dba282d1be8dc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d41d859a4e0575bfe13d3d6586bc32440d6e6627","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class PortHasPortForwarding(n_exc.BadRequest):"},{"line_number":29,"context_line":"    message \u003d _(\"Cannot associate floating IP %(fip_id)s to port \""},{"line_number":30,"context_line":"                \"%(port_id)s because it has binding port \""},{"line_number":31,"context_line":"                \"forwarding\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class FipInUseByPortForwarding(n_exc.InUse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bd725c4a","line":31,"range":{"start_line":30,"start_character":40,"end_line":31,"end_character":27},"in_reply_to":"3f79a3b5_7f7da66e","updated":"2018-11-05 04:21:21.000000000","message":"Done","commit_id":"481036b08199bd2215bf080d2b5dba282d1be8dc"}],"neutron/services/portforwarding/pf_plugin.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6c234709bfc5751d5a8df771427062728ff8b229","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        floatingip_id \u003d kwargs[\u0027floatingip_id\u0027]"},{"line_number":111,"context_line":"        port_id \u003d kwargs[\u0027floatingip\u0027].get(\u0027port_id\u0027)"},{"line_number":112,"context_line":"        if port_id:"},{"line_number":113,"context_line":"            self._check_port_has_port_forwarding(context, floatingip_id,"},{"line_number":114,"context_line":"                                                 port_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _check_port_has_port_forwarding(self, context, port_id, fip_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c008bd26","line":113,"range":{"start_line":113,"start_character":17,"end_line":113,"end_character":48},"updated":"2018-11-01 20:58:57.000000000","message":"Could we skip this check if the \u0027dvr\u0027 extension is not present? I am not sure. Just want to ask.","commit_id":"cf528d2b7632652aaebef8ce3fe522e20c7e6783"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6afa96c7da78a9f1e97c7cb21be8816bd6db2780","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        floatingip_id \u003d kwargs[\u0027floatingip_id\u0027]"},{"line_number":111,"context_line":"        port_id \u003d kwargs[\u0027floatingip\u0027].get(\u0027port_id\u0027)"},{"line_number":112,"context_line":"        if port_id:"},{"line_number":113,"context_line":"            self._check_port_has_port_forwarding(context, floatingip_id,"},{"line_number":114,"context_line":"                                                 port_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _check_port_has_port_forwarding(self, context, port_id, fip_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d6cf1c88","line":113,"range":{"start_line":113,"start_character":17,"end_line":113,"end_character":48},"in_reply_to":"3f79a3b5_c008bd26","updated":"2018-11-02 11:23:21.000000000","message":"dvr router can be created before you disable the dvr extension.","commit_id":"cf528d2b7632652aaebef8ce3fe522e20c7e6783"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6c234709bfc5751d5a8df771427062728ff8b229","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        pf_objs \u003d pf.PortForwarding.get_objects("},{"line_number":118,"context_line":"            context, internal_neutron_port_id\u003dport_id)"},{"line_number":119,"context_line":"        for port_forwading in pf_objs:"},{"line_number":120,"context_line":"            # Port may not binding to host yet, port may migrate from a"},{"line_number":121,"context_line":"            # dvr_no_external host to dvr host. So we just do not allow all"},{"line_number":122,"context_line":"            # dvr router\u0027s floating IP to be binded to a port which already"},{"line_number":123,"context_line":"            # has port forwarding."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_25ff436a","line":120,"range":{"start_line":120,"start_character":27,"end_line":120,"end_character":34},"updated":"2018-11-01 20:58:57.000000000","message":"nit: bind","commit_id":"cf528d2b7632652aaebef8ce3fe522e20c7e6783"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6afa96c7da78a9f1e97c7cb21be8816bd6db2780","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        pf_objs \u003d pf.PortForwarding.get_objects("},{"line_number":118,"context_line":"            context, internal_neutron_port_id\u003dport_id)"},{"line_number":119,"context_line":"        for port_forwading in pf_objs:"},{"line_number":120,"context_line":"            # Port may not binding to host yet, port may migrate from a"},{"line_number":121,"context_line":"            # dvr_no_external host to dvr host. So we just do not allow all"},{"line_number":122,"context_line":"            # dvr router\u0027s floating IP to be binded to a port which already"},{"line_number":123,"context_line":"            # has port forwarding."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_166cb469","line":120,"range":{"start_line":120,"start_character":27,"end_line":120,"end_character":34},"in_reply_to":"3f79a3b5_25ff436a","updated":"2018-11-02 11:23:21.000000000","message":"Done","commit_id":"cf528d2b7632652aaebef8ce3fe522e20c7e6783"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6c234709bfc5751d5a8df771427062728ff8b229","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            # dvr_no_external host to dvr host. So we just do not allow all"},{"line_number":122,"context_line":"            # dvr router\u0027s floating IP to be binded to a port which already"},{"line_number":123,"context_line":"            # has port forwarding."},{"line_number":124,"context_line":"            router \u003d self.l3_plugin.get_router(context.elevated(),"},{"line_number":125,"context_line":"                                               port_forwading.router_id)"},{"line_number":126,"context_line":"            if l3_dvr_db.is_distributed_router(router):"},{"line_number":127,"context_line":"                raise pf_exc.PortHasPortForwarding(fip_id\u003dfip_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a5fcb340","line":124,"range":{"start_line":124,"start_character":36,"end_line":124,"end_character":46},"updated":"2018-11-01 20:58:57.000000000","message":"I would advice to do this call outside of the for loop since we want to minimize the number of DB access to optimize the performance. In particular, suggest to do something similar as below (UNTESTED):\n\n        pf_objs \u003d pf.PortForwarding.get_objects(\n            context, internal_neutron_port_id\u003dport_id)\n        router_ids \u003d [obj.router_id for obj in pf_objs]\n        routers \u003d self.l3_plugin.get_routers(context.elevated(), filters\u003d{\u0027id\u0027: router_ids})\n        for router in routers:\n            if l3_dvr_db.is_distributed_router(router):\n                raise pf_exc.PortHasPortForwarding(fip_id\u003dfip_id,\n                                                   port_id\u003dport_id)","commit_id":"cf528d2b7632652aaebef8ce3fe522e20c7e6783"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6afa96c7da78a9f1e97c7cb21be8816bd6db2780","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            # dvr_no_external host to dvr host. So we just do not allow all"},{"line_number":122,"context_line":"            # dvr router\u0027s floating IP to be binded to a port which already"},{"line_number":123,"context_line":"            # has port forwarding."},{"line_number":124,"context_line":"            router \u003d self.l3_plugin.get_router(context.elevated(),"},{"line_number":125,"context_line":"                                               port_forwading.router_id)"},{"line_number":126,"context_line":"            if l3_dvr_db.is_distributed_router(router):"},{"line_number":127,"context_line":"                raise pf_exc.PortHasPortForwarding(fip_id\u003dfip_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5689cc26","line":124,"range":{"start_line":124,"start_character":36,"end_line":124,"end_character":46},"in_reply_to":"3f79a3b5_a5fcb340","updated":"2018-11-02 11:23:21.000000000","message":"Actually one port forwarding is enough, since port forwarding can not be created cross routers to one same port.","commit_id":"cf528d2b7632652aaebef8ce3fe522e20c7e6783"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5cf8dabd59f5fe4b49b5f4f14c69fc5d7cbc9aee","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        floatingip_id \u003d kwargs[\u0027floatingip_id\u0027]"},{"line_number":111,"context_line":"        port_id \u003d kwargs[\u0027floatingip\u0027].get(\u0027port_id\u0027)"},{"line_number":112,"context_line":"        if port_id:"},{"line_number":113,"context_line":"            self._check_port_has_port_forwarding(context, floatingip_id,"},{"line_number":114,"context_line":"                                                 port_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _check_port_has_port_forwarding(self, context, port_id, fip_id):"},{"line_number":117,"context_line":"        pf_objs \u003d pf.PortForwarding.get_objects("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ff0bf61f","line":114,"range":{"start_line":113,"start_character":58,"end_line":114,"end_character":57},"updated":"2018-11-02 21:50:47.000000000","message":"These arguments are in the wrong order","commit_id":"481036b08199bd2215bf080d2b5dba282d1be8dc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d41d859a4e0575bfe13d3d6586bc32440d6e6627","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        floatingip_id \u003d kwargs[\u0027floatingip_id\u0027]"},{"line_number":111,"context_line":"        port_id \u003d kwargs[\u0027floatingip\u0027].get(\u0027port_id\u0027)"},{"line_number":112,"context_line":"        if port_id:"},{"line_number":113,"context_line":"            self._check_port_has_port_forwarding(context, floatingip_id,"},{"line_number":114,"context_line":"                                                 port_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _check_port_has_port_forwarding(self, context, port_id, fip_id):"},{"line_number":117,"context_line":"        pf_objs \u003d pf.PortForwarding.get_objects("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5d71c844","line":114,"range":{"start_line":113,"start_character":58,"end_line":114,"end_character":57},"in_reply_to":"3f79a3b5_ff0bf61f","updated":"2018-11-05 04:21:21.000000000","message":"Done","commit_id":"481036b08199bd2215bf080d2b5dba282d1be8dc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fbde02d600584f0bba6526d633a3fc5324d209de","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                               events.BEFORE_UPDATE])"},{"line_number":109,"context_line":"    def _check_port_has_port_forwarding(self, resource, event,"},{"line_number":110,"context_line":"                                        trigger, payload\u003dNone):"},{"line_number":111,"context_line":"        port_id \u003d payload.request_body[\u0027floatingip\u0027].get(\u0027port_id\u0027)"},{"line_number":112,"context_line":"        if not port_id:"},{"line_number":113,"context_line":"            return"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f769fc5_b2ae3be5","line":111,"updated":"2018-12-31 13:43:55.000000000","message":"Looking at change in https://review.openstack.org/#/c/614727/14/neutron/db/l3_db.py isn\u0027t \"request_body\" already \"FloatingIP\" object?","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c9066bca4c6c8aa020d6c1ece302bb1cbb347f83","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                               events.BEFORE_UPDATE])"},{"line_number":109,"context_line":"    def _check_port_has_port_forwarding(self, resource, event,"},{"line_number":110,"context_line":"                                        trigger, payload\u003dNone):"},{"line_number":111,"context_line":"        port_id \u003d payload.request_body[\u0027floatingip\u0027].get(\u0027port_id\u0027)"},{"line_number":112,"context_line":"        if not port_id:"},{"line_number":113,"context_line":"            return"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f769fc5_d273b7e6","line":111,"in_reply_to":"1f769fc5_b2ae3be5","updated":"2018-12-31 16:42:02.000000000","message":"No, it\u0027s an API input, these are some relevant code there:\nhttps://review.openstack.org/#/c/614727/14/neutron/db/l3_db.py@1347\nhttps://review.openstack.org/#/c/614727/14/neutron/db/l3_db.py@1347","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"81862f4fa58336fff6471415d57f4cb325b36291","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                               events.BEFORE_UPDATE])"},{"line_number":109,"context_line":"    def _check_port_has_port_forwarding(self, resource, event,"},{"line_number":110,"context_line":"                                        trigger, payload\u003dNone):"},{"line_number":111,"context_line":"        port_id \u003d payload.request_body[\u0027floatingip\u0027].get(\u0027port_id\u0027)"},{"line_number":112,"context_line":"        if not port_id:"},{"line_number":113,"context_line":"            return"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f769fc5_57ab111c","line":111,"in_reply_to":"1f769fc5_d273b7e6","updated":"2019-01-02 08:53:52.000000000","message":"Ok, now I checked how it looks in neutron-lib and it\u0027s fine like it\u0027s now","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fbde02d600584f0bba6526d633a3fc5324d209de","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # already has port forwarding."},{"line_number":123,"context_line":"        router \u003d self.l3_plugin.get_router(payload.context.elevated(),"},{"line_number":124,"context_line":"                                           pf_objs[0].router_id)"},{"line_number":125,"context_line":"        if l3_dvr_db.is_distributed_router(router):"},{"line_number":126,"context_line":"            raise pf_exc.PortHasPortForwarding(port_id\u003dport_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @registry.receives(resources.FLOATING_IP, [events.PRECOMMIT_UPDATE,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f769fc5_f27d936e","line":125,"updated":"2018-12-31 13:43:55.000000000","message":"Ok, I understand now that this exception will be raised in case when user will try to associate FIP to port when this FIP has already some port forwarding configured, right?\nIf so, I have one more question. Why it\u0027s only for DVR routers? What about legacy routers? Shouldn\u0027t this be forbidden also?","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"81862f4fa58336fff6471415d57f4cb325b36291","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # already has port forwarding."},{"line_number":123,"context_line":"        router \u003d self.l3_plugin.get_router(payload.context.elevated(),"},{"line_number":124,"context_line":"                                           pf_objs[0].router_id)"},{"line_number":125,"context_line":"        if l3_dvr_db.is_distributed_router(router):"},{"line_number":126,"context_line":"            raise pf_exc.PortHasPortForwarding(port_id\u003dport_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @registry.receives(resources.FLOATING_IP, [events.PRECOMMIT_UPDATE,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f769fc5_f7bc9d6a","line":125,"in_reply_to":"1f769fc5_f26cb309","updated":"2019-01-02 08:53:52.000000000","message":"Ok, I understand now. Thx","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c9066bca4c6c8aa020d6c1ece302bb1cbb347f83","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # already has port forwarding."},{"line_number":123,"context_line":"        router \u003d self.l3_plugin.get_router(payload.context.elevated(),"},{"line_number":124,"context_line":"                                           pf_objs[0].router_id)"},{"line_number":125,"context_line":"        if l3_dvr_db.is_distributed_router(router):"},{"line_number":126,"context_line":"            raise pf_exc.PortHasPortForwarding(port_id\u003dport_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @registry.receives(resources.FLOATING_IP, [events.PRECOMMIT_UPDATE,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f769fc5_f26cb309","line":125,"in_reply_to":"1f769fc5_f27d936e","updated":"2018-12-31 16:42:02.000000000","message":"IMO, the LP bug description or the release note has the answer.\nThis patch is trying to avoid floating IP is binding to a `neutron port` , if there already has related portfwarding pointing to that `neutron port`. Only dvr router floating IPs will break the existing port forwarding functionality. Any other centralized routers do not have such issue.","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"}],"neutron/tests/functional/services/portforwarding/test_port_forwarding.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7851e23a2b8344f8fdea416610bf0b5e31d8ea22","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._prepare_env()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _prepare_env(self):"},{"line_number":89,"context_line":"        self.router \u003d self._create_router(distributed\u003dTrue)"},{"line_number":90,"context_line":"        self.ext_net \u003d self._create_network("},{"line_number":91,"context_line":"            self.fmt, \u0027ext-net\u0027, True, arg_list\u003d(\"router:external\",),"},{"line_number":92,"context_line":"            **{\"router:external\": True}).json[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_8050622f","line":89,"updated":"2018-12-17 09:31:12.000000000","message":"Do we need to change router to be distributed in all those tests? Why don\u0027t create distributed router only in test where You really need it?","commit_id":"4645f5ace400c91aa01ac173a040a9aa439c032d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"45b8f2a94217aedd3e76037e3176aad73f271a75","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._prepare_env()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _prepare_env(self):"},{"line_number":89,"context_line":"        self.router \u003d self._create_router(distributed\u003dTrue)"},{"line_number":90,"context_line":"        self.ext_net \u003d self._create_network("},{"line_number":91,"context_line":"            self.fmt, \u0027ext-net\u0027, True, arg_list\u003d(\"router:external\",),"},{"line_number":92,"context_line":"            **{\"router:external\": True}).json[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_a3bb28dc","line":89,"in_reply_to":"3f79a3b5_8050622f","updated":"2018-12-17 09:54:27.000000000","message":"Otherwise in that test case we need add all the following `create` procedure. DRY : )","commit_id":"4645f5ace400c91aa01ac173a040a9aa439c032d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7851e23a2b8344f8fdea416610bf0b5e31d8ea22","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    def test_create_floatingip_port_forwarding_port_in_use(self):"},{"line_number":466,"context_line":"        res \u003d self.pf_plugin.create_floatingip_port_forwarding("},{"line_number":467,"context_line":"            self.context, self.fip[\u0027id\u0027], self.port_forwarding)"},{"line_number":468,"context_line":"        expect \u003d {"},{"line_number":469,"context_line":"            \"external_port\": 2225,"},{"line_number":470,"context_line":"            \"internal_port\": 25,"},{"line_number":471,"context_line":"            \"internal_port_id\": self.port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_20406e5e","line":468,"range":{"start_line":468,"start_character":8,"end_line":468,"end_character":14},"updated":"2018-12-17 09:31:12.000000000","message":"nitty nit: expected","commit_id":"4645f5ace400c91aa01ac173a040a9aa439c032d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"45b8f2a94217aedd3e76037e3176aad73f271a75","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    def test_create_floatingip_port_forwarding_port_in_use(self):"},{"line_number":466,"context_line":"        res \u003d self.pf_plugin.create_floatingip_port_forwarding("},{"line_number":467,"context_line":"            self.context, self.fip[\u0027id\u0027], self.port_forwarding)"},{"line_number":468,"context_line":"        expect \u003d {"},{"line_number":469,"context_line":"            \"external_port\": 2225,"},{"line_number":470,"context_line":"            \"internal_port\": 25,"},{"line_number":471,"context_line":"            \"internal_port_id\": self.port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_03c3fc8d","line":468,"range":{"start_line":468,"start_character":8,"end_line":468,"end_character":14},"in_reply_to":"3f79a3b5_20406e5e","updated":"2018-12-17 09:54:27.000000000","message":"\u0027expect\u0027 stays in this file test cases, haha, : )","commit_id":"4645f5ace400c91aa01ac173a040a9aa439c032d"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"35a94f241d0ff094b6c5fb77d063369ffe14a8dd","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            if arg in kwargs:"},{"line_number":360,"context_line":"                data[\u0027router\u0027][arg] \u003d kwargs[arg]"},{"line_number":361,"context_line":"        if \u0027distributed\u0027 in kwargs:"},{"line_number":362,"context_line":"            data[\u0027router\u0027][\u0027distributed\u0027] \u003d bool(kwargs.get(\u0027distributed\u0027))"},{"line_number":363,"context_line":"        router_req \u003d self.new_create_request(\u0027routers\u0027, data, fmt)"},{"line_number":364,"context_line":"        if set_context and tenant_id:"},{"line_number":365,"context_line":"            # create a specific auth context for this request"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_48311d58","line":362,"range":{"start_line":362,"start_character":49,"end_line":362,"end_character":74},"updated":"2018-11-02 17:04:10.000000000","message":"Nit: kwargs[\u0027distributed\u0027] since you are sure the key is there.","commit_id":"481036b08199bd2215bf080d2b5dba282d1be8dc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d41d859a4e0575bfe13d3d6586bc32440d6e6627","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            if arg in kwargs:"},{"line_number":360,"context_line":"                data[\u0027router\u0027][arg] \u003d kwargs[arg]"},{"line_number":361,"context_line":"        if \u0027distributed\u0027 in kwargs:"},{"line_number":362,"context_line":"            data[\u0027router\u0027][\u0027distributed\u0027] \u003d bool(kwargs.get(\u0027distributed\u0027))"},{"line_number":363,"context_line":"        router_req \u003d self.new_create_request(\u0027routers\u0027, data, fmt)"},{"line_number":364,"context_line":"        if set_context and tenant_id:"},{"line_number":365,"context_line":"            # create a specific auth context for this request"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7d6cc46a","line":362,"range":{"start_line":362,"start_character":49,"end_line":362,"end_character":74},"in_reply_to":"3f79a3b5_48311d58","updated":"2018-11-05 04:21:21.000000000","message":"Done","commit_id":"481036b08199bd2215bf080d2b5dba282d1be8dc"}],"releasenotes/notes/fip-binding-limitation-1d2509950847b085.yaml":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"c0de4f91f16295f079751eda15e66d7d8905b60d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    If an instance port is under a dvr router, and the port already has"},{"line_number":5,"context_line":"    binding port forwarding(s). Neutron will no longer allow binding a"},{"line_number":6,"context_line":"    floating IP to that port again, because dvr floating IP traffic rules"},{"line_number":7,"context_line":"    will break the existing port forwarding functionality."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1f769fc5_84572f03","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":38},"updated":"2019-01-02 16:39:11.000000000","message":"nit: DVR","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fbde02d600584f0bba6526d633a3fc5324d209de","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    If an instance port is under a dvr router, and the port already has"},{"line_number":5,"context_line":"    binding port forwarding(s). Neutron will no longer allow binding a"},{"line_number":6,"context_line":"    floating IP to that port again, because dvr floating IP traffic rules"},{"line_number":7,"context_line":"    will break the existing port forwarding functionality."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1f769fc5_52a007f5","line":5,"range":{"start_line":5,"start_character":30,"end_line":5,"end_character":31},"updated":"2018-12-31 13:43:55.000000000","message":"nitty nit: should be comma probably","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"c0de4f91f16295f079751eda15e66d7d8905b60d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    If an instance port is under a dvr router, and the port already has"},{"line_number":5,"context_line":"    binding port forwarding(s). Neutron will no longer allow binding a"},{"line_number":6,"context_line":"    floating IP to that port again, because dvr floating IP traffic rules"},{"line_number":7,"context_line":"    will break the existing port forwarding functionality."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1f769fc5_44411739","line":6,"range":{"start_line":6,"start_character":44,"end_line":6,"end_character":47},"updated":"2019-01-02 16:39:11.000000000","message":"nit: DVR","commit_id":"8bf0ab5bc77ad20e79aeea1f899580c2d6998793"}]}
