)]}'
{"neutron/agent/linux/bridge_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"862641f86ead5459101f2d8bedc4bdeb4af868fe","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class BridgeDevice(ip_lib.IPDevice):"},{"line_number":55,"context_line":"    def _ip_link(self, cmd):"},{"line_number":56,"context_line":"        cmd \u003d [\u0027ip\u0027, \u0027link\u0027] + cmd"},{"line_number":57,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"},{"line_number":58,"context_line":"        return ip_wrapper.netns.execute(cmd, run_as_root\u003dTrue)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4e587024","line":56,"updated":"2018-11-15 08:38:27.000000000","message":"can\u0027t this be done directly using privsep and pyroute2 libs?","commit_id":"2572c158f5290ddc3bc2e4f06ecbd4768c82eee4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecc36d0f5ce5a4e5022c5f33be15c8c53e012a3b","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class BridgeDevice(ip_lib.IPDevice):"},{"line_number":55,"context_line":"    def _ip_link(self, cmd):"},{"line_number":56,"context_line":"        cmd \u003d [\u0027ip\u0027, \u0027link\u0027] + cmd"},{"line_number":57,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"},{"line_number":58,"context_line":"        return ip_wrapper.netns.execute(cmd, run_as_root\u003dTrue)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7f8aadbd","line":56,"in_reply_to":"3f79a3b5_3f93d5b2","updated":"2018-11-15 19:52:39.000000000","message":"I understand Your point Brian. That\u0027s why I +2 this already :)","commit_id":"2572c158f5290ddc3bc2e4f06ecbd4768c82eee4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1816c212a2cbc65f03e1d75c1d465c06620eb234","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class BridgeDevice(ip_lib.IPDevice):"},{"line_number":55,"context_line":"    def _ip_link(self, cmd):"},{"line_number":56,"context_line":"        cmd \u003d [\u0027ip\u0027, \u0027link\u0027] + cmd"},{"line_number":57,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"},{"line_number":58,"context_line":"        return ip_wrapper.netns.execute(cmd, run_as_root\u003dTrue)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_698f6677","line":56,"in_reply_to":"3f79a3b5_4e587024","updated":"2018-11-15 09:38:02.000000000","message":"Yes, it can be done. Actually I thought that this migration was going to be based in pyroute.\n\nCreate bridge:\n  ipdb.create(kind\u003d\u0027bridge\u0027, ifname\u003d\u0027control\u0027)\n\nAdd port\n  with ipdb.create(kind\u003d\u0027bridge\u0027, ifname\u003d\u0027control\u0027) as i:\n    i.add_port(ip.interfaces.eth1)\n    i.add_ip(\u002710.0.0.1/24\u0027)\n\nDel port\n  with ipdb.create(kind\u003d\u0027bridge\u0027, ifname\u003d\u0027control\u0027) as i:\n    i.del_port(ip.interfaces.eth1)\n\nSet fd:\n  with ipdb.create(kind\u003d\u0027bridge\u0027, ifname\u003d\u0027control\u0027) as i:\n    i.br_forward_delay \u003d int(fd)\n\nDisable stp:\n  with ipdb.create(kind\u003d\u0027bridge\u0027, ifname\u003d\u0027control\u0027) as i:\n    i.br_stp_state \u003d 0","commit_id":"2572c158f5290ddc3bc2e4f06ecbd4768c82eee4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"852bb0802ee8c92b7674a63d2edaea6055247251","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class BridgeDevice(ip_lib.IPDevice):"},{"line_number":55,"context_line":"    def _ip_link(self, cmd):"},{"line_number":56,"context_line":"        cmd \u003d [\u0027ip\u0027, \u0027link\u0027] + cmd"},{"line_number":57,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"},{"line_number":58,"context_line":"        return ip_wrapper.netns.execute(cmd, run_as_root\u003dTrue)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3f93d5b2","line":56,"in_reply_to":"3f79a3b5_698f6677","updated":"2018-11-15 18:53:05.000000000","message":"I did the create/delete using the ip_lib code that uses pyroute2, but in an effort to merge quicker I did some using /sbin/ip figuring it could be moved to use pyroute2 as a follow-on.  Maybe it\u0027s simpler than I thought but it seemed to be more involved as I looked at the privileged/ip_lib code.","commit_id":"2572c158f5290ddc3bc2e4f06ecbd4768c82eee4"}]}
