)]}'
{"neutron/agent/common/async_process.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ea8640a62f781a74be3741438ee5503de73e8d2d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        :param kill_signal: Number of signal that will be sent to the process"},{"line_number":126,"context_line":"                            when terminating the process"},{"line_number":127,"context_line":"        :param kill_timeout: If given, process will be killed with SIGKILL"},{"line_number":128,"context_line":"                             this timeout will be reached and process will"},{"line_number":129,"context_line":"                             still be running"},{"line_number":130,"context_line":"        :raises utils.WaitTimeout if blocking is True and the process"},{"line_number":131,"context_line":"                did not stop in time."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_12fe206d","line":128,"range":{"start_line":128,"start_character":29,"end_line":128,"end_character":33},"updated":"2018-11-14 21:00:09.000000000","message":"if?","commit_id":"1c4d1c6f4c2707d25f1ec9d54542fadd08d21bfe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"729b79e15ad6e0d05bc8941200eb56b4b86271f3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        :param kill_signal: Number of signal that will be sent to the process"},{"line_number":126,"context_line":"                            when terminating the process"},{"line_number":127,"context_line":"        :param kill_timeout: If given, process will be killed with SIGKILL"},{"line_number":128,"context_line":"                             this timeout will be reached and process will"},{"line_number":129,"context_line":"                             still be running"},{"line_number":130,"context_line":"        :raises utils.WaitTimeout if blocking is True and the process"},{"line_number":131,"context_line":"                did not stop in time."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_721674a4","line":128,"range":{"start_line":128,"start_character":29,"end_line":128,"end_character":33},"in_reply_to":"3f79a3b5_12fe206d","updated":"2018-11-14 21:03:27.000000000","message":"Done","commit_id":"1c4d1c6f4c2707d25f1ec9d54542fadd08d21bfe"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ea8640a62f781a74be3741438ee5503de73e8d2d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                self._process.wait(kill_timeout)"},{"line_number":197,"context_line":"            except subprocess.TimeoutExpired:"},{"line_number":198,"context_line":"                LOG.warning(\"Process %(pid)s [%(cmd)s] still running after \""},{"line_number":199,"context_line":"                            \"%(timeout)s seconds. Sending %(signal)s to kill \""},{"line_number":200,"context_line":"                            \"it.\","},{"line_number":201,"context_line":"                            {\u0027pid\u0027: pid,"},{"line_number":202,"context_line":"                             \u0027cmd\u0027: self.cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_32031c78","line":199,"range":{"start_line":199,"start_character":39,"end_line":199,"end_character":40},"updated":"2018-11-14 21:00:09.000000000","message":"d","commit_id":"1c4d1c6f4c2707d25f1ec9d54542fadd08d21bfe"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ea8640a62f781a74be3741438ee5503de73e8d2d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                self._process.wait(kill_timeout)"},{"line_number":197,"context_line":"            except subprocess.TimeoutExpired:"},{"line_number":198,"context_line":"                LOG.warning(\"Process %(pid)s [%(cmd)s] still running after \""},{"line_number":199,"context_line":"                            \"%(timeout)s seconds. Sending %(signal)s to kill \""},{"line_number":200,"context_line":"                            \"it.\","},{"line_number":201,"context_line":"                            {\u0027pid\u0027: pid,"},{"line_number":202,"context_line":"                             \u0027cmd\u0027: self.cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d2f7488e","line":199,"range":{"start_line":199,"start_character":67,"end_line":199,"end_character":68},"updated":"2018-11-14 21:00:09.000000000","message":"d","commit_id":"1c4d1c6f4c2707d25f1ec9d54542fadd08d21bfe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"729b79e15ad6e0d05bc8941200eb56b4b86271f3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                self._process.wait(kill_timeout)"},{"line_number":197,"context_line":"            except subprocess.TimeoutExpired:"},{"line_number":198,"context_line":"                LOG.warning(\"Process %(pid)s [%(cmd)s] still running after \""},{"line_number":199,"context_line":"                            \"%(timeout)s seconds. Sending %(signal)s to kill \""},{"line_number":200,"context_line":"                            \"it.\","},{"line_number":201,"context_line":"                            {\u0027pid\u0027: pid,"},{"line_number":202,"context_line":"                             \u0027cmd\u0027: self.cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_12714014","line":199,"range":{"start_line":199,"start_character":39,"end_line":199,"end_character":40},"in_reply_to":"3f79a3b5_32031c78","updated":"2018-11-14 21:03:27.000000000","message":"Done","commit_id":"1c4d1c6f4c2707d25f1ec9d54542fadd08d21bfe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"729b79e15ad6e0d05bc8941200eb56b4b86271f3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                self._process.wait(kill_timeout)"},{"line_number":197,"context_line":"            except subprocess.TimeoutExpired:"},{"line_number":198,"context_line":"                LOG.warning(\"Process %(pid)s [%(cmd)s] still running after \""},{"line_number":199,"context_line":"                            \"%(timeout)s seconds. Sending %(signal)s to kill \""},{"line_number":200,"context_line":"                            \"it.\","},{"line_number":201,"context_line":"                            {\u0027pid\u0027: pid,"},{"line_number":202,"context_line":"                             \u0027cmd\u0027: self.cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3276bc0d","line":199,"range":{"start_line":199,"start_character":67,"end_line":199,"end_character":68},"in_reply_to":"3f79a3b5_d2f7488e","updated":"2018-11-14 21:03:27.000000000","message":"Done","commit_id":"1c4d1c6f4c2707d25f1ec9d54542fadd08d21bfe"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"d23f491a8537f2cbf7bee87c757fe9aa2b3b1a37","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                             \u0027cmd\u0027: self.cmd,"},{"line_number":203,"context_line":"                             \u0027timeout\u0027: kill_timeout,"},{"line_number":204,"context_line":"                             \u0027signal\u0027: signal.SIGKILL})"},{"line_number":205,"context_line":"                utils.kill_process(pid, signal.SIGKILL, self.run_as_root)"},{"line_number":206,"context_line":"        return True"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _handle_process_error(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_19fdd96c","line":205,"updated":"2018-11-15 17:08:44.000000000","message":"This is probably excessive error handling, but what happens if this raises an exception like we handle on L189? I imagine it\u0027s unlikely, but in case it happens it looks like the onus is on the caller to handle it.","commit_id":"8817476e75b6f5f97473af3c806a5463e05ca620"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"15200723483149f966d1410512d494a9609062f8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                             \u0027cmd\u0027: self.cmd,"},{"line_number":203,"context_line":"                             \u0027timeout\u0027: kill_timeout,"},{"line_number":204,"context_line":"                             \u0027signal\u0027: signal.SIGKILL})"},{"line_number":205,"context_line":"                utils.kill_process(pid, signal.SIGKILL, self.run_as_root)"},{"line_number":206,"context_line":"        return True"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _handle_process_error(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e2fffa00","line":205,"in_reply_to":"3f79a3b5_19fdd96c","updated":"2018-11-16 14:51:04.000000000","message":"You\u0027re right. I changed it.","commit_id":"8817476e75b6f5f97473af3c806a5463e05ca620"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7d380e683e7b582428d1ab4282ee819375010e18","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                return self._kill_process(pid, signal.SIGKILL)"},{"line_number":201,"context_line":"        return True"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _kill_process(self, pid, kill_signal):"},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            # A process started by a root helper will be running as"},{"line_number":206,"context_line":"            # root and need to be killed via the same helper."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_42534e3c","line":203,"updated":"2018-11-16 14:58:58.000000000","message":"I like the way this was refactored, very clean.","commit_id":"9b23abbdb68f7e0c80c305ec1874281f6dea7e9e"}],"neutron/tests/fullstack/resources/process.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"88ae9122d8473c3f55220115732220d7a5cf6ad0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.process.stop("},{"line_number":79,"context_line":"                block\u003dTrue, kill_signal\u003dkill_signal,"},{"line_number":80,"context_line":"                kill_timeout\u003d60)"},{"line_number":81,"context_line":"        except async_process.AsyncProcessException as e:"},{"line_number":82,"context_line":"            if \"Process is not running\" not in str(e):"},{"line_number":83,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8e544825","line":80,"range":{"start_line":80,"start_character":29,"end_line":80,"end_character":31},"updated":"2018-11-15 09:23:13.000000000","message":"This is a lot of time, don\u0027t you think so? Maybe 15 secs is more than enough.","commit_id":"2c386487623a5d97482cc4111d6fde62a7c372ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d7d0101020a970dd63d00de66aecb8449e5bd233","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            self.process.stop("},{"line_number":79,"context_line":"                block\u003dTrue, kill_signal\u003dkill_signal,"},{"line_number":80,"context_line":"                kill_timeout\u003d60)"},{"line_number":81,"context_line":"        except async_process.AsyncProcessException as e:"},{"line_number":82,"context_line":"            if \"Process is not running\" not in str(e):"},{"line_number":83,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_894a02ac","line":80,"range":{"start_line":80,"start_character":29,"end_line":80,"end_character":31},"in_reply_to":"3f79a3b5_8e544825","updated":"2018-11-15 10:13:55.000000000","message":"yes, 15 seconds should be enough :)","commit_id":"2c386487623a5d97482cc4111d6fde62a7c372ea"}]}
