)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b077cc2546beddf78a37dd368a047667dede81da","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can avoid connections rarely hanging due to tcp window"},{"line_number":10,"context_line":"scaling not correctly being observed by the TCP connection"},{"line_number":11,"context_line":"tracking. this seems to happen when retransmits are occurring"},{"line_number":12,"context_line":"occassionally."},{"line_number":13,"context_line":"Setting this parameter turns off validating the window scaling"},{"line_number":14,"context_line":"checks for the purpose of matching whether a packet matches"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_5a418707","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":47},"updated":"2018-11-24 08:23:26.000000000","message":"Interesting, can you give us some information about this retransmit? How it happened? How to observe the retransmit?","commit_id":"13f4ac25dd67a7bb2ee21a4fc8e1b9e19c418d12"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b077cc2546beddf78a37dd368a047667dede81da","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can avoid connections rarely hanging due to tcp window"},{"line_number":10,"context_line":"scaling not correctly being observed by the TCP connection"},{"line_number":11,"context_line":"tracking. this seems to happen when retransmits are occurring"},{"line_number":12,"context_line":"occassionally."},{"line_number":13,"context_line":"Setting this parameter turns off validating the window scaling"},{"line_number":14,"context_line":"checks for the purpose of matching whether a packet matches"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_9a3b9f98","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":11},"updated":"2018-11-24 08:23:26.000000000","message":"T","commit_id":"13f4ac25dd67a7bb2ee21a4fc8e1b9e19c418d12"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab3f9d7589080df7562e2e2330720aa8242f9353","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f2ad440a_2792072f","updated":"2023-03-02 00:10:56.000000000","message":"Added release note.","commit_id":"a9cbd5e4bb084904e83044c1f21f25ff753463f8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f09c1d2a4321356946feb7611c24f7eddaf57184","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c9300c9d_a6600133","updated":"2023-01-27 10:16:46.000000000","message":"Looks like it\u0027s something we can do.. could you just add a release note for that? Also it is something that we always want? we could also add an option for it and let operator deciding whether to active it or not","commit_id":"a9cbd5e4bb084904e83044c1f21f25ff753463f8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4ace0b3c90c5b8e12557cb40eacca44a4e8de81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c16ed98e_7d30fabb","in_reply_to":"c9300c9d_a6600133","updated":"2023-01-30 21:43:44.000000000","message":"I could put a release note. It does seem like something we always want to do looking a little deeper, as a lot of firewall vendors typically turn this on to avoid unnecessary resets. What do others think on adding an option to control this?","commit_id":"a9cbd5e4bb084904e83044c1f21f25ff753463f8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c364795ab1a8cfea92c24de8b457ba0597a7339c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"17c1a150_9855ef29","updated":"2023-03-24 14:36:57.000000000","message":"++","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"f6f22b23bfdbd368fa464f3ad06cff253cd8762d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5ca4f2b9_51989e72","updated":"2023-04-06 09:24:17.000000000","message":"Looks good to me. I hope this could be backported.","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fd5411c895d80584fac88e35f96966dd0b0da347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b32fdf99_7441ea6d","updated":"2023-03-24 10:56:39.000000000","message":"long story, thanks for finishing","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e8eeb9d8dfc0a6e813791b1ae6beddf695d67d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"783a6ee2_779ec82b","updated":"2023-09-30 07:49:01.000000000","message":"recheck get fresh logs and bump","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41b1abac711b9918132e17f8efc0700dc34e6dac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"47ce6b6b_8c7c0c07","updated":"2023-07-31 22:07:35.000000000","message":"recheck just been a while since last zuul vote","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"da53fc3e4bb94df866eb97a573f66468836bc650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"84a784f4_bbee3349","updated":"2023-05-25 21:16:11.000000000","message":"recheck just been a while since last zuul vote","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8fa96ecfed44994c9080e7851d110bf82d7eae64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"13245475_87e8637b","updated":"2024-01-19 22:15:25.000000000","message":"recheck get fresh logs and ping reviewers","commit_id":"379ef90cb2ed2c8bb4d6370f79ed9ec75034b716"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"edf8f965a450490820d377a0af197c839b8049b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7fe54470_75f692e9","updated":"2024-01-21 17:21:12.000000000","message":"recheck unrelated test failure","commit_id":"379ef90cb2ed2c8bb4d6370f79ed9ec75034b716"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51d64f2092b0f01bda610fdd5c303d62151ef86b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a14e72e6_85ec83db","updated":"2024-01-22 00:11:39.000000000","message":"recheck unrelated test failure","commit_id":"379ef90cb2ed2c8bb4d6370f79ed9ec75034b716"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dfbd3ec6518392a747bd5d0f1da95322b082584f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b24e3448_5f5f35f7","updated":"2024-08-12 20:21:02.000000000","message":"This has been in a good state for a long time, let\u0027s get it merged.","commit_id":"ab94c6b02116ccc24c67c1ed8e09c6840d092424"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e73d65800d14940d896c2ff8ea9168017a32093a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c44c64fd_ff2a5b61","updated":"2024-06-16 01:01:27.000000000","message":"recheck job timeout","commit_id":"ab94c6b02116ccc24c67c1ed8e09c6840d092424"}],"neutron/agent/l3/dvr_snat_ns.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f17f043c6358f4858b10ec5db241c3066e40aaba","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Be liberal in the state tracking to avoid"},{"line_number":39,"context_line":"        # issues with TCP window scaling"},{"line_number":40,"context_line":"        cmd \u003d [\u0027net.netfilter.nf_conntrack_tcp_loose\u003d0\u0027,"},{"line_number":41,"context_line":"               \u0027net.netfilter.nf_conntrack_tcp_be_liberal\u003d1\u0027]"},{"line_number":42,"context_line":"        ip_lib.sysctl(cmd, namespace\u003dself.name)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b94dc5c7","line":41,"updated":"2018-11-15 17:17:07.000000000","message":"I know this will fail the unit test, and not sure passing two at once will even work in the code.","commit_id":"3034a90592ff86e5ff95e5b8a4515bdb859dd021"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"680faf1af7c4ae1952a1c4fa1f1685fc51ba7ef9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Be liberal in the state tracking to avoid"},{"line_number":39,"context_line":"        # issues with TCP window scaling"},{"line_number":40,"context_line":"        cmd \u003d [\u0027net.netfilter.nf_conntrack_tcp_loose\u003d0\u0027,"},{"line_number":41,"context_line":"               \u0027net.netfilter.nf_conntrack_tcp_be_liberal\u003d1\u0027]"},{"line_number":42,"context_line":"        ip_lib.sysctl(cmd, namespace\u003dself.name)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3cbe40af","line":41,"in_reply_to":"3f79a3b5_b94dc5c7","updated":"2018-11-20 22:55:54.000000000","message":"I\u0027ve tested that it actually works (its just merging the array and sysctl -w accepts more than one parameter per call). I\u0027ll fix the unit test.","commit_id":"3034a90592ff86e5ff95e5b8a4515bdb859dd021"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b077cc2546beddf78a37dd368a047667dede81da","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Be liberal in the state tracking to avoid"},{"line_number":39,"context_line":"        # issues with TCP window scaling"},{"line_number":40,"context_line":"        cmd \u003d [\u0027net.netfilter.nf_conntrack_tcp_loose\u003d0\u0027,"},{"line_number":41,"context_line":"               \u0027net.netfilter.nf_conntrack_tcp_be_liberal\u003d1\u0027]"},{"line_number":42,"context_line":"        ip_lib.sysctl(cmd, namespace\u003dself.name)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1a478f1d","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":59},"updated":"2018-11-24 08:23:26.000000000","message":"If this this work for all SNAT traffic, IMO, this settings should be installed to all the SNAT ralated namespace:\n(1) qrouter-namespace in legacy or dvr_snat node.\n(2) qrouter-namespace for HA router in legacy or dvr_snat node.\n(3) qrouter-namespace for dvr floating IP snat in compute node.\n(4) snat-namespace (this one you added here)\n\nSo, if this is really worth to install and fix the issue, we can install this directly to all the router namespace.","commit_id":"13f4ac25dd67a7bb2ee21a4fc8e1b9e19c418d12"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"fafb1234f6880f77282eedcef30c08aed1672562","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Be liberal in the state tracking to avoid"},{"line_number":39,"context_line":"        # issues with TCP window scaling"},{"line_number":40,"context_line":"        cmd \u003d [\u0027net.netfilter.nf_conntrack_tcp_loose\u003d0\u0027,"},{"line_number":41,"context_line":"               \u0027net.netfilter.nf_conntrack_tcp_be_liberal\u003d1\u0027]"},{"line_number":42,"context_line":"        ip_lib.sysctl(cmd, namespace\u003dself.name)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_db0639cd","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":59},"in_reply_to":"3f79a3b5_1a478f1d","updated":"2018-12-04 22:48:07.000000000","message":"I think this issue is seen only with the DVR routers with SNAT traffic and so since the DVR routers have a separate SNAT Namespace, it is worth adding it to the SNAT Namespaces.\nEven if HA is configured for DVR Routers, it is going to call this class to create the SNAT Namespace, so it should not be a problem with the HA routers.\nThat is my understanding.\nI don\u0027t think we need this rule for the qrouter namespaces in the case of FloatingIP\u0027s configured on the compute.","commit_id":"13f4ac25dd67a7bb2ee21a4fc8e1b9e19c418d12"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"f24fbf5b4299d922dec3ce2a7ff7e5a276f6d649","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Be liberal in the state tracking to avoid"},{"line_number":39,"context_line":"        # issues with TCP window scaling"},{"line_number":40,"context_line":"        cmd \u003d [\u0027net.netfilter.nf_conntrack_tcp_loose\u003d0\u0027,"},{"line_number":41,"context_line":"               \u0027net.netfilter.nf_conntrack_tcp_be_liberal\u003d1\u0027]"},{"line_number":42,"context_line":"        ip_lib.sysctl(cmd, namespace\u003dself.name)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_5c757797","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":60},"updated":"2019-02-07 22:53:50.000000000","message":"Is this necessary? Wouldn\u0027t L32 take care of this (see L92 neutron/agent/l3/namespaces.py in this patch). The way this is written, it looks like invoking super(SnatNamespace, self).create() would cause nf_conntrack_tcp_be_liberal to be set making this superfluous.","commit_id":"9657b62c071e33a84ebfa242b674141410bc6081"}],"neutron/agent/l3/namespaces.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a80e5d320f68b48df4b721675a851756bd9ec374","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    def create(self, ipv6_forwarding\u003dTrue):"},{"line_number":92,"context_line":"        self.ip_wrapper_root.ensure_namespace(self.name)"},{"line_number":93,"context_line":"        # See networking (netdev) tree, file"},{"line_number":94,"context_line":"        # Documentation/networking/ip-sysctl.txt for an explanation of"},{"line_number":95,"context_line":"        # these sysctl values."},{"line_number":96,"context_line":"        # Here\u0027s what we are setting:"},{"line_number":97,"context_line":"        # 1) nf_conntrack_tcp_be_liberal\u003d1 - Be liberal in the state tracking"}],"source_content_type":"text/x-python","patch_set":12,"id":"b5e5cce8_514ed91c","line":94,"updated":"2024-09-10 15:36:56.000000000","message":"The new option is documented elsewhere, in https://www.kernel.org/doc/html/latest/networking/nf_conntrack-sysctl.html","commit_id":"ab94c6b02116ccc24c67c1ed8e09c6840d092424"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6f5ab52e08ccd948a44fb4473fb0d84922ad2691","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def create(self, ipv6_forwarding\u003dTrue):"},{"line_number":92,"context_line":"        self.ip_wrapper_root.ensure_namespace(self.name)"},{"line_number":93,"context_line":"        # See networking (netdev) tree, file"},{"line_number":94,"context_line":"        # Documentation/networking/ip-sysctl.txt for an explanation of"},{"line_number":95,"context_line":"        # these sysctl values."},{"line_number":96,"context_line":"        # Here\u0027s what we are setting:"},{"line_number":97,"context_line":"        # 1) nf_conntrack_tcp_be_liberal\u003d1 - Be liberal in the state tracking"}],"source_content_type":"text/x-python","patch_set":12,"id":"6b904517_d7ddeceb","line":94,"in_reply_to":"b5e5cce8_514ed91c","updated":"2024-09-10 20:14:06.000000000","message":"Yes nf_conntrack_tcp_be_liberal is elsewhere, I will update if I need to respin, else can add in a follow-on.","commit_id":"ab94c6b02116ccc24c67c1ed8e09c6840d092424"}],"neutron/tests/unit/agent/l3/test_dvr_fip_ns.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4ace0b3c90c5b8e12557cb40eacca44a4e8de81","unresolved":true,"context_lines":[{"line_number":217,"context_line":"    def _test_create(self, old_kernel, exists, execute, IPTables):"},{"line_number":218,"context_line":"        exists.return_value \u003d True"},{"line_number":219,"context_line":"        # There are up to 3 sysctl calls - one to enable forwarding,"},{"line_number":220,"context_line":"        # arp_ignore and arp_announce, and one for ip_nonlocal_bind"},{"line_number":221,"context_line":"        execute.side_effect \u003d [None,"},{"line_number":222,"context_line":"                               RuntimeError if old_kernel else None, None]"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ed871e9c_ec6a390b","line":220,"range":{"start_line":220,"start_character":43,"end_line":220,"end_character":46},"updated":"2023-01-30 21:43:44.000000000","message":"Looks like this should still be \u0027two\u0027 based on below. Also this sentence doesn\u0027t mention the new sysctl that was added.","commit_id":"a9cbd5e4bb084904e83044c1f21f25ff753463f8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab3f9d7589080df7562e2e2330720aa8242f9353","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def _test_create(self, old_kernel, exists, execute, IPTables):"},{"line_number":218,"context_line":"        exists.return_value \u003d True"},{"line_number":219,"context_line":"        # There are up to 3 sysctl calls - one to enable forwarding,"},{"line_number":220,"context_line":"        # arp_ignore and arp_announce, and one for ip_nonlocal_bind"},{"line_number":221,"context_line":"        execute.side_effect \u003d [None,"},{"line_number":222,"context_line":"                               RuntimeError if old_kernel else None, None]"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"2440a6d7_9181d4d1","line":220,"range":{"start_line":220,"start_character":43,"end_line":220,"end_character":46},"in_reply_to":"ed871e9c_ec6a390b","updated":"2023-03-02 00:10:56.000000000","message":"Done","commit_id":"a9cbd5e4bb084904e83044c1f21f25ff753463f8"}],"releasenotes/notes/enable-nf_conntrack_tcp_be_liberal-00432039c9e7ab9d.yaml":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c364795ab1a8cfea92c24de8b457ba0597a7339c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Liberal TCP connection tracking is now enabled in SNAT namespaces,"},{"line_number":5,"context_line":"    (``sysctl net.netfilter.nf_conntrack_tcp_be_liberal\u003d1``)."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a7d5373f_87aa7245","line":2,"updated":"2023-03-24 14:36:57.000000000","message":"We can certainly backport it right?","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"585c73cb554189250a46e0eb384e88b259b912bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Liberal TCP connection tracking is now enabled in SNAT namespaces,"},{"line_number":5,"context_line":"    (``sysctl net.netfilter.nf_conntrack_tcp_be_liberal\u003d1``)."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3768a0ad_75704a70","line":2,"in_reply_to":"a7d5373f_87aa7245","updated":"2024-09-06 18:20:16.000000000","message":"Sorry, hadn\u0027t seen this comment, but yes, it can be backported.","commit_id":"4cbd24f96b41ac838a21b2128ce0bd91f0712a4e"}]}