)]}'
{".zuul.yaml":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"ff2f54a8d1653254c3e74be2c49e05b4f6a56f14","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # We need to copy directory with logs to have it in job artifacts also,"},{"line_number":130,"context_line":"        # /opt/stack/logs is default logs directory defined in neutron\u0027s"},{"line_number":131,"context_line":"        # tox.ini file"},{"line_number":132,"context_line":"        \u0027/opt/stack/logs/dsvm-functional-logs\u0027: logs"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- job:"},{"line_number":135,"context_line":"    name: neutron-functional-python27"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"9fdfeff1_e3f6958f","line":132,"range":{"start_line":132,"start_character":9,"end_line":132,"end_character":24},"updated":"2019-02-14 17:28:51.000000000","message":"nit: we could avoid hard-code the fullpath by doing something like: https://github.com/openstack/tempest/blob/master/.zuul.yaml#L24","commit_id":"3cb11151e2184fc8614dca81747b56ca577ea95b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a5faa28b324148b83d02f041111847472da5e6c1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # We need to copy directory with logs to have it in job artifacts also,"},{"line_number":130,"context_line":"        # /opt/stack/logs is default logs directory defined in neutron\u0027s"},{"line_number":131,"context_line":"        # tox.ini file"},{"line_number":132,"context_line":"        \u0027/opt/stack/logs/dsvm-functional-logs\u0027: logs"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- job:"},{"line_number":135,"context_line":"    name: neutron-functional-python27"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"9fdfeff1_d40f8534","line":132,"range":{"start_line":132,"start_character":9,"end_line":132,"end_character":24},"in_reply_to":"9fdfeff1_e3f6958f","updated":"2019-02-14 20:17:19.000000000","message":"Done","commit_id":"3cb11151e2184fc8614dca81747b56ca577ea95b"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"881b1aef840b9f6b5b795ba67c000b00fb88bbb3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    description: Run neutron functional tests"},{"line_number":104,"context_line":"    timeout: 7800"},{"line_number":105,"context_line":"    required-projects:"},{"line_number":106,"context_line":"      - git.openstack.org/openstack-dev/devstack"},{"line_number":107,"context_line":"      - openstack/neutron"},{"line_number":108,"context_line":"    roles:"},{"line_number":109,"context_line":"      - zuul: openstack-dev/devstack"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9fdfeff1_8661c507","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":39},"updated":"2019-02-15 15:11:07.000000000","message":"Personal curiosity: openstack-dev/xxx is not supported? Or is it the recommended way to setup now","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"872ac5e69ed644fe6cfa597d796c1934d957c023","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    description: Run neutron functional tests"},{"line_number":104,"context_line":"    timeout: 7800"},{"line_number":105,"context_line":"    required-projects:"},{"line_number":106,"context_line":"      - git.openstack.org/openstack-dev/devstack"},{"line_number":107,"context_line":"      - openstack/neutron"},{"line_number":108,"context_line":"    roles:"},{"line_number":109,"context_line":"      - zuul: openstack-dev/devstack"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9fdfeff1_f54067a4","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":39},"in_reply_to":"9fdfeff1_8661c507","updated":"2019-02-16 08:57:15.000000000","message":"It is supported. Changing :)","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"881b1aef840b9f6b5b795ba67c000b00fb88bbb3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      - git.openstack.org/openstack-dev/devstack"},{"line_number":107,"context_line":"      - openstack/neutron"},{"line_number":108,"context_line":"    roles:"},{"line_number":109,"context_line":"      - zuul: openstack-dev/devstack"},{"line_number":110,"context_line":"    pre-run: playbooks/configure_functional_job.yaml"},{"line_number":111,"context_line":"    run: playbooks/run_functional_job.yaml"},{"line_number":112,"context_line":"    post-run: playbooks/post_functional_job.yaml"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9fdfeff1_416bc783","line":109,"range":{"start_line":109,"start_character":14,"end_line":109,"end_character":36},"updated":"2019-02-15 15:11:07.000000000","message":"Nit: should be coherent with line 106? I see in devstack they use URL style (\"zuul: git.openstack.org/openstack-infra/devstack-gate\")","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"872ac5e69ed644fe6cfa597d796c1934d957c023","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      - git.openstack.org/openstack-dev/devstack"},{"line_number":107,"context_line":"      - openstack/neutron"},{"line_number":108,"context_line":"    roles:"},{"line_number":109,"context_line":"      - zuul: openstack-dev/devstack"},{"line_number":110,"context_line":"    pre-run: playbooks/configure_functional_job.yaml"},{"line_number":111,"context_line":"    run: playbooks/run_functional_job.yaml"},{"line_number":112,"context_line":"    post-run: playbooks/post_functional_job.yaml"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9fdfeff1_95155b9e","line":109,"range":{"start_line":109,"start_character":14,"end_line":109,"end_character":36},"in_reply_to":"9fdfeff1_416bc783","updated":"2019-02-16 08:57:15.000000000","message":"changed in L106","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"881b1aef840b9f6b5b795ba67c000b00fb88bbb3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      devstack_localrc:"},{"line_number":123,"context_line":"        USE_PYTHON3: true"},{"line_number":124,"context_line":"        INSTALL_TESTONLY_PACKAGES: true"},{"line_number":125,"context_line":"        DATABASE_PASSWORD: stackdb"},{"line_number":126,"context_line":"      tox_envlist: dsvm-functional"},{"line_number":127,"context_line":"      tox_install_siblings: false"},{"line_number":128,"context_line":"      zuul_copy_output:"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9fdfeff1_4119871f","line":125,"range":{"start_line":125,"start_character":27,"end_line":125,"end_character":34},"updated":"2019-02-15 15:11:07.000000000","message":"It looks like functional tests can run with other DB passwords, maybe we can drop this line?","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"872ac5e69ed644fe6cfa597d796c1934d957c023","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      devstack_localrc:"},{"line_number":123,"context_line":"        USE_PYTHON3: true"},{"line_number":124,"context_line":"        INSTALL_TESTONLY_PACKAGES: true"},{"line_number":125,"context_line":"        DATABASE_PASSWORD: stackdb"},{"line_number":126,"context_line":"      tox_envlist: dsvm-functional"},{"line_number":127,"context_line":"      tox_install_siblings: false"},{"line_number":128,"context_line":"      zuul_copy_output:"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"9fdfeff1_b5189fd2","line":125,"range":{"start_line":125,"start_character":27,"end_line":125,"end_character":34},"in_reply_to":"9fdfeff1_4119871f","updated":"2019-02-16 08:57:15.000000000","message":"I was trying to drop it but then for some reason devstack script was failing and job was not run properly. This needs to be here :)","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"6b20036d454014163400278587f8b9abdf0984d3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    description: Run neutron functional tests"},{"line_number":106,"context_line":"    timeout: 7800"},{"line_number":107,"context_line":"    required-projects:"},{"line_number":108,"context_line":"      - git.openstack.org/openstack-dev/devstack"},{"line_number":109,"context_line":"      - openstack/neutron"},{"line_number":110,"context_line":"    roles:"},{"line_number":111,"context_line":"      - zuul: openstack-dev/devstack"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"9fdfeff1_8b3509de","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":25},"updated":"2019-03-04 16:40:09.000000000","message":"Comparing to patchset 52 (last I looked at), this is the only diff, so I guess the full URL was needed?","commit_id":"751c7cffa9c4db241f95e6f58c04f2781e7ef495"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"881b1aef840b9f6b5b795ba67c000b00fb88bbb3","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"case $VENV in"},{"line_number":58,"context_line":"\"dsvm-fullstack\")"},{"line_number":59,"context_line":"    # The following need to be set before sourcing"},{"line_number":60,"context_line":"    # configure_for_func_testing."},{"line_number":61,"context_line":"    GATE_STACK_USER\u003dstack"}],"source_content_type":"text/x-sh","patch_set":50,"id":"9fdfeff1_46051d13","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":17},"updated":"2019-02-15 15:11:07.000000000","message":"Looks like we are getting close to drop this file (after fullstack migration)? :)","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"872ac5e69ed644fe6cfa597d796c1934d957c023","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"case $VENV in"},{"line_number":58,"context_line":"\"dsvm-fullstack\")"},{"line_number":59,"context_line":"    # The following need to be set before sourcing"},{"line_number":60,"context_line":"    # configure_for_func_testing."},{"line_number":61,"context_line":"    GATE_STACK_USER\u003dstack"}],"source_content_type":"text/x-sh","patch_set":50,"id":"9fdfeff1_550b737b","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":17},"in_reply_to":"9fdfeff1_46051d13","updated":"2019-02-16 08:57:15.000000000","message":"Yes, I hope we will be able to get rid of this whole directory maybe :)","commit_id":"10931e9df8cef9835c9b647e25d82dbc7d7df8d8"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7151d1f53ba58840f3b28097ed5f416e7541aa5e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"case $VENV in"},{"line_number":58,"context_line":"\"dsvm-fullstack\")"},{"line_number":59,"context_line":"    # The following need to be set before sourcing"},{"line_number":60,"context_line":"    # configure_for_func_testing."},{"line_number":61,"context_line":"    GATE_STACK_USER\u003dstack"}],"source_content_type":"text/x-sh","patch_set":61,"id":"5fc1f717_b25cdf4b","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":17},"updated":"2019-03-07 22:08:14.000000000","message":"case isn\u0027t need if [[ \"$VENV\" \u003d~ \"dsvm-fullstack\" ]]; then\nwould be simple ?","commit_id":"8dac515dbfd565f83d7d1ab29f1f00707efa7091"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"190c0d40191cf05b08428d4135cb2f216d71d2e1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"case $VENV in"},{"line_number":58,"context_line":"\"dsvm-fullstack\")"},{"line_number":59,"context_line":"    # The following need to be set before sourcing"},{"line_number":60,"context_line":"    # configure_for_func_testing."},{"line_number":61,"context_line":"    GATE_STACK_USER\u003dstack"}],"source_content_type":"text/x-sh","patch_set":61,"id":"5fc1f717_c05abef1","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":17},"in_reply_to":"5fc1f717_b25cdf4b","updated":"2019-03-11 16:59:28.000000000","message":"ignore this comment !","commit_id":"8dac515dbfd565f83d7d1ab29f1f00707efa7091"}],"playbooks/configure_functional_job.yaml":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"567cadaae09a80e68367c9175d384e09744a0e6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"      - setup_logdir"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_365e0d51","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":6},"updated":"2018-11-26 22:13:46.000000000","message":"nit: the indentation is weird.","commit_id":"621be882f7f8d08df12a61b15248d5ed2ef3d0aa"}],"roles/configure_for_func_testing/defaults/main.yaml":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"331d3fbfbbb4c0f2205872de8aa9c58346da8c3d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"repo_base: /opt/stack/new"},{"line_number":2,"context_line":"venv_name: dsvm-functional"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_ba21bba3","line":1,"range":{"start_line":1,"start_character":22,"end_line":1,"end_character":25},"updated":"2018-11-24 07:15:25.000000000","message":"This is a folder name or project name?","commit_id":"e50fb5e44dfbd43d5858603d55664bc08df7623f"}],"roles/configure_functional_tests/tasks/main.yaml":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"ff2f54a8d1653254c3e74be2c49e05b4f6a56f14","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        GATE_STACK_USER\u003d{{ ansible_user }}"},{"line_number":6,"context_line":"        IS_GATE\u003dTrue"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        BASE_DIR\u003d{{ base_dir }}"},{"line_number":9,"context_line":"        GATE_DEST\u003d{{ gate_dest_dir }}"},{"line_number":10,"context_line":"        NEUTRON_PATH\u003d{{ neutron_dir }}"},{"line_number":11,"context_line":"        DEVSTACK_PATH\u003d{{ devstack_dir }}"},{"line_number":12,"context_line":"        VENV\u003d{{ tests_venv }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"        source $DEVSTACK_PATH/functions"},{"line_number":15,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"9fdfeff1_23581d2f","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":29},"updated":"2019-02-14 17:28:51.000000000","message":"Where these variables are used? I looked at the logs and it seems these variables are not used anywhere but I might miss something.","commit_id":"3cb11151e2184fc8614dca81747b56ca577ea95b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a5faa28b324148b83d02f041111847472da5e6c1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        GATE_STACK_USER\u003d{{ ansible_user }}"},{"line_number":6,"context_line":"        IS_GATE\u003dTrue"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        BASE_DIR\u003d{{ base_dir }}"},{"line_number":9,"context_line":"        GATE_DEST\u003d{{ gate_dest_dir }}"},{"line_number":10,"context_line":"        NEUTRON_PATH\u003d{{ neutron_dir }}"},{"line_number":11,"context_line":"        DEVSTACK_PATH\u003d{{ devstack_dir }}"},{"line_number":12,"context_line":"        VENV\u003d{{ tests_venv }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"        source $DEVSTACK_PATH/functions"},{"line_number":15,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"9fdfeff1_3415b149","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":29},"in_reply_to":"9fdfeff1_23581d2f","updated":"2019-02-14 20:17:19.000000000","message":"BASE_DIR is used in devstack,\nGATE_DEST is used in https://github.com/openstack/neutron/blob/master/tools/configure_for_func_testing.sh#L60\nNEUTRON_PATH and DEVSTACK_PATH are used only in this file, see below,\nVENV is used in https://github.com/openstack/neutron/blob/master/tools/configure_for_func_testing.sh#L57","commit_id":"3cb11151e2184fc8614dca81747b56ca577ea95b"}],"roles/fetch_journal_log/README.rst":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7151d1f53ba58840f3b28097ed5f416e7541aa5e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"   :default: {{ ansible_user_dir }}/workspace/logs"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"   Path where journal log file will be stored on job\u0027s node."},{"line_number":12,"context_line":"   "},{"line_number":13,"context_line":".. zuul:rolevar:: journal_log_file_name"},{"line_number":14,"context_line":"   :default: {{ journal_log_path }}/journal.log"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":61,"id":"5fc1f717_b2ae1f2c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"updated":"2019-03-07 22:08:14.000000000","message":"pep8 don\u0027t catch this ?","commit_id":"8dac515dbfd565f83d7d1ab29f1f00707efa7091"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6348621008d8ecfc65d2c044e035f0c782314319","unresolved":false,"context_lines":[{"line_number":9,"context_line":"   :default: {{ ansible_user_dir }}/workspace/logs"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"   Path where journal log file will be stored on job\u0027s node."},{"line_number":12,"context_line":"   "},{"line_number":13,"context_line":".. zuul:rolevar:: journal_log_file_name"},{"line_number":14,"context_line":"   :default: {{ journal_log_path }}/journal.log"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":64,"id":"5fc1f717_b161ea07","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"updated":"2019-03-12 21:31:27.000000000","message":"nit: remove this","commit_id":"fafabd46c8d3e534d91bd0cde6169b719ebe3aab"}],"roles/fetch_journal_log/tasks/main.yaml":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7151d1f53ba58840f3b28097ed5f416e7541aa5e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    owner: \"{{ ansible_user }}\""},{"line_number":8,"context_line":"    group: \"{{ ansible_user }}\""},{"line_number":9,"context_line":"    mode: 0775"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"- name: Store journal logs in {{ journal_log_file_name }}"},{"line_number":12,"context_line":"  become: yes"},{"line_number":13,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":61,"id":"5fc1f717_32c30ff0","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2019-03-07 22:08:14.000000000","message":"nit:","commit_id":"8dac515dbfd565f83d7d1ab29f1f00707efa7091"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6348621008d8ecfc65d2c044e035f0c782314319","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    owner: \"{{ ansible_user }}\""},{"line_number":8,"context_line":"    group: \"{{ ansible_user }}\""},{"line_number":9,"context_line":"    mode: 0775"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"- name: Store journal logs in {{ journal_log_file_name }}"},{"line_number":12,"context_line":"  become: yes"},{"line_number":13,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"5fc1f717_712ce2ab","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2019-03-12 21:31:27.000000000","message":"extra spaces","commit_id":"fafabd46c8d3e534d91bd0cde6169b719ebe3aab"}],"roles/functional_testing/tasks/main.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6070125ef0f9eb46f5829a0f8f408b73c0f90ff6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    cmd: |"},{"line_number":3,"context_line":"        set -e"},{"line_number":4,"context_line":"        set -x"},{"line_number":5,"context_line":"        /opt/stack/new/neutron/tools/configure_for_func_testing.sh /opt/stack/devstack"},{"line_number":6,"context_line":"    executable: /bin/bash"},{"line_number":7,"context_line":"  environment: \u0027{{ zuul | zuul_legacy_vars }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_14d51eb5","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":66},"updated":"2018-12-20 14:51:51.000000000","message":"it\u0027s better to use:\n\n/home/zuul/git.openstack.org/openstack/neutron/tools/configure_for_func_testing.sh","commit_id":"edbd0dc8f9f047450df075f1eba0cdf19959e02f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1b5c061308ac028b04bec219c198cc5995dccdd2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    cmd: |"},{"line_number":3,"context_line":"        set -e"},{"line_number":4,"context_line":"        set -x"},{"line_number":5,"context_line":"        /opt/stack/new/neutron/tools/configure_for_func_testing.sh /opt/stack/devstack"},{"line_number":6,"context_line":"    executable: /bin/bash"},{"line_number":7,"context_line":"  environment: \u0027{{ zuul | zuul_legacy_vars }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_94b04e8e","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":66},"in_reply_to":"3f79a3b5_14d51eb5","updated":"2018-12-20 14:54:13.000000000","message":"Done","commit_id":"edbd0dc8f9f047450df075f1eba0cdf19959e02f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6070125ef0f9eb46f5829a0f8f408b73c0f90ff6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        set -x"},{"line_number":5,"context_line":"        /opt/stack/new/neutron/tools/configure_for_func_testing.sh /opt/stack/devstack"},{"line_number":6,"context_line":"    executable: /bin/bash"},{"line_number":7,"context_line":"  environment: \u0027{{ zuul | zuul_legacy_vars }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_74dd72d8","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":42},"updated":"2018-12-20 14:51:51.000000000","message":"this is a thing really just intended for legacy jobs - it would be better to have teh script not need them.","commit_id":"edbd0dc8f9f047450df075f1eba0cdf19959e02f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1b5c061308ac028b04bec219c198cc5995dccdd2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        set -x"},{"line_number":5,"context_line":"        /opt/stack/new/neutron/tools/configure_for_func_testing.sh /opt/stack/devstack"},{"line_number":6,"context_line":"    executable: /bin/bash"},{"line_number":7,"context_line":"  environment: \u0027{{ zuul | zuul_legacy_vars }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_34a93a25","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":42},"in_reply_to":"3f79a3b5_74dd72d8","updated":"2018-12-20 14:54:13.000000000","message":"ok, lets remove it and see what will happen :)","commit_id":"edbd0dc8f9f047450df075f1eba0cdf19959e02f"}],"roles/setup_logdir/tasks/main.yaml":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"2dfb2665375db07489f11db1e687f1592afad371","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ logdir }}\""},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    owner: stack"},{"line_number":7,"context_line":"    group: stack"},{"line_number":8,"context_line":"    mode: 0775"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_b371cfe1","line":6,"updated":"2018-11-26 20:38:40.000000000","message":"Despite this, the functional job is still erroring out with:\n\n    OSError: [Errno 13] Permission denied: \u0027/opt/stack/logs/dsvm-functional-logs\u0027","commit_id":"621be882f7f8d08df12a61b15248d5ed2ef3d0aa"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"567cadaae09a80e68367c9175d384e09744a0e6c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ logdir }}\""},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    owner: stack"},{"line_number":7,"context_line":"    group: stack"},{"line_number":8,"context_line":"    mode: 0775"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_c9313ef0","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":16},"updated":"2018-11-26 22:13:46.000000000","message":"could be:\n\n  owner: \"{{ ansible_user }}\"\n\nExample: http://git.openstack.org/cgit/openstack-dev/devstack/tree/roles/export-devstack-journal/tasks/main.yaml","commit_id":"621be882f7f8d08df12a61b15248d5ed2ef3d0aa"}]}