)]}'
{"etc/dhcp_agent.ini":[{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"480833129bd07d9f06d71c18e57a79e930037e15","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# dnsmasq_config_file \u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# List of another DNS servers which will be used before"},{"line_number":66,"context_line":"# any in /etc/resolv.conf."},{"line_number":67,"context_line":"# dnsmasq_dns_server \u003d"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Limit number of leases to prevent a denial-of-service."}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAATn%2F9Oqg%3D","line":66,"updated":"2013-12-13 18:54:33.000000000","message":"nit: I think you could remove the \u0027before any in /etc/resolv.conf\u0027 because dnsmasq is systemically spawn with option \u0027--no-resolv\u0027","commit_id":"9ac6a83e6a89b5410e9068257696a77d75dbea6f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"babe73e575224b59931eac61345c16c156bbddc9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# Override the default dnsmasq settings with this file"},{"line_number":63,"context_line":"# dnsmasq_config_file \u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# List of another DNS servers which will be used by dnsmasq"},{"line_number":66,"context_line":"# as forwarders."},{"line_number":67,"context_line":"# dnsmasq_dns_server \u003d"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAATn%2F89KM%3D","line":65,"updated":"2013-12-18 12:28:16.000000000","message":"List of DNS servers (another does not fit anymore in the sentence)","commit_id":"8ecc20859e5fc4149002ef2000c53651af6887e0"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"8237097d809b0b94f6aa23cd551678686c6879eb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# Override the default dnsmasq settings with this file"},{"line_number":63,"context_line":"# dnsmasq_config_file \u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# List of another DNS servers which will be used by dnsmasq"},{"line_number":66,"context_line":"# as forwarders."},{"line_number":67,"context_line":"# dnsmasq_dns_server \u003d"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAATn%2F8nDI%3D","line":65,"in_reply_to":"AAAATn%2F89KM%3D","updated":"2013-12-24 11:03:46.000000000","message":"Done","commit_id":"8ecc20859e5fc4149002ef2000c53651af6887e0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"187f7fb5db00e8558206b0255258c894e2e7c62f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# Override the default dnsmasq settings with this file"},{"line_number":63,"context_line":"# dnsmasq_config_file \u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# List of DNS servers which will be used by dnsmasq"},{"line_number":66,"context_line":"# as forwarders."},{"line_number":67,"context_line":"# dnsmasq_dns_server \u003d"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"AAAATn%2F8mxo%3D","line":65,"updated":"2013-12-24 12:30:08.000000000","message":"worth to add that the list is comma separated","commit_id":"760b019ba3c38b44774db3b23cc2757fedb65dcf"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"480833129bd07d9f06d71c18e57a79e930037e15","unresolved":false,"context_lines":[{"line_number":50,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":51,"context_line":"               help\u003d_(\u0027Override the default dnsmasq settings with this file\u0027)),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_server\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\u0027Use another DNS server before any in \u0027"},{"line_number":54,"context_line":"                      \u0027/etc/resolv.conf.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"},{"line_number":56,"context_line":"                help\u003d_(\"Delete namespace after removing a dhcp server.\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Oos%3D","line":53,"updated":"2013-12-13 18:54:33.000000000","message":"pep8: under-indente","commit_id":"9ac6a83e6a89b5410e9068257696a77d75dbea6f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ad5bde00f8abf072d485eebc3311cd14f4baff22","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.StrOpt(\u0027dnsmasq_config_file\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":51,"context_line":"               help\u003d_(\u0027Override the default dnsmasq settings with this file\u0027)),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_server\u0027,"},{"line_number":53,"context_line":"                help\u003d_(\u0027List of another DNS servers which will be used as \u0027"},{"line_number":54,"context_line":"                       \u0027forwarders.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9ILI%3D","line":52,"updated":"2013-12-16 15:19:43.000000000","message":"Ideally the option name should be plural, but we need to keep the option backward-compatible. Just changing the option type is one candidate, but hopefully we have a better name.","commit_id":"f1ac56b5fdd03608e2a65fe0cc8f99583fc56be0"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"83541b43e907fdfed5ace3653ebbc95f389c019c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.StrOpt(\u0027dnsmasq_config_file\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":51,"context_line":"               help\u003d_(\u0027Override the default dnsmasq settings with this file\u0027)),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_server\u0027,"},{"line_number":53,"context_line":"                help\u003d_(\u0027List of another DNS servers which will be used as \u0027"},{"line_number":54,"context_line":"                       \u0027forwarders.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9H7c%3D","line":52,"in_reply_to":"AAAATn%2F9ILI%3D","updated":"2013-12-16 15:57:38.000000000","message":"Yes I didn\u0027t change the name only to the backward-compatibility.","commit_id":"f1ac56b5fdd03608e2a65fe0cc8f99583fc56be0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ad5bde00f8abf072d485eebc3311cd14f4baff22","unresolved":false,"context_lines":[{"line_number":50,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":51,"context_line":"               help\u003d_(\u0027Override the default dnsmasq settings with this file\u0027)),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_server\u0027,"},{"line_number":53,"context_line":"                help\u003d_(\u0027List of another DNS servers which will be used as \u0027"},{"line_number":54,"context_line":"                       \u0027forwarders.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"},{"line_number":56,"context_line":"                help\u003d_(\"Delete namespace after removing a dhcp server.\")),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9IIg%3D","line":53,"updated":"2013-12-16 15:19:43.000000000","message":"\"another\" seems unnecessary.\n\n\"Comma-separated list\" is more user-friendly.","commit_id":"f1ac56b5fdd03608e2a65fe0cc8f99583fc56be0"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"83541b43e907fdfed5ace3653ebbc95f389c019c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":51,"context_line":"               help\u003d_(\u0027Override the default dnsmasq settings with this file\u0027)),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_server\u0027,"},{"line_number":53,"context_line":"                help\u003d_(\u0027List of another DNS servers which will be used as \u0027"},{"line_number":54,"context_line":"                       \u0027forwarders.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"},{"line_number":56,"context_line":"                help\u003d_(\"Delete namespace after removing a dhcp server.\")),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9H50%3D","line":53,"in_reply_to":"AAAATn%2F9IIg%3D","updated":"2013-12-16 15:57:38.000000000","message":"Done","commit_id":"f1ac56b5fdd03608e2a65fe0cc8f99583fc56be0"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"7ae2856b07575a09436fb7d281ec72eef9138708","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.StrOpt(\u0027dnsmasq_config_file\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":51,"context_line":"               help\u003d_(\u0027Override the default dnsmasq settings with this file\u0027)),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_server\u0027,"},{"line_number":53,"context_line":"                help\u003d_(\u0027Comma-separated list of the DNS servers which will be \u0027"},{"line_number":54,"context_line":"                       \u0027used as forwarders.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F9mps%3D","line":52,"updated":"2014-02-05 18:18:34.000000000","message":"We should rename this to dnsmasq_dns_servers and use deprecated name to provide compatibility support.","commit_id":"a65e05f54c87e301ac34f856911806938a7bd85b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"7ae2856b07575a09436fb7d281ec72eef9138708","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        cmd.append(\u0027--conf-file\u003d%s\u0027 % self.conf.dnsmasq_config_file)"},{"line_number":367,"context_line":"        if self.conf.dnsmasq_dns_server:"},{"line_number":368,"context_line":"            for dns_server in self.conf.dnsmasq_dns_server:"},{"line_number":369,"context_line":"                cmd.append(\u0027--server\u003d%s\u0027 % dns_server)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        if self.conf.dhcp_domain:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F9mpg%3D","line":368,"updated":"2014-02-05 18:18:34.000000000","message":"cmd.extend(\n    \u0027--server\u003d%s\u0027 % server\n    for server in self.conf.dnsmasq_dns_servers\n)","commit_id":"a65e05f54c87e301ac34f856911806938a7bd85b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2fca5f702a8ef598508d2cf5af3f437411220d2a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"               help\u003d_(\u0027Use another DNS server before any in \u0027"},{"line_number":54,"context_line":"                      \u0027/etc/resolv.conf. This parameter will be deprecated, \u0027"},{"line_number":55,"context_line":"                      \u0027dnsmasq_dns_servers has to used\u0027)),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_servers\u0027,"},{"line_number":57,"context_line":"                help\u003d_(\u0027Comma-separated list of the DNS servers which will be \u0027"},{"line_number":58,"context_line":"                       \u0027used as forwarders.\u0027)),"},{"line_number":59,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9fWo%3D","line":56,"updated":"2014-02-06 15:23:36.000000000","message":"Is this a case where you can add this:\n\ndeprecated_name\u003d\u0027dnsmasq_dns_server\u0027\n\nAnd have the agent accept either and do the right thing?  Not sure if it works since you\u0027re changing the type here.  Then the code below for the old value could go away.","commit_id":"81632a6a6ec44eb9c510925436803a5028225a25"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"03321e186c003e2873bfe71d4078f868886441a9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"               help\u003d_(\u0027Use another DNS server before any in \u0027"},{"line_number":54,"context_line":"                      \u0027/etc/resolv.conf. This parameter will be deprecated, \u0027"},{"line_number":55,"context_line":"                      \u0027dnsmasq_dns_servers has to used\u0027)),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027dnsmasq_dns_servers\u0027,"},{"line_number":57,"context_line":"                help\u003d_(\u0027Comma-separated list of the DNS servers which will be \u0027"},{"line_number":58,"context_line":"                       \u0027used as forwarders.\u0027)),"},{"line_number":59,"context_line":"    cfg.BoolOpt(\u0027dhcp_delete_namespaces\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F9fCY%3D","line":56,"in_reply_to":"AAAAUH%2F9fWo%3D","updated":"2014-02-06 15:52:04.000000000","message":"Done, thx Brian","commit_id":"81632a6a6ec44eb9c510925436803a5028225a25"}],"neutron/tests/unit/test_linux_dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"deef5b548446a56347c6d6f830af52a77b96ea7d","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027])"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    def test_spawn_cfg_dns_server(self):"},{"line_number":666,"context_line":"        self.conf.set_override(\u0027dnsmasq_dns_servers\u0027, [\u00278.8.8.8\u0027])"},{"line_number":667,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":668,"context_line":"                          \u0027--server\u003d8.8.8.8\u0027,"},{"line_number":669,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F9ajg%3D","line":666,"updated":"2014-02-07 02:52:35.000000000","message":"Should you leave this one alone to serve as a test for the deprecated one to make sure we don\u0027t break it?  or add a _deprecated test ?","commit_id":"a269541c603f8923b35b7e722f1b8c0ebd42c95a"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"23e5a70bab854622f23e84dfe8e89c955884a9e3","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027])"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    def test_spawn_cfg_dns_server(self):"},{"line_number":666,"context_line":"        self.conf.set_override(\u0027dnsmasq_dns_servers\u0027, [\u00278.8.8.8\u0027])"},{"line_number":667,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":668,"context_line":"                          \u0027--server\u003d8.8.8.8\u0027,"},{"line_number":669,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FsVc%3D","line":666,"in_reply_to":"AAAAUH%2F9ajg%3D","updated":"2014-02-11 13:10:24.000000000","message":"This test has to be rewritten since the type of the parameter is converted from Str to List.","commit_id":"a269541c603f8923b35b7e722f1b8c0ebd42c95a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a03c5b7a8b488ed576cec380ea4fa0e0890fdb6b","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027])"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    def test_spawn_cfg_dns_server(self):"},{"line_number":666,"context_line":"        self.conf.set_override(\u0027dnsmasq_dns_servers\u0027, [\u00278.8.8.8\u0027])"},{"line_number":667,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027,"},{"line_number":668,"context_line":"                          \u0027--server\u003d8.8.8.8\u0027,"},{"line_number":669,"context_line":"                          \u0027--domain\u003dopenstacklocal\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FpDQ%3D","line":666,"in_reply_to":"AAAAUH%2F9ajg%3D","updated":"2014-02-11 19:56:30.000000000","message":"grenade testing should validate legacy config names.  We have traditionally not tested the values for deprecated_names.","commit_id":"a269541c603f8923b35b7e722f1b8c0ebd42c95a"}]}