)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"169527a184add48f665430573cf6f1698392a74e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"this work item is required for supporting VM live-migration"},{"line_number":13,"context_line":"with SR-IOV in nova with libvirt as hypervisor."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commits implemets the following:"},{"line_number":16,"context_line":"- Implement binding_activate() and binding_deactivate() methods in agent."},{"line_number":17,"context_line":"- Configure agent to listen on the relevant topics."},{"line_number":18,"context_line":"- RPC version bump on agend side."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fdfeff1_0e0c9192","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":12},"updated":"2019-02-22 00:44:32.000000000","message":"Nit: remove. No action needed unless you roll out another patch","commit_id":"a05e1369b0f440f24a76f395a27e0bdac33ecd0c"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                                           port_id,"},{"line_number":356,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"},{"line_number":357,"context_line":"                self.ext_manager.handle_port(self.context, device_details)"},{"line_number":358,"context_line":"            else:"},{"line_number":359,"context_line":"                if c_const.NO_ACTIVE_BINDING in device_details:"},{"line_number":360,"context_line":"                    # Port was added but its binding in this agent"},{"line_number":361,"context_line":"                    # hasn\u0027t been activated yet. It will be treated as"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_193094e8","line":358,"updated":"2019-02-19 18:21:08.000000000","message":"You can remove one nesting level:\n\nif \u0027port_id\u0027 in device_details:\n ...\n\nelif c_const.NO_ACTIVE_BINDING in device_details:\n ...\n\nelse:\n LOG.info(\"Device with MAC %s not defined on plugin\", device)","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                                           port_id,"},{"line_number":356,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"},{"line_number":357,"context_line":"                self.ext_manager.handle_port(self.context, device_details)"},{"line_number":358,"context_line":"            else:"},{"line_number":359,"context_line":"                if c_const.NO_ACTIVE_BINDING in device_details:"},{"line_number":360,"context_line":"                    # Port was added but its binding in this agent"},{"line_number":361,"context_line":"                    # hasn\u0027t been activated yet. It will be treated as"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_468dc628","line":358,"in_reply_to":"9fdfeff1_193094e8","updated":"2019-02-20 17:34:57.000000000","message":"Done","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    def get_device_details_from_port_id(self, port_id):"},{"line_number":431,"context_line":"        \"\"\"Get device details from server"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        :param port_id:  port identifier (UUID)."},{"line_number":434,"context_line":"        :return: A dict containing various port attributes if the port is"},{"line_number":435,"context_line":"                 bound to the host. In case the port is not bound to the host"},{"line_number":436,"context_line":"                 then the method will return A dict with a minimal set of"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_d9620cae","line":433,"range":{"start_line":433,"start_character":24,"end_line":433,"end_character":26},"updated":"2019-02-19 18:21:08.000000000","message":"nit: extra space. Please, don\u0027t mix upper and lower case to start new sentences (L419, L421, L433, L434)","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    def get_device_details_from_port_id(self, port_id):"},{"line_number":431,"context_line":"        \"\"\"Get device details from server"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        :param port_id:  port identifier (UUID)."},{"line_number":434,"context_line":"        :return: A dict containing various port attributes if the port is"},{"line_number":435,"context_line":"                 bound to the host. In case the port is not bound to the host"},{"line_number":436,"context_line":"                 then the method will return A dict with a minimal set of"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_46db8620","line":433,"range":{"start_line":433,"start_character":24,"end_line":433,"end_character":26},"in_reply_to":"9fdfeff1_d9620cae","updated":"2019-02-20 17:34:57.000000000","message":"Done","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        \"\"\""},{"line_number":439,"context_line":"        device_details \u003d self.plugin_rpc.get_device_details("},{"line_number":440,"context_line":"            self.context, port_id, self.agent_id, host\u003dcfg.CONF.host)"},{"line_number":441,"context_line":"        return device_details"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def daemon_loop(self):"},{"line_number":444,"context_line":"        sync \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_b902a8b9","line":441,"range":{"start_line":441,"start_character":8,"end_line":441,"end_character":29},"updated":"2019-02-19 18:21:08.000000000","message":"Just return the result of the function call. Let\u0027s save variables.","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        \"\"\""},{"line_number":439,"context_line":"        device_details \u003d self.plugin_rpc.get_device_details("},{"line_number":440,"context_line":"            self.context, port_id, self.agent_id, host\u003dcfg.CONF.host)"},{"line_number":441,"context_line":"        return device_details"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def daemon_loop(self):"},{"line_number":444,"context_line":"        sync \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_66bb2ac4","line":441,"range":{"start_line":441,"start_character":8,"end_line":441,"end_character":29},"in_reply_to":"9fdfeff1_b902a8b9","updated":"2019-02-20 17:34:57.000000000","message":"Done","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bdcaf6c726c42ed0874d993cf4e3adc4e5477607","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        \"\"\""},{"line_number":439,"context_line":"        device_details \u003d self.plugin_rpc.get_device_details("},{"line_number":440,"context_line":"            self.context, port_id, self.agent_id, host\u003dcfg.CONF.host)"},{"line_number":441,"context_line":"        return device_details"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def daemon_loop(self):"},{"line_number":444,"context_line":"        sync \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_d19dee57","line":441,"range":{"start_line":441,"start_character":8,"end_line":441,"end_character":29},"in_reply_to":"9fdfeff1_b902a8b9","updated":"2019-02-20 15:35:57.000000000","message":"haha they are not an endangered species but yes it can be removed.\n\nRVO is eaiser to do then NRVO and a direct return can often elide all overhead of copies or asiginments entirely so yes in this case it makse sense.\n\nthat said at that point you could just call \nself.plugin_rpc.get_device_details(\n            self.context, port_id, self.agent_id, host\u003dcfg.CONF.host) directly and not have \nget_device_details_from_port_id\nbut i do think this is a little cleaner.","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                                  self.exclude_devices)"},{"line_number":469,"context_line":"                device_info \u003d self.scan_devices(devices, updated_devices_copy)"},{"line_number":470,"context_line":"                if activated_bindings_copy:"},{"line_number":471,"context_line":"                    # Deal with activated port binding."},{"line_number":472,"context_line":"                    self.process_activated_bindings(device_info,"},{"line_number":473,"context_line":"                                                    activated_bindings_copy)"},{"line_number":474,"context_line":"                if self._device_info_has_changes(device_info):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_f96030d2","line":471,"updated":"2019-02-19 18:21:08.000000000","message":"This comment is not necessary. Code should be self-documenting.","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                                  self.exclude_devices)"},{"line_number":469,"context_line":"                device_info \u003d self.scan_devices(devices, updated_devices_copy)"},{"line_number":470,"context_line":"                if activated_bindings_copy:"},{"line_number":471,"context_line":"                    # Deal with activated port binding."},{"line_number":472,"context_line":"                    self.process_activated_bindings(device_info,"},{"line_number":473,"context_line":"                                                    activated_bindings_copy)"},{"line_number":474,"context_line":"                if self._device_info_has_changes(device_info):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_6609ea93","line":471,"in_reply_to":"9fdfeff1_f96030d2","updated":"2019-02-20 17:34:57.000000000","message":"Done","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"1a52a04d1a1d2b2fc5a7bbba23fff7a4106d5256","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def _setup_rpc(self):"},{"line_number":158,"context_line":"        self.agent_id \u003d \u0027nic-switch-agent.%s\u0027 % socket.gethostname()"},{"line_number":159,"context_line":"        LOG.info(\"RPC agent_id: %s\", self.agent_id)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        self.topic \u003d topics.AGENT"},{"line_number":162,"context_line":"        self.failed_report_state \u003d False"},{"line_number":163,"context_line":"        self.state_rpc \u003d agent_rpc.PluginReportStateAPI(topics.REPORTS)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_e3f11e03","side":"PARENT","line":160,"updated":"2019-02-22 11:07:14.000000000","message":"unrelated change","commit_id":"45ab1dc9dbb2cc030135a527fb2610999ad85ca8"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"1a52a04d1a1d2b2fc5a7bbba23fff7a4106d5256","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                                           port_id,"},{"line_number":356,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"},{"line_number":357,"context_line":"                self.ext_manager.handle_port(self.context, device_details)"},{"line_number":358,"context_line":"            elif c_const.NO_ACTIVE_BINDING in device_details:"},{"line_number":359,"context_line":"                # Port was added but its binding in this agent"},{"line_number":360,"context_line":"                # hasn\u0027t been activated yet. It will be treated as"},{"line_number":361,"context_line":"                # added when binding is activated"},{"line_number":362,"context_line":"                LOG.info(\"Device with MAC %s has no active binding in host\","},{"line_number":363,"context_line":"                         device)"},{"line_number":364,"context_line":"            else:"},{"line_number":365,"context_line":"                LOG.info(\"Device with MAC %s not defined on plugin\","},{"line_number":366,"context_line":"                         device)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_43390aa1","line":363,"range":{"start_line":358,"start_character":0,"end_line":363,"end_character":32},"updated":"2019-02-22 11:07:14.000000000","message":"so I don\u0027t get this in L336 you check if pord_id in device_details and this will be most of the time so when do you will get to L358?\nshould this if be a inside of block of L336?","commit_id":"a05e1369b0f440f24a76f395a27e0bdac33ecd0c"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"051209d6d110726b1ee38dd966347b178d4f9a22","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                                           port_id,"},{"line_number":356,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"},{"line_number":357,"context_line":"                self.ext_manager.handle_port(self.context, device_details)"},{"line_number":358,"context_line":"            elif c_const.NO_ACTIVE_BINDING in device_details:"},{"line_number":359,"context_line":"                # Port was added but its binding in this agent"},{"line_number":360,"context_line":"                # hasn\u0027t been activated yet. It will be treated as"},{"line_number":361,"context_line":"                # added when binding is activated"},{"line_number":362,"context_line":"                LOG.info(\"Device with MAC %s has no active binding in host\","},{"line_number":363,"context_line":"                         device)"},{"line_number":364,"context_line":"            else:"},{"line_number":365,"context_line":"                LOG.info(\"Device with MAC %s not defined on plugin\","},{"line_number":366,"context_line":"                         device)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_ef2faba4","line":363,"range":{"start_line":358,"start_character":0,"end_line":363,"end_character":32},"in_reply_to":"9fdfeff1_43390aa1","updated":"2019-02-24 12:14:47.000000000","message":"So,\nNeutron server does not provide the port id (and a bunch of other attributes as well) if the port is not bound to the host.\n\nsee: https://github.com/openstack/neutron/blob/5323e9549d907de54c8f1208cba5c4e7693f0630/neutron/plugins/ml2/rpc.py#L134\n\nfor a port with an inactive binding for the current host, the device_details entry will look like:\n\n{u\u0027device\u0027: u\u0027fa:16:3e:f8:ae:af\u0027, u\u0027no_active_binding\u0027: True}\n\nwe log different messages in case of an un-bound port with no port binding and an un-bound port with inactive port bindings, similarly to whats being done in \n\nhttps://github.com/openstack/neutron/blob/45ab1dc9dbb2cc030135a527fb2610999ad85ca8/neutron/plugins/ml2/drivers/agent/_common_agent.py#L322","commit_id":"a05e1369b0f440f24a76f395a27e0bdac33ecd0c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"751fa697b0e8e11260a7d124e2152a774265bf1f","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                                           port_id,"},{"line_number":356,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"},{"line_number":357,"context_line":"                self.ext_manager.handle_port(self.context, device_details)"},{"line_number":358,"context_line":"            elif c_const.NO_ACTIVE_BINDING in device_details:"},{"line_number":359,"context_line":"                # Port was added but its binding in this agent"},{"line_number":360,"context_line":"                # hasn\u0027t been activated yet. It will be treated as"},{"line_number":361,"context_line":"                # added when binding is activated"},{"line_number":362,"context_line":"                LOG.info(\"Device with MAC %s has no active binding in host\","},{"line_number":363,"context_line":"                         device)"},{"line_number":364,"context_line":"            else:"},{"line_number":365,"context_line":"                LOG.info(\"Device with MAC %s not defined on plugin\","},{"line_number":366,"context_line":"                         device)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_ea2c794b","line":363,"range":{"start_line":358,"start_character":0,"end_line":363,"end_character":32},"in_reply_to":"9fdfeff1_ef2faba4","updated":"2019-02-24 12:25:07.000000000","message":"Ok got it thanks :)","commit_id":"a05e1369b0f440f24a76f395a27e0bdac33ecd0c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"169527a184add48f665430573cf6f1698392a74e","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        :return: None"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        LOG.debug(\"Processing activated bindings: %s\", activated_bindings_copy)"},{"line_number":423,"context_line":"        # Compute which ports for activated bindings are already present"},{"line_number":424,"context_line":"        activated_bindings_copy \u0026\u003d device_info[\u0027current\u0027]"},{"line_number":425,"context_line":"        # Treat them as just added"},{"line_number":426,"context_line":"        device_info[\u0027added\u0027] |\u003d activated_bindings_copy"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_e243613e","line":423,"range":{"start_line":423,"start_character":57,"end_line":423,"end_character":64},"updated":"2019-02-22 00:44:32.000000000","message":"Nit: still. No action required unless you have to roll another patch","commit_id":"a05e1369b0f440f24a76f395a27e0bdac33ecd0c"}],"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_sriov_nic_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        self.assertEqual(set([(\u0027mac1\u0027, \u0027slot1\u0027)]), self.agent.updated_devices)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def test_binding_activate(self):"},{"line_number":662,"context_line":"        # Mock stuff"},{"line_number":663,"context_line":"        fake_port \u003d self._create_fake_port()"},{"line_number":664,"context_line":"        self.agent.get_device_details_from_port_id \u003d mock.Mock()"},{"line_number":665,"context_line":"        self.agent.get_device_details_from_port_id.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_cfd55e1d","line":662,"updated":"2019-02-19 18:21:08.000000000","message":"Not needed comments","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        self.assertEqual(set([(\u0027mac1\u0027, \u0027slot1\u0027)]), self.agent.updated_devices)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def test_binding_activate(self):"},{"line_number":662,"context_line":"        # Mock stuff"},{"line_number":663,"context_line":"        fake_port \u003d self._create_fake_port()"},{"line_number":664,"context_line":"        self.agent.get_device_details_from_port_id \u003d mock.Mock()"},{"line_number":665,"context_line":"        self.agent.get_device_details_from_port_id.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_86908eef","line":662,"in_reply_to":"9fdfeff1_cfd55e1d","updated":"2019-02-20 17:34:57.000000000","message":"Usually, as a personal preference, I state out the logical sections of the tests by adding comments so it is clear when one stage ends and the other begins. \n\nthe tests are pretty short, so ill remove.","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        }"},{"line_number":669,"context_line":"        kwargs \u003d self._create_fake_bindings(fake_port, self.agent.conf.host)"},{"line_number":670,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":671,"context_line":"        # Call binding activates"},{"line_number":672,"context_line":"        self.sriov_rpc_callback.binding_activate(**kwargs)"},{"line_number":673,"context_line":"        # Assert agent.activated_binding set contains the new binding"},{"line_number":674,"context_line":"        self.assertIn((fake_port[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_8fdf5639","line":671,"updated":"2019-02-19 18:21:08.000000000","message":"ditto","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        }"},{"line_number":669,"context_line":"        kwargs \u003d self._create_fake_bindings(fake_port, self.agent.conf.host)"},{"line_number":670,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":671,"context_line":"        # Call binding activates"},{"line_number":672,"context_line":"        self.sriov_rpc_callback.binding_activate(**kwargs)"},{"line_number":673,"context_line":"        # Assert agent.activated_binding set contains the new binding"},{"line_number":674,"context_line":"        self.assertIn((fake_port[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_46bce66b","line":671,"in_reply_to":"9fdfeff1_8fdf5639","updated":"2019-02-20 17:34:57.000000000","message":"Done","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bdcaf6c726c42ed0874d993cf4e3adc4e5477607","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        }"},{"line_number":669,"context_line":"        kwargs \u003d self._create_fake_bindings(fake_port, self.agent.conf.host)"},{"line_number":670,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":671,"context_line":"        # Call binding activates"},{"line_number":672,"context_line":"        self.sriov_rpc_callback.binding_activate(**kwargs)"},{"line_number":673,"context_line":"        # Assert agent.activated_binding set contains the new binding"},{"line_number":674,"context_line":"        self.assertIn((fake_port[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_d1cbae47","line":671,"in_reply_to":"9fdfeff1_8fdf5639","updated":"2019-02-20 15:35:57.000000000","message":"i like comment in tests but ya this does not add much value\nas it just descibes the nezt ling without saying why or adding other context.\n\ni would conisder this a nit however as the comment is not wrong but i could get out of date in the future so unless a commen add adtional value i also tend to let the code document it self.","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                      self.agent.activated_bindings)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def test_binding_activate_no_host(self):"},{"line_number":679,"context_line":"        # Mock stuff"},{"line_number":680,"context_line":"        fake_port \u003d self._create_fake_port()"},{"line_number":681,"context_line":"        kwargs \u003d self._create_fake_bindings(fake_port, \u0027other-host\u0027)"},{"line_number":682,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_efc62269","line":679,"updated":"2019-02-19 18:21:08.000000000","message":"ditto","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                      self.agent.activated_bindings)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def test_binding_activate_no_host(self):"},{"line_number":679,"context_line":"        # Mock stuff"},{"line_number":680,"context_line":"        fake_port \u003d self._create_fake_port()"},{"line_number":681,"context_line":"        kwargs \u003d self._create_fake_bindings(fake_port, \u0027other-host\u0027)"},{"line_number":682,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_66c1eae4","line":679,"in_reply_to":"9fdfeff1_efc62269","updated":"2019-02-20 17:34:57.000000000","message":"Done","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        fake_port \u003d self._create_fake_port()"},{"line_number":681,"context_line":"        kwargs \u003d self._create_fake_bindings(fake_port, \u0027other-host\u0027)"},{"line_number":682,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":683,"context_line":"        # Call binding activate"},{"line_number":684,"context_line":"        self.sriov_rpc_callback.binding_activate(**kwargs)"},{"line_number":685,"context_line":"        # Assert no bindings were added"},{"line_number":686,"context_line":"        self.assertEqual(set(), self.agent.activated_bindings)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_0fc4c65e","line":683,"updated":"2019-02-19 18:21:08.000000000","message":"ditto","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        fake_port \u003d self._create_fake_port()"},{"line_number":681,"context_line":"        kwargs \u003d self._create_fake_bindings(fake_port, \u0027other-host\u0027)"},{"line_number":682,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":683,"context_line":"        # Call binding activate"},{"line_number":684,"context_line":"        self.sriov_rpc_callback.binding_activate(**kwargs)"},{"line_number":685,"context_line":"        # Assert no bindings were added"},{"line_number":686,"context_line":"        self.assertEqual(set(), self.agent.activated_bindings)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_06b6de8b","line":683,"in_reply_to":"9fdfeff1_0fc4c65e","updated":"2019-02-20 17:34:57.000000000","message":"Done","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee1e15e53aeb4bbc63ad5e628e3b955e69f7ccc2","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":695,"context_line":"        self.sriov_rpc_callback.binding_deactivate(**kwargs)"},{"line_number":696,"context_line":"        kwargs[\u0027host\u0027] \u003d \u0027other-host\u0027"},{"line_number":697,"context_line":"        self.sriov_rpc_callback.binding_deactivate(**kwargs)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class TestSRIOVAgentExtensionConfig(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_4fcace6e","line":697,"updated":"2019-02-19 18:21:08.000000000","message":"What are you checking in this function?","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bdcaf6c726c42ed0874d993cf4e3adc4e5477607","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":695,"context_line":"        self.sriov_rpc_callback.binding_deactivate(**kwargs)"},{"line_number":696,"context_line":"        kwargs[\u0027host\u0027] \u003d \u0027other-host\u0027"},{"line_number":697,"context_line":"        self.sriov_rpc_callback.binding_deactivate(**kwargs)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class TestSRIOVAgentExtensionConfig(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_31db1a22","line":697,"in_reply_to":"9fdfeff1_4fcace6e","updated":"2019-02-20 15:35:57.000000000","message":"it has no asserts so the only think it is checking is that no\nexception are raise as that is the only way i would fail modulo typos.","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a3d0d17de7be452a9371d2f0d2ca5a8d2ba9d34e","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        kwargs[\u0027context\u0027] \u003d self.context"},{"line_number":695,"context_line":"        self.sriov_rpc_callback.binding_deactivate(**kwargs)"},{"line_number":696,"context_line":"        kwargs[\u0027host\u0027] \u003d \u0027other-host\u0027"},{"line_number":697,"context_line":"        self.sriov_rpc_callback.binding_deactivate(**kwargs)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class TestSRIOVAgentExtensionConfig(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_265f6273","line":697,"in_reply_to":"9fdfeff1_4fcace6e","updated":"2019-02-20 17:34:57.000000000","message":"well, its basically code coverage and make sure no exception is raised.","commit_id":"7ce421d45fb8e22f78f004b4ff0d06a118e668f8"}]}
