)]}'
{"neutron/db/_model_query.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"af975cabc2592b989c56f3610694cd68a2da9d7f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    # do multiple equals matches"},{"line_number":91,"context_line":"                    query \u003d query.filter("},{"line_number":92,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":93,"context_line":"                elif isinstance(value, obj_utils.FilterObj):"},{"line_number":94,"context_line":"                    query \u003d query.filter(value.filter(column))"},{"line_number":95,"context_line":"                elif None in value:"},{"line_number":96,"context_line":"                    # in_() operator does not support NULL element so we have"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_14606938","line":93,"updated":"2018-11-29 13:18:43.000000000","message":"As I mentioned in [1] this whole module is going away before long... I assume the reason you want to update it now is because you need the update now and can\u0027t wait for what I mentioned in [1]??\n\n\n\n[1] https://review.openstack.org/#/c/620410/1/neutron/db/_model_query.py@33","commit_id":"3e2e2e557756a333c3b1579279b762298fbe63d2"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2ffadd7b28489bdfa1454feaf0619ab8a9f984ab","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    # do multiple equals matches"},{"line_number":91,"context_line":"                    query \u003d query.filter("},{"line_number":92,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":93,"context_line":"                elif isinstance(value, obj_utils.FilterObj):"},{"line_number":94,"context_line":"                    query \u003d query.filter(value.filter(column))"},{"line_number":95,"context_line":"                elif None in value:"},{"line_number":96,"context_line":"                    # in_() operator does not support NULL element so we have"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a55b81f6","line":93,"in_reply_to":"3f79a3b5_14606938","updated":"2018-11-29 15:21:25.000000000","message":"Before this module is going away, I think it is a good practice to sync up this module with neutron-lib. By doing this, we know what might break and potentially fix it before the switch. This will be beneficial with what you are doing as well because you don\u0027t want to take the risk to break when releasing a newer version of neutron-lib :)","commit_id":"3e2e2e557756a333c3b1579279b762298fbe63d2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"16268cce6e934ccd579c6e2e0ef51529977b12d5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    # do multiple equals matches"},{"line_number":91,"context_line":"                    query \u003d query.filter("},{"line_number":92,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":93,"context_line":"                elif isinstance(value, obj_utils.FilterObj):"},{"line_number":94,"context_line":"                    query \u003d query.filter(value.filter(column))"},{"line_number":95,"context_line":"                elif None in value:"},{"line_number":96,"context_line":"                    # in_() operator does not support NULL element so we have"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c0fd4b0b","line":93,"in_reply_to":"3f79a3b5_a55b81f6","updated":"2018-11-29 16:39:06.000000000","message":"Ok thanks.\nIn general I don\u0027t really this \"pre-consumption testing\" is needed because I will fully test when I remove the module and things are fully switched over to neutron-lib. That said if folks want to land this, no biggie by me, I just don\u0027t see it as necessary.","commit_id":"3e2e2e557756a333c3b1579279b762298fbe63d2"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"8c7dcdbc54178fe7d5862c2bc99652180bec4c37","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    # do multiple equals matches"},{"line_number":91,"context_line":"                    query \u003d query.filter("},{"line_number":92,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":93,"context_line":"                elif isinstance(value, obj_utils.FilterObj):"},{"line_number":94,"context_line":"                    query \u003d query.filter(value.filter(column))"},{"line_number":95,"context_line":"                elif None in value:"},{"line_number":96,"context_line":"                    # in_() operator does not support NULL element so we have"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_863c4c92","line":93,"in_reply_to":"3f79a3b5_c0fd4b0b","updated":"2018-11-29 16:56:08.000000000","message":"But I want to mention that I have patches depending on this one so I would like to proceed with merging if it doesn\u0027t hurt anything on your side.","commit_id":"3e2e2e557756a333c3b1579279b762298fbe63d2"}]}
