)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3ddeb127c8da06588cf65a1fd2a82d25a1d665a8","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            if self.agent_state.pop(\u0027start_flag\u0027, None) and self.iter_num \u003d\u003d 0:"},{"line_number":349,"context_line":"                # On initial start, we notify systemd after initialization"},{"line_number":350,"context_line":"                # is complete."},{"line_number":351,"context_line":"                systemd.notify_once()"},{"line_number":352,"context_line":"        except Exception:"},{"line_number":353,"context_line":"            LOG.exception(\"Failed reporting state!\")"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7fb063fd","line":351,"updated":"2018-12-03 09:12:04.000000000","message":"When l2pop checks if the agent is restarted, checks the boot time (agent.started_at) and the latest heartbeat. This notification will update the agent status, but not the DB timestamps.\n\nMech driver won\u0027t consider the l2 agent was restarted and won\u0027t send again the fdb entries.\n\nAm I missing something?","commit_id":"ae031d18866a9e3652f4fc122f120915209a7b29"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aac556ad8a7be2d6bc68ae0fa580b56cda4cc3ac","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            if self.agent_state.pop(\u0027start_flag\u0027, None) and self.iter_num \u003d\u003d 0:"},{"line_number":349,"context_line":"                # On initial start, we notify systemd after initialization"},{"line_number":350,"context_line":"                # is complete."},{"line_number":351,"context_line":"                systemd.notify_once()"},{"line_number":352,"context_line":"        except Exception:"},{"line_number":353,"context_line":"            LOG.exception(\"Failed reporting state!\")"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_70c3b08d","line":351,"in_reply_to":"3f79a3b5_7fb063fd","updated":"2018-12-03 11:27:17.000000000","message":"By setting flag self.agent_state[\"start_flag\"] to True in L 2051 we are \"forcing\" information that agent was just started and thus l2pop mech driver will configure all fdb flows in the same way as during normal restart of neutron-ovs-agent.\n\nI know that it\u0027s \"hack\" but if You think about it a bit, it\u0027s not as bad because in fact after openvswitch is restarted it should be treated as restart of agent because many things needs to be reconfigured then :)","commit_id":"ae031d18866a9e3652f4fc122f120915209a7b29"}]}