)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"693435311aa54c2f74ebe66db19504981cbb20f1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reinitialize ovs firewall after ovs-vswitchd restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs-vswitchd process is restarted on host neutron-ovs-agent"},{"line_number":10,"context_line":"can properly handle that and recover openflows and bridges config."},{"line_number":11,"context_line":"But when ovs firewall driver is used, it wasn\u0027t reinitialized"},{"line_number":12,"context_line":"so there were missing some OF rules in br-int and connectivity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_fb427193","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":38},"updated":"2018-11-29 23:09:34.000000000","message":"Is it possible to have a test (fullstack?) to cover this scenario?","commit_id":"81e0622050177ae5caf41727f2d459eabb553d09"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58b3924b2855943ccc55dfb780d71a4c3da7a450","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reinitialize ovs firewall after ovs-vswitchd restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs-vswitchd process is restarted on host neutron-ovs-agent"},{"line_number":10,"context_line":"can properly handle that and recover openflows and bridges config."},{"line_number":11,"context_line":"But when ovs firewall driver is used, it wasn\u0027t reinitialized"},{"line_number":12,"context_line":"so there were missing some OF rules in br-int and connectivity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d05ac4f2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":38},"in_reply_to":"3f79a3b5_fb427193","updated":"2018-12-03 12:36:24.000000000","message":"In fact no because we are sharing one ovs-vswitchd for all tests so restart of it may cause random failures in other tests.","commit_id":"81e0622050177ae5caf41727f2d459eabb553d09"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"127d826c445c100ea8b589d54fc685eebe6716ab","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs-vswitchd process is restarted on host neutron-ovs-agent"},{"line_number":10,"context_line":"can properly handle that and recover openflows and bridges config."},{"line_number":11,"context_line":"But when ovs firewall driver is used, it wasn\u0027t reinitialized"},{"line_number":12,"context_line":"so there were missing some OF rules in br-int and connectivity"},{"line_number":13,"context_line":"to/from instances was broken."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_67ac78eb","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":61},"updated":"2018-11-30 14:54:59.000000000","message":"100% possibilities? OK, I see, ovs-agent can not handle the `ovs-vswitchd` unexpected restart.","commit_id":"81e0622050177ae5caf41727f2d459eabb553d09"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58b3924b2855943ccc55dfb780d71a4c3da7a450","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs-vswitchd process is restarted on host neutron-ovs-agent"},{"line_number":10,"context_line":"can properly handle that and recover openflows and bridges config."},{"line_number":11,"context_line":"But when ovs firewall driver is used, it wasn\u0027t reinitialized"},{"line_number":12,"context_line":"so there were missing some OF rules in br-int and connectivity"},{"line_number":13,"context_line":"to/from instances was broken."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b0fce8bc","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":61},"in_reply_to":"3f79a3b5_67ac78eb","updated":"2018-12-03 12:36:24.000000000","message":"neutron-ovs-agent is handling restart of ovs-vswitchd basically but there was missing reinitialization of openvswitch firewall and some rules in br-int were missing.","commit_id":"81e0622050177ae5caf41727f2d459eabb553d09"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"642986bc9791f2ee418b9c1220e2fc559689b137","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        self.iptables_helper.load_driver_if_needed()"},{"line_number":406,"context_line":"        self._initialize_firewall()"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        callbacks_registry.subscribe("},{"line_number":409,"context_line":"            self._init_firewall_callback,"},{"line_number":410,"context_line":"            callbacks_resources.AGENT,"},{"line_number":411,"context_line":"            callbacks_events.OVS_RESTARTED)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_14cfc2b6","line":408,"range":{"start_line":408,"start_character":27,"end_line":408,"end_character":36},"updated":"2018-12-03 23:37:11.000000000","message":"nit: it seems the general preference is to use @registry.receives instead of registry.subscribe","commit_id":"2ba9e95156d86bc67ecd8440d7343028e89cae3a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d35075ad6bc03b22e2fce15a65892c266595051b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            callbacks_events.OVS_RESTARTED)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def _init_firewall_callback(self, resource, event, trigger, **kwargs):"},{"line_number":414,"context_line":"        LOG.info(\"Reinitialize Openvswitch firewall after OVS restart.\")"},{"line_number":415,"context_line":"        self._initialize_firewall()"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _initialize_firewall(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8d0bce2b","line":414,"range":{"start_line":414,"start_character":18,"end_line":414,"end_character":30},"updated":"2018-12-03 20:18:49.000000000","message":"nit: Re-initialize","commit_id":"2ba9e95156d86bc67ecd8440d7343028e89cae3a"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2625afb05ad1714c13b65783b040c131ec4906de","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"            self.dvr_agent.reset_dvr_parameters()"},{"line_number":2058,"context_line":"            self.dvr_agent.setup_dvr_flows()"},{"line_number":2059,"context_line":"        # notify that OVS has restarted"},{"line_number":2060,"context_line":"        registry.notify("},{"line_number":2061,"context_line":"            callback_resources.AGENT,"},{"line_number":2062,"context_line":"            callback_events.OVS_RESTARTED,"},{"line_number":2063,"context_line":"            self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5ca9f575","line":2060,"updated":"2018-12-03 08:16:48.000000000","message":"How about implementing a handler in OVS firewall for this notification? Are all the security group rules refreshed somewhere too?","commit_id":"81e0622050177ae5caf41727f2d459eabb553d09"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58b3924b2855943ccc55dfb780d71a4c3da7a450","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"            self.dvr_agent.reset_dvr_parameters()"},{"line_number":2058,"context_line":"            self.dvr_agent.setup_dvr_flows()"},{"line_number":2059,"context_line":"        # notify that OVS has restarted"},{"line_number":2060,"context_line":"        registry.notify("},{"line_number":2061,"context_line":"            callback_resources.AGENT,"},{"line_number":2062,"context_line":"            callback_events.OVS_RESTARTED,"},{"line_number":2063,"context_line":"            self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b025c860","line":2060,"in_reply_to":"3f79a3b5_5ca9f575","updated":"2018-12-03 12:36:24.000000000","message":"That is good idea to use notifications here. I will change that.\nAll rules for ports are reconfigured because ports are \"updated\" so this triggers also reconfigure of SG rules for each of them.\nProblem is only with some basic rules in br-int, like rules in table 94 IIRC thus packets can\u0027t get out from br-int.","commit_id":"81e0622050177ae5caf41727f2d459eabb553d09"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"4e1624b5427103676e580c36b023e52be38f028c","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"            self.dvr_agent.reset_dvr_parameters()"},{"line_number":2058,"context_line":"            self.dvr_agent.setup_dvr_flows()"},{"line_number":2059,"context_line":"        # notify that OVS has restarted"},{"line_number":2060,"context_line":"        registry.notify("},{"line_number":2061,"context_line":"            callback_resources.AGENT,"},{"line_number":2062,"context_line":"            callback_events.OVS_RESTARTED,"},{"line_number":2063,"context_line":"            self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e325b916","line":2060,"in_reply_to":"3f79a3b5_b025c860","updated":"2018-12-03 15:00:24.000000000","message":"Nice! I didn\u0027t realize we got a notification for this. Using callbacks here is a much cleaner approach.","commit_id":"81e0622050177ae5caf41727f2d459eabb553d09"}]}
